@vellumai/assistant 0.5.6 → 0.5.8

package/src/__tests__/memory-recall-quality.test.ts

@@ -397,7 +397,6 @@ describe("Memory Recall Quality", () => {
         TEST_CONFIG,
       );
 
-      expect(recall.recencyHits).toBeGreaterThan(0);
       expect(recall.enabled).toBe(true);
       // With high-scoring Qdrant results, items should be injected
       expect(recall.semanticHits).toBeGreaterThan(0);
@@ -502,7 +501,6 @@ describe("Memory Recall Quality", () => {
         TEST_CONFIG,
       );
 
-      expect(recall.recencyHits).toBeGreaterThan(0);
       expect(recall.enabled).toBe(true);
       // High-importance preference should be injected
       expect(recall.injectedText).toContain("TypeScript");
@@ -566,7 +564,6 @@ describe("Memory Recall Quality", () => {
       );
 
       // Recency search finds the segment but tier classification filters it
-      expect(recall.recencyHits).toBeGreaterThan(0);
       // Superseded items should not leak into injected text
       expect(recall.injectedText).not.toContain("vim for editing code");
     });
@@ -623,7 +620,6 @@ describe("Memory Recall Quality", () => {
 
       // Recency search finds segments but tier classification filters them.
       // Key assertion: superseded MySQL item should not leak.
-      expect(recall.recencyHits).toBeGreaterThan(0);
       expect(recall.injectedText).not.toContain("MySQL");
     });
 
@@ -671,13 +667,29 @@ describe("Memory Recall Quality", () => {
         firstSeenAt: now - 50_000,
       });
 
+      // Mock Qdrant to return the active item as a semantic search result
+      mockQdrantResults = [
+        {
+          id: "emb-framework-active",
+          score: 0.92,
+          payload: {
+            target_type: "item",
+            target_id: "item-framework-active",
+            text: "Framework preference is React for this codebase",
+            kind: "preference",
+            status: "active",
+            created_at: now,
+            last_seen_at: now,
+          },
+        },
+      ];
+
       const recall = await buildMemoryRecall(
         "framework preference",
         "conv-invalid-status",
         TEST_CONFIG,
       );
-      expect(recall.recencyHits).toBeGreaterThan(0);
-      // Active segment content should be injected; invalidated item should not leak
+      // Active item should be injected via semantic search; invalidated item should not leak
       expect(recall.injectedText).toContain("React");
       expect(recall.injectedText).not.toContain("Angular");
     });
@@ -765,7 +777,6 @@ describe("Memory Recall Quality", () => {
         TEST_CONFIG,
       );
 
-      expect(recall.recencyHits).toBeGreaterThan(0);
       expect(recall.enabled).toBe(true);
       // Recent Bun item should be injected, old Node reference should not
       expect(recall.injectedText).toContain("Bun");
@@ -870,7 +881,6 @@ describe("Memory Recall Quality", () => {
         TEST_CONFIG,
       );
 
-      expect(recall.recencyHits).toBeGreaterThan(0);
       expect(recall.enabled).toBe(true);
       // Frequently accessed timezone item should be in injected text
       expect(recall.injectedText).toContain("America/Los_Angeles");
@@ -940,7 +950,6 @@ describe("Memory Recall Quality", () => {
         TEST_CONFIG,
       );
 
-      expect(recall.recencyHits).toBeGreaterThan(0);
       expect(recall.enabled).toBe(true);
       // Deployment rule should be injected
       expect(recall.injectedText).toContain("staging");
@@ -987,7 +996,7 @@ describe("Memory Recall Quality", () => {
       );
     });
 
-    test("precision@k guard verifies pipeline completes with seeded segments", async () => {
+    test("precision@k guard verifies pipeline completes with seeded items", async () => {
       const db = getDb();
       const now = 1_700_000_700_000;
       insertConversation(db, "conv-pk", now, 3);
@@ -995,17 +1004,17 @@ describe("Memory Recall Quality", () => {
       const prefs = [
         {
           msg: "msg-pk-1",
-          seg: "seg-pk-1",
+          item: "item-pk-1",
           text: "I prefer dark mode over light mode",
         },
         {
           msg: "msg-pk-2",
-          seg: "seg-pk-2",
+          item: "item-pk-2",
           text: "I like using TypeScript for all projects",
         },
         {
           msg: "msg-pk-3",
-          seg: "seg-pk-3",
+          item: "item-pk-3",
           text: "I prefer tabs over spaces for indentation",
         },
       ];
@@ -1014,18 +1023,40 @@ describe("Memory Recall Quality", () => {
         const p = prefs[i]!;
         const t = now + i * 1000;
         insertMessage(db, p.msg, "conv-pk", "user", p.text, t);
-        insertSegment(db, p.seg, p.msg, "conv-pk", "user", p.text, t);
+        insertItem(db, {
+          id: p.item,
+          kind: "preference",
+          subject: `preference-${i}`,
+          statement: p.text,
+          importance: 0.8,
+          firstSeenAt: t,
+        });
+        insertItemSource(db, p.item, p.msg, t);
       }
 
+      // Mock Qdrant to return all three preference items
+      mockQdrantResults = prefs.map((p, i) => ({
+        id: `emb-pk-${i}`,
+        score: 0.9 - i * 0.05,
+        payload: {
+          target_type: "item",
+          target_id: p.item,
+          text: p.text,
+          kind: "preference",
+          status: "active",
+          created_at: now + i * 1000,
+          last_seen_at: now + i * 1000,
+        },
+      }));
+
       const recall = await buildMemoryRecall(
         "what do I prefer",
         "conv-pk",
         TEST_CONFIG,
       );
 
-      // Recency-only candidates are promoted to tier 2 and injected.
-      // Verify the pipeline recalled the preference content.
-      expect(recall.recencyHits).toBeGreaterThan(0);
+      // Semantic search returns all three preference items which pass
+      // tier classification and are injected.
       expect(recall.enabled).toBe(true);
       assertPrecisionAtK(
         recall.injectedText,