@vellumai/assistant 0.5.16 → 0.6.1

package/src/__tests__/db-schedule-syntax-migration.test.ts

@@ -42,6 +42,7 @@ describe("schedule_syntax column migration", () => {
         routing_hints_json TEXT NOT NULL DEFAULT '{}',
         status TEXT NOT NULL DEFAULT 'active',
         quiet INTEGER NOT NULL DEFAULT 0,
+        reuse_conversation INTEGER NOT NULL DEFAULT 0,
         created_at INTEGER NOT NULL,
         updated_at INTEGER NOT NULL
       )
@@ -108,7 +109,7 @@ describe("schedule_syntax column migration", () => {
       `INSERT INTO cron_jobs (id, name, enabled, cron_expression, timezone, message, next_run_at, last_run_at, last_status, retry_count, created_by, created_at, updated_at) VALUES ('old-1', 'Old Job', 1, '0 9 * * *', NULL, 'hello', ${now + 60000}, NULL, NULL, 0, 'agent', ${now}, ${now})`,
     );
 
-    // Run the migration
+    // Run the migrations
     try {
       raw.exec(
         `ALTER TABLE cron_jobs ADD COLUMN schedule_syntax TEXT NOT NULL DEFAULT 'cron'`,
@@ -116,6 +117,13 @@ describe("schedule_syntax column migration", () => {
     } catch {
       /* already exists */
     }
+    try {
+      raw.exec(
+        `ALTER TABLE cron_jobs ADD COLUMN reuse_conversation INTEGER NOT NULL DEFAULT 0`,
+      );
+    } catch {
+      /* already exists */
+    }
 
     const row = db
       .select()
@@ -167,6 +175,13 @@ describe("schedule_syntax column migration", () => {
     } catch {
       /* ok */
     }
+    try {
+      raw.exec(
+        `ALTER TABLE cron_jobs ADD COLUMN reuse_conversation INTEGER NOT NULL DEFAULT 0`,
+      );
+    } catch {
+      /* ok */
+    }
 
     const now = Date.now();
     raw.exec(

package/src/__tests__/file-list-tool.test.ts

@@ -0,0 +1,219 @@
+import {
+  mkdirSync,
+  mkdtempSync,
+  realpathSync,
+  rmSync,
+  writeFileSync,
+} from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, describe, expect, test } from "bun:test";
+
+import {
+  isToolActiveForContext,
+  type SkillProjectionContext,
+  SUBAGENT_ONLY_TOOL_NAMES,
+} from "../daemon/conversation-tool-setup.js";
+import { fileListTool } from "../tools/filesystem/list.js";
+import {
+  FileSystemOps,
+  type PathPolicy,
+} from "../tools/shared/filesystem/file-ops-service.js";
+import { sandboxPolicy } from "../tools/shared/filesystem/path-policy.js";
+import type { ToolContext } from "../tools/types.js";
+
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+
+const testDirs: string[] = [];
+
+function makeTempDir(): string {
+  const dir = realpathSync(mkdtempSync(join(tmpdir(), "file-list-test-")));
+  testDirs.push(dir);
+  return dir;
+}
+
+afterEach(() => {
+  for (const dir of testDirs.splice(0)) {
+    rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+/** Build a sandbox-bound PathPolicy for the given directory. */
+function sandboxPolicyFor(boundary: string): PathPolicy {
+  return (rawPath, options) => sandboxPolicy(rawPath, boundary, options);
+}
+
+// ---------------------------------------------------------------------------
+// listDirSafe
+// ---------------------------------------------------------------------------
+
+describe("FileSystemOps.listDirSafe", () => {
+  test("lists directory contents with type indicators (dirs end with /)", () => {
+    const dir = makeTempDir();
+    mkdirSync(join(dir, "subdir-a"));
+    mkdirSync(join(dir, "subdir-b"));
+    writeFileSync(join(dir, "file-a.txt"), "hello");
+    writeFileSync(join(dir, "file-b.md"), "world");
+
+    const ops = new FileSystemOps(sandboxPolicyFor(dir));
+    const result = ops.listDirSafe({ path: dir });
+    expect(result.ok).toBe(true);
+    if (!result.ok) return;
+
+    const lines = result.value.listing.split("\n");
+    // Directories first with trailing /
+    expect(lines[0]).toBe("subdir-a/");
+    expect(lines[1]).toBe("subdir-b/");
+    // Files after directories, with size info
+    expect(lines[2]).toMatch(/^file-a\.txt\s+\d+\s*B$/);
+    expect(lines[3]).toMatch(/^file-b\.md\s+\d+\s*B$/);
+  });
+
+  test("glob filtering works (e.g. '*.md' only returns .md files)", () => {
+    const dir = makeTempDir();
+    writeFileSync(join(dir, "readme.md"), "# Title");
+    writeFileSync(join(dir, "notes.md"), "some notes");
+    writeFileSync(join(dir, "app.ts"), "console.log('hi')");
+    writeFileSync(join(dir, "config.json"), "{}");
+
+    const ops = new FileSystemOps(sandboxPolicyFor(dir));
+    const result = ops.listDirSafe({ path: dir, glob: "*.md" });
+    expect(result.ok).toBe(true);
+    if (!result.ok) return;
+
+    const lines = result.value.listing.split("\n");
+    expect(lines.length).toBe(2);
+    expect(lines[0]).toMatch(/^notes\.md/);
+    expect(lines[1]).toMatch(/^readme\.md/);
+  });
+
+  test("returns NOT_A_DIRECTORY error for file paths", () => {
+    const dir = makeTempDir();
+    writeFileSync(join(dir, "regular-file.txt"), "content");
+
+    const ops = new FileSystemOps(sandboxPolicyFor(dir));
+    const result = ops.listDirSafe({ path: join(dir, "regular-file.txt") });
+    expect(result.ok).toBe(false);
+    if (result.ok) return;
+    expect(result.error.code).toBe("NOT_A_DIRECTORY");
+  });
+
+  test("returns NOT_FOUND error for nonexistent paths", () => {
+    const dir = makeTempDir();
+
+    const ops = new FileSystemOps(sandboxPolicyFor(dir));
+    const result = ops.listDirSafe({ path: join(dir, "nonexistent") });
+    expect(result.ok).toBe(false);
+    if (result.ok) return;
+    expect(result.error.code).toBe("NOT_FOUND");
+  });
+
+  test("sandbox policy rejects paths outside boundary", () => {
+    const dir = makeTempDir();
+
+    const ops = new FileSystemOps(sandboxPolicyFor(dir));
+    const result = ops.listDirSafe({ path: "../../../etc" });
+    expect(result.ok).toBe(false);
+    if (result.ok) return;
+    expect(result.error.code).toBe("PATH_OUT_OF_BOUNDS");
+  });
+});
+
+// ---------------------------------------------------------------------------
+// FileListTool integration tests
+// ---------------------------------------------------------------------------
+
+/** Build a minimal ToolContext with the given workingDir. */
+function makeToolContext(workingDir: string): ToolContext {
+  return {
+    workingDir,
+    conversationId: "test-conv",
+    trustClass: "guardian",
+  };
+}
+
+describe("FileListTool", () => {
+  test("execute() returns formatted listing for a temp directory", async () => {
+    const dir = makeTempDir();
+    mkdirSync(join(dir, "src"));
+    writeFileSync(join(dir, "README.md"), "# Hello");
+    writeFileSync(join(dir, "index.ts"), "export {}");
+
+    const result = await fileListTool.execute(
+      { path: dir, activity: "listing test dir" },
+      makeToolContext(dir),
+    );
+
+    expect(result.isError).toBe(false);
+    const lines = result.content.split("\n");
+    // Directory first with trailing /
+    expect(lines[0]).toBe("src/");
+    // Files after (alphabetical), with size info
+    expect(lines[1]).toMatch(/^index\.ts\s+\d+\s*B$/);
+    expect(lines[2]).toMatch(/^README\.md\s+\d+\s*B$/);
+  });
+
+  test("execute() returns error for invalid path input", async () => {
+    const dir = makeTempDir();
+    const result = await fileListTool.execute(
+      { path: 123, activity: "test" },
+      makeToolContext(dir),
+    );
+    expect(result.isError).toBe(true);
+    expect(result.content).toContain("path is required and must be a string");
+  });
+
+  test("execute() returns error for nonexistent directory", async () => {
+    const dir = makeTempDir();
+    const result = await fileListTool.execute(
+      { path: join(dir, "nope"), activity: "test" },
+      makeToolContext(dir),
+    );
+    expect(result.isError).toBe(true);
+    expect(result.content).toContain("not found");
+  });
+});
+
+// ---------------------------------------------------------------------------
+// Subagent-only visibility
+// ---------------------------------------------------------------------------
+
+describe("file_list subagent visibility", () => {
+  test("file_list is in SUBAGENT_ONLY_TOOL_NAMES", () => {
+    expect(SUBAGENT_ONLY_TOOL_NAMES.has("file_list")).toBe(true);
+  });
+
+  test("isToolActiveForContext hides file_list when isSubagent is false", () => {
+    const ctx: SkillProjectionContext = {
+      skillProjectionState: new Map(),
+      skillProjectionCache: {},
+      coreToolNames: new Set(["file_list"]),
+      toolsDisabledDepth: 0,
+    };
+    expect(isToolActiveForContext("file_list", ctx)).toBe(false);
+  });
+
+  test("isToolActiveForContext hides file_list when isSubagent is undefined", () => {
+    const ctx: SkillProjectionContext = {
+      skillProjectionState: new Map(),
+      skillProjectionCache: {},
+      coreToolNames: new Set(["file_list"]),
+      toolsDisabledDepth: 0,
+      isSubagent: undefined,
+    };
+    expect(isToolActiveForContext("file_list", ctx)).toBe(false);
+  });
+
+  test("isToolActiveForContext shows file_list when isSubagent is true", () => {
+    const ctx: SkillProjectionContext = {
+      skillProjectionState: new Map(),
+      skillProjectionCache: {},
+      coreToolNames: new Set(["file_list"]),
+      toolsDisabledDepth: 0,
+      isSubagent: true,
+    };
+    expect(isToolActiveForContext("file_list", ctx)).toBe(true);
+  });
+});

package/src/__tests__/first-greeting.test.ts

@@ -53,7 +53,7 @@ describe("first-greeting", () => {
       const greeting = getCannedFirstGreeting();
       expect(greeting).toBe(CANNED_FIRST_GREETING);
       expect(greeting).toContain("brand new");
-      expect(greeting).toContain("no name, no memories");
+      expect(greeting).toContain("No name, no memories");
     });
   });
 });

package/src/__tests__/followup-tools.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -16,7 +16,7 @@ mock.module("../config/loader.js", () => ({
 
 import type { Database } from "bun:sqlite";
 
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import { executeFollowupCreate } from "../tools/followups/followup_create.js";
 import { executeFollowupList } from "../tools/followups/followup_list.js";
 import { executeFollowupResolve } from "../tools/followups/followup_resolve.js";
@@ -24,10 +24,6 @@ import type { ToolContext } from "../tools/types.js";
 
 initializeDb();
 
-afterAll(() => {
-  resetDb();
-});
-
 function getRawDb(): Database {
   return (getDb() as unknown as { $client: Database }).$client;
 }

package/src/__tests__/graph-extraction-event-date.test.ts

@@ -0,0 +1,186 @@
+import { describe, expect, test } from "bun:test";
+
+import {
+  parseEpochMs,
+  parseExtractionResponse,
+} from "../memory/graph/extraction.js";
+
+// ---------------------------------------------------------------------------
+// parseEpochMs unit tests
+// ---------------------------------------------------------------------------
+
+describe("parseEpochMs", () => {
+  test("returns number as-is", () => {
+    expect(parseEpochMs(1712534400000)).toBe(1712534400000);
+  });
+
+  test("coerces numeric string to number", () => {
+    expect(parseEpochMs("1712534400000")).toBe(1712534400000);
+  });
+
+  test("returns null for non-numeric string", () => {
+    expect(parseEpochMs("not a number")).toBeNull();
+  });
+
+  test("returns null for null", () => {
+    expect(parseEpochMs(null)).toBeNull();
+  });
+
+  test("returns null for undefined", () => {
+    expect(parseEpochMs(undefined)).toBeNull();
+  });
+
+  test("returns null for Infinity", () => {
+    expect(parseEpochMs(Infinity)).toBeNull();
+  });
+
+  test("returns null for NaN", () => {
+    expect(parseEpochMs(NaN)).toBeNull();
+  });
+
+  test("returns null for empty string", () => {
+    expect(parseEpochMs("")).toBeNull();
+  });
+});
+
+// ---------------------------------------------------------------------------
+// parseExtractionResponse — event_date coercion
+// ---------------------------------------------------------------------------
+
+describe("parseExtractionResponse event_date coercion", () => {
+  const candidateNodeIds = new Set<string>();
+  const conversationId = "test-convo";
+  const scopeId = "default";
+  const now = Date.now();
+
+  function makeInput(overrides: Record<string, unknown> = {}) {
+    return {
+      create_nodes: [
+        {
+          content: "Test memory",
+          type: "episodic",
+          emotional_charge: {
+            valence: 0.5,
+            intensity: 0.5,
+            decay_curve: "linear",
+            decay_rate: 0.05,
+          },
+          significance: 0.5,
+          confidence: 0.8,
+          source_type: "direct",
+          ...overrides,
+        },
+      ],
+      reinforce_node_ids: [],
+    };
+  }
+
+  test("coerces string event_date on create_nodes", () => {
+    const input = makeInput({ event_date: "1712534400000" });
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidateNodeIds,
+      now,
+    );
+    expect(diff.createNodes[0].eventDate).toBe(1712534400000);
+  });
+
+  test("passes through numeric event_date on create_nodes", () => {
+    const input = makeInput({ event_date: 1712534400000 });
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidateNodeIds,
+      now,
+    );
+    expect(diff.createNodes[0].eventDate).toBe(1712534400000);
+  });
+
+  test("nullifies non-numeric string event_date on create_nodes", () => {
+    const input = makeInput({ event_date: "next tuesday" });
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidateNodeIds,
+      now,
+    );
+    expect(diff.createNodes[0].eventDate).toBeNull();
+  });
+
+  test("coerces string event_date on triggers", () => {
+    const input = makeInput({
+      event_date: 1712534400000,
+      triggers: [
+        {
+          type: "event",
+          event_date: "1712534400000",
+          ramp_days: 7,
+          follow_up_days: 2,
+        },
+      ],
+    });
+    const { deferredTriggers } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidateNodeIds,
+      now,
+    );
+    // Should have the explicit trigger (coerced) plus possibly the auto-created one
+    const explicitTrigger = deferredTriggers.find(
+      (t) => t.trigger.eventDate === 1712534400000,
+    );
+    expect(explicitTrigger).toBeTruthy();
+    expect(explicitTrigger!.trigger.eventDate).toBe(1712534400000);
+  });
+
+  test("coerces string event_date on update_nodes", () => {
+    const existingNodeId = "existing-node-1";
+    const candidates = new Set([existingNodeId]);
+    const input = {
+      create_nodes: [],
+      reinforce_node_ids: [],
+      update_nodes: [
+        {
+          id: existingNodeId,
+          event_date: "1712534400000",
+        },
+      ],
+    };
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidates,
+      now,
+    );
+    expect(diff.updateNodes[0].changes.eventDate).toBe(1712534400000);
+  });
+
+  test("null-clears event_date on update_nodes when explicitly null", () => {
+    const existingNodeId = "existing-node-1";
+    const candidates = new Set([existingNodeId]);
+    const input = {
+      create_nodes: [],
+      reinforce_node_ids: [],
+      update_nodes: [
+        {
+          id: existingNodeId,
+          event_date: null,
+        },
+      ],
+    };
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidates,
+      now,
+    );
+    expect(diff.updateNodes[0].changes.eventDate).toBeNull();
+  });
+});

package/src/__tests__/guardian-action-conversation-turn.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -11,7 +11,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   createGuardianActionDelivery,
   createGuardianActionRequest,
@@ -133,10 +133,6 @@ describe("guardian-action-conversation-turn", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── processGuardianFollowUpTurn: classification ─────────────────────
 
   test('classifies "call them back" as call_back', async () => {

package/src/__tests__/guardian-action-followup-executor.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -56,7 +56,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { initializeDb, resetDb } from "../memory/db.js";
+import { initializeDb } from "../memory/db.js";
 import { getDb } from "../memory/db.js";
 import {
   createGuardianActionDelivery,
@@ -160,10 +160,6 @@ describe("guardian-action-followup-executor", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── Counterparty resolution ─────────────────────────────────────────
 
   describe("resolveCounterparty", () => {

package/src/__tests__/guardian-action-followup-store.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -11,7 +11,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   createGuardianActionRequest,
   expireGuardianActionRequest,
@@ -75,10 +75,6 @@ describe("guardian-action-followup-store", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── markTimedOutWithReason ──────────────────────────────────────────
 
   test("markTimedOutWithReason sets expired_reason correctly for call_timeout", () => {

package/src/__tests__/guardian-action-grant-mint-consume.test.ts

@@ -10,7 +10,7 @@
  *   5. Second consume attempt is denied (one-time use)
  */
 
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 // ── Platform + logger mocks ─────────────────────────────────────────
 
@@ -28,7 +28,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   createGuardianActionRequest,
   resolveGuardianActionRequest,
@@ -43,10 +43,6 @@ import { computeToolApprovalDigest } from "../security/tool-approval-digest.js";
 
 initializeDb();
 
-afterAll(() => {
-  resetDb();
-});
-
 // ── Constants ───────────────────────────────────────────────────────
 
 const TOOL_NAME = "execute_shell";

package/src/__tests__/guardian-action-late-reply.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -18,7 +18,7 @@ import {
   getCallSession,
   updateCallSession,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   createGuardianActionDelivery,
   createGuardianActionRequest,
@@ -115,10 +115,6 @@ describe("guardian-action-late-reply", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── getExpiredDeliveriesByDestination ──────────────────────────────
 
   test("getExpiredDeliveriesByDestination returns expired deliveries for follow-up eligible requests", () => {

package/src/__tests__/guardian-action-store.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -11,7 +11,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   cancelGuardianActionRequest,
   createGuardianActionDelivery,
@@ -57,10 +57,6 @@ describe("guardian-action-store", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── Helper to create a pending request+delivery targeting a conversation ──
   function createPendingRequestWithDelivery(
     convId: string,

package/src/__tests__/guardian-binding-drift-heal.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -9,7 +9,7 @@ mock.module("../util/logger.js", () => ({
 
 import { findGuardianForChannel } from "../contacts/contact-store.js";
 import { createGuardianBinding } from "../contacts/contacts-write.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import { healGuardianBindingDrift } from "../runtime/guardian-vellum-migration.js";
 
 initializeDb();
@@ -25,10 +25,6 @@ describe("healGuardianBindingDrift", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   test("heals drift when both principals have vellum-principal- prefix", () => {
     // Simulate DB reset: new guardian binding with a different UUID
     createGuardianBinding({