@vellumai/assistant 0.5.16 → 0.6.0

package/src/__tests__/graph-extraction-event-date.test.ts

@@ -0,0 +1,186 @@
+import { describe, expect, test } from "bun:test";
+
+import {
+  parseEpochMs,
+  parseExtractionResponse,
+} from "../memory/graph/extraction.js";
+
+// ---------------------------------------------------------------------------
+// parseEpochMs unit tests
+// ---------------------------------------------------------------------------
+
+describe("parseEpochMs", () => {
+  test("returns number as-is", () => {
+    expect(parseEpochMs(1712534400000)).toBe(1712534400000);
+  });
+
+  test("coerces numeric string to number", () => {
+    expect(parseEpochMs("1712534400000")).toBe(1712534400000);
+  });
+
+  test("returns null for non-numeric string", () => {
+    expect(parseEpochMs("not a number")).toBeNull();
+  });
+
+  test("returns null for null", () => {
+    expect(parseEpochMs(null)).toBeNull();
+  });
+
+  test("returns null for undefined", () => {
+    expect(parseEpochMs(undefined)).toBeNull();
+  });
+
+  test("returns null for Infinity", () => {
+    expect(parseEpochMs(Infinity)).toBeNull();
+  });
+
+  test("returns null for NaN", () => {
+    expect(parseEpochMs(NaN)).toBeNull();
+  });
+
+  test("returns null for empty string", () => {
+    expect(parseEpochMs("")).toBeNull();
+  });
+});
+
+// ---------------------------------------------------------------------------
+// parseExtractionResponse — event_date coercion
+// ---------------------------------------------------------------------------
+
+describe("parseExtractionResponse event_date coercion", () => {
+  const candidateNodeIds = new Set<string>();
+  const conversationId = "test-convo";
+  const scopeId = "default";
+  const now = Date.now();
+
+  function makeInput(overrides: Record<string, unknown> = {}) {
+    return {
+      create_nodes: [
+        {
+          content: "Test memory",
+          type: "episodic",
+          emotional_charge: {
+            valence: 0.5,
+            intensity: 0.5,
+            decay_curve: "linear",
+            decay_rate: 0.05,
+          },
+          significance: 0.5,
+          confidence: 0.8,
+          source_type: "direct",
+          ...overrides,
+        },
+      ],
+      reinforce_node_ids: [],
+    };
+  }
+
+  test("coerces string event_date on create_nodes", () => {
+    const input = makeInput({ event_date: "1712534400000" });
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidateNodeIds,
+      now,
+    );
+    expect(diff.createNodes[0].eventDate).toBe(1712534400000);
+  });
+
+  test("passes through numeric event_date on create_nodes", () => {
+    const input = makeInput({ event_date: 1712534400000 });
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidateNodeIds,
+      now,
+    );
+    expect(diff.createNodes[0].eventDate).toBe(1712534400000);
+  });
+
+  test("nullifies non-numeric string event_date on create_nodes", () => {
+    const input = makeInput({ event_date: "next tuesday" });
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidateNodeIds,
+      now,
+    );
+    expect(diff.createNodes[0].eventDate).toBeNull();
+  });
+
+  test("coerces string event_date on triggers", () => {
+    const input = makeInput({
+      event_date: 1712534400000,
+      triggers: [
+        {
+          type: "event",
+          event_date: "1712534400000",
+          ramp_days: 7,
+          follow_up_days: 2,
+        },
+      ],
+    });
+    const { deferredTriggers } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidateNodeIds,
+      now,
+    );
+    // Should have the explicit trigger (coerced) plus possibly the auto-created one
+    const explicitTrigger = deferredTriggers.find(
+      (t) => t.trigger.eventDate === 1712534400000,
+    );
+    expect(explicitTrigger).toBeTruthy();
+    expect(explicitTrigger!.trigger.eventDate).toBe(1712534400000);
+  });
+
+  test("coerces string event_date on update_nodes", () => {
+    const existingNodeId = "existing-node-1";
+    const candidates = new Set([existingNodeId]);
+    const input = {
+      create_nodes: [],
+      reinforce_node_ids: [],
+      update_nodes: [
+        {
+          id: existingNodeId,
+          event_date: "1712534400000",
+        },
+      ],
+    };
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidates,
+      now,
+    );
+    expect(diff.updateNodes[0].changes.eventDate).toBe(1712534400000);
+  });
+
+  test("null-clears event_date on update_nodes when explicitly null", () => {
+    const existingNodeId = "existing-node-1";
+    const candidates = new Set([existingNodeId]);
+    const input = {
+      create_nodes: [],
+      reinforce_node_ids: [],
+      update_nodes: [
+        {
+          id: existingNodeId,
+          event_date: null,
+        },
+      ],
+    };
+    const { diff } = parseExtractionResponse(
+      input,
+      conversationId,
+      scopeId,
+      candidates,
+      now,
+    );
+    expect(diff.updateNodes[0].changes.eventDate).toBeNull();
+  });
+});

package/src/__tests__/guardian-action-conversation-turn.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -11,7 +11,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   createGuardianActionDelivery,
   createGuardianActionRequest,
@@ -133,10 +133,6 @@ describe("guardian-action-conversation-turn", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── processGuardianFollowUpTurn: classification ─────────────────────
 
   test('classifies "call them back" as call_back', async () => {

package/src/__tests__/guardian-action-followup-executor.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -56,7 +56,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { initializeDb, resetDb } from "../memory/db.js";
+import { initializeDb } from "../memory/db.js";
 import { getDb } from "../memory/db.js";
 import {
   createGuardianActionDelivery,
@@ -160,10 +160,6 @@ describe("guardian-action-followup-executor", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── Counterparty resolution ─────────────────────────────────────────
 
   describe("resolveCounterparty", () => {

package/src/__tests__/guardian-action-followup-store.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -11,7 +11,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   createGuardianActionRequest,
   expireGuardianActionRequest,
@@ -75,10 +75,6 @@ describe("guardian-action-followup-store", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── markTimedOutWithReason ──────────────────────────────────────────
 
   test("markTimedOutWithReason sets expired_reason correctly for call_timeout", () => {

package/src/__tests__/guardian-action-grant-mint-consume.test.ts

@@ -10,7 +10,7 @@
  *   5. Second consume attempt is denied (one-time use)
  */
 
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 // ── Platform + logger mocks ─────────────────────────────────────────
 
@@ -28,7 +28,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   createGuardianActionRequest,
   resolveGuardianActionRequest,
@@ -43,10 +43,6 @@ import { computeToolApprovalDigest } from "../security/tool-approval-digest.js";
 
 initializeDb();
 
-afterAll(() => {
-  resetDb();
-});
-
 // ── Constants ───────────────────────────────────────────────────────
 
 const TOOL_NAME = "execute_shell";

package/src/__tests__/guardian-action-late-reply.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -18,7 +18,7 @@ import {
   getCallSession,
   updateCallSession,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   createGuardianActionDelivery,
   createGuardianActionRequest,
@@ -115,10 +115,6 @@ describe("guardian-action-late-reply", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── getExpiredDeliveriesByDestination ──────────────────────────────
 
   test("getExpiredDeliveriesByDestination returns expired deliveries for follow-up eligible requests", () => {

package/src/__tests__/guardian-action-store.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -11,7 +11,7 @@ import {
   createCallSession,
   createPendingQuestion,
 } from "../calls/call-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   cancelGuardianActionRequest,
   createGuardianActionDelivery,
@@ -57,10 +57,6 @@ describe("guardian-action-store", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── Helper to create a pending request+delivery targeting a conversation ──
   function createPendingRequestWithDelivery(
     convId: string,

package/src/__tests__/guardian-binding-drift-heal.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -9,7 +9,7 @@ mock.module("../util/logger.js", () => ({
 
 import { findGuardianForChannel } from "../contacts/contact-store.js";
 import { createGuardianBinding } from "../contacts/contacts-write.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import { healGuardianBindingDrift } from "../runtime/guardian-vellum-migration.js";
 
 initializeDb();
@@ -25,10 +25,6 @@ describe("healGuardianBindingDrift", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   test("heals drift when both principals have vellum-principal- prefix", () => {
     // Simulate DB reset: new guardian binding with a different UUID
     createGuardianBinding({

package/src/__tests__/guardian-decision-primitive-canonical.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -23,7 +23,7 @@ import {
   createCanonicalGuardianRequest,
   getCanonicalGuardianRequest,
 } from "../memory/canonical-guardian-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import { scopedApprovalGrants } from "../memory/schema.js";
 
 initializeDb();
@@ -35,10 +35,6 @@ function resetTables(): void {
   db.run("DELETE FROM canonical_guardian_requests");
 }
 
-afterAll(() => {
-  resetDb();
-});
-
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------
@@ -736,8 +732,12 @@ describe("mintCanonicalRequestGrant", () => {
     const db = getDb();
     const grants = db.select().from(scopedApprovalGrants).all();
     expect(grants.length).toBe(1);
-    expect(grants[0].expiresAt).toBeGreaterThanOrEqual(before + GRANT_TTL_10M_MS);
-    expect(grants[0].expiresAt).toBeLessThanOrEqual(Date.now() + GRANT_TTL_10M_MS);
+    expect(grants[0].expiresAt).toBeGreaterThanOrEqual(
+      before + GRANT_TTL_10M_MS,
+    );
+    expect(grants[0].expiresAt).toBeLessThanOrEqual(
+      Date.now() + GRANT_TTL_10M_MS,
+    );
   });
 
   test("mints grant with no wall-clock expiry for approve_conversation", () => {

package/src/__tests__/guardian-dispatch.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 import type { ConversationCreatedInfo } from "../notifications/broadcaster.js";
 import type { NotificationDeliveryResult } from "../notifications/types.js";
@@ -71,7 +71,7 @@ import {
   createPendingQuestion,
 } from "../calls/call-store.js";
 import { dispatchGuardianQuestion } from "../calls/guardian-dispatch.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import { conversations } from "../memory/schema.js";
 
 initializeDb();
@@ -125,10 +125,6 @@ describe("guardian-dispatch", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   test("creates a guardian action request and vellum delivery from pipeline results", async () => {
     const convId = "conv-dispatch-1";
     ensureConversation(convId);

package/src/__tests__/guardian-grant-minting.test.ts

@@ -6,15 +6,7 @@
  * Non-tool-approval requests and rejections must NOT mint grants.
  */
 
-import {
-  afterAll,
-  beforeEach,
-  describe,
-  expect,
-  mock,
-  spyOn,
-  test,
-} from "bun:test";
+import { beforeEach, describe, expect, mock, spyOn, test } from "bun:test";
 
 // ---------------------------------------------------------------------------
 // Test isolation: in-memory SQLite via temp directory
@@ -30,7 +22,7 @@ mock.module("../util/logger.js", () => ({
 import { GRANT_TTL_MS } from "../approvals/guardian-decision-primitive.js";
 import type { Conversation } from "../daemon/conversation.js";
 import type { TrustContext } from "../daemon/conversation-runtime-assembly.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 import {
   createApprovalRequest,
   getPendingApprovalForRequest,
@@ -46,10 +38,6 @@ import "../memory/scoped-approval-grants.js";
 
 initializeDb();
 
-afterAll(() => {
-  resetDb();
-});
-
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------

package/src/__tests__/guardian-principal-id-roundtrip.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -13,7 +13,7 @@ import {
   resolveCanonicalGuardianRequest,
   updateCanonicalGuardianRequest,
 } from "../memory/canonical-guardian-store.js";
-import { getDb, initializeDb, resetDb } from "../memory/db.js";
+import { getDb, initializeDb } from "../memory/db.js";
 
 initializeDb();
 
@@ -28,10 +28,6 @@ describe("guardianPrincipalId roundtrip", () => {
     resetTables();
   });
 
-  afterAll(() => {
-    resetDb();
-  });
-
   // ── canonical_guardian_requests ──────────────────────────────────────
 
   describe("canonical_guardian_requests", () => {