@vellumai/assistant 0.5.15 → 0.5.16

package/src/__tests__/oauth-provider-serializer.test.ts

@@ -19,7 +19,6 @@ function makeRow(overrides: Partial<OAuthProviderRow> = {}): OAuthProviderRow {
     defaultScopes: "[]",
     scopePolicy: "{}",
     extraParams: null,
-    callbackTransport: null,
     pingUrl: null,
     pingMethod: null,
     pingHeaders: null,
@@ -41,6 +40,7 @@ function makeRow(overrides: Partial<OAuthProviderRow> = {}): OAuthProviderRow {
     identityResponsePaths: null,
     identityFormat: null,
     identityOkField: null,
+    featureFlag: null,
     createdAt: now,
     updatedAt: now,
     ...overrides,
@@ -191,6 +191,7 @@ describe("serializeProviderSummary", () => {
       client_id_placeholder: "your-client-id.apps.googleusercontent.com",
       requires_client_secret: true,
       supports_managed_mode: true,
+      feature_flag: null,
     });
   });
 

package/src/__tests__/oauth-provider-visibility.test.ts

@@ -0,0 +1,149 @@
+import {
+  afterAll,
+  afterEach,
+  beforeEach,
+  describe,
+  expect,
+  mock,
+  test,
+} from "bun:test";
+
+mock.module("../util/logger.js", () => ({
+  getLogger: () =>
+    new Proxy({} as Record<string, unknown>, {
+      get: () => () => {},
+    }),
+}));
+
+mock.module("../security/secure-keys.js", () => ({
+  deleteSecureKeyAsync: () => Promise.resolve("deleted" as const),
+  setSecureKeyAsync: () => Promise.resolve(true),
+  getSecureKeyAsync: () => Promise.resolve(undefined),
+}));
+
+import { _setOverridesForTesting } from "../config/assistant-feature-flags.js";
+import type { AssistantConfig } from "../config/schema.js";
+import { initializeDb, resetDb, resetTestTables } from "../memory/db.js";
+import { listProviders, seedProviders } from "../oauth/oauth-store.js";
+import { isProviderVisible } from "../oauth/provider-visibility.js";
+
+initializeDb();
+
+/** Create a minimal AssistantConfig for testing. */
+function makeConfig(): AssistantConfig {
+  return {} as AssistantConfig;
+}
+
+beforeEach(() => {
+  resetTestTables("oauth_connections", "oauth_apps", "oauth_providers");
+  _setOverridesForTesting({});
+});
+
+afterEach(() => {
+  _setOverridesForTesting({});
+});
+
+afterAll(() => {
+  resetDb();
+});
+
+describe("isProviderVisible", () => {
+  test("returns true when featureFlag is null", () => {
+    seedProviders([
+      {
+        providerKey: "no-flag-provider",
+        authUrl: "https://example.com/auth",
+        tokenUrl: "https://example.com/token",
+        defaultScopes: ["read"],
+        scopePolicy: {},
+      },
+    ]);
+
+    const providers = listProviders();
+    const provider = providers.find(
+      (p) => p.providerKey === "no-flag-provider",
+    );
+    expect(provider).toBeDefined();
+    expect(provider!.featureFlag).toBeNull();
+
+    const config = makeConfig();
+    expect(isProviderVisible(provider!, config)).toBe(true);
+  });
+
+  test("returns true when featureFlag is set and the flag is enabled", () => {
+    _setOverridesForTesting({ "test-gate": true });
+
+    seedProviders([
+      {
+        providerKey: "gated-provider",
+        authUrl: "https://example.com/auth",
+        tokenUrl: "https://example.com/token",
+        defaultScopes: ["read"],
+        scopePolicy: {},
+        featureFlag: "test-gate",
+      },
+    ]);
+
+    const providers = listProviders();
+    const provider = providers.find((p) => p.providerKey === "gated-provider");
+    expect(provider).toBeDefined();
+    expect(provider!.featureFlag).toBe("test-gate");
+
+    const config = makeConfig();
+    expect(isProviderVisible(provider!, config)).toBe(true);
+  });
+
+  test("returns false when featureFlag is set and the flag is disabled", () => {
+    _setOverridesForTesting({ "test-gate": false });
+
+    seedProviders([
+      {
+        providerKey: "gated-provider",
+        authUrl: "https://example.com/auth",
+        tokenUrl: "https://example.com/token",
+        defaultScopes: ["read"],
+        scopePolicy: {},
+        featureFlag: "test-gate",
+      },
+    ]);
+
+    const providers = listProviders();
+    const provider = providers.find((p) => p.providerKey === "gated-provider");
+    expect(provider).toBeDefined();
+
+    const config = makeConfig();
+    expect(isProviderVisible(provider!, config)).toBe(false);
+  });
+
+  test("listProviders returns all providers but isProviderVisible filters gated ones when flag is disabled", () => {
+    _setOverridesForTesting({ "test-gate": false });
+
+    seedProviders([
+      {
+        providerKey: "visible-provider",
+        authUrl: "https://example.com/auth",
+        tokenUrl: "https://example.com/token",
+        defaultScopes: ["read"],
+        scopePolicy: {},
+      },
+      {
+        providerKey: "gated-provider",
+        authUrl: "https://gated.example.com/auth",
+        tokenUrl: "https://gated.example.com/token",
+        defaultScopes: ["read"],
+        scopePolicy: {},
+        featureFlag: "test-gate",
+      },
+    ]);
+
+    const allProviders = listProviders();
+    expect(allProviders).toHaveLength(2);
+
+    const config = makeConfig();
+    const visibleProviders = allProviders.filter((p) =>
+      isProviderVisible(p, config),
+    );
+    expect(visibleProviders).toHaveLength(1);
+    expect(visibleProviders[0]!.providerKey).toBe("visible-provider");
+  });
+});

package/src/__tests__/oauth-providers-routes.test.ts

@@ -17,7 +17,7 @@ const mockListProviders = mock(() => [
     defaultScopes: "[]",
     scopePolicy: "[]",
     extraParams: null,
-    callbackTransport: null,
+
     pingUrl: null,
     pingMethod: null,
     pingHeaders: null,
@@ -33,6 +33,7 @@ const mockListProviders = mock(() => [
     identityFormat: null,
     identityOkField: null,
     identityResponsePaths: null,
+    featureFlag: null,
     createdAt: 1735689500000,
     updatedAt: 1735689550000,
   },
@@ -52,7 +53,7 @@ const mockListProviders = mock(() => [
     defaultScopes: "[]",
     scopePolicy: "[]",
     extraParams: null,
-    callbackTransport: null,
+
     pingUrl: null,
     pingMethod: null,
     pingHeaders: null,
@@ -68,6 +69,7 @@ const mockListProviders = mock(() => [
     identityFormat: null,
     identityOkField: null,
     identityResponsePaths: null,
+    featureFlag: null,
     createdAt: 1735689600000,
     updatedAt: 1735689650000,
   },
@@ -148,6 +150,7 @@ describe("GET /v1/oauth/providers", () => {
       "client_id_placeholder",
       "requires_client_secret",
       "supports_managed_mode",
+      "feature_flag",
     ];
 
     for (const provider of body.providers) {

package/src/__tests__/oauth-store.test.ts

@@ -208,7 +208,6 @@ describe("provider operations", () => {
           userinfoUrl: "https://api.github.com/user",
           baseUrl: "https://api.github.com",
           extraParams: { prompt: "consent" },
-          callbackTransport: "loopback",
 
           pingUrl: "https://api.github.com/user",
         },
@@ -249,7 +248,6 @@ describe("provider operations", () => {
           userinfoUrl: "https://api.github.com/user-v2",
           baseUrl: "https://api.github.com/v2",
           extraParams: { prompt: "login" },
-          callbackTransport: "gateway",
 
           pingUrl: "https://api.github.com/user-v2",
         },
@@ -272,7 +270,6 @@ describe("provider operations", () => {
       expect(row!.tokenEndpointAuthMethod).toBe("client_secret_basic");
       expect(row!.userinfoUrl).toBe("https://api.github.com/user-v2");
       expect(JSON.parse(row!.extraParams!)).toEqual({ prompt: "login" });
-      expect(row!.callbackTransport).toBe("gateway");
       expect(row!.pingUrl).toBe("https://api.github.com/user-v2");
     });
   });
@@ -286,14 +283,12 @@ describe("provider operations", () => {
           tokenUrl: "https://github.com/token",
           defaultScopes: ["repo"],
           scopePolicy: {},
-          callbackTransport: "loopback",
         },
       ]);
 
       const row = getProvider("github");
       expect(row).toBeDefined();
       expect(row!.providerKey).toBe("github");
-      expect(row!.callbackTransport).toBe("loopback");
     });
 
     test("returns undefined for unknown keys", () => {