@vellumai/assistant 0.5.13 → 0.5.15

package/src/__tests__/memory-regressions.experimental.test.ts

@@ -1,6 +1,3 @@
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
 import {
   afterAll,
   beforeAll,
@@ -11,17 +8,15 @@ import {
   test,
 } from "bun:test";
 
-const testDir = mkdtempSync(join(tmpdir(), "memory-regressions-exp-"));
-
-mock.module("../util/platform.js", () => ({
-  getDataDir: () => testDir,
-  isMacOS: () => process.platform === "darwin",
-  isLinux: () => process.platform === "linux",
-  isWindows: () => process.platform === "win32",
-  getPidPath: () => join(testDir, "test.pid"),
-  getDbPath: () => join(testDir, "test.db"),
-  getLogPath: () => join(testDir, "test.log"),
-  ensureDataDir: () => {},
+mock.module("../security/secure-keys.js", () => ({
+  getProviderKeyAsync: async () => undefined,
+  getSecureKeyAsync: async () => undefined,
+  getSecureKeyResultAsync: async () => ({ status: "missing" }),
+  listSecureKeysAsync: async () => [],
+  setSecureKeyAsync: async () => ({ status: "ok" }),
+  deleteSecureKeyAsync: async () => ({ status: "ok" }),
+  getActiveBackendName: () => "mock",
+  _resetBackend: () => {},
 }));
 
 mock.module("../util/logger.js", () => ({
@@ -112,11 +107,6 @@ describe("Memory regressions (experimental)", () => {
 
   afterAll(() => {
     resetDb();
-    try {
-      rmSync(testDir, { recursive: true });
-    } catch {
-      // best effort cleanup
-    }
   });
 
   async function withMockOllamaQueryEmbedding<T>(
@@ -169,7 +159,7 @@ describe("Memory regressions (experimental)", () => {
         totalOutputTokens: 0,
         totalEstimatedCost: 0,
         contextSummary: null,
-        contextCompactedMessageCount: 0,
+        contextCompactedMessageCount: 1,
         contextCompactedAt: null,
       })
       .run();
@@ -293,7 +283,7 @@ describe("Memory regressions (experimental)", () => {
         totalOutputTokens: 0,
         totalEstimatedCost: 0,
         contextSummary: null,
-        contextCompactedMessageCount: 0,
+        contextCompactedMessageCount: 1,
         contextCompactedAt: null,
       })
       .run();
@@ -506,7 +496,10 @@ describe("Memory regressions (experimental)", () => {
         conversationId: "conv-index",
         role: "user",
         content: JSON.stringify([
-          { type: "text", text: "Please remember this implementation detail." },
+          {
+            type: "text",
+            text: "Please remember this important implementation detail about our project configuration.",
+          },
         ]),
         createdAt,
       })
@@ -518,14 +511,17 @@ describe("Memory regressions (experimental)", () => {
         conversationId: "conv-index",
         role: "user",
         content: JSON.stringify([
-          { type: "text", text: "Please remember this implementation detail." },
+          {
+            type: "text",
+            text: "Please remember this important implementation detail about our project configuration.",
+          },
         ]),
         createdAt,
       },
       DEFAULT_CONFIG.memory,
     );
-    // embed_segment (1 segment) + extract_items + build_conversation_summary = 3
-    expect(result.enqueuedJobs).toBe(3);
+    // embed_segment (1 segment) — extraction and conversation summary are batched, not per-message
+    expect(result.enqueuedJobs).toBe(1);
 
     const embedSegmentJobs = db
       .select()
@@ -558,7 +554,10 @@ describe("Memory regressions (experimental)", () => {
         conversationId: "conv-assistant-index",
         role: "assistant",
         content: JSON.stringify([
-          { type: "text", text: "I think your timezone is PST." },
+          {
+            type: "text",
+            text: "I think your timezone is PST based on your previous messages and location data.",
+          },
         ]),
         createdAt,
       })
@@ -578,15 +577,17 @@ describe("Memory regressions (experimental)", () => {
         conversationId: "conv-assistant-index",
         role: "assistant",
         content: JSON.stringify([
-          { type: "text", text: "I think your timezone is PST." },
+          {
+            type: "text",
+            text: "I think your timezone is PST based on your previous messages and location data.",
+          },
         ]),
         createdAt,
       },
       memoryConfig,
     );
-    // embed_segment (1 segment) + build_conversation_summary = 2
-    // (extract_items is skipped for assistant messages when extractFromAssistant=false)
-    expect(result.enqueuedJobs).toBe(2);
+    // embed_segment (1 segment) — extraction and conversation summary are batched, not per-message
+    expect(result.enqueuedJobs).toBe(1);
 
     const extractionJobs = db
       .select()