@vellumai/assistant 0.5.11 → 0.5.13

package/src/cli/commands/oauth/ping.ts

@@ -7,7 +7,6 @@ import {
 import { getProvider } from "../../../oauth/oauth-store.js";
 import { getCliLogger } from "../../logger.js";
 import { shouldOutputJson, writeOutput } from "../../output.js";
-import { resolveService } from "./shared.js";
 
 const log = getCliLogger("cli");
 
@@ -19,7 +18,7 @@ export function registerPingCommand(oauth: Command): void {
   oauth
     .command("ping <provider>")
     .description(
-      "Verify an OAuth token is valid by hitting the provider's health-check endpoint",
+      "Verify an OAuth token is valid by hitting the provider's configured health-check endpoint",
     )
     .option("--account <account>", "Account identifier for multi-account")
     .option("--client-id <id>", "BYO app client ID disambiguation")
@@ -27,25 +26,16 @@ export function registerPingCommand(oauth: Command): void {
       "after",
       `
 Arguments:
-  provider   Provider key, alias, or provider ID from 'assistant oauth providers list'.
-             Accepts canonical keys (e.g. integration:google), aliases (e.g.
-             gmail), or bare provider names (e.g. google).
-
-Options:
-  --account <account>   Account identifier (e.g. email) to disambiguate when
-                        multiple accounts are connected for the same provider.
-  --client-id <id>      BYO-only: select a specific OAuth app when multiple
-                        apps exist for the same provider. Ignored for
-                        platform-managed providers.
-
-Mode detection:
-  The command auto-detects whether the provider runs in platform-managed or
-  BYO (bring-your-own credentials) mode via resolveOAuthConnection. Managed
-  mode routes through the platform proxy; BYO mode uses locally stored tokens.
+  provider   Provider name (e.g. google, slack).
+             Run 'assistant oauth providers list' to see available providers.
+
+Hits the provider's configured ping URL with the stored OAuth token and
+reports whether the token is valid. Use 'assistant oauth status <provider>'
+to find account identifiers for --account.
 
 Examples:
   $ assistant oauth ping google
-  $ assistant oauth ping integration:google --json
+  $ assistant oauth ping google --json
   $ assistant oauth ping google --account user@example.com`,
     )
     .action(
@@ -61,19 +51,14 @@ Examples:
 
         try {
           // -----------------------------------------------------------------
-          // 1. Resolve provider key
-          // -----------------------------------------------------------------
-          const providerKey = resolveService(provider);
-
-          // -----------------------------------------------------------------
-          // 2. Validate provider exists
+          // 1. Validate provider exists
           // -----------------------------------------------------------------
-          const providerRow = getProvider(providerKey);
+          const providerRow = getProvider(provider);
           if (!providerRow) {
             writeOutput(cmd, {
               ok: false,
               error:
-                `Unknown provider "${providerKey}". ` +
+                `Unknown provider "${provider}". ` +
                 `Run 'assistant oauth providers list' to see available providers.`,
             });
             process.exitCode = 1;
@@ -87,7 +72,7 @@ Examples:
             writeOutput(cmd, {
               ok: false,
               error:
-                `No ping URL configured for "${providerKey}". ` +
+                `No ping URL configured for "${provider}". ` +
                 `Register one with 'assistant oauth providers register --ping-url <url>'.`,
             });
             process.exitCode = 1;
@@ -118,10 +103,7 @@ Examples:
 
           let connection;
           try {
-            connection = await resolveOAuthConnection(
-              providerKey,
-              resolveOptions,
-            );
+            connection = await resolveOAuthConnection(provider, resolveOptions);
           } catch (resolveErr) {
             const resolveMessage =
               resolveErr instanceof Error
@@ -132,7 +114,7 @@ Examples:
               ok: false,
               error: resolveMessage,
               hint:
-                `Run 'assistant oauth status ${providerKey}' to check connection health. ` +
+                `Run 'assistant oauth status ${provider}' to check connection health. ` +
                 `To reconnect, run 'assistant oauth connect --help'.`,
             });
             process.exitCode = 1;
@@ -171,25 +153,25 @@ Examples:
           if (response.status >= 200 && response.status < 300) {
             // Success
             if (!jsonMode) {
-              log.info(`${providerKey}: OK (HTTP ${response.status})`);
+              log.info(`${provider}: OK (HTTP ${response.status})`);
             }
             writeOutput(cmd, {
               ok: true,
-              provider: providerKey,
+              provider: provider,
               status: response.status,
             });
           } else {
             // Non-2xx failure
             const payload: Record<string, unknown> = {
               ok: false,
-              provider: providerKey,
+              provider: provider,
               status: response.status,
               error: `Ping failed with HTTP ${response.status}`,
             };
 
             if (response.status === 401 || response.status === 403) {
               payload.hint =
-                `Run 'assistant oauth status ${providerKey}' to check connection health. ` +
+                `Run 'assistant oauth status ${provider}' to check connection health. ` +
                 `To reconnect, run 'assistant oauth connect --help'.`;
             }
 
@@ -200,19 +182,11 @@ Examples:
           // Network failure or other unexpected error
           const message = err instanceof Error ? err.message : String(err);
 
-          // Try to extract providerKey for recovery hints
-          let providerKey: string;
-          try {
-            providerKey = resolveService(provider);
-          } catch {
-            providerKey = provider;
-          }
-
           writeOutput(cmd, {
             ok: false,
             error: message,
             hint:
-              `Run 'assistant oauth status ${providerKey}' to check connection health. ` +
+              `Run 'assistant oauth status ${provider}' to check connection health. ` +
               `To reconnect, run 'assistant oauth connect --help'.`,
           });
           process.exitCode = 1;