@vellumai/assistant 0.5.0 → 0.5.2

package/src/__tests__/suggestion-routes.test.ts

@@ -0,0 +1,443 @@
+/**
+ * Unit tests for the GET /v1/suggestion endpoint (handleGetSuggestion).
+ *
+ * Validates happy path, all null-return paths, caching, staleness check,
+ * quote stripping, word-boundary truncation, empty response rejection,
+ * and modelIntent verification.
+ */
+
+import { describe, expect, mock, test } from "bun:test";
+
+// ---------------------------------------------------------------------------
+// Mocks — must be defined before importing the module under test
+// ---------------------------------------------------------------------------
+
+mock.module("../util/logger.js", () => ({
+  getLogger: () =>
+    new Proxy({} as Record<string, unknown>, {
+      get: () => () => {},
+    }),
+}));
+
+const mockGetConversationByKey = mock(
+  (_key: string): { conversationId: string } | null => ({
+    conversationId: "conv-test",
+  }),
+);
+
+mock.module("../memory/conversation-key-store.js", () => ({
+  getConversationByKey: mockGetConversationByKey,
+}));
+
+const mockGetMessages = mock((_conversationId: string) => [
+  {
+    id: "msg-user-1",
+    conversationId: "conv-test",
+    role: "user",
+    content: JSON.stringify([{ type: "text", text: "Hello there" }]),
+    createdAt: Date.now() - 2000,
+    metadata: null,
+  },
+  {
+    id: "msg-asst-1",
+    conversationId: "conv-test",
+    role: "assistant",
+    content: JSON.stringify([
+      { type: "text", text: "Hi! How can I help you today?" },
+    ]),
+    createdAt: Date.now() - 1000,
+    metadata: null,
+  },
+]);
+
+mock.module("../memory/conversation-crud.js", () => ({
+  getMessages: mockGetMessages,
+}));
+
+const mockGetConfiguredProvider = mock(async () => ({
+  name: "test-provider",
+  sendMessage: mock(async () => ({
+    content: [{ type: "text", text: "Let's do round two!" }],
+    model: "test",
+    usage: { inputTokens: 1, outputTokens: 1 },
+    stopReason: "end_turn",
+  })),
+}));
+
+mock.module("../providers/provider-send-message.js", () => ({
+  getConfiguredProvider: mockGetConfiguredProvider,
+}));
+
+mock.module("../daemon/handlers/shared.js", () => ({
+  renderHistoryContent: (content: unknown) => {
+    // Extract text from content blocks, mirroring the real function
+    if (Array.isArray(content)) {
+      const texts = content
+        .filter((b: { type: string }) => b.type === "text" && "text" in b)
+        .map((b: { text: string }) => b.text);
+      return {
+        text: texts.join("\n"),
+        toolCalls: [],
+        toolCallsBeforeText: false,
+        textSegments: [],
+        contentOrder: [],
+        surfaces: [],
+      };
+    }
+    return {
+      text: typeof content === "string" ? content : "",
+      toolCalls: [],
+      toolCallsBeforeText: false,
+      textSegments: [],
+      contentOrder: [],
+      surfaces: [],
+    };
+  },
+}));
+
+// ---------------------------------------------------------------------------
+// Imports (after mocks)
+// ---------------------------------------------------------------------------
+
+import { handleGetSuggestion } from "../runtime/routes/conversation-routes.js";
+
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+
+function makeUrl(params: {
+  conversationKey?: string;
+  messageId?: string;
+}): URL {
+  const url = new URL("http://localhost/v1/suggestion");
+  if (params.conversationKey) {
+    url.searchParams.set("conversationKey", params.conversationKey);
+  }
+  if (params.messageId) {
+    url.searchParams.set("messageId", params.messageId);
+  }
+  return url;
+}
+
+function makeDeps() {
+  return {
+    suggestionCache: new Map<string, string>(),
+    suggestionInFlight: new Map<string, Promise<string | null>>(),
+  };
+}
+
+function makeMockProvider(text: string) {
+  return {
+    name: "test-provider",
+    sendMessage: mock(async () => ({
+      content: [{ type: "text" as const, text }],
+      model: "test",
+      usage: { inputTokens: 1, outputTokens: 1 },
+      stopReason: "end_turn",
+    })),
+  };
+}
+
+// ---------------------------------------------------------------------------
+// Tests
+// ---------------------------------------------------------------------------
+
+describe("GET /v1/suggestion", () => {
+  test("returns suggestion from LLM", async () => {
+    const provider = makeMockProvider("Let's do round two!");
+    mockGetConfiguredProvider.mockImplementation(async () => provider);
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => [
+      {
+        id: "msg-user-1",
+        conversationId: "conv-test",
+        role: "user",
+        content: JSON.stringify([{ type: "text", text: "Hello" }]),
+        createdAt: Date.now() - 2000,
+        metadata: null,
+      },
+      {
+        id: "msg-asst-1",
+        conversationId: "conv-test",
+        role: "assistant",
+        content: JSON.stringify([
+          { type: "text", text: "Hi! How can I help you today?" },
+        ]),
+        createdAt: Date.now() - 1000,
+        metadata: null,
+      },
+    ]);
+
+    const url = makeUrl({ conversationKey: "test-key" });
+    const deps = makeDeps();
+    const res = await handleGetSuggestion(url, deps);
+    const body = (await res.json()) as {
+      suggestion: string;
+      source: string;
+    };
+
+    expect(body.suggestion).toBe("Let's do round two!");
+    expect(body.source).toBe("llm");
+  });
+
+  test("returns null when no conversation found", async () => {
+    mockGetConversationByKey.mockImplementation(() => null);
+
+    const url = makeUrl({ conversationKey: "nonexistent-key" });
+    const deps = makeDeps();
+    const res = await handleGetSuggestion(url, deps);
+    const body = (await res.json()) as { suggestion: string | null };
+
+    expect(body.suggestion).toBeNull();
+  });
+
+  test("returns null when no messages", async () => {
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => []);
+
+    const url = makeUrl({ conversationKey: "test-key" });
+    const deps = makeDeps();
+    const res = await handleGetSuggestion(url, deps);
+    const body = (await res.json()) as { suggestion: string | null };
+
+    expect(body.suggestion).toBeNull();
+  });
+
+  test("returns null when provider unavailable", async () => {
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => [
+      {
+        id: "msg-asst-1",
+        conversationId: "conv-test",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Hello there" }]),
+        createdAt: Date.now(),
+        metadata: null,
+      },
+    ]);
+    mockGetConfiguredProvider.mockImplementation(
+      async () =>
+        null as unknown as Awaited<
+          ReturnType<typeof mockGetConfiguredProvider>
+        >,
+    );
+
+    const url = makeUrl({ conversationKey: "test-key" });
+    const deps = makeDeps();
+    const res = await handleGetSuggestion(url, deps);
+    const body = (await res.json()) as { suggestion: string | null };
+
+    expect(body.suggestion).toBeNull();
+  });
+
+  test("returns null when provider throws", async () => {
+    const throwingProvider = {
+      name: "test-provider",
+      sendMessage: mock(async () => {
+        throw new Error("Provider error");
+      }),
+    };
+    mockGetConfiguredProvider.mockImplementation(async () => throwingProvider);
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => [
+      {
+        id: "msg-asst-1",
+        conversationId: "conv-test",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Hello there" }]),
+        createdAt: Date.now(),
+        metadata: null,
+      },
+    ]);
+
+    const url = makeUrl({ conversationKey: "test-key" });
+    const deps = makeDeps();
+    const res = await handleGetSuggestion(url, deps);
+
+    // Should return null gracefully, not a 500
+    expect(res.status).toBe(200);
+    const body = (await res.json()) as { suggestion: string | null };
+    expect(body.suggestion).toBeNull();
+  });
+
+  test("strips quotes from LLM response", async () => {
+    const provider = makeMockProvider('"Sure, let\'s go!"');
+    mockGetConfiguredProvider.mockImplementation(async () => provider);
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => [
+      {
+        id: "msg-asst-1",
+        conversationId: "conv-test",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Hello there" }]),
+        createdAt: Date.now(),
+        metadata: null,
+      },
+    ]);
+
+    const url = makeUrl({ conversationKey: "test-key" });
+    const deps = makeDeps();
+    const res = await handleGetSuggestion(url, deps);
+    const body = (await res.json()) as { suggestion: string };
+
+    expect(body.suggestion).toBe("Sure, let's go!");
+  });
+
+  test("truncates long suggestions at word boundary", async () => {
+    // A 60-char string that will exceed the 50-char limit
+    const longText =
+      "This is a really long suggestion that goes well beyond fifty chars";
+    const provider = makeMockProvider(longText);
+    mockGetConfiguredProvider.mockImplementation(async () => provider);
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => [
+      {
+        id: "msg-asst-1",
+        conversationId: "conv-test",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Hello there" }]),
+        createdAt: Date.now(),
+        metadata: null,
+      },
+    ]);
+
+    const url = makeUrl({ conversationKey: "test-key" });
+    const deps = makeDeps();
+    const res = await handleGetSuggestion(url, deps);
+    const body = (await res.json()) as { suggestion: string };
+
+    expect(body.suggestion.length).toBeLessThanOrEqual(50);
+    // Should end at a word boundary (no partial words)
+    expect(body.suggestion).not.toMatch(/\s$/);
+  });
+
+  test("rejects empty LLM response", async () => {
+    const provider = makeMockProvider("");
+    mockGetConfiguredProvider.mockImplementation(async () => provider);
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => [
+      {
+        id: "msg-asst-1",
+        conversationId: "conv-test",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Hello there" }]),
+        createdAt: Date.now(),
+        metadata: null,
+      },
+    ]);
+
+    const url = makeUrl({ conversationKey: "test-key" });
+    const deps = makeDeps();
+    const res = await handleGetSuggestion(url, deps);
+    const body = (await res.json()) as { suggestion: string | null };
+
+    expect(body.suggestion).toBeNull();
+  });
+
+  test("returns cached suggestion", async () => {
+    const provider = makeMockProvider("Fresh suggestion");
+    mockGetConfiguredProvider.mockImplementation(async () => provider);
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => [
+      {
+        id: "msg-asst-cache",
+        conversationId: "conv-test",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Some response" }]),
+        createdAt: Date.now(),
+        metadata: null,
+      },
+    ]);
+
+    const url = makeUrl({ conversationKey: "test-key" });
+    const deps = makeDeps();
+
+    // First call — should hit the LLM
+    const res1 = await handleGetSuggestion(url, deps);
+    const body1 = (await res1.json()) as { suggestion: string };
+    expect(body1.suggestion).toBe("Fresh suggestion");
+
+    // Second call — should return from cache
+    const res2 = await handleGetSuggestion(url, deps);
+    const body2 = (await res2.json()) as { suggestion: string };
+    expect(body2.suggestion).toBe("Fresh suggestion");
+
+    // Provider sendMessage should have been called only once
+    expect(provider.sendMessage).toHaveBeenCalledTimes(1);
+  });
+
+  test("returns stale when messageId doesn't match", async () => {
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => [
+      {
+        id: "msg-asst-latest",
+        conversationId: "conv-test",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Latest response" }]),
+        createdAt: Date.now(),
+        metadata: null,
+      },
+    ]);
+
+    const url = makeUrl({
+      conversationKey: "test-key",
+      messageId: "msg-asst-old",
+    });
+    const deps = makeDeps();
+    const res = await handleGetSuggestion(url, deps);
+    const body = (await res.json()) as {
+      suggestion: string | null;
+      stale: boolean;
+    };
+
+    expect(body.stale).toBe(true);
+    expect(body.suggestion).toBeNull();
+  });
+
+  test("uses latency-optimized model intent", async () => {
+    const provider = makeMockProvider("Quick reply");
+    mockGetConfiguredProvider.mockImplementation(async () => provider);
+    mockGetConversationByKey.mockImplementation(() => ({
+      conversationId: "conv-test",
+    }));
+    mockGetMessages.mockImplementation(() => [
+      {
+        id: "msg-asst-intent",
+        conversationId: "conv-test",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Hello!" }]),
+        createdAt: Date.now(),
+        metadata: null,
+      },
+    ]);
+
+    const url = makeUrl({ conversationKey: "test-key" });
+    const deps = makeDeps();
+    await handleGetSuggestion(url, deps);
+
+    expect(provider.sendMessage).toHaveBeenCalledTimes(1);
+    const callArgs = provider.sendMessage.mock.calls[0] as unknown[];
+    const options = callArgs[3] as
+      | { config?: { modelIntent?: string } }
+      | undefined;
+    expect(options?.config?.modelIntent).toBe("latency-optimized");
+  });
+});

package/src/__tests__/swarm-conversation-integration.test.ts

@@ -70,6 +70,7 @@ const mockTestProvider = {
 let mockAnthropicKey: string | undefined = "test-api-key";
 mock.module("../security/secure-keys.js", () => ({
   getSecureKeyAsync: async () => mockAnthropicKey,
+  getProviderKeyAsync: async () => mockAnthropicKey,
 }));
 
 mock.module("../providers/registry.js", () => ({

package/src/__tests__/swarm-recursion.test.ts

@@ -81,6 +81,7 @@ const mockProvider = {
 };
 mock.module("../security/secure-keys.js", () => ({
   getSecureKeyAsync: async () => "test-api-key",
+  getProviderKeyAsync: async () => "test-api-key",
 }));
 
 mock.module("../providers/registry.js", () => ({

package/src/__tests__/swarm-tool.test.ts

@@ -76,6 +76,7 @@ const mockProvider = {
 };
 mock.module("../security/secure-keys.js", () => ({
   getSecureKeyAsync: async () => "test-api-key",
+  getProviderKeyAsync: async () => "test-api-key",
 }));
 
 mock.module("../providers/registry.js", () => ({

package/src/__tests__/system-prompt.test.ts

@@ -237,6 +237,14 @@ describe("buildSystemPrompt", () => {
     expect(result).toContain("browser automation as last resort");
   });
 
+  test("includes inline media attachment guidance", () => {
+    const result = buildSystemPrompt();
+    expect(result).toContain(
+      "Image and video attachments can render inline in chat.",
+    );
+    expect(result).toContain("attach it instead of only printing its path");
+  });
+
   test("does not include removed sections", () => {
     const result = buildSystemPrompt();
     expect(result).not.toContain("## External Communications Identity");

package/src/__tests__/tool-execution-abort-cleanup.test.ts

@@ -79,6 +79,7 @@ mock.module("../util/platform.js", () => ({
   getRootDir: () => "/tmp",
   getDataDir: () => "/tmp",
   getWorkspaceDir: () => "/tmp/workspace",
+  getConversationsDir: () => "/tmp/workspace/conversations",
   getDbPath: () => "/tmp/assistant.db",
   ensureDataDir: () => {},
 }));

package/src/__tests__/tool-preview-lifecycle.test.ts

@@ -68,6 +68,7 @@ mock.module("../memory/conversation-crud.js", () => ({
 
 mock.module("../memory/llm-request-log-store.js", () => ({
   recordRequestLog: () => {},
+  backfillMessageIdOnLogs: () => {},
 }));
 
 // ── Imports (after mocks) ─────────────────────────────────────────────────────
@@ -238,13 +239,13 @@ describe("tool preview lifecycle", () => {
       expect(activity.statusText).toMatch(/^Preparing/);
     });
 
-    test("handleInputJsonDelta includes toolUseId", () => {
+    test("handleInputJsonDelta includes toolUseId for app tools", () => {
       const collector = createEventCollector();
       const deps = createMockDeps({ onEvent: collector.onEvent });
 
       handleInputJsonDelta(state, deps, {
         type: "input_json_delta",
-        toolName: "bash",
+        toolName: "app_create",
         toolUseId: "toolu_delta456",
         accumulatedJson: '{"command": "ls"}',
       });
@@ -253,7 +254,7 @@ describe("tool preview lifecycle", () => {
       const emitted = collector.events[0];
       expect(emitted.type).toBe("tool_input_delta");
       expect((emitted as any).toolUseId).toBe("toolu_delta456");
-      expect((emitted as any).toolName).toBe("bash");
+      expect((emitted as any).toolName).toBe("app_create");
       expect((emitted as any).content).toBe('{"command": "ls"}');
       expect((emitted as any).conversationId).toBe("test-session-id");
     });
@@ -305,7 +306,8 @@ describe("tool preview lifecycle", () => {
       });
 
       const toolUseId = "toolu_ordering_test";
-      const toolName = "file_read";
+      // Use an app tool so input_json_delta is forwarded to the client
+      const toolName = "app_create";
 
       // Step 1: tool_use_preview_start (emitted by provider on content_block_start)
       handleToolUsePreviewStart(state, deps, {
@@ -344,6 +346,30 @@ describe("tool preview lifecycle", () => {
       }
     });
 
+    test("non-app tool input_json_delta events are not forwarded to client", () => {
+      const collector = createEventCollector();
+      const deps = createMockDeps({
+        onEvent: collector.onEvent,
+        ctx: {
+          ...createMockDeps().ctx,
+          emitActivityState: collector.emitActivityState,
+        } as unknown as EventHandlerDeps["ctx"],
+      });
+
+      const toolUseId = "toolu_non_app_delta";
+      const toolName = "file_read";
+
+      handleInputJsonDelta(state, deps, {
+        type: "input_json_delta",
+        toolName,
+        toolUseId,
+        accumulatedJson: '{"path": "/test"}',
+      });
+
+      // Non-app tools should not emit tool_input_delta to the client
+      expect(collector.events).toEqual([]);
+    });
+
     test("full lifecycle: preview_start → input_delta → tool_use → tool_result", () => {
       const collector = createEventCollector();
       const deps = createMockDeps({
@@ -355,7 +381,8 @@ describe("tool preview lifecycle", () => {
       });
 
       const toolUseId = "toolu_full_lifecycle";
-      const toolName = "bash";
+      // Use an app tool so input_json_delta is forwarded to the client
+      const toolName = "app_create";
 
       // 1. Preview start
       handleToolUsePreviewStart(state, deps, {

package/src/__tests__/top-level-renderer.test.ts

@@ -123,4 +123,26 @@ describe("renderWorkspaceTopLevelContext", () => {
     expect(result).toContain("Directories: ");
     expect(result).toContain("Files: a.txt, b.txt");
   });
+
+  test("renders current conversation and attachment paths when provided", () => {
+    const snapshot: TopLevelSnapshot = {
+      rootPath: "/sandbox",
+      directories: ["src"],
+      files: ["package.json"],
+      truncated: false,
+    };
+
+    const result = renderWorkspaceTopLevelContext(snapshot, {
+      currentConversationPath: "conversations/2026-03-19T12-00-00.000Z_conv-1/",
+      currentConversationAttachmentsPath:
+        "conversations/2026-03-19T12-00-00.000Z_conv-1/attachments/",
+    });
+
+    expect(result).toContain(
+      "Current conversation folder: conversations/2026-03-19T12-00-00.000Z_conv-1/",
+    );
+    expect(result).toContain(
+      "Attachment files: conversations/2026-03-19T12-00-00.000Z_conv-1/attachments/",
+    );
+  });
 });