@vellumai/assistant 0.4.55 → 0.4.57

package/src/__tests__/guardian-decision-primitive-canonical.test.ts

@@ -126,7 +126,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "shell",
       inputDigest: "sha256:abc",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -160,7 +160,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "shell",
       inputDigest: "sha256:abc",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -187,7 +187,7 @@ describe("applyCanonicalGuardianDecision", () => {
       callSessionId: "call-1",
       pendingQuestionId: "pq-1",
       questionText: "What is the gate code?",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -214,7 +214,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -241,7 +241,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "shell",
       inputDigest: "sha256:abc",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -265,7 +265,7 @@ describe("applyCanonicalGuardianDecision", () => {
       sourceType: "channel",
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -286,7 +286,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -309,7 +309,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     // First decision succeeds
@@ -358,7 +358,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -388,7 +388,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "shell",
       inputDigest: "sha256:abc",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -421,7 +421,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() - 10_000).toISOString(), // already expired
+      expiresAt: Date.now() - 10_000, // already expired
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -466,7 +466,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "file_read",
       inputDigest: "sha256:def",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -488,7 +488,7 @@ describe("applyCanonicalGuardianDecision", () => {
       callSessionId: "call-99",
       pendingQuestionId: "pq-99",
       questionText: "What is the password?",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -510,7 +510,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     // Should still succeed — CAS resolution happens regardless of resolver
@@ -535,7 +535,7 @@ describe("applyCanonicalGuardianDecision", () => {
       toolName: "host_bash",
       inputDigest: "sha256:voice-digest-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({

package/src/__tests__/guardian-dispatch.test.ts

@@ -3,7 +3,7 @@ import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
-import type { ThreadCreatedInfo } from "../notifications/broadcaster.js";
+import type { ConversationCreatedInfo } from "../notifications/broadcaster.js";
 import type { NotificationDeliveryResult } from "../notifications/types.js";
 
 const testDir = mkdtempSync(join(tmpdir(), "guardian-dispatch-test-"));
@@ -48,7 +48,7 @@ mock.module("../runtime/guardian-vellum-migration.js", () => ({
 }));
 
 const emitCalls: unknown[] = [];
-let threadCreatedFromMock: ThreadCreatedInfo | null = null;
+let conversationCreatedFromMock: ConversationCreatedInfo | null = null;
 let mockEmitResult: {
   signalId: string;
   deduplicated: boolean;
@@ -73,9 +73,9 @@ let mockEmitResult: {
 mock.module("../notifications/emit-signal.js", () => ({
   emitNotificationSignal: async (params: Record<string, unknown>) => {
     emitCalls.push(params);
-    const callback = params.onThreadCreated;
-    if (typeof callback === "function" && threadCreatedFromMock) {
-      callback(threadCreatedFromMock);
+    const callback = params.onConversationCreated;
+    if (typeof callback === "function" && conversationCreatedFromMock) {
+      callback(conversationCreatedFromMock);
     }
     return mockEmitResult;
   },
@@ -119,7 +119,7 @@ function resetTables(): void {
   // Note: mockTelegramBinding/mockVoiceBinding/mockVellumBinding assignments
   // removed — they only fed the stale channel-guardian-store mock.
   emitCalls.length = 0;
-  threadCreatedFromMock = null;
+  conversationCreatedFromMock = null;
   mockEmitResult = {
     signalId: "sig-1",
     deduplicated: false,
@@ -195,8 +195,7 @@ describe("guardian-dispatch", () => {
     expect(vellumDelivery!.destination_conversation_id).toBe("conv-vellum-1");
 
     const signalParams = emitCalls[0] as Record<string, unknown>;
-    expect(signalParams.skipVellumThread).toBeUndefined();
-    expect(typeof signalParams.onThreadCreated).toBe("function");
+    expect(typeof signalParams.onConversationCreated).toBe("function");
   });
 
   test("creates a telegram guardian delivery with binding metadata when pipeline sends telegram", async () => {
@@ -310,11 +309,11 @@ describe("guardian-dispatch", () => {
     expect(vellumDelivery!.status).toBe("failed");
   });
 
-  test("uses onThreadCreated callback conversation when delivery result omits conversationId", async () => {
+  test("uses onConversationCreated callback conversation when delivery result omits conversationId", async () => {
     const convId = "conv-dispatch-4";
     ensureConversation(convId);
 
-    threadCreatedFromMock = {
+    conversationCreatedFromMock = {
       conversationId: "conv-from-thread-created",
       title: "Guardian alert",
       sourceEventName: "guardian.question",

package/src/__tests__/guardian-grant-minting.test.ts

@@ -45,8 +45,8 @@ mock.module("../util/logger.js", () => ({
 }));
 
 import { GRANT_TTL_MS } from "../approvals/guardian-decision-primitive.js";
-import type { Session } from "../daemon/session.js";
-import type { TrustContext } from "../daemon/session-runtime-assembly.js";
+import type { Conversation } from "../daemon/conversation.js";
+import type { TrustContext } from "../daemon/conversation-runtime-assembly.js";
 import { getDb, initializeDb, resetDb } from "../memory/db.js";
 import {
   createApprovalRequest,
@@ -125,10 +125,10 @@ function registerPendingInteraction(
   const mockSession = {
     handleConfirmationResponse,
     ensureActorScopedHistory: async () => {},
-  } as unknown as Session;
+  } as unknown as Conversation;
 
   pendingInteractions.register(requestId, {
-    session: mockSession,
+    conversation: mockSession,
     conversationId,
     kind: "confirmation",
     confirmationDetails: {
@@ -570,7 +570,7 @@ describe("guardian grant minting on tool-approval decisions", () => {
     const grant = getLatestGrant();
     expect(grant).not.toBeNull();
 
-    const expiresAt = new Date(grant!.expires_at as string).getTime();
+    const expiresAt = grant!.expires_at as number;
     const expectedMin = beforeTime + GRANT_TTL_MS - 1000; // 1s tolerance
     const expectedMax = beforeTime + GRANT_TTL_MS + 5000; // 5s tolerance
     expect(expiresAt).toBeGreaterThanOrEqual(expectedMin);

package/src/__tests__/guardian-question-copy.test.ts

@@ -3,19 +3,21 @@ import { describe, expect, test } from "bun:test";
 import { buildFallbackCopy } from "../calls/guardian-question-copy.js";
 
 describe("buildFallbackCopy", () => {
-  test("threadTitle starts with warning emoji", () => {
+  test("conversationTitle starts with warning emoji", () => {
     const result = buildFallbackCopy("What is the gate code?");
-    expect(result.threadTitle.startsWith("\u26A0\uFE0F")).toBe(true);
+    expect(result.conversationTitle.startsWith("\u26A0\uFE0F")).toBe(true);
   });
 
-  test('threadTitle does not start with "Guardian question:"', () => {
+  test('conversationTitle does not start with "Guardian question:"', () => {
     const result = buildFallbackCopy("What is the gate code?");
-    expect(result.threadTitle.startsWith("Guardian question:")).toBe(false);
+    expect(result.conversationTitle.startsWith("Guardian question:")).toBe(
+      false,
+    );
   });
 
-  test("threadTitle is under 80 characters for reasonable input", () => {
+  test("conversationTitle is under 80 characters for reasonable input", () => {
     const result = buildFallbackCopy("What is the gate code?");
-    expect(result.threadTitle.length).toBeLessThan(80);
+    expect(result.conversationTitle.length).toBeLessThan(80);
   });
 
   test("initialMessage contains the question text", () => {
@@ -35,12 +37,12 @@ describe("buildFallbackCopy", () => {
 
     // Title should use questionText.slice(0, 70), so the question portion is at most 70 chars
     // Plus the emoji prefix and space, should still be well under 80
-    expect(result.threadTitle.length).toBeLessThanOrEqual(
+    expect(result.conversationTitle.length).toBeLessThanOrEqual(
       "\u26A0\uFE0F ".length + 70,
     );
 
     // The full question should NOT appear in the title
-    expect(result.threadTitle).not.toContain(longQuestion);
+    expect(result.conversationTitle).not.toContain(longQuestion);
 
     // But the full question should still appear in the initial message
     expect(result.initialMessage).toContain(longQuestion);