@vellumai/assistant 0.4.55 → 0.4.56

package/src/__tests__/{session-init.benchmark.test.ts → conversation-init.benchmark.test.ts}

@@ -1,5 +1,5 @@
 /**
- * Session Initialization Benchmark
+ * Conversation Initialization Benchmark
  *
  * Measures latency of key session startup components and end-to-end
  * session creation timing (request to first-tool-ready state).
@@ -14,9 +14,9 @@
  * - getAllToolDefinitions: < 10ms
  *
  * End-to-end targets (median of 3 runs):
- * - Session creation (no preactivated skills): < 200ms
- * - Session creation (3 preactivated skills): < 300ms
- * - Session constructor (sync, no loadFromDb): < 10ms
+ * - Conversation creation (no preactivated skills): < 200ms
+ * - Conversation creation (3 preactivated skills): < 300ms
+ * - Conversation constructor (sync, no loadFromDb): < 10ms
  */
 import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
@@ -167,7 +167,7 @@ mock.module("../config/loader.js", () => ({
   setNestedValue: () => {},
 }));
 
-// Additional mocks required for Session constructor and end-to-end tests
+// Additional mocks required for Conversation constructor and end-to-end tests
 
 mock.module("../memory/conversation-crud.js", () => ({
   addMessage: () => ({ id: "msg-1" }),
@@ -177,7 +177,7 @@ mock.module("../memory/conversation-crud.js", () => ({
   createConversation: () => ({
     id: "bench-conv",
     title: "Bench",
-    threadType: "standard",
+    conversationType: "standard",
   }),
   clearAll: () => {},
   deleteConversation: () => {},
@@ -185,7 +185,7 @@ mock.module("../memory/conversation-crud.js", () => ({
   deleteMessageById: () => ({ memoryItemIds: [], memoryEntityIds: [] }),
   getConversationOriginChannel: () => null,
   getConversationOriginInterface: () => null,
-  getConversationThreadType: () => "standard",
+  getConversationType: () => "standard",
   getConversationMemoryScopeId: () => "default",
   getConversationRecentProvenanceTrustClass: () => null,
   provenanceFromTrustContext: () => ({}),
@@ -273,13 +273,13 @@ mock.module("../calls/call-store.js", () => ({
 }));
 
 mock.module("../daemon/watch-handler.js", () => ({
-  lastCommentaryBySession: new Map(),
-  lastSummaryBySession: new Map(),
+  lastCommentaryByConversation: new Map(),
+  lastSummaryByConversation: new Map(),
 }));
 
 mock.module("../tools/browser/browser-screencast.js", () => ({
-  registerSessionSender: () => {},
-  unregisterSessionSender: () => {},
+  registerConversationSender: () => {},
+  unregisterConversationSender: () => {},
   ensureScreencast: () => Promise.resolve(),
   stopBrowserScreencast: () => Promise.resolve(),
   stopAllScreencasts: () => Promise.resolve(),
@@ -294,9 +294,9 @@ mock.module("../services/published-app-updater.js", () => ({
 const { initializeTools, getAllToolDefinitions, __resetRegistryForTesting } =
   await import("../tools/registry.js");
 const { buildSystemPrompt } = await import("../prompts/system-prompt.js");
-const { Session } = await import("../daemon/session.js");
+const { Conversation } = await import("../daemon/conversation.js");
 const { projectSkillTools, resetSkillToolProjection } =
-  await import("../daemon/session-skill-tools.js");
+  await import("../daemon/conversation-skill-tools.js");
 import type { Provider } from "../providers/types.js";
 
 afterAll(() => {
@@ -308,7 +308,7 @@ afterAll(() => {
   }
 });
 
-describe("Session initialization benchmark", () => {
+describe("Conversation initialization benchmark", () => {
   test("initializeTools completes under 100ms (median of 5)", async () => {
     // Warm-up run to eliminate JIT / lazy-load overhead
     __resetRegistryForTesting();
@@ -391,9 +391,9 @@ describe("Session initialization benchmark", () => {
 });
 
 describe("End-to-end session creation benchmark", () => {
-  // Uses the real Session constructor + loadFromDb() path, which wires up
+  // Uses the real Conversation constructor + loadFromDb() path, which wires up
   // the tool executor, event bus, agent loop, context window manager, and
-  // notifiers. Note: the daemon's getOrCreateSession() adds provider
+  // notifiers. Note: the daemon's getOrCreateConversation() adds provider
   // construction, rate limiting, concurrency guards, and evictor management
   // on top — those are lightweight config-driven operations not benchmarked
   // here.
@@ -416,7 +416,7 @@ describe("End-to-end session creation benchmark", () => {
     const systemPrompt = buildSystemPrompt();
 
     // Warm-up run
-    const warmup = new Session(
+    const warmup = new Conversation(
       "bench-warmup-0",
       mockProvider,
       systemPrompt,
@@ -431,7 +431,7 @@ describe("End-to-end session creation benchmark", () => {
     for (let i = 0; i < 3; i++) {
       const id = `bench-no-skills-${i}`;
       const start = performance.now();
-      const session = new Session(
+      const session = new Conversation(
         id,
         mockProvider,
         systemPrompt,
@@ -459,7 +459,7 @@ describe("End-to-end session creation benchmark", () => {
     const systemPrompt = buildSystemPrompt();
 
     // Warm-up run — includes skill projection so manifest loading is JIT'd
-    const warmup = new Session(
+    const warmup = new Conversation(
       "bench-warmup-s",
       mockProvider,
       systemPrompt,
@@ -481,7 +481,7 @@ describe("End-to-end session creation benchmark", () => {
     for (let i = 0; i < 3; i++) {
       const id = `bench-with-skills-${i}`;
       const start = performance.now();
-      const session = new Session(
+      const session = new Conversation(
         id,
         mockProvider,
         systemPrompt,
@@ -513,11 +513,11 @@ describe("End-to-end session creation benchmark", () => {
     expect(median(timings)).toBeLessThan(300);
   });
 
-  test("Session constructor (sync, no loadFromDb) completes under 10ms (median of 5)", () => {
+  test("Conversation constructor (sync, no loadFromDb) completes under 10ms (median of 5)", () => {
     const systemPrompt = buildSystemPrompt();
 
     // Warm-up
-    const warmup = new Session(
+    const warmup = new Conversation(
       "bench-events-w",
       mockProvider,
       systemPrompt,
@@ -530,7 +530,7 @@ describe("End-to-end session creation benchmark", () => {
     const timings: number[] = [];
     for (let i = 0; i < 5; i++) {
       const start = performance.now();
-      const session = new Session(
+      const session = new Conversation(
         `bench-events-${i}`,
         mockProvider,
         systemPrompt,

package/src/__tests__/{session-load-history-repair.test.ts → conversation-load-history-repair.test.ts}

@@ -2,7 +2,7 @@ import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 import type { Message } from "../providers/types.js";
 
-// Stub out heavy dependencies before importing Session
+// Stub out heavy dependencies before importing Conversation
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, { get: () => () => {} }),
@@ -61,7 +61,7 @@ let mockConversation: Record<string, unknown> | null = null;
 let nextMockMessageId = 1;
 
 mock.module("../memory/conversation-crud.js", () => ({
-  getConversationThreadType: () => "default",
+  getConversationType: () => "default",
   updateConversationContextWindow: () => {},
   deleteMessageById: () => {},
   updateConversationTitle: () => {},
@@ -98,9 +98,9 @@ mock.module("../memory/conversation-queries.js", () => ({
   listConversations: () => [],
 }));
 
-import { Session } from "../daemon/session.js";
+import { Conversation } from "../daemon/conversation.js";
 
-function makeSession(): Session {
+function makeConversation(): Conversation {
   const provider = {
     name: "mock",
     sendMessage: async () => ({
@@ -110,7 +110,7 @@ function makeSession(): Session {
       stopReason: "end_turn",
     }),
   };
-  return new Session(
+  return new Conversation(
     "conv-1",
     provider,
     "system prompt",
@@ -155,9 +155,9 @@ describe("loadFromDb history repair", () => {
       },
     ];
 
-    const session = makeSession();
-    await session.loadFromDb();
-    const messages = session.getMessages();
+    const conversation = makeConversation();
+    await conversation.loadFromDb();
+    const messages = conversation.getMessages();
 
     // Repair should have inserted a synthetic user message with tool_result
     expect(messages).toHaveLength(4);
@@ -201,9 +201,9 @@ describe("loadFromDb history repair", () => {
       content: JSON.stringify(m.content),
     }));
 
-    const session = makeSession();
-    await session.loadFromDb();
-    const messages = session.getMessages();
+    const conversation = makeConversation();
+    await conversation.loadFromDb();
+    const messages = conversation.getMessages();
 
     expect(messages).toEqual(validMessages);
   });
@@ -226,10 +226,10 @@ describe("loadFromDb history repair", () => {
       },
     ];
 
-    const session = makeSession();
+    const conversation = makeConversation();
     // Should not throw
-    await session.loadFromDb();
-    const messages = session.getMessages();
+    await conversation.loadFromDb();
+    const messages = conversation.getMessages();
 
     expect(messages).toHaveLength(2);
     // The broken message should have been replaced with a text block
@@ -259,9 +259,9 @@ describe("loadFromDb history repair", () => {
       },
     ];
 
-    const session = makeSession();
-    await session.loadFromDb();
-    const messages = session.getMessages();
+    const conversation = makeConversation();
+    await conversation.loadFromDb();
+    const messages = conversation.getMessages();
 
     expect(messages).toHaveLength(4);
     // String JSON should be wrapped
@@ -299,9 +299,9 @@ describe("loadFromDb history repair", () => {
       },
     ];
 
-    const session = makeSession();
-    await session.loadFromDb();
-    const messages = session.getMessages();
+    const conversation = makeConversation();
+    await conversation.loadFromDb();
+    const messages = conversation.getMessages();
 
     expect(messages).toHaveLength(2);
     expect(messages[1].content).toEqual([{ type: "text", text: "Sure" }]);
@@ -363,13 +363,13 @@ describe("loadFromDb history repair", () => {
       },
     ];
 
-    const session = makeSession();
-    session.setTrustContext({
+    const conversation = makeConversation();
+    conversation.setTrustContext({
       trustClass: "unknown",
       sourceChannel: "telegram",
     });
-    await session.loadFromDb();
-    const messages = session.getMessages();
+    await conversation.loadFromDb();
+    const messages = conversation.getMessages();
 
     expect(messages).toHaveLength(2);
     expect(messages[0].role).toBe("user");
@@ -430,21 +430,21 @@ describe("loadFromDb history repair", () => {
       },
     ];
 
-    const session = makeSession();
+    const conversation = makeConversation();
 
-    session.setTrustContext({
+    conversation.setTrustContext({
       trustClass: "guardian",
       sourceChannel: "telegram",
     });
-    await session.ensureActorScopedHistory();
-    expect(session.getMessages()).toHaveLength(4);
+    await conversation.ensureActorScopedHistory();
+    expect(conversation.getMessages()).toHaveLength(4);
 
-    session.setTrustContext({
+    conversation.setTrustContext({
       trustClass: "unknown",
       sourceChannel: "telegram",
     });
-    await session.ensureActorScopedHistory();
-    const downgradedMessages = session.getMessages();
+    await conversation.ensureActorScopedHistory();
+    const downgradedMessages = conversation.getMessages();
     expect(downgradedMessages).toHaveLength(2);
     expect(downgradedMessages[0].content).toEqual([
       { type: "text", text: "Unverified ping" },
@@ -506,21 +506,21 @@ describe("loadFromDb history repair", () => {
       },
     ];
 
-    const session = makeSession();
+    const conversation = makeConversation();
 
-    session.setTrustContext({
+    conversation.setTrustContext({
       trustClass: "unknown",
       sourceChannel: "telegram",
     });
-    await session.ensureActorScopedHistory();
-    expect(session.getMessages()).toHaveLength(2);
+    await conversation.ensureActorScopedHistory();
+    expect(conversation.getMessages()).toHaveLength(2);
 
-    session.setTrustContext({
+    conversation.setTrustContext({
       trustClass: "guardian",
       sourceChannel: "telegram",
     });
-    await session.persistUserMessage("Guardian follow-up", []);
-    const messagesAfterPersist = session.getMessages();
+    await conversation.persistUserMessage("Guardian follow-up", []);
+    const messagesAfterPersist = conversation.getMessages();
 
     expect(messagesAfterPersist).toHaveLength(5);
     expect(messagesAfterPersist[0].content).toEqual([

package/src/__tests__/{session-media-retry.test.ts → conversation-media-retry.test.ts}

@@ -1,7 +1,7 @@
 import { describe, expect, test } from "bun:test";
 
 import { createContextSummaryMessage } from "../context/window-manager.js";
-import { stripMediaPayloadsForRetry } from "../daemon/session-media-retry.js";
+import { stripMediaPayloadsForRetry } from "../daemon/conversation-media-retry.js";
 import type { ContentBlock, Message } from "../providers/types.js";
 
 // ---------------------------------------------------------------------------

package/src/__tests__/{session-messaging-secret-redirect.test.ts → conversation-messaging-secret-redirect.test.ts}

@@ -3,7 +3,7 @@ import { beforeEach, describe, expect, mock, test } from "bun:test";
 import {
   type RedirectedSecretRecord,
   redirectToSecurePrompt,
-} from "../daemon/session-messaging.js";
+} from "../daemon/conversation-messaging.js";
 import type { SecretPrompter } from "../permissions/secret-prompter.js";
 import { credentialKey } from "../security/credential-key.js";