@vellumai/assistant 0.4.54 → 0.4.56

package/src/__tests__/diagnostics-export.test.ts

@@ -90,8 +90,19 @@ function seedMessage(
   );
 }
 
+function seedConversationKey(
+  conversationKey: string,
+  conversationId: string,
+): void {
+  db().run(
+    "INSERT INTO conversation_keys (id, conversation_key, conversation_id, created_at) VALUES (?, ?, ?, ?)",
+    [crypto.randomUUID(), conversationKey, conversationId, Date.now()],
+  );
+}
+
 function cleanDb(): void {
   db().run("DELETE FROM messages");
+  db().run("DELETE FROM conversation_keys");
   db().run("DELETE FROM conversations");
 }
 
@@ -170,6 +181,25 @@ describe("diagnostics export", () => {
     expect(json.filePath).toContain("diagnostics-");
   });
 
+  test("resolves conversation key to daemon conversation ID", async () => {
+    const daemonConvId = "conv-6-daemon";
+    const clientKey = "AAAAAAAA-BBBB-CCCC-DDDD-EEEEEEEEEEEE";
+    const now = Date.now();
+
+    seedConversation(daemonConvId);
+    seedConversationKey(clientKey, daemonConvId);
+    seedMessage("msg-user-6", daemonConvId, "user", "hello", now - 1000);
+    seedMessage("msg-assistant-6", daemonConvId, "assistant", "world", now);
+
+    // Client sends the conversation key (client-side UUID), not the daemon ID
+    const res = await callExport({ conversationId: clientKey });
+    expect(res.status).toBe(200);
+    const json = (await res.json()) as { success: boolean; filePath: string };
+    expect(json.success).toBe(true);
+    // The export should find the messages via the resolved daemon ID
+    expect(json.filePath).toContain("diagnostics-");
+  });
+
   test("falls back to any-message when anchorMessageId is provided but not found", async () => {
     const convId = "conv-5";
     const now = Date.now();

package/src/__tests__/dynamic-page-surface.test.ts

@@ -65,7 +65,7 @@ describe("UiSurfaceShowDynamicPage structure", () => {
   test("can construct a well-typed UiSurfaceShowDynamicPage object", () => {
     const msg: UiSurfaceShowDynamicPage = {
       type: "ui_surface_show",
-      sessionId: "session-abc",
+      conversationId: "session-abc",
       surfaceId: "surface-123",
       surfaceType: "dynamic_page",
       data: { html: "<div>Content</div>" },
@@ -74,7 +74,7 @@ describe("UiSurfaceShowDynamicPage structure", () => {
     expect(msg.type).toBe("ui_surface_show");
     expect(msg.surfaceType).toBe("dynamic_page");
     expect(typeof msg.data.html).toBe("string");
-    expect(msg.sessionId).toBe("session-abc");
+    expect(msg.conversationId).toBe("session-abc");
     expect(msg.surfaceId).toBe("surface-123");
   });
 });

package/src/__tests__/dynamic-skill-workflow-prompt.test.ts

@@ -57,6 +57,19 @@ mock.module("../config/loader.js", () => ({
     assistantFeatureFlagValues: {
       "feature_flags.browser.enabled": true,
     },
+    services: {
+      inference: {
+        mode: "your-own",
+        provider: "anthropic",
+        model: "claude-opus-4-6",
+      },
+      "image-generation": {
+        mode: "your-own",
+        provider: "gemini",
+        model: "gemini-2.5-flash-image",
+      },
+      "web-search": { mode: "your-own", provider: "anthropic-native" },
+    },
   }),
   loadConfig: () => ({}),
   loadRawConfig: () => ({}),
@@ -107,7 +120,7 @@ describe("Dynamic Skill Authoring Workflow prompt section", () => {
     expect(result).toContain("3 attempts");
   });
 
-  test("workflow section includes session eviction note", () => {
+  test("workflow section includes conversation eviction note", () => {
     writeFileSync(join(TEST_DIR, "IDENTITY.md"), "I am Vellum.");
     const result = buildSystemPrompt();
     expect(result).toContain("recreated session");
@@ -147,11 +160,12 @@ describe("Dynamic Skill Authoring Workflow prompt section", () => {
     expect(result).toContain("skill_load");
   });
 
-  test("system prompt includes browser skill prerequisite guidance", () => {
+  test("browser skill has activation hints in available_skills XML instead of dedicated section", () => {
     writeFileSync(join(TEST_DIR, "IDENTITY.md"), "I am Vellum.");
     const result = buildSystemPrompt();
-    expect(result).toContain("Browser Skill Prerequisite");
-    expect(result).toContain("browser_*");
-    expect(result).toContain("skill_load");
+    // Browser routing moved from dedicated section to frontmatter hints
+    expect(result).not.toContain("Browser Skill Prerequisite");
+    expect(result).toContain('id="browser"');
+    expect(result).toContain("hints=");
   });
 });

package/src/__tests__/emit-signal-routing-intent.test.ts

@@ -40,7 +40,7 @@ mock.module("../notifications/adapters/telegram.js", () => ({
 mock.module("../notifications/broadcaster.js", () => ({
   NotificationBroadcaster: class {
     constructor(_adapters: unknown[]) {}
-    setOnThreadCreated(_fn: unknown) {}
+    setOnConversationCreated(_fn: unknown) {}
   },
 }));
 

package/src/__tests__/event-bus.test.ts

@@ -13,18 +13,17 @@ describe("EventBus", () => {
     });
     bus.on("tool.execution.started", async (event) => {
       await Promise.resolve();
-      seen.push(`second:${event.sessionId}`);
+      seen.push(`second:${event.conversationId}`);
     });
 
     await bus.emit("tool.execution.started", {
       conversationId: "conv-1",
-      sessionId: "sess-1",
       toolName: "bash",
       input: { command: "ls" },
       startedAtMs: Date.now(),
     });
 
-    expect(seen).toEqual(["first:bash", "second:sess-1"]);
+    expect(seen).toEqual(["first:bash", "second:conv-1"]);
   });
 
   test("supports onAny listeners with event envelopes", async () => {
@@ -68,7 +67,6 @@ describe("EventBus", () => {
 
     await bus.emit("tool.permission.decided", {
       conversationId: "conv-2",
-      sessionId: "sess-2",
       toolName: "bash",
       decision: "allow",
       riskLevel: "medium",
@@ -162,7 +160,6 @@ describe("EventBus", () => {
     await expect(
       bus.emit("tool.execution.finished", {
         conversationId: "conv-3",
-        sessionId: "sess-3",
         toolName: "file_read",
         decision: "allow",
         riskLevel: "low",
@@ -201,7 +198,6 @@ describe("EventBus", () => {
     try {
       await bus.emit("tool.execution.failed", {
         conversationId: "conv-4",
-        sessionId: "sess-4",
         toolName: "bash",
         decision: "error",
         riskLevel: "high",

package/src/__tests__/file-edit-tool.test.ts

@@ -23,7 +23,6 @@ beforeAll(async () => {
 function makeContext(workingDir: string): ToolContext {
   return {
     workingDir,
-    sessionId: "test-session",
     conversationId: "test-conversation",
     trustClass: "guardian",
   };

package/src/__tests__/file-read-tool.test.ts

@@ -23,7 +23,6 @@ beforeAll(async () => {
 function makeContext(workingDir: string): ToolContext {
   return {
     workingDir,
-    sessionId: "test-session",
     conversationId: "test-conversation",
     trustClass: "guardian",
   };

package/src/__tests__/file-write-tool.test.ts

@@ -24,7 +24,6 @@ beforeAll(async () => {
 function makeContext(workingDir: string): ToolContext {
   return {
     workingDir,
-    sessionId: "test-session",
     conversationId: "test-conversation",
     trustClass: "guardian",
   };

package/src/__tests__/fixtures/mock-signup-server.ts

@@ -174,7 +174,7 @@ export function createMockSignupServer(): MockSignupServer {
   /** Stores the most recently generated verification code (for the test-only endpoint). */
   let lastVerificationCode = "";
 
-  function getOrCreateSession(cookieHeader: string | null): {
+  function getOrCreateConversation(cookieHeader: string | null): {
     session: SignupSession;
     id: string;
   } {
@@ -244,7 +244,7 @@ export function createMockSignupServer(): MockSignupServer {
       });
     }
 
-    const { session, id } = getOrCreateSession(cookieHeader);
+    const { session, id } = getOrCreateConversation(cookieHeader);
 
     // ── Step 1: Name form ─────────────────────────────────────────
     if (method === "GET" && path === "/signup") {

package/src/__tests__/followup-tools.test.ts

@@ -55,7 +55,6 @@ function getRawDb(): Database {
 
 const ctx: ToolContext = {
   workingDir: "/tmp",
-  sessionId: "test-session",
   conversationId: "test-conversation",
   trustClass: "guardian",
 };
@@ -79,7 +78,7 @@ describe("followup_create tool", () => {
     const result = await executeFollowupCreate(
       {
         channel: "email",
-        thread_id: "thread-123",
+        conversation_id: "conv-123",
       },
       ctx,
     );
@@ -87,7 +86,7 @@ describe("followup_create tool", () => {
     expect(result.isError).toBe(false);
     expect(result.content).toContain("Created follow-up");
     expect(result.content).toContain("email");
-    expect(result.content).toContain("thread-123");
+    expect(result.content).toContain("conv-123");
     expect(result.content).toContain("Status: pending");
   });
 
@@ -95,7 +94,7 @@ describe("followup_create tool", () => {
     const result = await executeFollowupCreate(
       {
         channel: "slack",
-        thread_id: "slack-thread-1",
+        conversation_id: "slack-thread-1",
         expected_response_hours: 24,
       },
       ctx,
@@ -109,7 +108,7 @@ describe("followup_create tool", () => {
     const result = await executeFollowupCreate(
       {
         channel: "email",
-        thread_id: "thread-456",
+        conversation_id: "conv-456",
         reminder_schedule_id: "sched-abc",
       },
       ctx,
@@ -122,7 +121,7 @@ describe("followup_create tool", () => {
   test("rejects missing channel", async () => {
     const result = await executeFollowupCreate(
       {
-        thread_id: "thread-123",
+        conversation_id: "conv-123",
       },
       ctx,
     );
@@ -135,7 +134,7 @@ describe("followup_create tool", () => {
     const result = await executeFollowupCreate(
       {
         channel: "   ",
-        thread_id: "thread-123",
+        conversation_id: "conv-123",
       },
       ctx,
     );
@@ -144,7 +143,7 @@ describe("followup_create tool", () => {
     expect(result.content).toContain("channel is required");
   });
 
-  test("rejects missing thread_id", async () => {
+  test("rejects missing conversation_id", async () => {
     const result = await executeFollowupCreate(
       {
         channel: "email",
@@ -153,14 +152,14 @@ describe("followup_create tool", () => {
     );
 
     expect(result.isError).toBe(true);
-    expect(result.content).toContain("thread_id is required");
+    expect(result.content).toContain("conversation_id is required");
   });
 
   test("rejects non-positive expected_response_hours", async () => {
     const result = await executeFollowupCreate(
       {
         channel: "email",
-        thread_id: "thread-123",
+        conversation_id: "conv-123",
         expected_response_hours: -1,
       },
       ctx,
@@ -176,7 +175,7 @@ describe("followup_create tool", () => {
     const result = await executeFollowupCreate(
       {
         channel: "email",
-        thread_id: "thread-123",
+        conversation_id: "conv-123",
         contact_id: "nonexistent-contact",
       },
       ctx,
@@ -201,11 +200,11 @@ describe("followup_list tool", () => {
 
   test("lists all follow-ups", async () => {
     await executeFollowupCreate(
-      { channel: "email", thread_id: "thread-1" },
+      { channel: "email", conversation_id: "conv-1" },
       ctx,
     );
     await executeFollowupCreate(
-      { channel: "slack", thread_id: "thread-2" },
+      { channel: "slack", conversation_id: "conv-2" },
       ctx,
     );
 
@@ -219,7 +218,7 @@ describe("followup_list tool", () => {
 
   test("filters by status", async () => {
     await executeFollowupCreate(
-      { channel: "email", thread_id: "thread-1" },
+      { channel: "email", conversation_id: "conv-1" },
       ctx,
     );
 
@@ -231,11 +230,11 @@ describe("followup_list tool", () => {
 
   test("filters by channel", async () => {
     await executeFollowupCreate(
-      { channel: "email", thread_id: "thread-1" },
+      { channel: "email", conversation_id: "conv-1" },
       ctx,
     );
     await executeFollowupCreate(
-      { channel: "slack", thread_id: "thread-2" },
+      { channel: "slack", conversation_id: "conv-2" },
       ctx,
     );
 
@@ -263,7 +262,7 @@ describe("followup_resolve tool", () => {
     const createResult = await executeFollowupCreate(
       {
         channel: "email",
-        thread_id: "thread-1",
+        conversation_id: "conv-1",
       },
       ctx,
     );
@@ -276,11 +275,11 @@ describe("followup_resolve tool", () => {
     expect(result.content).toContain("Status: resolved");
   });
 
-  test("resolves by channel and thread_id", async () => {
+  test("resolves by channel and conversation_id", async () => {
     await executeFollowupCreate(
       {
         channel: "email",
-        thread_id: "thread-1",
+        conversation_id: "conv-1",
       },
       ctx,
     );
@@ -288,7 +287,7 @@ describe("followup_resolve tool", () => {
     const result = await executeFollowupResolve(
       {
         channel: "email",
-        thread_id: "thread-1",
+        conversation_id: "conv-1",
       },
       ctx,
     );
@@ -299,18 +298,18 @@ describe("followup_resolve tool", () => {
 
   test("resolves multiple follow-ups by thread", async () => {
     await executeFollowupCreate(
-      { channel: "email", thread_id: "shared-thread" },
+      { channel: "email", conversation_id: "shared-thread" },
       ctx,
     );
     await executeFollowupCreate(
-      { channel: "email", thread_id: "shared-thread" },
+      { channel: "email", conversation_id: "shared-thread" },
       ctx,
     );
 
     const result = await executeFollowupResolve(
       {
         channel: "email",
-        thread_id: "shared-thread",
+        conversation_id: "shared-thread",
       },
       ctx,
     );
@@ -323,7 +322,7 @@ describe("followup_resolve tool", () => {
     const result = await executeFollowupResolve(
       {
         channel: "email",
-        thread_id: "nonexistent",
+        conversation_id: "nonexistent",
       },
       ctx,
     );
@@ -339,12 +338,12 @@ describe("followup_resolve tool", () => {
     expect(result.content).toContain("not found");
   });
 
-  test("rejects when neither id nor channel+thread_id provided", async () => {
+  test("rejects when neither id nor channel+conversation_id provided", async () => {
     const result = await executeFollowupResolve({}, ctx);
 
     expect(result.isError).toBe(true);
     expect(result.content).toContain(
-      "Either id or both channel and thread_id are required",
+      "Either id or both channel and conversation_id are required",
     );
   });
 });

package/src/__tests__/frontmatter.test.ts

@@ -184,10 +184,10 @@ describe("parseFrontmatterFields", () => {
 
   test("boolean values are parsed as native booleans", () => {
     const result = parseFrontmatterFields(
-      "---\nuser-invocable: false\ndisable-model-invocation: true\n---\n",
+      "---\ndisable-feature: true\nsome-flag: false\n---\n",
     );
-    expect(result!.fields["user-invocable"]).toBe(false);
-    expect(result!.fields["disable-model-invocation"]).toBe(true);
+    expect(result!.fields["disable-feature"]).toBe(true);
+    expect(result!.fields["some-flag"]).toBe(false);
   });
 
   // -- CRLF handling --
@@ -219,7 +219,7 @@ describe("parseFrontmatterFields", () => {
       '  emoji: "\uD83D\uDD0C"',
       "  vellum:",
       '    display-name: "Test Skill"',
-      "    user-invocable: false",
+      "    some-custom-field: true",
       "---",
       "Body",
     ].join("\n");
@@ -230,7 +230,7 @@ describe("parseFrontmatterFields", () => {
       emoji: "\uD83D\uDD0C",
       vellum: {
         "display-name": "Test Skill",
-        "user-invocable": false,
+        "some-custom-field": true,
       },
     });
   });
@@ -242,13 +242,13 @@ describe("parseFrontmatterFields", () => {
       'description: "A test skill"',
       "metadata:",
       "  vellum:",
-      "    os:",
-      "      - darwin",
-      "      - linux",
       "    requires:",
       "      bins:",
       "        - node",
       "        - npm",
+      "      env:",
+      "        - API_KEY",
+      "        - SECRET",
       "---",
       "Body",
     ].join("\n");
@@ -256,8 +256,10 @@ describe("parseFrontmatterFields", () => {
     expect(result).not.toBeNull();
     const meta = result!.fields.metadata as Record<string, unknown>;
     const vellum = meta.vellum as Record<string, unknown>;
-    expect(vellum.os).toEqual(["darwin", "linux"]);
-    expect(vellum.requires).toEqual({ bins: ["node", "npm"] });
+    expect(vellum.requires).toEqual({
+      bins: ["node", "npm"],
+      env: ["API_KEY", "SECRET"],
+    });
   });
 
   test("returns null for invalid YAML frontmatter", () => {

package/src/__tests__/guardian-action-late-reply.test.ts

@@ -479,7 +479,7 @@ describe("guardian-action-late-reply", () => {
       );
       const code = req1.requestCode; // e.g. "A1B2C3"
 
-      // Simulate case-insensitive prefix matching as done in session-process.ts
+      // Simulate case-insensitive prefix matching as done in conversation-process.ts
       const userInput = `${code.toLowerCase()} the answer is 42`;
       const matched = userInput.toUpperCase().startsWith(code);
       expect(matched).toBe(true);

package/src/__tests__/guardian-action-no-hardcoded-copy.test.ts

@@ -21,7 +21,7 @@ const SCANNED_FILES = [
   "calls/guardian-action-sweep.ts",
   "runtime/routes/inbound-message-handler.ts",
   "runtime/guardian-action-conversation-turn.ts",
-  "daemon/session-process.ts",
+  "daemon/conversation-process.ts",
 ];
 
 const BANNED_PATTERNS: { pattern: RegExp; description: string }[] = [

package/src/__tests__/guardian-decision-primitive-canonical.test.ts

@@ -126,7 +126,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "shell",
       inputDigest: "sha256:abc",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -160,7 +160,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "shell",
       inputDigest: "sha256:abc",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -187,7 +187,7 @@ describe("applyCanonicalGuardianDecision", () => {
       callSessionId: "call-1",
       pendingQuestionId: "pq-1",
       questionText: "What is the gate code?",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -214,7 +214,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -241,7 +241,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "shell",
       inputDigest: "sha256:abc",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -265,7 +265,7 @@ describe("applyCanonicalGuardianDecision", () => {
       sourceType: "channel",
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -286,7 +286,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -309,7 +309,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     // First decision succeeds
@@ -358,7 +358,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -388,7 +388,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "shell",
       inputDigest: "sha256:abc",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -421,7 +421,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() - 10_000).toISOString(), // already expired
+      expiresAt: Date.now() - 10_000, // already expired
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -466,7 +466,7 @@ describe("applyCanonicalGuardianDecision", () => {
       guardianPrincipalId: TEST_PRINCIPAL_ID,
       toolName: "file_read",
       inputDigest: "sha256:def",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -488,7 +488,7 @@ describe("applyCanonicalGuardianDecision", () => {
       callSessionId: "call-99",
       pendingQuestionId: "pq-99",
       questionText: "What is the password?",
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({
@@ -510,7 +510,7 @@ describe("applyCanonicalGuardianDecision", () => {
       conversationId: "conv-1",
       guardianExternalUserId: "guardian-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     // Should still succeed — CAS resolution happens regardless of resolver
@@ -535,7 +535,7 @@ describe("applyCanonicalGuardianDecision", () => {
       toolName: "host_bash",
       inputDigest: "sha256:voice-digest-1",
       guardianPrincipalId: TEST_PRINCIPAL_ID,
-      expiresAt: new Date(Date.now() + 60_000).toISOString(),
+      expiresAt: Date.now() + 60_000,
     });
 
     const result = await applyCanonicalGuardianDecision({