@vellumai/assistant 0.4.52 → 0.4.54

package/src/__tests__/session-slash-unknown.test.ts

@@ -22,7 +22,6 @@ mock.module("../util/platform.js", () => ({
 }));
 
 mock.module("../memory/guardian-action-store.js", () => ({
-  getPendingDeliveryByConversation: () => null,
   getGuardianActionRequest: () => null,
   resolveGuardianActionRequest: () => {},
 }));
@@ -54,7 +53,6 @@ mock.module("../config/loader.js", () => ({
       },
     },
     rateLimit: { maxRequestsPerMinute: 0, maxTokensPerSession: 0 },
-    apiKeys: {},
     daemon: {
       startupSocketWaitMs: 5000,
       stopTimeoutMs: 5000,
@@ -199,6 +197,9 @@ let agentLoopRunCalled = false;
 mock.module("../agent/loop.js", () => ({
   AgentLoop: class {
     constructor() {}
+    getToolTokenBudget() {
+      return 0;
+    }
     async run(
       messages: Message[],
       onEvent: (event: AgentEvent) => void,

package/src/__tests__/session-workspace-cache-state.test.ts

@@ -36,7 +36,6 @@ mock.module("../config/loader.js", () => ({
       summaryBudgetRatio: 0.05,
     },
     rateLimit: { maxRequestsPerMinute: 0, maxTokensPerSession: 0 },
-    apiKeys: {},
     memory: { enabled: false },
   }),
   loadRawConfig: () => ({}),
@@ -154,6 +153,9 @@ mock.module("../memory/app-store.js", () => ({
 mock.module("../agent/loop.js", () => ({
   AgentLoop: class {
     constructor() {}
+    getToolTokenBudget() {
+      return 0;
+    }
     async run(
       messages: Message[],
       onEvent: (event: AgentEvent) => void,

package/src/__tests__/session-workspace-injection.test.ts

@@ -25,7 +25,6 @@ mock.module("../util/platform.js", () => ({
 }));
 
 mock.module("../memory/guardian-action-store.js", () => ({
-  getPendingDeliveryByConversation: () => null,
   getGuardianActionRequest: () => null,
   resolveGuardianActionRequest: () => {},
 }));
@@ -57,7 +56,6 @@ mock.module("../config/loader.js", () => ({
       },
     },
     rateLimit: { maxRequestsPerMinute: 0, maxTokensPerSession: 0 },
-    apiKeys: {},
     memory: { enabled: false },
     daemon: {
       startupSocketWaitMs: 5000,
@@ -197,6 +195,9 @@ mock.module("../workspace/top-level-scanner.js", () => ({
 mock.module("../agent/loop.js", () => ({
   AgentLoop: class {
     constructor() {}
+    getToolTokenBudget() {
+      return 0;
+    }
     async run(
       messages: Message[],
       onEvent: (event: AgentEvent) => void,

package/src/__tests__/session-workspace-tool-tracking.test.ts

@@ -23,7 +23,6 @@ mock.module("../util/platform.js", () => ({
 }));
 
 mock.module("../memory/guardian-action-store.js", () => ({
-  getPendingDeliveryByConversation: () => null,
   getGuardianActionRequest: () => null,
   resolveGuardianActionRequest: () => {},
 }));
@@ -55,7 +54,6 @@ mock.module("../config/loader.js", () => ({
       },
     },
     rateLimit: { maxRequestsPerMinute: 0, maxTokensPerSession: 0 },
-    apiKeys: {},
     memory: { enabled: false },
     daemon: {
       startupSocketWaitMs: 5000,
@@ -182,6 +180,9 @@ mock.module("../memory/app-store.js", () => ({
 mock.module("../agent/loop.js", () => ({
   AgentLoop: class {
     constructor() {}
+    getToolTokenBudget() {
+      return 0;
+    }
     async run(
       messages: Message[],
       onEvent: (event: AgentEvent) => void,

package/src/__tests__/shell-tool-proxy-mode.test.ts

@@ -27,7 +27,6 @@ mock.module("node:child_process", () => ({
 const mockConfig = {
   provider: "anthropic",
   model: "test",
-  apiKeys: {},
   maxTokens: 4096,
   dataDir: "/tmp",
   timeouts: {

package/src/__tests__/skill-projection-feature-flag.test.ts

@@ -54,7 +54,6 @@ mock.module("../config/assistant-feature-flags.js", () => ({
   },
   loadDefaultsRegistry: () => ({}),
   getAssistantFeatureFlagDefaults: () => ({}),
-  _resetDefaultsCache: () => {},
 }));
 
 mock.module("../config/skill-state.js", () => ({

package/src/__tests__/skill-script-runner-sandbox.test.ts

@@ -10,7 +10,6 @@ import { afterAll, beforeAll, describe, expect, mock, test } from "bun:test";
 const mockConfig = {
   provider: "anthropic",
   model: "test",
-  apiKeys: {},
   maxTokens: 4096,
   dataDir: "/tmp",
   timeouts: {

package/src/__tests__/skillssh-registry.test.ts

@@ -427,6 +427,27 @@ describe("fetchSkillFromGitHub", () => {
     expect(files["scripts/filter.sh"]).toBe("#!/bin/bash\necho filter");
   });
 
+  test("surfaces non-404 errors from tree lookup instead of misleading 'not found'", async () => {
+    mockFetchImpl = (url: string | URL | Request) => {
+      const urlStr = url.toString();
+      // Probe for conventional path returns 404
+      if (urlStr.includes("/contents/skills/my-skill")) {
+        return Promise.resolve(new Response("Not Found", { status: 404 }));
+      }
+      // Tree API returns a rate-limit error
+      if (urlStr.includes("/git/trees/")) {
+        return Promise.resolve(
+          new Response("rate limit exceeded", { status: 403 }),
+        );
+      }
+      return Promise.resolve(new Response("not found", { status: 404 }));
+    };
+
+    await expect(
+      fetchSkillFromGitHub("owner", "repo", "my-skill"),
+    ).rejects.toThrow("GitHub API error while searching repo tree: HTTP 403");
+  });
+
   test("throws when skill not found in tree either", async () => {
     mockFetchImpl = (url: string | URL | Request) => {
       const urlStr = url.toString();

package/src/__tests__/slack-channel-config.test.ts

@@ -100,19 +100,13 @@ mock.module("../security/secure-keys.js", () => {
     return "not-found" as const;
   };
   return {
-    getSecureKey: (account: string) => secureKeyStore[account] ?? undefined,
     getSecureKeyAsync: async (account: string) =>
       secureKeyStore[account] ?? undefined,
-    setSecureKey: syncSet,
-    deleteSecureKey: syncDelete,
     setSecureKeyAsync: async (account: string, value: string) =>
       syncSet(account, value),
     deleteSecureKeyAsync: async (account: string) => syncDelete(account),
-    listSecureKeys: () => Object.keys(secureKeyStore),
-    getBackendType: () => "encrypted",
-    isDowngradedFromKeychain: () => false,
+    listSecureKeysAsync: async () => Object.keys(secureKeyStore),
     _resetBackend: () => {},
-    _setBackend: () => {},
   };
 });
 

package/src/__tests__/slack-share-routes.test.ts

@@ -6,7 +6,7 @@ import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 const secureKeyValues = new Map<string, string>();
 mock.module("../security/secure-keys.js", () => ({
-  getSecureKey: (key: string) => secureKeyValues.get(key),
+  getSecureKeyAsync: async (key: string) => secureKeyValues.get(key),
   setSecureKeyAsync: async () => {},
 }));
 

package/src/__tests__/swarm-recursion.test.ts

@@ -37,7 +37,6 @@ mock.module("../config/loader.js", () => ({
 
     provider: "anthropic",
     providerOrder: ["anthropic"],
-    apiKeys: { anthropic: "test-key" },
     swarm: {
       enabled: true,
       maxWorkers: 3,
@@ -67,6 +66,10 @@ const mockProvider = {
     };
   },
 };
+mock.module("../security/secure-keys.js", () => ({
+  getSecureKeyAsync: async () => "test-api-key",
+}));
+
 mock.module("../providers/registry.js", () => ({
   getProvider: () => mockProvider,
   getFailoverProvider: () => mockProvider,

package/src/__tests__/swarm-session-integration.test.ts

@@ -18,7 +18,6 @@ mock.module("../hooks/manager.js", () => ({
 }));
 
 let swarmEnabled = true;
-let hasApiKey = true;
 
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
@@ -26,7 +25,6 @@ mock.module("../config/loader.js", () => ({
 
     provider: "anthropic",
     providerOrder: ["anthropic"],
-    apiKeys: { anthropic: hasApiKey ? "test-key" : "" },
     swarm: {
       enabled: swarmEnabled,
       maxWorkers: 2,
@@ -56,6 +54,11 @@ const mockTestProvider = {
     };
   },
 };
+let mockAnthropicKey: string | undefined = "test-api-key";
+mock.module("../security/secure-keys.js", () => ({
+  getSecureKeyAsync: async () => mockAnthropicKey,
+}));
+
 mock.module("../providers/registry.js", () => ({
   getProvider: () => mockTestProvider,
   getFailoverProvider: () => mockTestProvider,
@@ -103,7 +106,6 @@ describe("swarm through AgentLoop", () => {
   beforeEach(() => {
     _resetSwarmActive();
     swarmEnabled = true;
-    hasApiKey = true;
   });
 
   test("agent loop calls swarm_delegate and receives tool result", async () => {
@@ -253,7 +255,6 @@ describe("swarm regression tests", () => {
   beforeEach(() => {
     _resetSwarmActive();
     swarmEnabled = true;
-    hasApiKey = true;
   });
 
   test("swarm_delegate returns graceful message when disabled", async () => {
@@ -298,17 +299,26 @@ describe("swarm regression tests", () => {
   });
 
   test("worker backend reports unavailable when no API key", async () => {
-    hasApiKey = false;
-
-    const result = await swarmDelegateTool.execute(
-      { objective: "Task without key" },
-      makeContext(),
-    );
+    const prevKey = mockAnthropicKey;
+    const prevEnv = process.env.ANTHROPIC_API_KEY;
+    mockAnthropicKey = undefined;
+    delete process.env.ANTHROPIC_API_KEY;
+    try {
+      const result = await swarmDelegateTool.execute(
+        { objective: "Task without key" },
+        makeContext(),
+      );
 
-    // The tool should still complete — the orchestrator handles backend failures
-    // The result may show failed tasks but shouldn't throw
-    expect(result.content).toBeTruthy();
-    hasApiKey = true;
+      // The tool should still complete — the orchestrator handles backend failures
+      // Tasks should fail because no backend is available
+      expect(result.content).toBeTruthy();
+      expect(result.content).toContain("failed");
+    } finally {
+      mockAnthropicKey = prevKey;
+      if (prevEnv !== undefined) {
+        process.env.ANTHROPIC_API_KEY = prevEnv;
+      }
+    }
   });
 
   test("progress chunks stream through onOutput", async () => {

package/src/__tests__/swarm-tool.test.ts

@@ -17,7 +17,6 @@ mock.module("../config/loader.js", () => ({
 
     provider: "anthropic",
     providerOrder: ["anthropic"],
-    apiKeys: { anthropic: "test-key" },
     swarm: {
       enabled: true,
       maxWorkers: 3,
@@ -32,7 +31,6 @@ mock.module("../config/loader.js", () => ({
   getSwarmDisabledConfig: () => ({
     provider: "anthropic",
     providerOrder: ["anthropic"],
-    apiKeys: { anthropic: "test-key" },
     swarm: {
       enabled: false,
       maxWorkers: 3,
@@ -63,6 +61,10 @@ const mockProvider = {
     };
   },
 };
+mock.module("../security/secure-keys.js", () => ({
+  getSecureKeyAsync: async () => "test-api-key",
+}));
+
 mock.module("../providers/registry.js", () => ({
   getProvider: () => mockProvider,
   getFailoverProvider: () => mockProvider,

package/src/__tests__/task-compiler.test.ts

@@ -32,7 +32,7 @@ mock.module("../config/loader.js", () => ({
 }));
 
 mock.module("./indexer.js", () => ({
-  indexMessageNow: () => {},
+  indexMessageNow: async () => ({ indexedSegments: 0, enqueuedJobs: 0 }),
 }));
 
 import type { Database } from "bun:sqlite";

package/src/__tests__/telegram-bot-username-resolution.test.ts

@@ -21,6 +21,7 @@ let mockConfigWriteCalls: Array<{
 
 mock.module("../telegram/bot-username.js", () => ({
   getTelegramBotUsername: () => mockBotUsername,
+  getTelegramBotId: () => (mockBotUsername ? "123456" : undefined),
 }));
 
 mock.module("../config/loader.js", () => ({
@@ -37,10 +38,7 @@ mock.module("../config/loader.js", () => ({
 }));
 
 mock.module("../security/secure-keys.js", () => ({
-  getSecureKey: (_keyId: string) => mockSecureKey,
-  setSecureKey: (_account: string, _value: string) => true,
-  deleteSecureKey: (_account: string) => "deleted" as const,
-  listSecureKeys: () => [] as string[],
+  getSecureKeyAsync: async (_keyId: string) => mockSecureKey,
 }));
 
 // Suppress logger output during tests

package/src/__tests__/test-support/browser-skill-harness.ts

@@ -61,24 +61,6 @@ export function buildSkillLoadHistory(
   ];
 }
 
-/**
- * Assert that a set of tool names is exactly the expected set (order-independent).
- */
-export function expectToolNamesEqual(
-  actual: string[],
-  expected: readonly string[],
-): void {
-  const sorted = [...actual].sort();
-  const expectedSorted = [...expected].sort();
-  if (JSON.stringify(sorted) !== JSON.stringify(expectedSorted)) {
-    throw new Error(
-      `Tool names mismatch.\nExpected: ${JSON.stringify(
-        expectedSorted,
-      )}\nActual: ${JSON.stringify(sorted)}`,
-    );
-  }
-}
-
 /**
  * Assert that all browser tool names are present in a given set.
  */

package/src/__tests__/test-support/computer-use-skill-harness.ts

@@ -17,28 +17,5 @@ export const COMPUTER_USE_TOOL_NAMES = [
   "computer_use_respond",
 ] as const;
 
-/** The skill ID for the bundled computer-use skill (used in later PRs). */
-export const COMPUTER_USE_SKILL_ID = "computer-use";
-
 /** Number of computer_use_* tools. */
 export const COMPUTER_USE_TOOL_COUNT = COMPUTER_USE_TOOL_NAMES.length; // 11
-
-import { expect } from "bun:test";
-
-/**
- * Assert that every COMPUTER_USE_TOOL_NAMES entry is present in `names`.
- */
-export function assertComputerUseToolsPresent(names: string[]): void {
-  for (const name of COMPUTER_USE_TOOL_NAMES) {
-    expect(names).toContain(name);
-  }
-}
-
-/**
- * Assert that no COMPUTER_USE_TOOL_NAMES entry is present in `names`.
- */
-export function assertComputerUseToolsAbsent(names: string[]): void {
-  for (const name of COMPUTER_USE_TOOL_NAMES) {
-    expect(names).not.toContain(name);
-  }
-}