@vellumai/assistant 0.4.51 → 0.4.53

package/src/__tests__/skillssh-registry.test.ts

@@ -427,6 +427,27 @@ describe("fetchSkillFromGitHub", () => {
     expect(files["scripts/filter.sh"]).toBe("#!/bin/bash\necho filter");
   });
 
+  test("surfaces non-404 errors from tree lookup instead of misleading 'not found'", async () => {
+    mockFetchImpl = (url: string | URL | Request) => {
+      const urlStr = url.toString();
+      // Probe for conventional path returns 404
+      if (urlStr.includes("/contents/skills/my-skill")) {
+        return Promise.resolve(new Response("Not Found", { status: 404 }));
+      }
+      // Tree API returns a rate-limit error
+      if (urlStr.includes("/git/trees/")) {
+        return Promise.resolve(
+          new Response("rate limit exceeded", { status: 403 }),
+        );
+      }
+      return Promise.resolve(new Response("not found", { status: 404 }));
+    };
+
+    await expect(
+      fetchSkillFromGitHub("owner", "repo", "my-skill"),
+    ).rejects.toThrow("GitHub API error while searching repo tree: HTTP 403");
+  });
+
   test("throws when skill not found in tree either", async () => {
     mockFetchImpl = (url: string | URL | Request) => {
       const urlStr = url.toString();

package/src/__tests__/slack-share-routes.test.ts

@@ -6,7 +6,7 @@ import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 const secureKeyValues = new Map<string, string>();
 mock.module("../security/secure-keys.js", () => ({
-  getSecureKey: (key: string) => secureKeyValues.get(key),
+  getSecureKeyAsync: async (key: string) => secureKeyValues.get(key),
   setSecureKeyAsync: async () => {},
 }));
 

package/src/__tests__/swarm-recursion.test.ts

@@ -37,7 +37,6 @@ mock.module("../config/loader.js", () => ({
 
     provider: "anthropic",
     providerOrder: ["anthropic"],
-    apiKeys: { anthropic: "test-key" },
     swarm: {
       enabled: true,
       maxWorkers: 3,
@@ -67,6 +66,11 @@ const mockProvider = {
     };
   },
 };
+mock.module("../security/secure-keys.js", () => ({
+  getSecureKeyAsync: async () => "test-api-key",
+  getSecureKey: () => "test-api-key",
+}));
+
 mock.module("../providers/registry.js", () => ({
   getProvider: () => mockProvider,
   getFailoverProvider: () => mockProvider,

package/src/__tests__/swarm-session-integration.test.ts

@@ -18,7 +18,6 @@ mock.module("../hooks/manager.js", () => ({
 }));
 
 let swarmEnabled = true;
-let hasApiKey = true;
 
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
@@ -26,7 +25,6 @@ mock.module("../config/loader.js", () => ({
 
     provider: "anthropic",
     providerOrder: ["anthropic"],
-    apiKeys: { anthropic: hasApiKey ? "test-key" : "" },
     swarm: {
       enabled: swarmEnabled,
       maxWorkers: 2,
@@ -56,6 +54,12 @@ const mockTestProvider = {
     };
   },
 };
+let mockAnthropicKey: string | undefined = "test-api-key";
+mock.module("../security/secure-keys.js", () => ({
+  getSecureKeyAsync: async () => mockAnthropicKey,
+  getSecureKey: () => mockAnthropicKey,
+}));
+
 mock.module("../providers/registry.js", () => ({
   getProvider: () => mockTestProvider,
   getFailoverProvider: () => mockTestProvider,
@@ -103,7 +107,6 @@ describe("swarm through AgentLoop", () => {
   beforeEach(() => {
     _resetSwarmActive();
     swarmEnabled = true;
-    hasApiKey = true;
   });
 
   test("agent loop calls swarm_delegate and receives tool result", async () => {
@@ -253,7 +256,6 @@ describe("swarm regression tests", () => {
   beforeEach(() => {
     _resetSwarmActive();
     swarmEnabled = true;
-    hasApiKey = true;
   });
 
   test("swarm_delegate returns graceful message when disabled", async () => {
@@ -298,17 +300,26 @@ describe("swarm regression tests", () => {
   });
 
   test("worker backend reports unavailable when no API key", async () => {
-    hasApiKey = false;
-
-    const result = await swarmDelegateTool.execute(
-      { objective: "Task without key" },
-      makeContext(),
-    );
+    const prevKey = mockAnthropicKey;
+    const prevEnv = process.env.ANTHROPIC_API_KEY;
+    mockAnthropicKey = undefined;
+    delete process.env.ANTHROPIC_API_KEY;
+    try {
+      const result = await swarmDelegateTool.execute(
+        { objective: "Task without key" },
+        makeContext(),
+      );
 
-    // The tool should still complete — the orchestrator handles backend failures
-    // The result may show failed tasks but shouldn't throw
-    expect(result.content).toBeTruthy();
-    hasApiKey = true;
+      // The tool should still complete — the orchestrator handles backend failures
+      // Tasks should fail because no backend is available
+      expect(result.content).toBeTruthy();
+      expect(result.content).toContain("failed");
+    } finally {
+      mockAnthropicKey = prevKey;
+      if (prevEnv !== undefined) {
+        process.env.ANTHROPIC_API_KEY = prevEnv;
+      }
+    }
   });
 
   test("progress chunks stream through onOutput", async () => {

package/src/__tests__/swarm-tool.test.ts

@@ -17,7 +17,6 @@ mock.module("../config/loader.js", () => ({
 
     provider: "anthropic",
     providerOrder: ["anthropic"],
-    apiKeys: { anthropic: "test-key" },
     swarm: {
       enabled: true,
       maxWorkers: 3,
@@ -32,7 +31,6 @@ mock.module("../config/loader.js", () => ({
   getSwarmDisabledConfig: () => ({
     provider: "anthropic",
     providerOrder: ["anthropic"],
-    apiKeys: { anthropic: "test-key" },
     swarm: {
       enabled: false,
       maxWorkers: 3,
@@ -63,6 +61,11 @@ const mockProvider = {
     };
   },
 };
+mock.module("../security/secure-keys.js", () => ({
+  getSecureKeyAsync: async () => "test-api-key",
+  getSecureKey: () => "test-api-key",
+}));
+
 mock.module("../providers/registry.js", () => ({
   getProvider: () => mockProvider,
   getFailoverProvider: () => mockProvider,

package/src/__tests__/telegram-bot-username-resolution.test.ts

@@ -21,6 +21,7 @@ let mockConfigWriteCalls: Array<{
 
 mock.module("../telegram/bot-username.js", () => ({
   getTelegramBotUsername: () => mockBotUsername,
+  getTelegramBotId: () => (mockBotUsername ? "123456" : undefined),
 }));
 
 mock.module("../config/loader.js", () => ({
@@ -37,10 +38,7 @@ mock.module("../config/loader.js", () => ({
 }));
 
 mock.module("../security/secure-keys.js", () => ({
-  getSecureKey: (_keyId: string) => mockSecureKey,
-  setSecureKey: (_account: string, _value: string) => true,
-  deleteSecureKey: (_account: string) => "deleted" as const,
-  listSecureKeys: () => [] as string[],
+  getSecureKeyAsync: async (_keyId: string) => mockSecureKey,
 }));
 
 // Suppress logger output during tests