@vellumai/assistant 0.4.45 → 0.4.48

package/src/tools/browser/headless-browser.ts

@@ -44,11 +44,6 @@ class BrowserNavigateTool implements Tool {
             description:
               "If true, allows navigation to localhost/private-network hosts. Disabled by default for SSRF safety.",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are navigating to and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
         required: ["url"],
       },
@@ -80,13 +75,7 @@ class BrowserSnapshotTool implements Tool {
       description: this.description,
       input_schema: {
         type: "object",
-        properties: {
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are inspecting and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
-        },
+        properties: {},
       },
     };
   }
@@ -122,11 +111,6 @@ class BrowserScreenshotTool implements Tool {
             description:
               "Capture the full scrollable page instead of just the viewport.",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are capturing and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
       },
     };
@@ -163,11 +147,6 @@ class BrowserCloseTool implements Tool {
             description:
               "If true, close all browser pages and the browser context. Default: false (close only the current session page).",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are doing and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
       },
     };
@@ -214,11 +193,6 @@ class BrowserClickTool implements Tool {
             description:
               "Max time in ms to wait for the element to be clickable (default: 10000).",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are clicking and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
       },
     };
@@ -273,11 +247,6 @@ class BrowserTypeTool implements Tool {
             type: "boolean",
             description: "If true, press Enter after typing the text.",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are typing and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
         required: ["text"],
       },
@@ -323,11 +292,6 @@ class BrowserPressKeyTool implements Tool {
             type: "string",
             description: "Optional CSS selector to target.",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are doing and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
         required: ["key"],
       },
@@ -378,11 +342,6 @@ class BrowserScrollTool implements Tool {
             type: "string",
             description: "Optional CSS selector of element to scroll within.",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are scrolling to see and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
         required: ["direction"],
       },
@@ -437,11 +396,6 @@ class BrowserSelectOptionTool implements Tool {
             type: "number",
             description: "The zero-based index of the <option> to select.",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are selecting and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
       },
     };
@@ -483,11 +437,6 @@ class BrowserHoverTool implements Tool {
             description:
               "A CSS selector to target. Used as fallback when element_id is not available.",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are hovering over and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
       },
     };
@@ -537,11 +486,6 @@ class BrowserWaitForTool implements Tool {
             description:
               "Maximum wait time in milliseconds (default and max: 30000).",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are waiting for and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
       },
     };
@@ -578,11 +522,6 @@ class BrowserExtractTool implements Tool {
             description:
               "If true, include a list of links found on the page (up to 200).",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are extracting and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
       },
     };
@@ -634,11 +573,6 @@ class BrowserFillCredentialTool implements Tool {
             type: "boolean",
             description: "Press Enter after filling",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are filling in and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
         required: ["service", "field"],
       },

package/src/tools/claude-code/claude-code.ts

@@ -123,11 +123,6 @@ export const claudeCodeTool: Tool = {
             description:
               "Worker profile that scopes tool access. Defaults to general (backward compatible).",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are delegating and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
       },
     };

package/src/tools/computer-use/request-computer-control.ts

@@ -42,11 +42,6 @@ export const requestComputerControlTool: Tool = {
             description:
               "Concise description of what computer use should accomplish",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are doing and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
         required: ["task"],
       },

package/src/tools/credentials/broker.ts

@@ -1,5 +1,6 @@
 import { v4 as uuid } from "uuid";
 
+import { credentialKey, migrateKeys } from "../../security/credential-key.js";
 import { getSecureKey } from "../../security/secure-keys.js";
 import { getLogger } from "../../util/logger.js";
 import type {
@@ -46,7 +47,7 @@ export class CredentialBroker {
    * browserFill or consume call for this service/field pair, then discarded.
    */
   injectTransient(service: string, field: string, value: string): void {
-    const key = `credential:${service}:${field}`;
+    const key = credentialKey(service, field);
     this.transientValues.set(key, { value });
     log.info(
       { service, field },
@@ -59,6 +60,7 @@ export class CredentialBroker {
    * Returns a single-use token on success, or a denial reason on failure.
    */
   authorize(request: AuthorizeRequest): AuthorizeResult {
+    migrateKeys();
     const metadata = getCredentialMetadata(request.service, request.field);
     if (!metadata) {
       return {
@@ -123,7 +125,7 @@ export class CredentialBroker {
     }
 
     token.consumed = true;
-    const storageKey = `credential:${token.service}:${token.field}`;
+    const storageKey = credentialKey(token.service, token.field);
     // Check for transient value first (one-time send) — consume and return the value
     // directly since transient values are never persisted to secure storage.
     const transient = this.transientValues.get(storageKey);
@@ -211,7 +213,7 @@ export class CredentialBroker {
       }
     }
 
-    const storageKey = `credential:${request.service}:${request.field}`;
+    const storageKey = credentialKey(request.service, request.field);
     // Check transient values first (one-time send), then fall back to keychain.
     // Deletion is deferred until after a successful fill so the value survives
     // transient failures (e.g. stale element, page navigation, Playwright timeout).
@@ -299,7 +301,7 @@ export class CredentialBroker {
       };
     }
 
-    const storageKey = `credential:${request.service}:${request.field}`;
+    const storageKey = credentialKey(request.service, request.field);
     const transient = this.transientValues.get(storageKey);
     const value = transient?.value ?? getSecureKey(storageKey);
     if (!value) {

package/src/tools/credentials/metadata-store.ts

@@ -27,20 +27,20 @@ export interface CredentialMetadata {
   oauth2TokenUrl?: string;
   /** OAuth2 client ID — paired with oauth2TokenUrl for refresh. */
   oauth2ClientId?: string;
-  /** OAuth2 client secret — for providers that require it (e.g. Slack). Stored in metadata for autonomous refresh. */
-  oauth2ClientSecret?: string;
   /** How the client authenticates at the token endpoint (client_secret_basic or client_secret_post). */
   oauth2TokenEndpointAuthMethod?: string;
   /** Human-friendly name for this credential (e.g. "fal-primary"). */
   alias?: string;
   /** Templates describing how to inject this credential into proxied requests. */
   injectionTemplates?: CredentialInjectionTemplate[];
+  /** Whether a refresh token exists in the secure store for this service. */
+  hasRefreshToken?: boolean;
   createdAt: number;
   updatedAt: number;
 }
 
 /** Current on-disk schema version. */
-const CURRENT_VERSION = 2;
+const CURRENT_VERSION = 4;
 
 interface MetadataFile {
   version: typeof CURRENT_VERSION;
@@ -120,10 +120,6 @@ function migrateRecordV1toV2(
       typeof record.oauth2ClientId === "string"
         ? record.oauth2ClientId
         : undefined,
-    oauth2ClientSecret:
-      typeof record.oauth2ClientSecret === "string"
-        ? record.oauth2ClientSecret
-        : undefined,
     oauth2TokenEndpointAuthMethod:
       typeof record.oauth2TokenEndpointAuthMethod === "string"
         ? record.oauth2TokenEndpointAuthMethod
@@ -132,11 +128,52 @@ function migrateRecordV1toV2(
     injectionTemplates: Array.isArray(record.injectionTemplates)
       ? (record.injectionTemplates as CredentialInjectionTemplate[])
       : undefined,
+    hasRefreshToken:
+      typeof record.hasRefreshToken === "boolean"
+        ? record.hasRefreshToken
+        : undefined,
     createdAt: record.createdAt as number,
     updatedAt: record.updatedAt as number,
   };
 }
 
+/**
+ * Migrate a v2 record to v3 by stripping the oauth2ClientSecret field.
+ * Client secrets are now read exclusively from the secure key store.
+ */
+function migrateRecordV2toV3(record: CredentialMetadata): CredentialMetadata {
+  const { oauth2ClientSecret: _removed, ...rest } =
+    record as CredentialMetadata & { oauth2ClientSecret?: string };
+  return rest;
+}
+
+/**
+ * Migrate v3 credentials to v4:
+ * - Delete ghost `refresh_token` metadata records
+ * - Set `hasRefreshToken: true` on corresponding `access_token` records
+ */
+function migrateV3toV4(
+  credentials: CredentialMetadata[],
+): CredentialMetadata[] {
+  // Collect services that had refresh_token ghost records
+  const servicesWithRefresh = new Set<string>();
+  for (const c of credentials) {
+    if (c.field === "refresh_token") {
+      servicesWithRefresh.add(c.service);
+    }
+  }
+
+  // Remove all refresh_token records and set hasRefreshToken on access_token records
+  const filtered = credentials.filter((c) => c.field !== "refresh_token");
+  for (const c of filtered) {
+    if (c.field === "access_token" && servicesWithRefresh.has(c.service)) {
+      c.hasRefreshToken = true;
+    }
+  }
+
+  return filtered;
+}
+
 function loadFile(): LoadResult {
   const raw = readTextFileSync(getMetadataPath());
   if (raw == null) {
@@ -148,7 +185,12 @@ function loadFile(): LoadResult {
       return { version: CURRENT_VERSION, credentials: [] };
     }
     const fileVersion = typeof data.version === "number" ? data.version : 1;
-    if (fileVersion !== 1 && fileVersion !== 2) {
+    if (
+      fileVersion !== 1 &&
+      fileVersion !== 2 &&
+      fileVersion !== 3 &&
+      fileVersion !== 4
+    ) {
       // Unrecognized version (future, fractional, negative, zero) — refuse to touch it
       return { unknownVersion: true };
     }
@@ -159,8 +201,24 @@ function loadFile(): LoadResult {
     const validRecords = rawCredentials.filter(isValidCredentialRecord);
 
     if (fileVersion < CURRENT_VERSION) {
-      // Migrate from v1 to v2 and persist the upgrade so we don't re-migrate on every read
-      const credentials = validRecords.map(migrateRecordV1toV2);
+      // Apply migrations in sequence: v1→v2→v3→v4
+      let credentials: CredentialMetadata[];
+      if (fileVersion === 1) {
+        credentials = migrateV3toV4(
+          validRecords.map(migrateRecordV1toV2).map(migrateRecordV2toV3),
+        );
+      } else if (fileVersion === 2) {
+        credentials = migrateV3toV4(
+          (validRecords as unknown as CredentialMetadata[]).map(
+            migrateRecordV2toV3,
+          ),
+        );
+      } else {
+        // fileVersion === 3
+        credentials = migrateV3toV4(
+          validRecords as unknown as CredentialMetadata[],
+        );
+      }
       const migrated: MetadataFile = { version: CURRENT_VERSION, credentials };
       try {
         saveFile(migrated);
@@ -219,13 +277,12 @@ export function upsertCredentialMetadata(
     grantedScopes?: string[];
     oauth2TokenUrl?: string;
     oauth2ClientId?: string;
-    /** Pass `null` to explicitly clear a previously-set client secret. */
-    oauth2ClientSecret?: string | null;
     oauth2TokenEndpointAuthMethod?: string;
     /** Pass `null` to explicitly clear a previously-set alias. */
     alias?: string | null;
     /** Pass `null` to explicitly clear injection templates. */
     injectionTemplates?: CredentialInjectionTemplate[] | null;
+    hasRefreshToken?: boolean;
   },
 ): CredentialMetadata {
   const result = loadFile();
@@ -261,13 +318,6 @@ export function upsertCredentialMetadata(
       existing.oauth2TokenUrl = policy.oauth2TokenUrl;
     if (policy?.oauth2ClientId !== undefined)
       existing.oauth2ClientId = policy.oauth2ClientId;
-    if (policy?.oauth2ClientSecret !== undefined) {
-      if (policy.oauth2ClientSecret == null) {
-        delete existing.oauth2ClientSecret;
-      } else {
-        existing.oauth2ClientSecret = policy.oauth2ClientSecret;
-      }
-    }
     if (policy?.oauth2TokenEndpointAuthMethod !== undefined)
       existing.oauth2TokenEndpointAuthMethod =
         policy.oauth2TokenEndpointAuthMethod;
@@ -285,6 +335,8 @@ export function upsertCredentialMetadata(
         existing.injectionTemplates = policy.injectionTemplates;
       }
     }
+    if (policy?.hasRefreshToken !== undefined)
+      existing.hasRefreshToken = policy.hasRefreshToken;
     existing.updatedAt = now;
     saveFile(data);
     return existing;
@@ -301,10 +353,10 @@ export function upsertCredentialMetadata(
     grantedScopes: policy?.grantedScopes,
     oauth2TokenUrl: policy?.oauth2TokenUrl,
     oauth2ClientId: policy?.oauth2ClientId,
-    oauth2ClientSecret: policy?.oauth2ClientSecret ?? undefined,
     oauth2TokenEndpointAuthMethod: policy?.oauth2TokenEndpointAuthMethod,
     alias: policy?.alias ?? undefined,
     injectionTemplates: policy?.injectionTemplates ?? undefined,
+    hasRefreshToken: policy?.hasRefreshToken,
     createdAt: now,
     updatedAt: now,
   };

package/src/tools/credentials/resolve.ts

@@ -6,6 +6,7 @@
  * secure key naming convention.
  */
 
+import { credentialKey } from "../../security/credential-key.js";
 import { matchHostPattern } from "./host-pattern-match.js";
 import {
   type CredentialMetadata,
@@ -33,7 +34,7 @@ function toResolved(metadata: CredentialMetadata): ResolvedCredential {
     credentialId: metadata.credentialId,
     service: metadata.service,
     field: metadata.field,
-    storageKey: `credential:${metadata.service}:${metadata.field}`,
+    storageKey: credentialKey(metadata.service, metadata.field),
     alias: metadata.alias,
     injectionTemplates: metadata.injectionTemplates ?? [],
     metadata,

package/src/tools/credentials/vault.ts

@@ -7,6 +7,10 @@ import {
 } from "../../oauth/provider-profiles.js";
 import { RiskLevel } from "../../permissions/types.js";
 import type { ToolDefinition } from "../../providers/types.js";
+import { buildAssistantEvent } from "../../runtime/assistant-event.js";
+import { assistantEventHub } from "../../runtime/assistant-event-hub.js";
+import { DAEMON_INTERNAL_ASSISTANT_ID } from "../../runtime/assistant-scope.js";
+import { credentialKey, migrateKeys } from "../../security/credential-key.js";
 import type { TokenEndpointAuthMethod } from "../../security/oauth2.js";
 import {
   deleteSecureKeyAsync,
@@ -33,10 +37,10 @@ import { toPolicyFromInput, validatePolicyInput } from "./policy-validate.js";
 const log = getLogger("credential-vault");
 
 /**
- * Look up a stored OAuth field (e.g. client_id or client_secret) for a service.
- * Checks both the canonical and alias service names.
+ * Look up a stored OAuth secret (e.g. client_secret) for a service from the
+ * secure store. Checks both the canonical and alias service names.
  */
-function findStoredOAuthField(
+function findStoredOAuthSecret(
   service: string,
   field: string,
 ): string | undefined {
@@ -47,7 +51,30 @@ function findStoredOAuthField(
     if (alias === service) servicesToCheck.push(canonical);
   }
   for (const svc of servicesToCheck) {
-    const value = getSecureKey(`credential:${svc}:${field}`);
+    const value = getSecureKey(credentialKey(svc, field));
+    if (value) return value;
+  }
+  return undefined;
+}
+
+/**
+ * Look up the stored OAuth client_id for a service from credential metadata.
+ * Checks both the canonical and alias service names.
+ */
+function findStoredOAuthClientId(service: string): string | undefined {
+  const servicesToCheck = [service];
+  for (const [alias, canonical] of Object.entries(SERVICE_ALIASES)) {
+    if (canonical === service) servicesToCheck.push(alias);
+    if (alias === service) servicesToCheck.push(canonical);
+  }
+  // Check metadata first (written by oauth2_connect after successful auth)
+  for (const svc of servicesToCheck) {
+    const meta = getCredentialMetadata(svc, "access_token");
+    if (meta?.oauth2ClientId) return meta.oauth2ClientId;
+  }
+  // Fall back to secure key store (written by credential_store prompt action)
+  for (const svc of servicesToCheck) {
+    const value = getSecureKey(credentialKey(svc, "client_id"));
     if (value) return value;
   }
   return undefined;
@@ -206,11 +233,6 @@ class CredentialStoreTool implements Tool {
             description:
               "Templates describing how to inject this credential into proxied requests (for store and prompt actions)",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are doing and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
         required: ["action"],
       },
@@ -221,6 +243,7 @@ class CredentialStoreTool implements Tool {
     input: Record<string, unknown>,
     context: ToolContext,
   ): Promise<ToolExecutionResult> {
+    migrateKeys();
     const action = input.action as string;
 
     switch (action) {
@@ -359,7 +382,7 @@ class CredentialStoreTool implements Tool {
           };
         }
 
-        const key = `credential:${service}:${field}`;
+        const key = credentialKey(service, field);
         const ok = await setSecureKeyAsync(key, value);
         if (!ok) {
           return {
@@ -422,7 +445,7 @@ class CredentialStoreTool implements Tool {
         const entries = allMetadata
           .filter((m) => {
             if (secureKeySet)
-              return secureKeySet.has(`credential:${m.service}:${m.field}`);
+              return secureKeySet.has(credentialKey(m.service, m.field));
             return true;
           })
           .map((m) => {
@@ -472,7 +495,7 @@ class CredentialStoreTool implements Tool {
           };
         }
 
-        const key = `credential:${service}:${field}`;
+        const key = credentialKey(service, field);
         const result = await deleteSecureKeyAsync(key);
         if (result === "error") {
           return {
@@ -712,7 +735,7 @@ class CredentialStoreTool implements Tool {
         }
 
         // Default: persist to keychain
-        const key = `credential:${service}:${field}`;
+        const key = credentialKey(service, field);
         const ok = await setSecureKeyAsync(key, result.value);
         if (!ok) {
           return {
@@ -757,13 +780,13 @@ class CredentialStoreTool implements Tool {
         // Fill missing params from provider profile
         const profile = getProviderProfile(service);
 
-        // Look up client_id/client_secret from stored credentials if not provided
+        // Look up client_id from metadata and client_secret from secure store
         const clientId =
           (input.client_id as string | undefined) ??
-          findStoredOAuthField(service, "client_id");
+          findStoredOAuthClientId(service);
         const clientSecret =
           (input.client_secret as string | undefined) ??
-          findStoredOAuthField(service, "client_secret");
+          findStoredOAuthSecret(service, "client_secret");
 
         // Early guardrails that stay in vault.ts (credential resolution is vault-specific)
         const inputScopes = input.scopes as string[] | undefined;
@@ -867,6 +890,44 @@ class CredentialStoreTool implements Tool {
           userinfoUrl:
             (input.userinfo_url as string | undefined) ?? profile?.userinfoUrl,
           tokenEndpointAuthMethod,
+          onDeferredComplete: (deferredResult) => {
+            // Emit oauth_connect_result to all connected SSE clients so the
+            // UI can update immediately when the deferred browser flow completes.
+            assistantEventHub
+              .publish(
+                buildAssistantEvent(DAEMON_INTERNAL_ASSISTANT_ID, {
+                  type: "oauth_connect_result",
+                  success: deferredResult.success,
+                  service: deferredResult.service,
+                  accountInfo: deferredResult.accountInfo,
+                  error: deferredResult.error,
+                }),
+              )
+              .catch((err) => {
+                log.warn(
+                  { err, service: deferredResult.service },
+                  "Failed to publish oauth_connect_result event",
+                );
+              });
+
+            if (deferredResult.success) {
+              log.info(
+                {
+                  service: deferredResult.service,
+                  accountInfo: deferredResult.accountInfo,
+                },
+                "Deferred OAuth connect completed successfully",
+              );
+            } else {
+              log.warn(
+                {
+                  service: deferredResult.service,
+                  err: deferredResult.error,
+                },
+                "Deferred OAuth connect failed",
+              );
+            }
+          },
         });
 
         if (!result.success) {

package/src/tools/filesystem/edit.ts

@@ -38,13 +38,8 @@ class FileEditTool implements Tool {
             description:
               "Replace all occurrences of old_string instead of requiring a unique match (default: false)",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of why this file is being edited, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
-        required: ["path", "old_string", "new_string", "reason"],
+        required: ["path", "old_string", "new_string"],
       },
     };
   }

package/src/tools/filesystem/read.ts

@@ -38,11 +38,6 @@ class FileReadTool implements Tool {
             type: "number",
             description: "Maximum number of lines to read",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of what you are reading and why, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
         required: ["path"],
       },

package/src/tools/filesystem/write.ts

@@ -28,13 +28,8 @@ class FileWriteTool implements Tool {
             type: "string",
             description: "The content to write to the file",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of why this file is being written, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
-        required: ["path", "content", "reason"],
+        required: ["path", "content"],
       },
     };
   }

package/src/tools/host-filesystem/edit.ts

@@ -35,13 +35,8 @@ class HostFileEditTool implements Tool {
             description:
               "Replace all occurrences instead of requiring a unique match (default: false)",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of why this file is being edited, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
-        required: ["path", "old_string", "new_string", "reason"],
+        required: ["path", "old_string", "new_string"],
       },
     };
   }

package/src/tools/host-filesystem/read.ts

@@ -29,13 +29,8 @@ class HostFileReadTool implements Tool {
             type: "number",
             description: "Maximum number of lines to read",
           },
-          reason: {
-            type: "string",
-            description:
-              "Brief non-technical explanation of why this file is being read, shown to the user as a status update. Use simple language a non-technical person would understand.",
-          },
         },
-        required: ["path", "reason"],
+        required: ["path"],
       },
     };
   }