@vellumai/assistant 0.4.44 → 0.4.45

package/src/__tests__/memory-context-benchmark.benchmark.test.ts

@@ -37,7 +37,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
@@ -199,10 +198,9 @@ describe("Memory context benchmark", () => {
       config: {
         ...DEFAULT_CONFIG.contextWindow,
         maxInputTokens: 6000,
-        targetInputTokens: 3200,
+        targetBudgetRatio: 0.58,
         compactThreshold: 0.6,
-        preserveRecentUserTurns: 8,
-        chunkTokens: 1200,
+        summaryBudgetRatio: 0.05,
       },
     });
 

package/src/__tests__/memory-lifecycle-e2e.test.ts

@@ -22,7 +22,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),

package/src/__tests__/memory-recall-quality.test.ts

@@ -26,7 +26,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),

package/src/__tests__/memory-regressions.experimental.test.ts

@@ -18,7 +18,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),

package/src/__tests__/memory-regressions.test.ts

@@ -18,7 +18,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),

package/src/__tests__/memory-retrieval.benchmark.test.ts

@@ -25,7 +25,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),

package/src/__tests__/memory-upsert-concurrency.test.ts

@@ -31,7 +31,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),

package/src/__tests__/messaging-send-tool.test.ts

@@ -38,6 +38,9 @@ mock.module("../config/bundled-skills/messaging/tools/shared.js", () => ({
   ) => fn("provider-token"),
   ok: (content: string) => ({ content, isError: false }),
   err: (content: string) => ({ content, isError: true }),
+  extractHeader: () => "",
+  parseAddressList: () => [],
+  extractEmail: (a: string) => a.toLowerCase(),
 }));
 
 import { run } from "../config/bundled-skills/messaging/tools/messaging-send.js";
@@ -71,6 +74,38 @@ describe("messaging-send tool", () => {
       {
         subject: undefined,
         inReplyTo: undefined,
+        threadId: undefined,
+        assistantId: "ast-alpha",
+      },
+    );
+  });
+
+  test("passes threadId to provider when replying on non-Gmail platform", async () => {
+    const result = await run(
+      {
+        platform: "phone",
+        conversation_id: "conv-1",
+        text: "reply text",
+        thread_id: "thread-abc",
+      },
+      {
+        workingDir: "/tmp",
+        sessionId: "sess-1",
+        conversationId: "conv-1",
+        assistantId: "ast-alpha",
+        trustClass: "guardian" as const,
+      },
+    );
+
+    expect(result.isError).toBe(false);
+    expect(sendMessageMock).toHaveBeenCalledWith(
+      "provider-token",
+      "conv-1",
+      "reply text",
+      {
+        subject: undefined,
+        inReplyTo: undefined,
+        threadId: "thread-abc",
         assistantId: "ast-alpha",
       },
     );

package/src/__tests__/messaging-skill-split.test.ts

@@ -0,0 +1,138 @@
+import { readFileSync } from "node:fs";
+import { dirname, resolve } from "node:path";
+import { fileURLToPath } from "node:url";
+import { describe, expect, mock, test } from "bun:test";
+
+mock.module("../config/env.js", () => ({ isHttpAuthDisabled: () => true }));
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+
+function loadManifest(skillDir: string) {
+  const manifestPath = resolve(
+    __dirname,
+    `../config/bundled-skills/${skillDir}/TOOLS.json`,
+  );
+  return JSON.parse(readFileSync(manifestPath, "utf-8"));
+}
+
+const messagingManifest = loadManifest("messaging");
+const gmailManifest = loadManifest("gmail");
+const sequencesManifest = loadManifest("sequences");
+const slackManifest = loadManifest("slack");
+
+describe("Messaging skill split", () => {
+  const expectedMessagingToolNames = [
+    "messaging_auth_test",
+    "messaging_list_conversations",
+    "messaging_read",
+    "messaging_search",
+    "messaging_send",
+    "messaging_mark_read",
+    "messaging_analyze_style",
+    "messaging_draft",
+    "messaging_sender_digest",
+    "messaging_archive_by_sender",
+  ];
+
+  const expectedGmailToolNames = [
+    "gmail_archive",
+    "gmail_label",
+    "gmail_trash",
+    "gmail_unsubscribe",
+    "gmail_draft",
+    "gmail_send_draft",
+    "gmail_attachments",
+    "gmail_forward",
+    "gmail_follow_up",
+    "gmail_filters",
+    "gmail_vacation",
+    "gmail_sender_digest",
+    "gmail_outreach_scan",
+  ];
+
+  const expectedSequenceToolNames = [
+    "sequence_create",
+    "sequence_list",
+    "sequence_get",
+    "sequence_update",
+    "sequence_delete",
+    "sequence_enroll",
+    "sequence_enrollment_list",
+    "sequence_import",
+    "sequence_analytics",
+  ];
+
+  const expectedSlackToolNames = ["slack_add_reaction", "slack_leave_channel"];
+
+  test("messaging/TOOLS.json contains all expected messaging_* tool names", () => {
+    const names: string[] = messagingManifest.tools.map(
+      (t: { name: string }) => t.name,
+    );
+    for (const name of expectedMessagingToolNames) {
+      expect(names).toContain(name);
+    }
+  });
+
+  test("messaging/TOOLS.json contains NO gmail_*, sequence_*, or google_contacts tools", () => {
+    const names: string[] = messagingManifest.tools.map(
+      (t: { name: string }) => t.name,
+    );
+    for (const name of names) {
+      expect(name).not.toMatch(/^gmail_/);
+      expect(name).not.toMatch(/^sequence_/);
+      expect(name).not.toBe("google_contacts");
+    }
+  });
+
+  test("gmail/TOOLS.json contains all expected gmail_* tool names", () => {
+    const names: string[] = gmailManifest.tools.map(
+      (t: { name: string }) => t.name,
+    );
+    for (const name of expectedGmailToolNames) {
+      expect(names).toContain(name);
+    }
+  });
+
+  test("sequences/TOOLS.json contains all expected sequence_* tool names", () => {
+    const names: string[] = sequencesManifest.tools.map(
+      (t: { name: string }) => t.name,
+    );
+    expect(names).toHaveLength(expectedSequenceToolNames.length);
+    for (const name of expectedSequenceToolNames) {
+      expect(names).toContain(name);
+    }
+  });
+
+  test("slack/TOOLS.json contains all expected slack_* tool names", () => {
+    const names: string[] = slackManifest.tools.map(
+      (t: { name: string }) => t.name,
+    );
+    for (const name of expectedSlackToolNames) {
+      expect(names).toContain(name);
+    }
+  });
+
+  test("total tools across all manifests meets expected minimum", () => {
+    const expectedMinimum =
+      expectedMessagingToolNames.length +
+      expectedGmailToolNames.length +
+      expectedSequenceToolNames.length +
+      expectedSlackToolNames.length;
+    const totalTools =
+      messagingManifest.tools.length +
+      gmailManifest.tools.length +
+      sequencesManifest.tools.length +
+      slackManifest.tools.length;
+    expect(totalTools).toBeGreaterThanOrEqual(expectedMinimum);
+  });
+
+  test("no tool name collisions across messaging, gmail, and sequences manifests", () => {
+    const allNames = [
+      ...messagingManifest.tools.map((t: { name: string }) => t.name),
+      ...gmailManifest.tools.map((t: { name: string }) => t.name),
+      ...sequencesManifest.tools.map((t: { name: string }) => t.name),
+    ];
+    const unique = new Set(allNames);
+    expect(unique.size).toBe(allNames.length);
+  });
+});

package/src/__tests__/migration-cross-version-compatibility.test.ts

@@ -64,7 +64,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => testDbPath,
   getLogPath: () => join(testDir, "test.log"),

package/src/__tests__/migration-export-http.test.ts

@@ -38,7 +38,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => testDbPath,
   getLogPath: () => join(testDir, "test.log"),
@@ -467,7 +466,7 @@ describe("route policy registration", () => {
     expect(policy?.requiredScopes).toContain("settings.write");
     expect(policy?.allowedPrincipalTypes).toContain("actor");
     expect(policy?.allowedPrincipalTypes).toContain("svc_gateway");
-    expect(policy?.allowedPrincipalTypes).toContain("ipc");
+    expect(policy?.allowedPrincipalTypes).toContain("local");
   });
 
   test("migrations/validate policy is still registered", async () => {
@@ -493,7 +492,7 @@ describe("auth policy shape", () => {
     expect(policy!.requiredScopes).toEqual(["settings.write"]);
     // Verify only the expected principal types are allowed
     expect(policy!.allowedPrincipalTypes).toEqual(
-      expect.arrayContaining(["actor", "svc_gateway", "svc_daemon", "ipc"]),
+      expect.arrayContaining(["actor", "svc_gateway", "svc_daemon", "local"]),
     );
     expect(policy!.allowedPrincipalTypes).toHaveLength(4);
   });

package/src/__tests__/migration-import-commit-http.test.ts

@@ -59,7 +59,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => testDbPath,
   getLogPath: () => join(testDir, "test.log"),
@@ -770,7 +769,7 @@ describe("route policy registration", () => {
     expect(policy?.requiredScopes).toContain("settings.write");
     expect(policy?.allowedPrincipalTypes).toContain("actor");
     expect(policy?.allowedPrincipalTypes).toContain("svc_gateway");
-    expect(policy?.allowedPrincipalTypes).toContain("ipc");
+    expect(policy?.allowedPrincipalTypes).toContain("local");
   });
 
   test("import policy matches other migration endpoint policies", async () => {

package/src/__tests__/migration-import-preflight-http.test.ts

@@ -45,7 +45,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => testDbPath,
   getLogPath: () => join(testDir, "test.log"),
@@ -708,7 +707,7 @@ describe("route policy registration", () => {
     expect(policy?.requiredScopes).toContain("settings.write");
     expect(policy?.allowedPrincipalTypes).toContain("actor");
     expect(policy?.allowedPrincipalTypes).toContain("svc_gateway");
-    expect(policy?.allowedPrincipalTypes).toContain("ipc");
+    expect(policy?.allowedPrincipalTypes).toContain("local");
   });
 
   test("import-preflight policy matches validate/export policy shape", async () => {

package/src/__tests__/migration-validate-http.test.ts

@@ -34,7 +34,6 @@ mock.module("../util/platform.js", () => ({
   isMacOS: () => process.platform === "darwin",
   isLinux: () => process.platform === "linux",
   isWindows: () => process.platform === "win32",
-  getSocketPath: () => join(testDir, "test.sock"),
   getPidPath: () => join(testDir, "test.pid"),
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
@@ -676,7 +675,7 @@ describe("route policy registration", () => {
     expect(policy?.requiredScopes).toContain("settings.write");
     expect(policy?.allowedPrincipalTypes).toContain("actor");
     expect(policy?.allowedPrincipalTypes).toContain("svc_gateway");
-    expect(policy?.allowedPrincipalTypes).toContain("ipc");
+    expect(policy?.allowedPrincipalTypes).toContain("local");
   });
 });