@vellumai/assistant 0.4.4 → 0.4.6

package/src/__tests__/call-pointer-messages.test.ts

@@ -25,8 +25,8 @@ mock.module('../util/logger.js', () => ({
     }),
 }));
 
-import { addPointerMessage, formatDuration, resetPointerCopyGenerator, setPointerCopyGenerator } from '../calls/call-pointer-messages.js';
-import { getMessages } from '../memory/conversation-store.js';
+import { addPointerMessage, formatDuration, resetPointerMessageProcessor, setPointerMessageProcessor } from '../calls/call-pointer-messages.js';
+import { addMessage, getMessages } from '../memory/conversation-store.js';
 import { getDb, initializeDb, resetDb } from '../memory/db.js';
 import { conversations } from '../memory/schema.js';
 
@@ -95,7 +95,7 @@ describe('addPointerMessage', () => {
   });
 
   afterEach(() => {
-    resetPointerCopyGenerator();
+    resetPointerMessageProcessor();
   });
 
   afterAll(() => {
@@ -192,87 +192,149 @@ describe('addPointerMessage', () => {
     expect(text).toContain('failed: Max attempts exceeded');
   });
 
-  // Trust-aware tests: in test env, generator is not called (NODE_ENV=test
-  // short-circuits to fallback), so these validate the trust gating path
-  // while still receiving deterministic text.
+  // Trust-aware tests
 
-  test('untrusted audience uses deterministic fallback even with generator set', () => {
+  test('untrusted audience uses deterministic fallback even with processor set', () => {
     const convId = 'conv-ptr-untrusted';
-    // standard threadType + no origin channel = untrusted
     ensureConversation(convId, { threadType: 'standard' });
 
-    const generatorCalled = { value: false };
-    setPointerCopyGenerator(async () => {
-      generatorCalled.value = true;
-      return 'generated text';
+    const processorCalled = { value: false };
+    setPointerMessageProcessor(async () => {
+      processorCalled.value = true;
     });
 
     addPointerMessage(convId, 'started', '+15551234567');
     const text = getLatestAssistantText(convId);
-    // In test env, deterministic fallback is always used regardless of trust
     expect(text).toContain('Call to +15551234567 started');
+    // processor not called because standard threadType + no origin = untrusted
+    expect(processorCalled.value).toBe(false);
   });
 
-  test('explicit untrusted audience mode skips generator', () => {
+  test('explicit untrusted audience mode skips processor', () => {
     const convId = 'conv-ptr-explicit-untrusted';
     ensureConversation(convId, { threadType: 'private' });
 
-    const generatorCalled = { value: false };
-    setPointerCopyGenerator(async () => {
-      generatorCalled.value = true;
-      return 'generated text';
+    const processorCalled = { value: false };
+    setPointerMessageProcessor(async () => {
+      processorCalled.value = true;
     });
 
     addPointerMessage(convId, 'started', '+15551234567', undefined, 'untrusted');
     const text = getLatestAssistantText(convId);
     expect(text).toContain('Call to +15551234567 started');
-    // generator is not called because audience is explicitly untrusted
-    expect(generatorCalled.value).toBe(false);
+    expect(processorCalled.value).toBe(false);
   });
 
-  test('private threadType is detected as trusted audience', async () => {
-    const convId = 'conv-ptr-private';
+  test('trusted audience routes through daemon processor with required facts', async () => {
+    const convId = 'conv-ptr-trusted';
     ensureConversation(convId, { threadType: 'private' });
 
-    setPointerCopyGenerator(async () => 'generated text');
+    let capturedInstruction = '';
+    let capturedFacts: string[] = [];
+    setPointerMessageProcessor(async (_convId, instruction, requiredFacts) => {
+      capturedInstruction = instruction;
+      capturedFacts = requiredFacts ?? [];
+    });
 
     await addPointerMessage(convId, 'completed', '+15559876543', { duration: '1m' });
+    // Processor was called with a structured instruction
+    expect(capturedInstruction).toContain('[CALL_STATUS_EVENT]');
+    expect(capturedInstruction).toContain('+15559876543');
+    expect(capturedInstruction).toContain('completed');
+    expect(capturedInstruction).toContain('1m');
+    // Required facts include phone number, duration, and outcome keyword
+    expect(capturedFacts).toContain('+15559876543');
+    expect(capturedFacts).toContain('1m');
+    expect(capturedFacts).toContain('completed');
+  });
+
+  test('trusted audience falls back to deterministic on processor failure', async () => {
+    const convId = 'conv-ptr-processor-fail';
+    ensureConversation(convId, { threadType: 'private' });
+
+    setPointerMessageProcessor(async () => {
+      throw new Error('Daemon unavailable');
+    });
+
+    await addPointerMessage(convId, 'failed', '+15559876543', { reason: 'busy' });
+    // Falls back to deterministic — written directly to conversation store
     const text = getLatestAssistantText(convId);
-    // In test env, falls back to deterministic even on trusted path
-    expect(text).toContain('Call to +15559876543 completed (1m)');
+    expect(text).toContain('failed: busy');
   });
 
   test('vellum origin channel is detected as trusted audience', async () => {
     const convId = 'conv-ptr-vellum';
     ensureConversation(convId, { originChannel: 'vellum' });
 
-    setPointerCopyGenerator(async () => 'generated text');
+    let processorCalled = false;
+    setPointerMessageProcessor(async () => {
+      processorCalled = true;
+    });
 
     await addPointerMessage(convId, 'failed', '+15559876543', { reason: 'busy' });
-    const text = getLatestAssistantText(convId);
-    expect(text).toContain('failed: busy');
+    expect(processorCalled).toBe(true);
   });
 
   test('missing conversation defaults to untrusted', () => {
-    const _convId = 'conv-ptr-missing';
-    // Don't create the conversation — trust resolution should default to untrusted
+    const convId = 'conv-ptr-no-signals';
+    ensureConversation(convId);
+
+    const processorCalled = { value: false };
+    setPointerMessageProcessor(async () => {
+      processorCalled.value = true;
+    });
+
+    addPointerMessage(convId, 'started', '+15551234567');
+    const text = getLatestAssistantText(convId);
+    expect(text).toContain('Call to +15551234567 started');
+    expect(processorCalled.value).toBe(false);
+  });
+
+  // Provenance trust class tests
+
+  test('guardian provenance trust class is detected as trusted audience', async () => {
+    const convId = 'conv-ptr-guardian-provenance';
+    ensureConversation(convId, { threadType: 'standard' });
+    // Add a user message with guardian provenance metadata
+    await addMessage(convId, 'user', 'hello', { provenanceTrustClass: 'guardian' });
+
+    let processorCalled = false;
+    setPointerMessageProcessor(async () => {
+      processorCalled = true;
+    });
+
+    await addPointerMessage(convId, 'completed', '+15559876543');
+    expect(processorCalled).toBe(true);
+  });
 
-    const generatorCalled = { value: false };
-    setPointerCopyGenerator(async () => {
-      generatorCalled.value = true;
-      return 'generated text';
+  test('trusted_contact provenance trust class is detected as trusted audience', async () => {
+    const convId = 'conv-ptr-tc-provenance';
+    ensureConversation(convId, { threadType: 'standard' });
+    // Add a user message with trusted_contact provenance metadata
+    await addMessage(convId, 'user', 'hello', { provenanceTrustClass: 'trusted_contact' });
+
+    let processorCalled = false;
+    setPointerMessageProcessor(async () => {
+      processorCalled = true;
     });
 
-    // This will fail at addMessage because conversation doesn't exist,
-    // but the trust check itself should not throw. Test just the trust
-    // gating by using a conversation that exists but has no trust signals.
-    const convId2 = 'conv-ptr-no-signals';
-    ensureConversation(convId2);
+    await addPointerMessage(convId, 'completed', '+15559876543');
+    expect(processorCalled).toBe(true);
+  });
+
+  test('unknown provenance trust class does not grant trusted audience', () => {
+    const convId = 'conv-ptr-unknown-provenance';
+    ensureConversation(convId, { threadType: 'standard' });
+    addMessage(convId, 'user', 'hello', { provenanceTrustClass: 'unknown' });
 
-    addPointerMessage(convId2, 'started', '+15551234567');
-    const text = getLatestAssistantText(convId2);
+    const processorCalled = { value: false };
+    setPointerMessageProcessor(async () => {
+      processorCalled.value = true;
+    });
+
+    addPointerMessage(convId, 'started', '+15551234567');
+    const text = getLatestAssistantText(convId);
     expect(text).toContain('Call to +15551234567 started');
-    // generator not called because standard threadType + no origin = untrusted
-    expect(generatorCalled.value).toBe(false);
+    expect(processorCalled.value).toBe(false);
   });
 });

package/src/__tests__/canonical-guardian-store.test.ts

@@ -41,6 +41,10 @@ import { getDb, initializeDb, resetDb } from '../memory/db.js';
 
 initializeDb();
 
+// All decisionable kinds (tool_approval, pending_question, access_request)
+// require a guardianPrincipalId. Use a constant for test fixtures.
+const TEST_PRINCIPAL = 'test-principal-id';
+
 function resetTables(): void {
   const db = getDb();
   db.run('DELETE FROM canonical_guardian_deliveries');
@@ -71,6 +75,7 @@ describe('canonical-guardian-store', () => {
       conversationId: 'conv-1',
       requesterExternalUserId: 'user-1',
       guardianExternalUserId: 'guardian-1',
+      guardianPrincipalId: TEST_PRINCIPAL,
       callSessionId: 'session-1',
       pendingQuestionId: 'pq-1',
       questionText: 'Can I run this tool?',
@@ -94,6 +99,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'access_request',
       sourceType: 'channel',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     expect(req.id).toBeTruthy();
@@ -111,6 +117,7 @@ describe('canonical-guardian-store', () => {
     const created = createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     const fetched = getCanonicalGuardianRequest(created.id);
@@ -127,16 +134,16 @@ describe('canonical-guardian-store', () => {
   // ── listCanonicalGuardianRequests ─────────────────────────────────
 
   test('lists all requests with no filters', () => {
-    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'voice' });
-    createCanonicalGuardianRequest({ kind: 'access_request', sourceType: 'channel' });
+    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'voice', guardianPrincipalId: TEST_PRINCIPAL });
+    createCanonicalGuardianRequest({ kind: 'access_request', sourceType: 'channel', guardianPrincipalId: TEST_PRINCIPAL });
 
     const all = listCanonicalGuardianRequests();
     expect(all).toHaveLength(2);
   });
 
   test('filters by status', () => {
-    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'voice' });
-    const req2 = createCanonicalGuardianRequest({ kind: 'access_request', sourceType: 'channel' });
+    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'voice', guardianPrincipalId: TEST_PRINCIPAL });
+    const req2 = createCanonicalGuardianRequest({ kind: 'access_request', sourceType: 'channel', guardianPrincipalId: TEST_PRINCIPAL });
     updateCanonicalGuardianRequest(req2.id, { status: 'approved' });
 
     const pending = listCanonicalGuardianRequests({ status: 'pending' });
@@ -153,11 +160,13 @@ describe('canonical-guardian-store', () => {
       kind: 'tool_approval',
       sourceType: 'voice',
       guardianExternalUserId: 'guardian-A',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
       guardianExternalUserId: 'guardian-B',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     const filtered = listCanonicalGuardianRequests({ guardianExternalUserId: 'guardian-A' });
@@ -170,11 +179,13 @@ describe('canonical-guardian-store', () => {
       kind: 'tool_approval',
       sourceType: 'voice',
       conversationId: 'conv-X',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
       conversationId: 'conv-Y',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     const filtered = listCanonicalGuardianRequests({ conversationId: 'conv-X' });
@@ -182,18 +193,18 @@ describe('canonical-guardian-store', () => {
   });
 
   test('filters by sourceType', () => {
-    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'voice' });
-    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'channel' });
-    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'desktop' });
+    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'voice', guardianPrincipalId: TEST_PRINCIPAL });
+    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'channel', guardianPrincipalId: TEST_PRINCIPAL });
+    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'desktop', guardianPrincipalId: TEST_PRINCIPAL });
 
     const voiceOnly = listCanonicalGuardianRequests({ sourceType: 'voice' });
     expect(voiceOnly).toHaveLength(1);
   });
 
   test('filters by kind', () => {
-    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'voice' });
-    createCanonicalGuardianRequest({ kind: 'pending_question', sourceType: 'voice' });
-    createCanonicalGuardianRequest({ kind: 'access_request', sourceType: 'channel' });
+    createCanonicalGuardianRequest({ kind: 'tool_approval', sourceType: 'voice', guardianPrincipalId: TEST_PRINCIPAL });
+    createCanonicalGuardianRequest({ kind: 'pending_question', sourceType: 'voice', guardianPrincipalId: TEST_PRINCIPAL });
+    createCanonicalGuardianRequest({ kind: 'access_request', sourceType: 'channel', guardianPrincipalId: TEST_PRINCIPAL });
 
     const toolOnly = listCanonicalGuardianRequests({ kind: 'tool_approval' });
     expect(toolOnly).toHaveLength(1);
@@ -204,16 +215,19 @@ describe('canonical-guardian-store', () => {
       kind: 'tool_approval',
       sourceType: 'voice',
       guardianExternalUserId: 'guardian-A',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'channel',
       guardianExternalUserId: 'guardian-A',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     createCanonicalGuardianRequest({
       kind: 'access_request',
       sourceType: 'voice',
       guardianExternalUserId: 'guardian-A',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     const filtered = listCanonicalGuardianRequests({
@@ -230,6 +244,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     const updated = updateCanonicalGuardianRequest(req.id, {
@@ -260,6 +275,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     const resolved = resolveCanonicalGuardianRequest(req.id, 'pending', {
@@ -278,6 +294,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'channel',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     const resolved = resolveCanonicalGuardianRequest(req.id, 'pending', {
@@ -293,6 +310,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     // Try to resolve with wrong expected status
@@ -311,6 +329,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     // First resolve succeeds
@@ -353,6 +372,7 @@ describe('canonical-guardian-store', () => {
       sourceChannel: 'twilio',
       conversationId: 'conv-voice-1',
       guardianExternalUserId: 'guardian-phone',
+      guardianPrincipalId: TEST_PRINCIPAL,
       callSessionId: 'call-123',
       pendingQuestionId: 'pq-456',
       questionText: 'What is the gate code?',
@@ -374,6 +394,7 @@ describe('canonical-guardian-store', () => {
       conversationId: 'conv-tg-1',
       requesterExternalUserId: 'requester-tg-user',
       guardianExternalUserId: 'guardian-tg-user',
+      guardianPrincipalId: TEST_PRINCIPAL,
       toolName: 'execute_code',
       inputDigest: 'sha256:abcdef',
       expiresAt: new Date(Date.now() + 120_000).toISOString(),
@@ -394,6 +415,7 @@ describe('canonical-guardian-store', () => {
       sourceType: 'desktop',
       conversationId: 'conv-desktop-1',
       guardianExternalUserId: 'guardian-desktop',
+      guardianPrincipalId: TEST_PRINCIPAL,
       questionText: 'User wants to access settings',
     });
 
@@ -408,6 +430,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     const d1 = createCanonicalGuardianDelivery({
@@ -436,6 +459,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     const deliveries = listCanonicalGuardianDeliveries(req.id);
@@ -446,10 +470,12 @@ describe('canonical-guardian-store', () => {
     const pendingReq = createCanonicalGuardianRequest({
       kind: 'pending_question',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     const resolvedReq = createCanonicalGuardianRequest({
       kind: 'pending_question',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     updateCanonicalGuardianRequest(resolvedReq.id, { status: 'approved' });
 
@@ -476,6 +502,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'pending_question',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     createCanonicalGuardianDelivery({
@@ -498,6 +525,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'tool_approval',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     const delivery = createCanonicalGuardianDelivery({
       requestId: req.id,
@@ -525,6 +553,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'pending_question',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     createCanonicalGuardianDelivery({
       requestId: req.id,
@@ -544,10 +573,12 @@ describe('canonical-guardian-store', () => {
     const pendingReq = createCanonicalGuardianRequest({
       kind: 'pending_question',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     const resolvedReq = createCanonicalGuardianRequest({
       kind: 'pending_question',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     updateCanonicalGuardianRequest(resolvedReq.id, { status: 'approved' });
 
@@ -574,6 +605,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'pending_question',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
 
     // Two delivery rows targeting the same chat for the same request
@@ -602,6 +634,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'pending_question',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     createCanonicalGuardianDelivery({
       requestId: req.id,
@@ -620,6 +653,7 @@ describe('canonical-guardian-store', () => {
     const req = createCanonicalGuardianRequest({
       kind: 'pending_question',
       sourceType: 'voice',
+      guardianPrincipalId: TEST_PRINCIPAL,
     });
     createCanonicalGuardianDelivery({
       requestId: req.id,