@vellumai/assistant 0.4.37 → 0.4.41

package/src/calls/call-domain.ts

@@ -123,7 +123,6 @@ export type CallerIdentityResult =
 export async function resolveCallerIdentity(
   config: AssistantConfig,
   requestedMode?: "assistant_number" | "user_number",
-  assistantId?: string,
 ): Promise<CallerIdentityResult> {
   const identityConfig = config.calls.callerIdentity;
   let mode: "assistant_number" | "user_number";
@@ -161,7 +160,7 @@ export async function resolveCallerIdentity(
   }
 
   if (mode === "assistant_number") {
-    const twilioConfig = getTwilioConfig(assistantId);
+    const twilioConfig = getTwilioConfig();
     log.info(
       { mode, source, fromNumber: twilioConfig.phoneNumber },
       "Resolved caller identity",
@@ -395,7 +394,6 @@ export async function startCall(
     const identityResult = await resolveCallerIdentity(
       ingressConfig,
       callerIdentityMode,
-      assistantId,
     );
     if (!identityResult.ok) {
       return { ok: false, error: identityResult.error, status: 400 };
@@ -883,12 +881,8 @@ export type StartGuardianVerificationCallResult =
 export async function startGuardianVerificationCall(
   input: StartGuardianVerificationCallInput,
 ): Promise<StartGuardianVerificationCallResult> {
-  const {
-    phoneNumber,
-    guardianVerificationSessionId,
-    assistantId = DAEMON_INTERNAL_ASSISTANT_ID,
-    originConversationId,
-  } = input;
+  const { phoneNumber, guardianVerificationSessionId, originConversationId } =
+    input;
 
   if (!phoneNumber || !E164_REGEX.test(phoneNumber)) {
     return {
@@ -905,11 +899,7 @@ export async function startGuardianVerificationCall(
     const provider = new TwilioConversationRelayProvider();
 
     // Resolve the assistant's Twilio number as the caller ID
-    const identityResult = await resolveCallerIdentity(
-      config,
-      undefined,
-      assistantId,
-    );
+    const identityResult = await resolveCallerIdentity(config);
     if (!identityResult.ok) {
       return { ok: false, error: identityResult.error, status: 400 };
     }

package/src/calls/relay-server.ts

@@ -19,7 +19,7 @@ import {
   createGuardianBinding,
   revokeGuardianBinding,
   touchContactInteraction,
-  upsertMember,
+  upsertContactChannel,
 } from "../contacts/contacts-write.js";
 import { getAssistantName } from "../daemon/identity-helpers.js";
 import { getCanonicalGuardianRequest } from "../memory/canonical-guardian-store.js";
@@ -785,7 +785,7 @@ export class RelayConnection {
 
     if (!params.skipMemberActivation) {
       try {
-        upsertMember({
+        upsertContactChannel({
           sourceChannel: "voice",
           externalUserId: fromNumber,
           externalChatId: fromNumber,

package/src/calls/twilio-config.ts

@@ -1,4 +1,3 @@
-import { getTwilioPhoneNumberEnv } from "../config/env.js";
 import { loadConfig } from "../config/loader.js";
 import {
   getPublicBaseUrl,
@@ -18,29 +17,11 @@ export interface TwilioConfig {
   wssBaseUrl: string;
 }
 
-function resolveTwilioPhoneNumber(
-  config: ReturnType<typeof loadConfig>,
-  assistantId?: string,
-): string {
-  if (assistantId) {
-    const scoped = (
-      config.sms?.assistantPhoneNumbers as Record<string, string> | undefined
-    )?.[assistantId];
-    if (scoped) return scoped;
-  }
-  return (
-    getTwilioPhoneNumberEnv() ||
-    config.sms?.phoneNumber ||
-    getSecureKey("credential:twilio:phone_number") ||
-    ""
-  );
-}
-
-export function getTwilioConfig(assistantId?: string): TwilioConfig {
-  const accountSid = getSecureKey("credential:twilio:account_sid");
-  const authToken = getSecureKey("credential:twilio:auth_token");
+export function getTwilioConfig(): TwilioConfig {
   const config = loadConfig();
-  const phoneNumber = resolveTwilioPhoneNumber(config, assistantId);
+  const accountSid = config.twilio?.accountSid || "";
+  const authToken = getSecureKey("credential:twilio:auth_token");
+  const phoneNumber = config.twilio?.phoneNumber || "";
   const webhookBaseUrl = getPublicBaseUrl(config);
 
   let wssBaseUrl: string;
@@ -52,7 +33,7 @@ export function getTwilioConfig(assistantId?: string): TwilioConfig {
 
   if (!accountSid || !authToken) {
     throw new ConfigError(
-      "Twilio credentials not configured. Set credential:twilio:account_sid and credential:twilio:auth_token via the credential_store tool.",
+      "Twilio credentials not configured. Set twilio.accountSid via config and twilio:auth_token via the credential_store tool.",
     );
   }
   if (!phoneNumber) {

package/src/calls/twilio-rest.ts

@@ -6,6 +6,7 @@
  * config handler. Uses fetch() directly — no twilio npm package.
  */
 
+import { loadConfig } from "../config/loader.js";
 import { getSecureKey } from "../security/secure-keys.js";
 import { ConfigError, ProviderError } from "../util/errors.js";
 
@@ -14,13 +15,27 @@ export interface TwilioCredentials {
   authToken: string;
 }
 
-/** Resolve Twilio credentials from the secure key store. Throws if not configured. */
+/**
+ * Resolve the Twilio Account SID from config.
+ * Returns undefined if not found.
+ */
+function resolveAccountSid(): string | undefined {
+  try {
+    const config = loadConfig();
+    if (config.twilio?.accountSid) return config.twilio.accountSid;
+  } catch {
+    // Config may not be available during early startup
+  }
+  return undefined;
+}
+
+/** Resolve Twilio credentials from config and secure key store. Throws if not configured. */
 export function getTwilioCredentials(): TwilioCredentials {
-  const accountSid = getSecureKey("credential:twilio:account_sid");
+  const accountSid = resolveAccountSid();
   const authToken = getSecureKey("credential:twilio:auth_token");
   if (!accountSid || !authToken) {
     throw new ConfigError(
-      "Twilio credentials not configured. Set credential:twilio:account_sid and credential:twilio:auth_token via the credential_store tool.",
+      "Twilio credentials not configured. Set twilio.accountSid via config and credential:twilio:auth_token via the credential_store tool.",
     );
   }
   return { accountSid, authToken };
@@ -29,8 +44,7 @@ export function getTwilioCredentials(): TwilioCredentials {
 /** Check whether Twilio credentials are present (non-throwing). */
 export function hasTwilioCredentials(): boolean {
   return (
-    !!getSecureKey("credential:twilio:account_sid") &&
-    !!getSecureKey("credential:twilio:auth_token")
+    !!resolveAccountSid() && !!getSecureKey("credential:twilio:auth_token")
   );
 }