@vellumai/assistant 0.4.33 → 0.4.34

package/src/__tests__/guardian-action-grant-mint-consume.test.ts

@@ -8,7 +8,6 @@
  *   3. tryMintGuardianActionGrant mints a tool_signature grant
  *   4. Voice consumer can consume the grant for the same tool+input
  *   5. Second consume attempt is denied (one-time use)
- *   6. Grant for a different assistantId is not consumable
  */
 
 import { mkdtempSync, rmSync } from "node:fs";
@@ -75,7 +74,6 @@ afterAll(() => {
 
 // ── Constants ───────────────────────────────────────────────────────
 
-const ASSISTANT_ID = "self";
 const TOOL_NAME = "execute_shell";
 const TOOL_INPUT = { command: "rm -rf /tmp/test" };
 const CONVERSATION_ID = "conv-e2e";
@@ -175,7 +173,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
     // Step 1: Create a guardian action request with tool metadata
     // (simulates the voice ASK_GUARDIAN path)
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -217,7 +214,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
     expect(grants[0].inputDigest).toBe(inputDigest);
     expect(grants[0].scopeMode).toBe("tool_signature");
     expect(grants[0].status).toBe("active");
-    expect(grants[0].assistantId).toBe(ASSISTANT_ID);
     expect(grants[0].callSessionId).toBe(CALL_SESSION_ID);
 
     // Step 4: Voice consumer consumes the grant
@@ -225,7 +221,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
       toolName: TOOL_NAME,
       inputDigest,
       consumingRequestId: "voice-req-1",
-      assistantId: ASSISTANT_ID,
       executionChannel: "voice",
       callSessionId: CALL_SESSION_ID,
       conversationId: CONVERSATION_ID,
@@ -240,7 +235,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
       toolName: TOOL_NAME,
       inputDigest,
       consumingRequestId: "voice-req-2",
-      assistantId: ASSISTANT_ID,
       executionChannel: "voice",
       callSessionId: CALL_SESSION_ID,
       conversationId: CONVERSATION_ID,
@@ -249,64 +243,9 @@ describe("guardian-action grant mint -> voice consume integration", () => {
     expect(secondConsume.grant).toBeNull();
   });
 
-  test("grant minted for one assistantId cannot be consumed by another", async () => {
-    const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
-
-    const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
-      kind: "ask_guardian",
-      sourceChannel: "voice",
-      sourceConversationId: CONVERSATION_ID,
-      callSessionId: CALL_SESSION_ID,
-      pendingQuestionId: nextPendingQuestionId(),
-      questionText: "Can I run the command?",
-      expiresAt: Date.now() + 60_000,
-      toolName: TOOL_NAME,
-      inputDigest,
-    });
-
-    const resolved = resolveGuardianActionRequest(
-      request.id,
-      "Yes",
-      "telegram",
-    );
-    expect(resolved).not.toBeNull();
-
-    await tryMintGuardianActionGrant({
-      request: resolved!,
-      answerText: "Yes",
-      decisionChannel: "telegram",
-    });
-
-    // Attempt to consume with a different assistantId
-    const wrongAssistant = consumeScopedApprovalGrantByToolSignature({
-      toolName: TOOL_NAME,
-      inputDigest,
-      consumingRequestId: "voice-req-wrong",
-      assistantId: "other-assistant",
-      executionChannel: "voice",
-      callSessionId: CALL_SESSION_ID,
-      conversationId: CONVERSATION_ID,
-    });
-    expect(wrongAssistant.ok).toBe(false);
-
-    // Correct assistantId succeeds
-    const correctAssistant = consumeScopedApprovalGrantByToolSignature({
-      toolName: TOOL_NAME,
-      inputDigest,
-      consumingRequestId: "voice-req-correct",
-      assistantId: ASSISTANT_ID,
-      executionChannel: "voice",
-      callSessionId: CALL_SESSION_ID,
-      conversationId: CONVERSATION_ID,
-    });
-    expect(correctAssistant.ok).toBe(true);
-  });
-
   test("no grant minted when guardian action request lacks tool metadata", async () => {
     // Create a request without toolName/inputDigest (informational consult)
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -340,7 +279,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -372,7 +310,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
       toolName: TOOL_NAME,
       inputDigest,
       consumingRequestId: "voice-req-desktop",
-      assistantId: ASSISTANT_ID,
       executionChannel: "voice",
       callSessionId: CALL_SESSION_ID,
       conversationId: CONVERSATION_ID,
@@ -384,7 +321,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -424,7 +360,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
       const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
       const request = createGuardianActionRequest({
-        assistantId: ASSISTANT_ID,
         kind: "ask_guardian",
         sourceChannel: "voice",
         sourceConversationId: CONVERSATION_ID,
@@ -459,7 +394,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -497,7 +431,6 @@ describe("guardian-action grant mint -> voice consume integration", () => {
       const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
       const request = createGuardianActionRequest({
-        assistantId: ASSISTANT_ID,
         kind: "ask_guardian",
         sourceChannel: "voice",
         sourceConversationId: CONVERSATION_ID,
@@ -544,7 +477,6 @@ describe("guardian-action grant minter: two-tier classification (deterministic +
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -585,7 +517,6 @@ describe("guardian-action grant minter: two-tier classification (deterministic +
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -626,7 +557,6 @@ describe("guardian-action grant minter: two-tier classification (deterministic +
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -666,7 +596,6 @@ describe("guardian-action grant minter: two-tier classification (deterministic +
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -705,7 +634,6 @@ describe("guardian-action grant minter: two-tier classification (deterministic +
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -740,7 +668,6 @@ describe("guardian-action grant minter: two-tier classification (deterministic +
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,
@@ -783,7 +710,6 @@ describe("guardian-action grant minter: two-tier classification (deterministic +
     const inputDigest = computeToolApprovalDigest(TOOL_NAME, TOOL_INPUT);
 
     const request = createGuardianActionRequest({
-      assistantId: ASSISTANT_ID,
       kind: "ask_guardian",
       sourceChannel: "voice",
       sourceConversationId: CONVERSATION_ID,

package/src/__tests__/guardian-action-late-reply.test.ts

@@ -151,7 +151,6 @@ describe("guardian-action-late-reply", () => {
     });
 
     const deliveries = getExpiredDeliveriesByDestination(
-      "self",
       "telegram",
       "chat-abc",
     );
@@ -163,11 +162,7 @@ describe("guardian-action-late-reply", () => {
   test("getExpiredDeliveriesByDestination returns empty for non-matching channel", () => {
     createExpiredRequest("conv-late-2", { chatId: "chat-abc" });
 
-    const deliveries = getExpiredDeliveriesByDestination(
-      "self",
-      "sms",
-      "chat-abc",
-    );
+    const deliveries = getExpiredDeliveriesByDestination("sms", "chat-abc");
     expect(deliveries).toHaveLength(0);
   });
 
@@ -180,7 +175,6 @@ describe("guardian-action-late-reply", () => {
     startFollowupFromExpiredRequest(request.id, "late answer text");
 
     const deliveries = getExpiredDeliveriesByDestination(
-      "self",
       "telegram",
       "chat-started",
     );
@@ -311,7 +305,6 @@ describe("guardian-action-late-reply", () => {
 
     // Should not appear in expired queries
     const expiredByDest = getExpiredDeliveriesByDestination(
-      "self",
       "telegram",
       "chat-answered",
     );

package/src/__tests__/guardian-grant-minting.test.ts

@@ -104,7 +104,6 @@ function createTestGuardianApproval(
     runId: `run-${requestId}`,
     requestId,
     conversationId: CONVERSATION_ID,
-    assistantId: ASSISTANT_ID,
     channel: "telegram",
     requesterExternalUserId: REQUESTER_USER,
     requesterChatId: REQUESTER_CHAT,

package/src/__tests__/guardian-routing-state.test.ts

@@ -185,7 +185,6 @@ describe("inbound-message-handler trusted-contact interactivity", () => {
     // Insert a test contact so the contacts-based ACL lookup passes
     upsertContact({
       displayName: "Test User",
-      assistantId: "self",
       channels: [
         {
           type: "telegram",
@@ -225,7 +224,6 @@ describe("inbound-message-handler trusted-contact interactivity", () => {
   test("trusted contact with guardian binding gets interactive turn", async () => {
     // Create guardian binding in contacts table so the trust resolver finds it
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-user-for-tc",
       guardianDeliveryChatId: "guardian-chat-for-tc",
@@ -326,7 +324,6 @@ describe("inbound-message-handler trusted-contact interactivity", () => {
   test("guardian actors remain interactive regardless", async () => {
     // Guardian binding matches the sender — use contacts-first so trust resolver finds it
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "telegram-user-default",
       guardianDeliveryChatId: "chat-123",

package/src/__tests__/inbound-invite-redemption.test.ts

@@ -329,7 +329,6 @@ describe("inbound invite redemption intercept", () => {
   test("existing active member sending normal message is unaffected", async () => {
     // Pre-create an active member
     upsertMember({
-      assistantId: "self",
       sourceChannel: "telegram",
       externalUserId: "user-active-member",
       externalChatId: "chat-active",
@@ -379,7 +378,6 @@ describe("inbound invite redemption intercept", () => {
 
     // Pre-create an active member that will click the invite link
     upsertMember({
-      assistantId: "self",
       sourceChannel: "telegram",
       externalUserId: "user-already-active",
       externalChatId: "chat-invite-test",
@@ -406,7 +404,6 @@ describe("inbound invite redemption intercept", () => {
     });
 
     upsertMember({
-      assistantId: "self",
       sourceChannel: "telegram",
       externalUserId: "user-invite-123",
       externalChatId: "chat-invite-test",

package/src/__tests__/non-member-access-request.test.ts

@@ -189,7 +189,6 @@ describe("non-member access request notification", () => {
   test("guardian is notified when a non-member messages and a guardian binding exists", async () => {
     // Set up a guardian binding for this channel
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-user-789",
       guardianDeliveryChatId: "guardian-chat-789",
@@ -235,7 +234,6 @@ describe("non-member access request notification", () => {
 
   test("no duplicate approval requests for repeated messages from same non-member", async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-user-789",
       guardianDeliveryChatId: "guardian-chat-789",
@@ -306,7 +304,6 @@ describe("non-member access request notification", () => {
   test("cross-channel fallback: SMS guardian binding resolves for Telegram access request", async () => {
     // Only an SMS guardian binding exists — no Telegram binding
     createGuardianBinding({
-      assistantId: "self",
       channel: "sms",
       guardianExternalUserId: "guardian-sms-user",
       guardianDeliveryChatId: "guardian-sms-chat",
@@ -342,7 +339,6 @@ describe("non-member access request notification", () => {
 
   test("no notification when actorExternalId is absent", async () => {
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-user-789",
       guardianDeliveryChatId: "guardian-chat-789",
@@ -419,7 +415,6 @@ describe("access-request-helper unit tests", () => {
   test("notifyGuardianOfAccessRequest uses cross-channel binding when source-channel binding is missing", () => {
     // Only SMS binding exists
     createGuardianBinding({
-      assistantId: "self",
       channel: "sms",
       guardianExternalUserId: "guardian-sms",
       guardianDeliveryChatId: "sms-chat",
@@ -455,7 +450,6 @@ describe("access-request-helper unit tests", () => {
   test("notifyGuardianOfAccessRequest prefers source-channel binding over cross-channel fallback", () => {
     // Both Telegram and SMS bindings exist
     createGuardianBinding({
-      assistantId: "self",
       channel: "telegram",
       guardianExternalUserId: "guardian-tg",
       guardianDeliveryChatId: "tg-chat",
@@ -463,7 +457,6 @@ describe("access-request-helper unit tests", () => {
       verifiedVia: "test",
     });
     createGuardianBinding({
-      assistantId: "self",
       channel: "sms",
       guardianExternalUserId: "guardian-sms",
       guardianDeliveryChatId: "sms-chat",

package/src/__tests__/notification-broadcaster.test.ts

@@ -23,7 +23,7 @@ mock.module("../util/logger.js", () => ({
 
 // Mock destination-resolver to return a destination for every requested channel
 mock.module("../notifications/destination-resolver.js", () => ({
-  resolveDestinations: (_assistantId: string, channels: string[]) => {
+  resolveDestinations: (channels: string[]) => {
     const m = new Map();
     for (const ch of channels) {
       m.set(ch, { channel: ch, endpoint: `mock-${ch}` });
@@ -84,7 +84,6 @@ function makeSignal(
 ): NotificationSignal {
   return {
     signalId: "sig-broadcast-001",
-    assistantId: "self",
     createdAt: Date.now(),
     sourceChannel: "scheduler",
     sourceSessionId: "sess-001",

package/src/__tests__/notification-decision-fallback.test.ts

@@ -63,7 +63,6 @@ function makeSignal(
 ): NotificationSignal {
   return {
     signalId: "sig-fallback-guardian-1",
-    assistantId: "self",
     createdAt: Date.now(),
     sourceChannel: "voice",
     sourceSessionId: "call-session-1",
@@ -307,7 +306,6 @@ describe("access-request instruction enforcement", () => {
   ): NotificationSignal {
     return {
       signalId: "sig-access-req-1",
-      assistantId: "self",
       createdAt: Date.now(),
       sourceChannel: "telegram",
       sourceSessionId: "tg-session-1",

package/src/__tests__/notification-decision-strategy.test.ts

@@ -36,7 +36,6 @@ function makeSignal(
 ): NotificationSignal {
   return {
     signalId: "sig-test-001",
-    assistantId: "self",
     createdAt: Date.now(),
     sourceChannel: "scheduler",
     sourceSessionId: "sess-001",