@vellumai/assistant 0.4.31 → 0.4.33

package/src/__tests__/schedule-tools.test.ts

@@ -76,7 +76,7 @@ describe("schedule_create tool", () => {
     const result = await executeScheduleCreate(
       {
         name: "Daily standup",
-        cron_expression: "0 9 * * 1-5",
+        expression: "0 9 * * 1-5",
         message: "Time for standup!",
       },
       ctx,
@@ -93,7 +93,7 @@ describe("schedule_create tool", () => {
     const result = await executeScheduleCreate(
       {
         name: "Paused job",
-        cron_expression: "0 12 * * *",
+        expression: "0 12 * * *",
         message: "Noon check",
         enabled: false,
       },
@@ -108,7 +108,7 @@ describe("schedule_create tool", () => {
     const result = await executeScheduleCreate(
       {
         name: "LA morning",
-        cron_expression: "0 8 * * *",
+        expression: "0 8 * * *",
         message: "Good morning LA",
         timezone: "America/Los_Angeles",
       },
@@ -122,7 +122,7 @@ describe("schedule_create tool", () => {
   test("rejects missing name", async () => {
     const result = await executeScheduleCreate(
       {
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -142,16 +142,14 @@ describe("schedule_create tool", () => {
     );
 
     expect(result.isError).toBe(true);
-    expect(result.content).toContain(
-      "expression (or cron_expression) is required",
-    );
+    expect(result.content).toContain("expression is required");
   });
 
   test("rejects missing message", async () => {
     const result = await executeScheduleCreate(
       {
         name: "Test",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
       },
       ctx,
     );
@@ -164,7 +162,8 @@ describe("schedule_create tool", () => {
     const result = await executeScheduleCreate(
       {
         name: "Bad cron",
-        cron_expression: "not-a-cron",
+        syntax: "cron",
+        expression: "not-a-cron",
         message: "test",
       },
       ctx,
@@ -194,7 +193,7 @@ describe("schedule_list tool", () => {
     await executeScheduleCreate(
       {
         name: "Job Alpha",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "Alpha",
       },
       ctx,
@@ -202,7 +201,7 @@ describe("schedule_list tool", () => {
     await executeScheduleCreate(
       {
         name: "Job Beta",
-        cron_expression: "0 17 * * *",
+        expression: "0 17 * * *",
         message: "Beta",
       },
       ctx,
@@ -220,7 +219,7 @@ describe("schedule_list tool", () => {
     await executeScheduleCreate(
       {
         name: "Enabled Job",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "enabled",
       },
       ctx,
@@ -228,7 +227,7 @@ describe("schedule_list tool", () => {
     await executeScheduleCreate(
       {
         name: "Disabled Job",
-        cron_expression: "0 17 * * *",
+        expression: "0 17 * * *",
         message: "disabled",
         enabled: false,
       },
@@ -246,7 +245,7 @@ describe("schedule_list tool", () => {
     await executeScheduleCreate(
       {
         name: "Detail Job",
-        cron_expression: "30 14 * * *",
+        expression: "30 14 * * *",
         message: "Afternoon check",
       },
       ctx,
@@ -286,7 +285,7 @@ describe("schedule_update tool", () => {
     await executeScheduleCreate(
       {
         name: "Old Name",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -312,7 +311,7 @@ describe("schedule_update tool", () => {
     await executeScheduleCreate(
       {
         name: "Timing Test",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -324,7 +323,7 @@ describe("schedule_update tool", () => {
     const result = await executeScheduleUpdate(
       {
         job_id: row.id,
-        cron_expression: "0 17 * * *",
+        expression: "0 17 * * *",
       },
       ctx,
     );
@@ -337,7 +336,7 @@ describe("schedule_update tool", () => {
     await executeScheduleCreate(
       {
         name: "Disable Me",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -370,7 +369,7 @@ describe("schedule_update tool", () => {
     await executeScheduleCreate(
       {
         name: "No Update",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -402,7 +401,7 @@ describe("schedule_update tool", () => {
     await executeScheduleCreate(
       {
         name: "Bad Update",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -414,7 +413,8 @@ describe("schedule_update tool", () => {
     const result = await executeScheduleUpdate(
       {
         job_id: row.id,
-        cron_expression: "invalid",
+        syntax: "cron",
+        expression: "invalid",
       },
       ctx,
     );
@@ -432,22 +432,6 @@ describe("schedule_create with RRULE", () => {
     getRawDb().run("DELETE FROM cron_jobs");
   });
 
-  test("creates a schedule with legacy cron_expression", async () => {
-    const result = await executeScheduleCreate(
-      {
-        name: "Legacy cron",
-        cron_expression: "0 9 * * 1-5",
-        message: "Legacy test",
-      },
-      ctx,
-    );
-
-    expect(result.isError).toBe(false);
-    expect(result.content).toContain("Schedule created successfully");
-    expect(result.content).toContain("Syntax: cron");
-    expect(result.content).toContain("Every weekday at 9:00 AM");
-  });
-
   test("creates a schedule with RRULE syntax + expression", async () => {
     const result = await executeScheduleCreate(
       {
@@ -507,7 +491,7 @@ describe("schedule_update with RRULE", () => {
     await executeScheduleCreate(
       {
         name: "Cron to RRULE",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -535,7 +519,7 @@ describe("schedule_update with RRULE", () => {
     await executeScheduleCreate(
       {
         name: "Auto-detect on update",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -561,7 +545,7 @@ describe("schedule_update with RRULE", () => {
     await executeScheduleCreate(
       {
         name: "Cron auto-detect",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -593,7 +577,7 @@ describe("schedule_list with RRULE", () => {
     await executeScheduleCreate(
       {
         name: "Cron Job",
-        cron_expression: "0 9 * * 1-5",
+        expression: "0 9 * * 1-5",
         message: "Cron test",
       },
       ctx,
@@ -750,7 +734,7 @@ describe("schedule_update with RRULE set", () => {
     await executeScheduleCreate(
       {
         name: "Cron to set",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -784,7 +768,7 @@ describe("schedule_update with RRULE set", () => {
     await executeScheduleCreate(
       {
         name: "Bad set update",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,
@@ -928,7 +912,7 @@ describe("schedule_delete tool", () => {
     await executeScheduleCreate(
       {
         name: "Delete Me",
-        cron_expression: "0 9 * * *",
+        expression: "0 9 * * *",
         message: "test",
       },
       ctx,

package/src/__tests__/session-init.benchmark.test.ts

@@ -107,13 +107,11 @@ mock.module("../util/platform.js", () => ({
   isWindows: () => process.platform === "win32",
   getPlatformName: () => process.platform,
   getClipboardCommand: () => null,
-  getHttpTokenPath: () => join(testDir, "http-token"),
   getPlatformTokenPath: () => join(testDir, "platform-token"),
   getTCPHost: () => "127.0.0.1",
   getTCPPort: () => 8765,
   isIOSPairingEnabled: () => false,
   isTCPEnabled: () => false,
-  readHttpToken: () => null,
   readLockfile: () => null,
   readPlatformToken: () => null,
   readSessionToken: () => null,

package/src/__tests__/skill-feature-flags.test.ts

@@ -120,10 +120,10 @@ describe("isAssistantFeatureFlagEnabled", () => {
 
   test("declared keys with no persisted override use registry default", () => {
     const config = makeConfig();
-    // browser is declared in the registry with defaultEnabled: false
+    // browser is declared in the registry with defaultEnabled: true
     expect(
       isAssistantFeatureFlagEnabled("feature_flags.browser.enabled", config),
-    ).toBe(false);
+    ).toBe(true);
   });
 });
 

package/src/__tests__/slack-channel-config.test.ts

@@ -28,7 +28,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  readHttpToken: () => undefined,
 }));
 
 mock.module("../util/logger.js", () => ({

package/src/__tests__/slack-inbound-verification.test.ts

@@ -30,7 +30,6 @@ mock.module("../util/platform.js", () => ({
   getDbPath: () => join(testDir, "test.db"),
   getLogPath: () => join(testDir, "test.log"),
   ensureDataDir: () => {},
-  readHttpToken: () => "test-bearer-token",
 }));
 
 mock.module("../util/logger.js", () => ({

package/src/__tests__/sms-messaging-provider.test.ts

@@ -33,10 +33,6 @@ mock.module("../security/secure-keys.js", () => ({
   getSecureKey: (key: string) => secureKeys[key],
 }));
 
-mock.module("../util/platform.js", () => ({
-  readHttpToken: () => "runtime-token",
-}));
-
 mock.module("../runtime/auth/token-service.js", () => ({
   mintDaemonDeliveryToken: () => "runtime-token",
 }));

package/src/__tests__/task-management-tools.test.ts

@@ -39,6 +39,8 @@ mock.module("../tools/registry.js", () => ({
   getAllTools: () => [],
 }));
 
+import type { Database } from "bun:sqlite";
+
 import { getDb, initializeDb, resetDb } from "../memory/db.js";
 import { renderTemplate } from "../tasks/task-runner.js";
 import {
@@ -54,6 +56,7 @@ import {
 import { executeTaskDelete } from "../tools/tasks/task-delete.js";
 import { executeTaskList } from "../tools/tasks/task-list.js";
 import { executeTaskRun } from "../tools/tasks/task-run.js";
+import { executeTaskSave } from "../tools/tasks/task-save.js";
 import { executeTaskListAdd } from "../tools/tasks/work-item-enqueue.js";
 import { executeTaskListShow } from "../tools/tasks/work-item-list.js";
 import { executeTaskListRemove } from "../tools/tasks/work-item-remove.js";
@@ -90,6 +93,10 @@ const ctx: ToolContext = {
   trustClass: "guardian",
 };
 
+function getRawDb(): Database {
+  return (getDb() as unknown as { $client: Database }).$client;
+}
+
 function clearTables() {
   const db = getDb();
   db.run("DELETE FROM work_items");
@@ -97,6 +104,41 @@ function clearTables() {
   db.run("DELETE FROM tasks");
 }
 
+function clearTablesWithConversations() {
+  const raw = getRawDb();
+  raw.run("DELETE FROM work_items");
+  raw.run("DELETE FROM task_runs");
+  raw.run("DELETE FROM tasks");
+  raw.run("DELETE FROM messages");
+  raw.run("DELETE FROM conversations");
+}
+
+function createTestConversation(id: string): string {
+  const raw = getRawDb();
+  const now = Date.now();
+  raw
+    .query(
+      `INSERT INTO conversations (id, title, created_at, updated_at, thread_type, memory_scope_id) VALUES (?, 'Test', ?, ?, 'standard', 'default')`,
+    )
+    .run(id, now, now);
+  return id;
+}
+
+function addTestMessage(
+  conversationId: string,
+  role: string,
+  content: string,
+): void {
+  const raw = getRawDb();
+  const id = crypto.randomUUID();
+  const now = Date.now();
+  raw
+    .query(
+      `INSERT INTO messages (id, conversation_id, role, content, created_at) VALUES (?, ?, ?, ?, ?)`,
+    )
+    .run(id, conversationId, role, content, now);
+}
+
 // ═══════════════════════════════════════════════════════════════════
 // Task Store — CRUD
 // ═══════════════════════════════════════════════════════════════════
@@ -1043,3 +1085,72 @@ describe("executeTaskListRemove tool", () => {
     expect(result.content).toContain("Multiple items match");
   });
 });
+
+// ═══════════════════════════════════════════════════════════════════
+// Tool: executeTaskSave
+// ═══════════════════════════════════════════════════════════════════
+
+describe("executeTaskSave tool", () => {
+  beforeEach(clearTablesWithConversations);
+
+  test("creates a task from a conversation", async () => {
+    const convId = createTestConversation("conv-save-1");
+    addTestMessage(convId, "user", "Please summarize the document");
+    addTestMessage(
+      convId,
+      "assistant",
+      JSON.stringify([
+        {
+          type: "tool_use",
+          id: "tu1",
+          name: "file_read",
+          input: { path: "/tmp/doc.txt" },
+        },
+      ]),
+    );
+    addTestMessage(convId, "assistant", "Here is the summary...");
+
+    const result = await executeTaskSave({ conversation_id: convId }, ctx);
+
+    expect(result.isError).toBe(false);
+    expect(result.content).toContain("Task saved successfully");
+    expect(result.content).toContain("Please summarize the document");
+    expect(result.content).toContain("file_read");
+  });
+
+  test("uses title override when provided", async () => {
+    const convId = createTestConversation("conv-save-2");
+    addTestMessage(convId, "user", "Read and analyze the logs");
+    addTestMessage(convId, "assistant", "Done!");
+
+    const result = await executeTaskSave(
+      { conversation_id: convId, title: "My Custom Title" },
+      ctx,
+    );
+
+    expect(result.isError).toBe(false);
+    expect(result.content).toContain("My Custom Title");
+  });
+
+  test("uses context conversation_id when missing", async () => {
+    const convId = createTestConversation(ctx.conversationId);
+    addTestMessage(convId, "user", "Summarize the report");
+    addTestMessage(convId, "assistant", "Done.");
+
+    const result = await executeTaskSave({}, ctx);
+
+    expect(result.isError).toBe(false);
+    expect(result.content).toContain("Task saved successfully");
+    expect(result.content).toContain("Summarize the report");
+  });
+
+  test("returns error for nonexistent conversation", async () => {
+    const result = await executeTaskSave(
+      { conversation_id: "nonexistent" },
+      ctx,
+    );
+
+    expect(result.isError).toBe(true);
+    expect(result.content).toContain("No messages found");
+  });
+});

package/src/__tests__/terminal-tools.test.ts

@@ -711,10 +711,13 @@ describe("formatShellOutput", () => {
     expect(result.isError).toBe(false);
   });
 
-  test("failed command with no output shows exit code tag", () => {
+  test("failed command with no output shows exit code tag and descriptive message", () => {
     const result = formatShellOutput("", "", 1, false, 120);
-    expect(result.content).toBe('<command_exit code="1" />');
+    expect(result.content).toContain('<command_exit code="1" />');
+    expect(result.content).toContain("Command failed with exit code 1");
+    expect(result.content).toContain("No stdout or stderr output was produced");
     expect(result.isError).toBe(true);
+    expect(result.status).toContain('<command_exit code="1" />');
   });
 
   test("failed command with output includes exit code in status", () => {