@vellumai/assistant 0.4.2 → 0.4.3

package/src/__tests__/ingress-routes-http.test.ts

@@ -492,6 +492,8 @@ describe('voice invite HTTP routes', () => {
       body: JSON.stringify({
         sourceChannel: 'voice',
         expectedExternalUserId: '+15551234567',
+        friendName: 'Alice',
+        guardianName: 'Bob',
         maxUses: 3,
       }),
     });
@@ -514,6 +516,9 @@ describe('voice invite HTTP routes', () => {
     expect(invite.voiceCodeDigits).toBe(6);
     // expectedExternalUserId should be recorded
     expect(invite.expectedExternalUserId).toBe('+15551234567');
+    // friendName and guardianName should be recorded
+    expect(invite.friendName).toBe('Alice');
+    expect(invite.guardianName).toBe('Bob');
   });
 
   test('voice invite creation requires expectedExternalUserId', async () => {
@@ -522,6 +527,8 @@ describe('voice invite HTTP routes', () => {
       headers: { 'Content-Type': 'application/json' },
       body: JSON.stringify({
         sourceChannel: 'voice',
+        friendName: 'Alice',
+        guardianName: 'Bob',
       }),
     });
 
@@ -540,6 +547,8 @@ describe('voice invite HTTP routes', () => {
       body: JSON.stringify({
         sourceChannel: 'voice',
         expectedExternalUserId: 'not-a-phone-number',
+        friendName: 'Alice',
+        guardianName: 'Bob',
       }),
     });
 
@@ -551,6 +560,44 @@ describe('voice invite HTTP routes', () => {
     expect(body.error).toContain('E.164');
   });
 
+  test('voice invite creation requires friendName', async () => {
+    const req = new Request('http://localhost/v1/ingress/invites', {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({
+        sourceChannel: 'voice',
+        expectedExternalUserId: '+15551234567',
+        guardianName: 'Bob',
+      }),
+    });
+
+    const res = await handleCreateInvite(req);
+    const body = await res.json() as Record<string, unknown>;
+
+    expect(res.status).toBe(400);
+    expect(body.ok).toBe(false);
+    expect(body.error).toContain('friendName');
+  });
+
+  test('voice invite creation requires guardianName', async () => {
+    const req = new Request('http://localhost/v1/ingress/invites', {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({
+        sourceChannel: 'voice',
+        expectedExternalUserId: '+15551234567',
+        friendName: 'Alice',
+      }),
+    });
+
+    const res = await handleCreateInvite(req);
+    const body = await res.json() as Record<string, unknown>;
+
+    expect(res.status).toBe(400);
+    expect(body.ok).toBe(false);
+    expect(body.error).toContain('guardianName');
+  });
+
   test('voiceCodeDigits is always 6 — custom values are ignored', async () => {
     const req = new Request('http://localhost/v1/ingress/invites', {
       method: 'POST',
@@ -558,6 +605,8 @@ describe('voice invite HTTP routes', () => {
       body: JSON.stringify({
         sourceChannel: 'voice',
         expectedExternalUserId: '+15551234567',
+        friendName: 'Alice',
+        guardianName: 'Bob',
         voiceCodeDigits: 8,
       }),
     });
@@ -579,6 +628,8 @@ describe('voice invite HTTP routes', () => {
       body: JSON.stringify({
         sourceChannel: 'voice',
         expectedExternalUserId: '+15551234567',
+        friendName: 'Alice',
+        guardianName: 'Bob',
       }),
     });
 
@@ -600,6 +651,8 @@ describe('voice invite HTTP routes', () => {
       body: JSON.stringify({
         sourceChannel: 'voice',
         expectedExternalUserId: '+15551234567',
+        friendName: 'Alice',
+        guardianName: 'Bob',
         maxUses: 1,
       }),
     }));
@@ -648,6 +701,8 @@ describe('voice invite HTTP routes', () => {
       body: JSON.stringify({
         sourceChannel: 'voice',
         expectedExternalUserId: '+15551234567',
+        friendName: 'Alice',
+        guardianName: 'Bob',
         maxUses: 1,
       }),
     }));

package/src/__tests__/non-member-access-request.test.ts

@@ -30,7 +30,6 @@ mock.module('../util/platform.js', () => ({
   getDbPath: () => join(testDir, 'test.db'),
   getLogPath: () => join(testDir, 'test.log'),
   ensureDataDir: () => {},
-  normalizeAssistantId: (id: string) => id === 'self' ? 'self' : id,
   readHttpToken: () => 'test-bearer-token',
 }));
 
@@ -437,6 +436,34 @@ describe('access-request-helper unit tests', () => {
     expect(payload.guardianBindingChannel).toBe('telegram');
   });
 
+  test('notifyGuardianOfAccessRequest for voice channel includes senderName in contextPayload', () => {
+    const result = notifyGuardianOfAccessRequest({
+      canonicalAssistantId: 'self',
+      sourceChannel: 'voice',
+      externalChatId: '+15559998888',
+      senderExternalUserId: '+15559998888',
+      senderName: 'Alice Caller',
+    });
+
+    expect(result.notified).toBe(true);
+    expect(emitSignalCalls.length).toBe(1);
+
+    const payload = emitSignalCalls[0].contextPayload as Record<string, unknown>;
+    expect(payload.sourceChannel).toBe('voice');
+    expect(payload.senderName).toBe('Alice Caller');
+    expect(payload.senderExternalUserId).toBe('+15559998888');
+    expect(payload.senderIdentifier).toBe('Alice Caller');
+
+    // Canonical request should exist
+    const pending = listCanonicalGuardianRequests({
+      status: 'pending',
+      requesterExternalUserId: '+15559998888',
+      sourceChannel: 'voice',
+      kind: 'access_request',
+    });
+    expect(pending.length).toBe(1);
+  });
+
   test('notifyGuardianOfAccessRequest includes requestCode in contextPayload', () => {
     const result = notifyGuardianOfAccessRequest({
       canonicalAssistantId: 'self',

package/src/__tests__/notification-decision-strategy.test.ts

@@ -196,6 +196,50 @@ describe('notification decision strategy', () => {
       expect(copy.vellum!.body).toContain('open invite flow');
     });
 
+    test('ingress.access_request template includes caller name for voice-originated requests', () => {
+      // In production, senderIdentifier resolves to senderName for voice
+      // calls (senderName || senderUsername || senderExternalUserId), so
+      // both values are the caller's name. The phone number arrives via
+      // senderExternalUserId and should appear in the parenthetical.
+      const signal = makeSignal({
+        sourceEventName: 'ingress.access_request',
+        contextPayload: {
+          senderIdentifier: 'Alice Smith',
+          senderName: 'Alice Smith',
+          senderExternalUserId: '+15559998888',
+          sourceChannel: 'voice',
+          requestCode: 'V1C2E3',
+        },
+      });
+
+      const copy = composeFallbackCopy(signal, channels);
+      expect(copy.vellum).toBeDefined();
+      expect(copy.vellum!.title).toBe('Access Request');
+      // Voice-originated requests should include the caller name and phone number in parentheses
+      expect(copy.vellum!.body).toContain('Alice Smith');
+      expect(copy.vellum!.body).toContain('(+15559998888)');
+      expect(copy.vellum!.body).toContain('calling');
+    });
+
+    test('ingress.access_request template falls back to non-voice copy when sourceChannel is not voice', () => {
+      const signal = makeSignal({
+        sourceEventName: 'ingress.access_request',
+        contextPayload: {
+          senderIdentifier: 'user-123',
+          senderName: 'Bob Jones',
+          sourceChannel: 'telegram',
+          requestCode: 'T1G2M3',
+        },
+      });
+
+      const copy = composeFallbackCopy(signal, channels);
+      expect(copy.vellum).toBeDefined();
+      // Non-voice should use the standard "requesting access" text, not "calling"
+      expect(copy.vellum!.body).toContain('user-123');
+      expect(copy.vellum!.body).toContain('requesting access');
+      expect(copy.vellum!.body).not.toContain('calling');
+    });
+
     test('ingress.access_request Telegram deliveryText is concise', () => {
       const signal = makeSignal({
         sourceEventName: 'ingress.access_request',