@vellumai/assistant 0.3.4 → 0.3.5

package/src/__tests__/credential-security-invariants.test.ts

@@ -197,6 +197,7 @@ describe('Invariant 2: no generic plaintext secret read API', () => {
       'calls/elevenlabs-config.ts',      // ElevenLabs credential lookup
       'cli/config-commands.ts',          // CLI config management
       'messaging/providers/telegram-bot/adapter.ts', // Telegram bot token lookup for connectivity check
+      'messaging/providers/sms/adapter.ts', // Twilio credential lookup for SMS connectivity check
     ]);
 
     const thisDir = dirname(fileURLToPath(import.meta.url));

package/src/__tests__/daemon-lifecycle.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test';
+import { beforeEach, describe, expect, mock, test } from 'bun:test';
 import type * as net from 'node:net';
 
 // ── Mocks ────────────────────────────────────────────────────────────
@@ -141,7 +141,7 @@ mock.module('../daemon/session.js', () => ({
 
 import { DaemonServer } from '../daemon/server.js';
 import { SessionEvictor, type EvictableSession } from '../daemon/session-evictor.js';
-import { createMessageParser, serialize, MAX_LINE_SIZE } from '../daemon/ipc-protocol.js';
+import { createMessageParser, serialize } from '../daemon/ipc-protocol.js';
 
 // ── Test Helpers ─────────────────────────────────────────────────────
 
@@ -165,7 +165,7 @@ function internals(server: DaemonServer): DaemonServerInternals {
 
 function createFakeSocket(overrides?: Partial<net.Socket>) {
   const writes: string[] = [];
-  const socket = {
+  const base: Record<string, unknown> = {
     destroyed: false,
     writable: true,
     remoteAddress: '127.0.0.1',
@@ -174,16 +174,17 @@ function createFakeSocket(overrides?: Partial<net.Socket>) {
       return true;
     },
     destroy(): void {
-      this.destroyed = true;
+      base.destroyed = true;
     },
     on(_event: string, _handler: (...args: unknown[]) => void): unknown {
-      return this;
+      return socket;
     },
     once(_event: string, _handler: (...args: unknown[]) => void): unknown {
-      return this;
+      return socket;
     },
     ...overrides,
-  } as unknown as net.Socket;
+  };
+  const socket = base as unknown as net.Socket;
   return { socket, writes };
 }
 
@@ -586,7 +587,7 @@ describe('IPC protocol', () => {
       const parser = createMessageParser();
       const messages = parser.feed('{"type":"ping"}\n');
       expect(messages).toHaveLength(1);
-      expect((messages[0] as Record<string, unknown>).type).toBe('ping');
+      expect((messages[0] as unknown as Record<string, unknown>).type).toBe('ping');
     });
 
     test('buffers partial messages until newline arrives', () => {
@@ -597,22 +598,22 @@ describe('IPC protocol', () => {
 
       const partial2 = parser.feed('"ping"}\n');
       expect(partial2).toHaveLength(1);
-      expect((partial2[0] as Record<string, unknown>).type).toBe('ping');
+      expect((partial2[0] as unknown as Record<string, unknown>).type).toBe('ping');
     });
 
     test('handles multiple messages in a single chunk', () => {
       const parser = createMessageParser();
       const messages = parser.feed('{"type":"ping"}\n{"type":"pong"}\n');
       expect(messages).toHaveLength(2);
-      expect((messages[0] as Record<string, unknown>).type).toBe('ping');
-      expect((messages[1] as Record<string, unknown>).type).toBe('pong');
+      expect((messages[0] as unknown as Record<string, unknown>).type).toBe('ping');
+      expect((messages[1] as unknown as Record<string, unknown>).type).toBe('pong');
     });
 
     test('skips malformed JSON lines gracefully', () => {
       const parser = createMessageParser();
       const messages = parser.feed('not json\n{"type":"valid"}\n');
       expect(messages).toHaveLength(1);
-      expect((messages[0] as Record<string, unknown>).type).toBe('valid');
+      expect((messages[0] as unknown as Record<string, unknown>).type).toBe('valid');
     });
 
     test('throws when line exceeds maxLineSize', () => {

package/src/__tests__/dictation-mode-detection.test.ts

@@ -0,0 +1,63 @@
+import { describe, expect, test } from 'bun:test';
+import type { DictationRequest } from '../daemon/ipc-protocol.js';
+import { detectDictationMode } from '../daemon/handlers/dictation.js';
+
+type DictationRequestOverrides = Omit<Partial<DictationRequest>, 'context'> & {
+  context?: Partial<DictationRequest['context']>;
+};
+
+function makeRequest(overrides: DictationRequestOverrides = {}): DictationRequest {
+  const base: DictationRequest = {
+    type: 'dictation_request',
+    transcription: 'hello there',
+    context: {
+      bundleIdentifier: 'com.google.Chrome',
+      appName: 'Google Chrome',
+      windowTitle: 'Inbox - Gmail',
+      selectedText: undefined,
+      cursorInTextField: false,
+    },
+  };
+  return {
+    ...base,
+    ...overrides,
+    context: {
+      ...base.context,
+      ...(overrides.context ?? {}),
+    },
+  };
+}
+
+describe('detectDictationMode', () => {
+  test('uses command mode when selected text exists', () => {
+    const mode = detectDictationMode(makeRequest({
+      transcription: 'make this friendlier',
+      context: { selectedText: 'Please send me the files.', cursorInTextField: true },
+    }));
+    expect(mode).toBe('command');
+  });
+
+  test('uses action mode for action-verb utterances', () => {
+    const mode = detectDictationMode(makeRequest({
+      transcription: 'send Alex a follow up',
+      context: { selectedText: undefined, cursorInTextField: false },
+    }));
+    expect(mode).toBe('action');
+  });
+
+  test('uses dictation mode when cursor is in a text field', () => {
+    const mode = detectDictationMode(makeRequest({
+      transcription: 'quick update on status',
+      context: { cursorInTextField: true },
+    }));
+    expect(mode).toBe('dictation');
+  });
+
+  test('defaults to dictation when context is ambiguous', () => {
+    const mode = detectDictationMode(makeRequest({
+      transcription: 'just checking in about tomorrow',
+      context: { selectedText: undefined, cursorInTextField: false },
+    }));
+    expect(mode).toBe('dictation');
+  });
+});