@vellumai/assistant 0.3.26 → 0.3.28

package/src/__tests__/guardian-dispatch.test.ts

@@ -103,6 +103,8 @@ function ensureConversation(id: string): void {
 
 function resetTables(): void {
   const db = getDb();
+  db.run('DELETE FROM canonical_guardian_deliveries');
+  db.run('DELETE FROM canonical_guardian_requests');
   db.run('DELETE FROM guardian_action_deliveries');
   db.run('DELETE FROM guardian_action_requests');
   db.run('DELETE FROM call_pending_questions');
@@ -160,7 +162,7 @@ describe('guardian-dispatch', () => {
 
     const db = getDb();
     const raw = (db as unknown as { $client: import('bun:sqlite').Database }).$client;
-    const request = raw.query('SELECT * FROM guardian_action_requests WHERE call_session_id = ?').get(session.id) as
+    const request = raw.query('SELECT * FROM canonical_guardian_requests WHERE call_session_id = ?').get(session.id) as
       | { id: string; status: string; question_text: string }
       | undefined;
     expect(request).toBeDefined();
@@ -168,7 +170,7 @@ describe('guardian-dispatch', () => {
     expect(request!.question_text).toBe('What is the gate code?');
 
     const vellumDelivery = raw.query(
-      'SELECT * FROM guardian_action_deliveries WHERE request_id = ? AND destination_channel = ?',
+      'SELECT * FROM canonical_guardian_deliveries WHERE request_id = ? AND destination_channel = ?',
     ).get(request!.id, 'vellum') as { status: string; destination_conversation_id: string | null } | undefined;
     expect(vellumDelivery).toBeDefined();
     expect(vellumDelivery!.status).toBe('sent');
@@ -224,18 +226,17 @@ describe('guardian-dispatch', () => {
 
     const db = getDb();
     const raw = (db as unknown as { $client: import('bun:sqlite').Database }).$client;
-    const request = raw.query('SELECT * FROM guardian_action_requests WHERE call_session_id = ?').get(session.id) as
+    const request = raw.query('SELECT * FROM canonical_guardian_requests WHERE call_session_id = ?').get(session.id) as
       | { id: string }
       | undefined;
     const telegramDelivery = raw.query(
-      'SELECT * FROM guardian_action_deliveries WHERE request_id = ? AND destination_channel = ?',
+      'SELECT * FROM canonical_guardian_deliveries WHERE request_id = ? AND destination_channel = ?',
     ).get(request!.id, 'telegram') as
-      | { status: string; destination_chat_id: string | null; destination_external_user_id: string | null }
+      | { status: string; destination_chat_id: string | null }
       | undefined;
     expect(telegramDelivery).toBeDefined();
     expect(telegramDelivery!.status).toBe('sent');
     expect(telegramDelivery!.destination_chat_id).toBe('tg-chat-999');
-    expect(telegramDelivery!.destination_external_user_id).toBe('tg-user-888');
   });
 
   test('marks non-sent pipeline delivery results as failed', async () => {
@@ -275,15 +276,14 @@ describe('guardian-dispatch', () => {
 
     const db = getDb();
     const raw = (db as unknown as { $client: import('bun:sqlite').Database }).$client;
-    const request = raw.query('SELECT * FROM guardian_action_requests WHERE call_session_id = ?').get(session.id) as
+    const request = raw.query('SELECT * FROM canonical_guardian_requests WHERE call_session_id = ?').get(session.id) as
       | { id: string }
       | undefined;
     const vellumDelivery = raw.query(
-      'SELECT * FROM guardian_action_deliveries WHERE request_id = ? AND destination_channel = ?',
-    ).get(request!.id, 'vellum') as { status: string; last_error: string | null } | undefined;
+      'SELECT * FROM canonical_guardian_deliveries WHERE request_id = ? AND destination_channel = ?',
+    ).get(request!.id, 'vellum') as { status: string } | undefined;
     expect(vellumDelivery).toBeDefined();
     expect(vellumDelivery!.status).toBe('failed');
-    expect(vellumDelivery!.last_error).toContain('IPC unavailable');
   });
 
   test('uses onThreadCreated callback conversation when delivery result omits conversationId', async () => {
@@ -326,17 +326,17 @@ describe('guardian-dispatch', () => {
 
     const db = getDb();
     const raw = (db as unknown as { $client: import('bun:sqlite').Database }).$client;
-    const request = raw.query('SELECT * FROM guardian_action_requests WHERE call_session_id = ?').get(session.id) as
+    const request = raw.query('SELECT * FROM canonical_guardian_requests WHERE call_session_id = ?').get(session.id) as
       | { id: string }
       | undefined;
     const vellumDelivery = raw.query(
-      'SELECT * FROM guardian_action_deliveries WHERE request_id = ? AND destination_channel = ?',
+      'SELECT * FROM canonical_guardian_deliveries WHERE request_id = ? AND destination_channel = ?',
     ).get(request!.id, 'vellum') as { destination_conversation_id: string | null } | undefined;
     expect(vellumDelivery).toBeDefined();
     expect(vellumDelivery!.destination_conversation_id).toBe('conv-from-thread-created');
   });
 
-  test('persists toolName and inputDigest on guardian action request for tool-approval dispatches', async () => {
+  test('persists toolName and inputDigest on canonical guardian request for tool-approval dispatches', async () => {
     const convId = 'conv-dispatch-5';
     ensureConversation(convId);
 
@@ -359,7 +359,7 @@ describe('guardian-dispatch', () => {
 
     const db = getDb();
     const raw = (db as unknown as { $client: import('bun:sqlite').Database }).$client;
-    const request = raw.query('SELECT * FROM guardian_action_requests WHERE call_session_id = ?').get(session.id) as
+    const request = raw.query('SELECT * FROM canonical_guardian_requests WHERE call_session_id = ?').get(session.id) as
       | { id: string; tool_name: string | null; input_digest: string | null }
       | undefined;
     expect(request).toBeDefined();
@@ -388,7 +388,7 @@ describe('guardian-dispatch', () => {
 
     const db = getDb();
     const raw = (db as unknown as { $client: import('bun:sqlite').Database }).$client;
-    const request = raw.query('SELECT * FROM guardian_action_requests WHERE call_session_id = ?').get(session.id) as
+    const request = raw.query('SELECT * FROM canonical_guardian_requests WHERE call_session_id = ?').get(session.id) as
       | { id: string; tool_name: string | null; input_digest: string | null }
       | undefined;
     expect(request).toBeDefined();
@@ -485,11 +485,11 @@ describe('guardian-dispatch', () => {
       pendingQuestion: pq2,
     });
 
-    // Both dispatches should have created separate action requests
+    // Both dispatches should have created separate canonical requests
     const db = getDb();
     const raw = (db as unknown as { $client: import('bun:sqlite').Database }).$client;
     const requests = raw.query(
-      'SELECT * FROM guardian_action_requests WHERE call_session_id = ? ORDER BY created_at ASC',
+      'SELECT * FROM canonical_guardian_requests WHERE call_session_id = ? ORDER BY created_at ASC',
     ).all(session.id) as Array<{ id: string; question_text: string }>;
     expect(requests).toHaveLength(2);
     expect(requests[0].question_text).toBe('What is the gate code?');
@@ -498,7 +498,7 @@ describe('guardian-dispatch', () => {
     // Each request should have its own delivery row, both pointing to the shared conversation
     for (const req of requests) {
       const delivery = raw.query(
-        'SELECT * FROM guardian_action_deliveries WHERE request_id = ? AND destination_channel = ?',
+        'SELECT * FROM canonical_guardian_deliveries WHERE request_id = ? AND destination_channel = ?',
       ).get(req.id, 'vellum') as { status: string; destination_conversation_id: string | null } | undefined;
       expect(delivery).toBeDefined();
       expect(delivery!.status).toBe('sent');
@@ -507,7 +507,7 @@ describe('guardian-dispatch', () => {
 
     // Total delivery rows should be 2 (one per request), not 1
     const allDeliveries = raw.query(
-      'SELECT * FROM guardian_action_deliveries WHERE destination_conversation_id = ?',
+      'SELECT * FROM canonical_guardian_deliveries WHERE destination_conversation_id = ?',
     ).all(sharedConversationId) as Array<{ request_id: string }>;
     expect(allDeliveries).toHaveLength(2);