@vellumai/assistant 0.12.4 → 0.12.5-dev.202609251017.e467a6c

package/src/workspace/migrations/158-repoint-opencode-host-provider-fragments.ts

@@ -0,0 +1,163 @@
+import { existsSync, readFileSync, renameSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+import { Database } from "bun:sqlite";
+
+import type { WorkspaceMigration } from "./types.js";
+
+/**
+ * Repoint legacy-shape LLM fragments (`provider: "openai-compatible"` plus a
+ * `provider_connection` binding) whose bound row's endpoint host is
+ * opencode.ai to `provider: "opencode"`.
+ *
+ * DB migration 383 restamps such rows as provider "opencode", and dispatch
+ * requires a bound row's provider to equal the fragment's declared provider,
+ * so a fragment left declaring "openai-compatible" would either mismatch or
+ * auto-resolve to an unrelated generic row. Entry-shape fragments (provider
+ * holds the row name) derive their kind from the row and need no rewrite.
+ * Rows are judged by their base_url host, not their provider column, so the
+ * result is the same whichever migration runs first.
+ *
+ * Swept in `llm.default` and `llm.profiles.*`; call-site fragments carry no
+ * binding (the schema strips a raw `provider_connection`).
+ */
+export const repointOpencodeHostProviderFragmentsMigration: WorkspaceMigration =
+  {
+    id: "158-repoint-opencode-host-provider-fragments",
+    description:
+      "Repoint openai-compatible LLM fragments bound to opencode.ai connections to provider opencode",
+    run(workspaceDir: string): void {
+      const configPath = join(workspaceDir, "config.json");
+      if (!existsSync(configPath)) {
+        return;
+      }
+
+      // Read outside the parse catch: a transient filesystem error must reach
+      // the runner so the migration retries, while malformed JSON is a
+      // permanent state this migration cannot repair.
+      const rawText = readFileSync(configPath, "utf-8");
+
+      let config: Record<string, unknown>;
+      try {
+        const raw = JSON.parse(rawText);
+        if (!raw || typeof raw !== "object" || Array.isArray(raw)) {
+          return;
+        }
+        config = raw as Record<string, unknown>;
+      } catch {
+        return;
+      }
+
+      const llm = readObject(config.llm);
+      if (llm === null) {
+        return;
+      }
+
+      // Rows load lazily: only a legacy-shape openai-compatible fragment
+      // needs them. An unreadable DB then fails the run (retried next boot)
+      // rather than checkpointing a pass that skipped bound fragments.
+      let openCodeRows: Set<string> | null | undefined;
+      const isOpenCodeRow = (name: unknown): boolean => {
+        if (typeof name !== "string" || name.length === 0) {
+          return false;
+        }
+        if (openCodeRows === undefined) {
+          openCodeRows = readOpenCodeRowNames(workspaceDir);
+        }
+        if (openCodeRows === null) {
+          throw new Error(
+            "provider_connections is not readable; retrying the opencode repoint on the next run",
+          );
+        }
+        return openCodeRows.has(name);
+      };
+
+      const repoint = (fragment: Record<string, unknown> | null): boolean => {
+        if (
+          fragment === null ||
+          fragment.provider !== "openai-compatible" ||
+          !isOpenCodeRow(fragment.provider_connection)
+        ) {
+          return false;
+        }
+        fragment.provider = "opencode";
+        return true;
+      };
+
+      let changed = repoint(readObject(llm.default));
+      const profiles = readObject(llm.profiles);
+      if (profiles !== null) {
+        for (const rawProfile of Object.values(profiles)) {
+          changed = repoint(readObject(rawProfile)) || changed;
+        }
+      }
+      if (!changed) {
+        return;
+      }
+
+      // Write-then-rename so an interrupted write cannot leave config.json
+      // truncated for the retry to misread as "nothing to do".
+      const tmpPath = `${configPath}.migration-158.tmp`;
+      writeFileSync(tmpPath, JSON.stringify(config, null, 2) + "\n");
+      renameSync(tmpPath, configPath);
+    },
+    // The exact-match rewrite is idempotent, so a transient failure is safe
+    // to retry on later startups.
+    retryFailedCheckpoint: true,
+    down(_workspaceDir: string): void {
+      // Forward-only: the rows these fragments bind now carry provider
+      // "opencode", so reverting the fragments would recreate the mismatch.
+    },
+  };
+
+// ---------------------------------------------------------------------------
+// Helpers: self-contained per workspace migrations AGENTS.md
+// ---------------------------------------------------------------------------
+
+/**
+ * Names of `provider_connections` rows whose base_url host is opencode.ai or
+ * a subdomain, or null when the DB or table is not readable. An absent DB
+ * file is a real state (no rows, so no fragment is bound to one).
+ */
+function readOpenCodeRowNames(workspaceDir: string): Set<string> | null {
+  const dbPath = join(workspaceDir, "data", "db", "assistant.db");
+  if (!existsSync(dbPath)) {
+    return new Set();
+  }
+  let db: Database;
+  try {
+    db = new Database(dbPath, { readonly: true });
+  } catch {
+    return null;
+  }
+  try {
+    const rows = db
+      .query(
+        `SELECT name, base_url FROM provider_connections WHERE base_url IS NOT NULL`,
+      )
+      .all() as Array<{ name: string; base_url: string }>;
+    return new Set(
+      rows.filter((row) => isOpenCodeHost(row.base_url)).map((row) => row.name),
+    );
+  } catch {
+    return null;
+  } finally {
+    db.close();
+  }
+}
+
+function isOpenCodeHost(baseUrl: string): boolean {
+  let host: string;
+  try {
+    host = new URL(baseUrl).hostname.toLowerCase();
+  } catch {
+    return false;
+  }
+  return host === "opencode.ai" || host.endsWith(".opencode.ai");
+}
+
+function readObject(value: unknown): Record<string, unknown> | null {
+  if (value === null || typeof value !== "object" || Array.isArray(value)) {
+    return null;
+  }
+  return value as Record<string, unknown>;
+}

package/src/workspace/migrations/__tests__/158-repoint-opencode-host-provider-fragments.test.ts

@@ -0,0 +1,188 @@
+import {
+  mkdirSync,
+  mkdtempSync,
+  readFileSync,
+  rmSync,
+  writeFileSync,
+} from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { Database } from "bun:sqlite";
+import { afterEach, describe, expect, test } from "bun:test";
+
+import { WORKSPACE_MIGRATIONS } from "../registry.js";
+
+const migration = WORKSPACE_MIGRATIONS.find(
+  (entry) => entry.id === "158-repoint-opencode-host-provider-fragments",
+)!;
+
+const workspaces: string[] = [];
+afterEach(() => {
+  for (const workspace of workspaces.splice(0)) {
+    rmSync(workspace, { recursive: true, force: true });
+  }
+});
+
+function setup(): string {
+  const workspace = mkdtempSync(join(tmpdir(), "opencode-repoint-migration-"));
+  workspaces.push(workspace);
+  return workspace;
+}
+
+function writeConfig(workspace: string, data: Record<string, unknown>): void {
+  writeFileSync(
+    join(workspace, "config.json"),
+    JSON.stringify(data, null, 2) + "\n",
+  );
+}
+
+function readLlm(workspace: string): Record<string, any> {
+  return JSON.parse(readFileSync(join(workspace, "config.json"), "utf-8")).llm;
+}
+
+function seedRows(
+  workspace: string,
+  rows: Array<{ name: string; provider: string; baseUrl: string | null }>,
+): void {
+  mkdirSync(join(workspace, "data", "db"), { recursive: true });
+  const db = new Database(join(workspace, "data", "db", "assistant.db"));
+  db.run(`CREATE TABLE provider_connections (
+    name TEXT PRIMARY KEY,
+    provider TEXT NOT NULL,
+    auth TEXT NOT NULL,
+    base_url TEXT,
+    created_at INTEGER NOT NULL,
+    updated_at INTEGER NOT NULL
+  )`);
+  for (const row of rows) {
+    db.query(
+      `INSERT INTO provider_connections (name, provider, auth, base_url, created_at, updated_at)
+       VALUES (?, ?, '{"type":"api_key","credential":"cred"}', ?, 1, 1)`,
+    ).run(row.name, row.provider, row.baseUrl);
+  }
+  db.close();
+}
+
+describe("migration 158: repoint opencode-host provider fragments", () => {
+  test("repoints legacy-shape fragments bound to an opencode.ai row, whichever provider the row stores", () => {
+    const workspace = setup();
+    seedRows(workspace, [
+      {
+        name: "go",
+        provider: "openai-compatible",
+        baseUrl: "https://opencode.ai/zen/go/v1",
+      },
+      {
+        name: "zen",
+        provider: "opencode",
+        baseUrl: "https://opencode.ai/zen/v1",
+      },
+      {
+        name: "vllm",
+        provider: "openai-compatible",
+        baseUrl: "http://localhost:8080/v1",
+      },
+    ]);
+    writeConfig(workspace, {
+      llm: {
+        default: {
+          provider: "openai-compatible",
+          provider_connection: "go",
+          model: "m",
+        },
+        profiles: {
+          a: {
+            provider: "openai-compatible",
+            provider_connection: "go",
+            model: "m",
+          },
+          b: {
+            provider: "openai-compatible",
+            provider_connection: "zen",
+            model: "m",
+          },
+          c: {
+            provider: "openai-compatible",
+            provider_connection: "vllm",
+            model: "m",
+          },
+          entry: { provider: "go", model: "m" },
+          unbound: { provider: "openai-compatible", model: "m" },
+          dangling: {
+            provider: "openai-compatible",
+            provider_connection: "gone",
+            model: "m",
+          },
+        },
+      },
+    });
+
+    migration.run(workspace);
+
+    const llm = readLlm(workspace);
+    expect(llm.default.provider).toBe("opencode");
+    expect(llm.default.provider_connection).toBe("go");
+    expect(llm.profiles.a.provider).toBe("opencode");
+    expect(llm.profiles.b.provider).toBe("opencode");
+    expect(llm.profiles.c.provider).toBe("openai-compatible");
+    expect(llm.profiles.entry.provider).toBe("go");
+    expect(llm.profiles.unbound.provider).toBe("openai-compatible");
+    expect(llm.profiles.dangling.provider).toBe("openai-compatible");
+  });
+
+  test("no-ops without config, without a db, or with nothing bound", () => {
+    const noConfig = setup();
+    expect(() => migration.run(noConfig)).not.toThrow();
+
+    const noDb = setup();
+    writeConfig(noDb, {
+      llm: {
+        profiles: {
+          a: { provider: "openai-compatible", provider_connection: "go" },
+        },
+      },
+    });
+    migration.run(noDb);
+    expect(readLlm(noDb).profiles.a.provider).toBe("openai-compatible");
+  });
+
+  test("fails the run instead of checkpointing when the db is unreadable", () => {
+    const workspace = setup();
+    seedRows(workspace, []);
+    writeFileSync(
+      join(workspace, "data", "db", "assistant.db"),
+      "not a database",
+    );
+    writeConfig(workspace, {
+      llm: {
+        profiles: {
+          a: { provider: "openai-compatible", provider_connection: "go" },
+        },
+      },
+    });
+    expect(() => migration.run(workspace)).toThrow(/not readable/);
+  });
+
+  test("is idempotent", () => {
+    const workspace = setup();
+    seedRows(workspace, [
+      {
+        name: "go",
+        provider: "openai-compatible",
+        baseUrl: "https://opencode.ai/zen/go/v1",
+      },
+    ]);
+    writeConfig(workspace, {
+      llm: {
+        profiles: {
+          a: { provider: "openai-compatible", provider_connection: "go" },
+        },
+      },
+    });
+    migration.run(workspace);
+    const once = readFileSync(join(workspace, "config.json"), "utf-8");
+    migration.run(workspace);
+    expect(readFileSync(join(workspace, "config.json"), "utf-8")).toBe(once);
+    expect(readLlm(workspace).profiles.a.provider).toBe("opencode");
+  });
+});

package/src/workspace/migrations/registry.ts

@@ -155,6 +155,7 @@ import { repairRetiredCodexGpt54ModelIdsMigration } from "./154-repair-retired-c
 import { moveFrontModelConfigToVoiceMigration } from "./155-move-front-model-config-to-voice.js";
 import { extractWorkspaceMcpJsonMigration } from "./156-extract-workspace-mcp-json.js";
 import { addDesktopFilesLauncherMigration } from "./157-add-desktop-files-launcher.js";
+import { repointOpencodeHostProviderFragmentsMigration } from "./158-repoint-opencode-host-provider-fragments.js";
 import { renameCollidingJevProfileNameMigration } from "./159-rename-colliding-jev-profile-name.js";
 import { migrateToWorkspaceVolumeMigration } from "./migrate-to-workspace-volume.js";
 import type { WorkspaceMigration } from "./types.js";
@@ -326,5 +327,6 @@ export const WORKSPACE_MIGRATIONS: WorkspaceMigration[] = [
   moveFrontModelConfigToVoiceMigration,
   extractWorkspaceMcpJsonMigration,
   addDesktopFilesLauncherMigration,
+  repointOpencodeHostProviderFragmentsMigration,
   renameCollidingJevProfileNameMigration,
 ];