@vellumai/assistant 0.12.2 → 0.12.3-staging.2

package/src/oauth/seed-providers.ts

@@ -1,3 +1,5 @@
+import type { IntegrationCategory } from "@vellumai/service-contracts/integration-categories";
+
 import type { AvailableScopes } from "./connect-types.js";
 import { migrateProviderBaseUrl, seedProviders } from "./oauth-store.js";
 
@@ -78,6 +80,8 @@ export const PROVIDER_SEED_DATA: Record<
     managedServiceIsPaid?: boolean;
     displayLabel: string;
     description: string;
+    /** Where the integrations catalog files this provider. */
+    category: IntegrationCategory;
     dashboardUrl: string | null;
     clientIdPlaceholder: string | null;
     requiresClientSecret?: boolean;
@@ -104,6 +108,14 @@ export const PROVIDER_SEED_DATA: Record<
     identityResponsePaths?: string[];
     identityFormat?: string;
     identityOkField?: string;
+    /**
+     * Dot path of the boolean the provider's API puts in every response body
+     * to report success (Slack: `ok`). Ping and the authenticated-request
+     * doors read an explicit `false` under a 2xx as a failed call, since such
+     * a provider hides refusals behind a successful status. Distinct from
+     * `identityOkField`, which governs only the identity call.
+     */
+    responseOkField?: string;
     featureFlag?: string;
     logoUrl?: string;
   }
@@ -124,6 +136,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://www.googleapis.com",
     displayLabel: "Google",
     description: "Gmail, Calendar, Drive, Docs, Sheets, Slides, and Contacts",
+    category: "productivity",
     dashboardUrl: "https://console.cloud.google.com/apis/credentials",
     clientIdPlaceholder: "123456789.apps.googleusercontent.com",
     logoUrl: "https://cdn.simpleicons.org/google",
@@ -210,6 +223,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://slack.com/api",
     displayLabel: "Slack",
     description: "Workspace messaging",
+    category: "communication",
     dashboardUrl: "https://api.slack.com/apps",
     clientIdPlaceholder: null,
     logoUrl:
@@ -256,6 +270,7 @@ export const PROVIDER_SEED_DATA: Record<
     appType: "Slack App",
     identityUrl: "https://slack.com/api/auth.test",
     identityOkField: "ok",
+    responseOkField: "ok",
     identityResponsePaths: ["user", "team"],
     identityFormat: "@${user} (${team})",
   },
@@ -269,6 +284,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.notion.com",
     displayLabel: "Notion",
     description: "Pages and databases",
+    category: "productivity",
     dashboardUrl: "https://www.notion.so/my-integrations",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/notion",
@@ -303,6 +319,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.x.com",
     displayLabel: "Twitter",
     description: "Posts and direct messages",
+    category: "communication",
     dashboardUrl: "https://developer.twitter.com/en/portal/dashboard",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/x",
@@ -348,6 +365,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.github.com",
     displayLabel: "GitHub",
     description: "Repositories and issues",
+    category: "engineering",
     dashboardUrl: "https://github.com/settings/developers",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/github",
@@ -381,6 +399,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.linear.app",
     displayLabel: "Linear",
     description: "Issues and projects",
+    category: "engineering",
     dashboardUrl: "https://linear.app/settings/api",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/linear",
@@ -429,6 +448,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.spotify.com/v1",
     displayLabel: "Spotify",
     description: "Music and playlists",
+    category: "productivity",
     dashboardUrl: "https://developer.spotify.com/dashboard",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/spotify",
@@ -468,6 +488,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.todoist.com/rest/v2",
     displayLabel: "Todoist",
     description: "Tasks and projects",
+    category: "productivity",
     dashboardUrl: "https://developer.todoist.com/appconsole.html",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/todoist",
@@ -514,6 +535,7 @@ export const PROVIDER_SEED_DATA: Record<
     // documents `messages.read` as local RPC only, so requesting it would put
     // a permission on the consent screen that grants nothing here.
     description: "Your servers and profile",
+    category: "communication",
     dashboardUrl: "https://discord.com/developers/applications",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/discord",
@@ -544,6 +566,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.dropboxapi.com/2",
     displayLabel: "Dropbox",
     description: "Files and folders",
+    category: "productivity",
     dashboardUrl: "https://www.dropbox.com/developers/apps",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/dropbox",
@@ -584,6 +607,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://app.asana.com/api/1.0",
     displayLabel: "Asana",
     description: "Tasks and projects",
+    category: "productivity",
     dashboardUrl: "https://app.asana.com/0/my-apps",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/asana",
@@ -612,6 +636,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.airtable.com/v0",
     displayLabel: "Airtable",
     description: "Bases and records",
+    category: "productivity",
     dashboardUrl: "https://airtable.com/create/tokens",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/airtable",
@@ -644,6 +669,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.hubapi.com",
     displayLabel: "HubSpot",
     description: "CRM contacts and deals",
+    category: "sales",
     dashboardUrl: "https://developers.hubspot.com/",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/hubspot",
@@ -687,6 +713,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://login.salesforce.com",
     displayLabel: "Salesforce",
     description: "CRM contacts, leads, and opportunities",
+    category: "sales",
     dashboardUrl:
       "https://help.salesforce.com/s/articleView?id=sf.connected_app_create.htm&type=5",
     clientIdPlaceholder: null,
@@ -735,6 +762,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.monday.com",
     displayLabel: "monday.com",
     description: "Boards, items, docs, and updates",
+    category: "productivity",
     dashboardUrl: "https://auth.monday.com/apps",
     clientIdPlaceholder: null,
     // Simple Icons does not host a monday.com mark (both `monday` and
@@ -859,6 +887,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://www.eventbriteapi.com",
     displayLabel: "Eventbrite",
     description: "Events, attendees, and ticket orders",
+    category: "commerce",
     dashboardUrl: "https://www.eventbrite.com/platform/api-keys/",
     clientIdPlaceholder: null,
     // Simple Icons does not host an Eventbrite mark (cdn.simpleicons.org
@@ -895,6 +924,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.calendly.com",
     displayLabel: "Calendly",
     description: "Scheduling links and meetings",
+    category: "meetings",
     dashboardUrl: "https://calendly.com/integrations/api_webhooks",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/calendly",
@@ -994,6 +1024,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.figma.com/v1",
     displayLabel: "Figma",
     description: "Design files and comments",
+    category: "engineering",
     dashboardUrl: "https://www.figma.com/developers/apps",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/figma",
@@ -1169,6 +1200,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://graph.microsoft.com",
     displayLabel: "Outlook / Microsoft",
     description: "Email and calendar",
+    category: "productivity",
     dashboardUrl:
       "https://portal.azure.com/#blade/Microsoft_AAD_RegisteredApps/ApplicationsListBlade",
     clientIdPlaceholder: "Application (client) ID from Azure portal",
@@ -1221,9 +1253,13 @@ export const PROVIDER_SEED_DATA: Record<
     authorizeUrl: "urn:manual-token",
     tokenExchangeUrl: "urn:manual-token",
     pingUrl: "https://slack.com/api/auth.test",
+    // The bot answers through the same Web API envelope as the person's
+    // integration, and auth.test refuses a revoked token inside an HTTP 200.
+    responseOkField: "ok",
     baseUrl: "https://slack.com/api",
     displayLabel: "Slack Channel",
     description: "Channel bot token",
+    category: "communication",
     dashboardUrl: null,
     clientIdPlaceholder: null,
     requiresClientSecret: false,
@@ -1247,6 +1283,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://discord.com/api/v10",
     displayLabel: "Discord Server",
     description: "A bot in your server",
+    category: "communication",
     dashboardUrl: "https://discord.com/developers/applications",
     clientIdPlaceholder: null,
     requiresClientSecret: false,
@@ -1269,6 +1306,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.telegram.org",
     displayLabel: "Telegram",
     description: "Bot messaging",
+    category: "communication",
     dashboardUrl: null,
     clientIdPlaceholder: null,
     requiresClientSecret: false,
@@ -1283,6 +1321,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.sanity.io",
     displayLabel: "Sanity",
     description: "Content management platform",
+    category: "marketing",
     dashboardUrl: "https://www.sanity.io/manage",
     clientIdPlaceholder: null,
     requiresClientSecret: false,
@@ -1311,6 +1350,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://api.link.com",
     displayLabel: "Link by Stripe",
     description: "Wallet payment methods for agent purchases",
+    category: "commerce",
     dashboardUrl: "https://dashboard.stripe.com",
     // Link issues OAuth clients by request rather than through a self-serve
     // dashboard, so there is no placeholder shape to suggest.
@@ -1374,6 +1414,7 @@ export const PROVIDER_SEED_DATA: Record<
     baseUrl: "https://{tenant_host}",
     displayLabel: "Shopify",
     description: "Products, orders, customers, and inventory",
+    category: "commerce",
     dashboardUrl: "https://shopify.dev/dashboard",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/shopify",
@@ -1599,6 +1640,7 @@ export const PROVIDER_SEED_DATA: Record<
     // managed sandbox connection to the production host).
     displayLabel: "QuickBooks",
     description: "Invoices, customers, vendors, and accounting data",
+    category: "finance",
     dashboardUrl: "https://developer.intuit.com/app/developer/dashboard",
     clientIdPlaceholder: null,
     logoUrl: "https://cdn.simpleicons.org/quickbooks",

package/src/onboarding/onboarding-events-store.ts

@@ -11,6 +11,12 @@ import {
   type LiveVoiceSessionOutcome,
   type LiveVoiceStepName,
 } from "../telemetry/live-voice-funnel.js";
+import {
+  PHONE_CALL_FUNNEL_VERSION,
+  PHONE_CALL_STEPS,
+  type PhoneCallOutcome,
+  type PhoneCallStepName,
+} from "../telemetry/phone-call-funnel.js";
 import { recordTelemetryOutboxEvent } from "../telemetry/telemetry-events-outbox.js";
 import type { OnboardingTelemetryEvent } from "../telemetry/types.js";
 import { getLogger } from "../util/logger.js";
@@ -136,12 +142,13 @@ export function recordActivationEvent(params: {
  * database is unavailable.
  *
  * **Never throws.** These fire from `LiveVoiceSession.start()` and `.close()`,
- * which are the user's call itself: the outbox insert raises on a telemetry DB
- * that is missing, locked, or mid-migration, and an uncaught raise there would
- * fail the session rather than the measurement. A dropped row costs a gap in a
- * chart; a raised one costs the user their conversation.
+ * and from the call store's create and status writes, which are the user's
+ * call itself: the outbox insert raises on a telemetry DB that is missing,
+ * locked, or mid-migration, and an uncaught raise there would fail the session
+ * rather than the measurement. A dropped row costs a gap in a chart; a raised
+ * one costs the user their conversation.
  */
-function recordLiveVoiceEventSafely(
+function recordVoiceFunnelEventSafely(
   record: () => OnboardingEvent | null,
 ): OnboardingEvent | null {
   try {
@@ -155,28 +162,51 @@ function recordLiveVoiceEventSafely(
   }
 }
 
-export function recordLiveVoiceSessionEvent(params: {
-  stepName: LiveVoiceStepName;
+/**
+ * Build one voice funnel row. The live-voice and phone-call funnels differ
+ * only in their version stamp and step vocabulary, so they share the row
+ * shape: same substrate, same session-keyed pairing, same duration math.
+ */
+function recordVoiceFunnelEvent(params: {
+  funnelVersion: string;
+  stepName: string;
   stepIndex: number;
   sessionId: string;
-  screen?: string;
-  outcome?: LiveVoiceSessionOutcome;
+  screen: string;
+  outcome?: string;
 }): OnboardingEvent | null {
-  return recordLiveVoiceEventSafely(() =>
+  return recordVoiceFunnelEventSafely(() =>
     recordTelemetryOutboxEvent("onboarding", (id, createdAt) =>
       buildOnboardingTelemetryEvent(id, createdAt, {
-        screen: params.screen ?? params.stepName,
+        screen: params.screen,
         sessionId: params.sessionId,
         stepName: params.stepName,
         stepIndex: params.stepIndex,
         completedAt: new Date(createdAt).toISOString(),
-        funnelVersion: LIVE_VOICE_FUNNEL_VERSION,
+        funnelVersion: params.funnelVersion,
         ...(params.outcome ? { outcome: params.outcome } : {}),
       }),
     ),
   );
 }
 
+export function recordLiveVoiceSessionEvent(params: {
+  stepName: LiveVoiceStepName;
+  stepIndex: number;
+  sessionId: string;
+  screen?: string;
+  outcome?: LiveVoiceSessionOutcome;
+}): OnboardingEvent | null {
+  return recordVoiceFunnelEvent({
+    funnelVersion: LIVE_VOICE_FUNNEL_VERSION,
+    stepName: params.stepName,
+    stepIndex: params.stepIndex,
+    sessionId: params.sessionId,
+    screen: params.screen ?? params.stepName,
+    ...(params.outcome ? { outcome: params.outcome } : {}),
+  });
+}
+
 /**
  * Record the "a live-voice session was attempted" milestone, with where it
  * was attempted from.
@@ -207,3 +237,60 @@ export function recordLiveVoiceSessionEnded(params: {
     outcome: params.outcome,
   });
 }
+
+/**
+ * Record a phone-call milestone (started / ended) on the same substrate as the
+ * live-voice pair, keyed by the call session id so the two events pair up
+ * downstream. See `telemetry/phone-call-funnel.ts` for why duration and turn
+ * count are derived from that pairing rather than carried as fields.
+ *
+ * Returns null when usage data collection is disabled or the telemetry
+ * database is unavailable, and never throws: these fire from the call store's
+ * writes, on the call's own path.
+ */
+function recordPhoneCallEvent(params: {
+  stepName: PhoneCallStepName;
+  stepIndex: number;
+  callSessionId: string;
+  screen: string;
+  outcome?: PhoneCallOutcome;
+}): OnboardingEvent | null {
+  return recordVoiceFunnelEvent({
+    funnelVersion: PHONE_CALL_FUNNEL_VERSION,
+    stepName: params.stepName,
+    stepIndex: params.stepIndex,
+    sessionId: params.callSessionId,
+    screen: params.screen,
+    ...(params.outcome ? { outcome: params.outcome } : {}),
+  });
+}
+
+/**
+ * Record the "a phone call was attempted" milestone, with how it was placed.
+ */
+export function recordPhoneCallStarted(params: {
+  callSessionId: string;
+  screen: string;
+}): OnboardingEvent | null {
+  return recordPhoneCallEvent({
+    stepName: PHONE_CALL_STEPS.callStarted.stepName,
+    stepIndex: PHONE_CALL_STEPS.callStarted.stepIndex,
+    callSessionId: params.callSessionId,
+    screen: params.screen,
+  });
+}
+
+/** Record the "a phone call ended" milestone, with how it ended. */
+export function recordPhoneCallEnded(params: {
+  callSessionId: string;
+  screen: string;
+  outcome: PhoneCallOutcome;
+}): OnboardingEvent | null {
+  return recordPhoneCallEvent({
+    stepName: PHONE_CALL_STEPS.callEnded.stepName,
+    stepIndex: PHONE_CALL_STEPS.callEnded.stepIndex,
+    callSessionId: params.callSessionId,
+    screen: params.screen,
+    outcome: params.outcome,
+  });
+}

package/src/permissions/confirmation-guardian-request.test.ts

@@ -111,6 +111,22 @@ describe("createGuardianRequestForConfirmation", () => {
     expect(expiresAt).toBeLessThanOrEqual(after + APPROVAL_WINDOW_MS);
   });
 
+  test("describes the request by the status sentence, never a tool's own reason argument", async () => {
+    await createGuardianRequestForConfirmation(
+      { ...MSG, input: { reason: "Task complete" } },
+      "conv-1",
+    );
+    await createGuardianRequestForConfirmation(
+      { ...MSG, input: { activity: "Stopping the app" } },
+      "conv-1",
+    );
+
+    expect(createCalls.map((call) => call.activityText)).toEqual([
+      undefined,
+      "Stopping the app",
+    ]);
+  });
+
   test("expires the row and skips the bridge when the confirmation resolved mid-create", async () => {
     confirmationPending = false;
 

package/src/permissions/confirmation-guardian-request.ts

@@ -73,10 +73,9 @@ export async function createGuardianRequestForConfirmation(
     const sourceChannel = trustContext?.sourceChannel ?? "vellum";
     const inputRecord = msg.input as Record<string, unknown>;
     const activityRaw =
-      (typeof inputRecord.activity === "string"
+      typeof inputRecord.activity === "string"
         ? inputRecord.activity
-        : undefined) ??
-      (typeof inputRecord.reason === "string" ? inputRecord.reason : undefined);
+        : undefined;
     // Tool approvals are decisionable: without a bound principal nobody could
     // ever decide them (mirrors the gateway create's integrity guard).
     const guardianPrincipalId = trustContext?.guardianPrincipalId;

package/src/permissions/question-prompter.test.ts

@@ -455,3 +455,34 @@ describe("QuestionPrompter", () => {
     expect(sent).toHaveLength(0);
   });
 });
+
+test("desktop help presentation survives broadcast and pending recovery until Done", async () => {
+  const { prompter, sent } = makePrompter();
+  const pending = prompter.prompt({
+    conversationId: "conv-123",
+    questions: [
+      {
+        question: "Please complete the CAPTCHA.",
+        presentation: "virtual_desktop",
+        options: [
+          { id: "done", label: "Done" },
+          { id: "skip", label: "Skip" },
+        ],
+      },
+    ],
+  });
+  const request = sent.find(
+    (event) => event.type === "question_request",
+  ) as QuestionRequestEvent;
+  expect(request.questions[0]?.presentation).toBe("virtual_desktop");
+  expect(_piStore.get(request.requestId)?.questionDetails?.entries).toEqual(
+    request.questions,
+  );
+  resolveBatch(request.requestId, [
+    { questionId: "q1", kind: "option", optionId: "done" },
+  ]);
+  expect((await pending).entries).toEqual([
+    { questionId: "q1", decision: "option", optionId: "done" },
+  ]);
+  expect(_piStore.has(request.requestId)).toBe(false);
+});

package/src/permissions/question-prompter.ts

@@ -77,6 +77,7 @@ export interface QuestionPromptParamsEntry {
   description?: string;
   options: QuestionOption[];
   freeTextPlaceholder?: string;
+  presentation?: QuestionEntry["presentation"];
 }
 
 export interface QuestionPromptParams {
@@ -201,6 +202,7 @@ export class QuestionPrompter {
       description: q.description,
       options: q.options,
       freeTextPlaceholder: q.freeTextPlaceholder,
+      ...(q.presentation ? { presentation: q.presentation } : {}),
     }));
     const orderedIds = entries.map((e) => e.id);
     const optionsById: Record<string, string[]> = {};