@vellumai/assistant 0.12.2 → 0.12.3-staging.1

package/src/api/attachment-provenance.test.ts

@@ -0,0 +1,68 @@
+import { describe, expect, test } from "bun:test";
+
+import { AssistantOutboundAttachmentSchema } from "./events/assistant-outbound-attachment.js";
+import { ConversationMessageAttachmentSchema } from "./responses/conversation-message.js";
+
+const outboundFixture = {
+  id: "attachment-1",
+  filename: "screenshot.png",
+  mimeType: "image/png",
+  data: "c2NyZWVuc2hvdA==",
+  sourceType: "tool_block" as const,
+};
+
+const historyFixture = {
+  id: "attachment-1",
+  filename: "screenshot.png",
+  mimeType: "image/png",
+  sizeBytes: 10,
+  kind: "image",
+};
+
+describe("computer-use screenshot attachment provenance", () => {
+  test("new schemas accept the marker and its absence", () => {
+    expect(
+      AssistantOutboundAttachmentSchema.parse({
+        ...outboundFixture,
+        computerUseScreenshot: true,
+      }).computerUseScreenshot,
+    ).toBe(true);
+    expect(
+      AssistantOutboundAttachmentSchema.parse(outboundFixture)
+        .computerUseScreenshot,
+    ).toBeUndefined();
+
+    expect(
+      ConversationMessageAttachmentSchema.parse({
+        ...historyFixture,
+        computerUseScreenshot: true,
+      }).computerUseScreenshot,
+    ).toBe(true);
+    expect(
+      ConversationMessageAttachmentSchema.parse(historyFixture)
+        .computerUseScreenshot,
+    ).toBeUndefined();
+  });
+
+  test("legacy object parsers tolerate and strip the additive marker", () => {
+    const legacyOutbound = AssistantOutboundAttachmentSchema.omit({
+      computerUseScreenshot: true,
+    });
+    const legacyHistory = ConversationMessageAttachmentSchema.omit({
+      computerUseScreenshot: true,
+    });
+
+    expect(
+      legacyOutbound.parse({
+        ...outboundFixture,
+        computerUseScreenshot: true,
+      }),
+    ).toEqual(outboundFixture);
+    expect(
+      legacyHistory.parse({
+        ...historyFixture,
+        computerUseScreenshot: true,
+      }),
+    ).toEqual(historyFixture);
+  });
+});

package/src/api/computer-use-tool.test.ts

@@ -0,0 +1,55 @@
+import { describe, expect, test } from "bun:test";
+
+import {
+  isComputerUseToolCall,
+  resolveComputerUseToolName,
+} from "./computer-use-tool.js";
+
+describe("isComputerUseToolCall", () => {
+  test("recognizes direct and skill-wrapped computer-use calls", () => {
+    expect(isComputerUseToolCall("computer_use_click", {})).toBe(true);
+    expect(
+      isComputerUseToolCall("skill_execute", { tool: "computer_use_type" }),
+    ).toBe(true);
+  });
+
+  test("resolves the direct or wrapped computer-use tool name", () => {
+    expect(resolveComputerUseToolName("computer_use_click", {})).toBe(
+      "computer_use_click",
+    );
+    expect(
+      resolveComputerUseToolName("skill_execute", {
+        tool: "computer_use_scroll",
+      }),
+    ).toBe("computer_use_scroll");
+  });
+
+  test("rejects unrelated media tools and malformed skill input", () => {
+    expect(isComputerUseToolCall("browser_screenshot", {})).toBe(false);
+    expect(isComputerUseToolCall("file_read", {})).toBe(false);
+    expect(isComputerUseToolCall("image_generate", {})).toBe(false);
+    expect(isComputerUseToolCall("skill_execute", null)).toBe(false);
+    expect(isComputerUseToolCall("skill_execute", "computer_use_click")).toBe(
+      false,
+    );
+    expect(isComputerUseToolCall("skill_execute", { tool: 42 })).toBe(false);
+    expect(
+      isComputerUseToolCall("skill_execute", {
+        tool: "browser_screenshot",
+      }),
+    ).toBe(false);
+  });
+
+  test("does not classify raw-only recovered skill input", () => {
+    expect(
+      isComputerUseToolCall("skill_execute", {
+        _raw: '{"tool":"computer_use_click"}',
+      }),
+    ).toBe(false);
+    expect(
+      resolveComputerUseToolName("skill_execute", {
+        _raw: '{"tool":"computer_use_click"}',
+      }),
+    ).toBeUndefined();
+  });
+});

package/src/api/computer-use-tool.ts

@@ -0,0 +1,27 @@
+/**
+ * Resolve the host computer-use tool behind a direct or skill-wrapped call.
+ *
+ * Skills expose their selected tool in structured input. Calls recovered only
+ * from `_raw` retain their legacy behavior because this helper deliberately
+ * does not parse a second input representation.
+ */
+export function resolveComputerUseToolName(
+  name: string,
+  input: unknown,
+): string | undefined {
+  if (name.startsWith("computer_use_")) {
+    return name;
+  }
+  if (name !== "skill_execute" || input === null || typeof input !== "object") {
+    return undefined;
+  }
+  const tool = (input as Record<string, unknown>).tool;
+  return typeof tool === "string" && tool.startsWith("computer_use_")
+    ? tool
+    : undefined;
+}
+
+/** True when a tool call is backed by the host computer-use capability. */
+export function isComputerUseToolCall(name: string, input: unknown): boolean {
+  return resolveComputerUseToolName(name, input) !== undefined;
+}

package/src/api/events/assistant-outbound-attachment.ts

@@ -28,6 +28,9 @@ export const AssistantOutboundAttachmentSchema = z.object({
    *  true and the client should hydrate via the /content endpoint. */
   data: z.string(),
   sourceType: z.enum(["sandbox_file", "host_file", "tool_block"]).optional(),
+  /** True when this existing computer-use screenshot was linked to the reply
+   *  automatically. Missing or false identifies legacy or explicit placement. */
+  computerUseScreenshot: z.boolean().optional(),
   /** Original file size in bytes. Present when `data` was omitted to
    *  keep payloads small. */
   sizeBytes: z.number().optional(),

package/src/api/events/desktop-activity-changed.ts

@@ -0,0 +1,10 @@
+import { z } from "zod";
+
+/** Transient browser activity changed; refetch desktop status. */
+export const DesktopActivityChangedEventSchema = z.object({
+  type: z.literal("desktop_activity_changed"),
+});
+
+export type DesktopActivityChangedEvent = z.infer<
+  typeof DesktopActivityChangedEventSchema
+>;

package/src/api/events/question-request.ts

@@ -48,6 +48,7 @@ export const QuestionEntrySchema = z.object({
   description: z.string().optional(),
   options: z.array(QuestionOptionSchema),
   freeTextPlaceholder: z.string().optional(),
+  presentation: z.literal("virtual_desktop").optional(),
 });
 
 export type QuestionEntry = z.infer<typeof QuestionEntrySchema>;

package/src/api/index.ts

@@ -1,5 +1,10 @@
 import { z } from "zod";
 
+export {
+  isComputerUseToolCall,
+  resolveComputerUseToolName,
+} from "./computer-use-tool.js";
+
 import { AcpAuthRequiredEventSchema } from "./events/acp-auth-required.js";
 import { AcpSessionCompletedEventSchema } from "./events/acp-session-completed.js";
 import { AcpSessionErrorEventSchema } from "./events/acp-session-error.js";
@@ -34,6 +39,7 @@ import { ConversationErrorEventSchema } from "./events/conversation-error.js";
 import { ConversationInferenceProfileUpdatedEventSchema } from "./events/conversation-inference-profile-updated.js";
 import { ConversationNoticeEventSchema } from "./events/conversation-notice.js";
 import { ConversationTitleUpdatedEventSchema } from "./events/conversation-title-updated.js";
+import { DesktopActivityChangedEventSchema } from "./events/desktop-activity-changed.js";
 import { DiskPressureStatusChangedEventSchema } from "./events/disk-pressure-status-changed.js";
 import { DocumentCommentCreatedEventSchema } from "./events/document-comment-created.js";
 import { DocumentCommentDeletedEventSchema } from "./events/document-comment-deleted.js";
@@ -342,6 +348,10 @@ export {
   type ConversationTitleUpdatedEvent,
   ConversationTitleUpdatedEventSchema,
 } from "./events/conversation-title-updated.js";
+export {
+  type DesktopActivityChangedEvent,
+  DesktopActivityChangedEventSchema,
+} from "./events/desktop-activity-changed.js";
 export {
   type DiskPressureBlockedCapability,
   DiskPressureBlockedCapabilitySchema,
@@ -1000,6 +1010,7 @@ export const AssistantEventSchema = z.discriminatedUnion("type", [
   ConversationInferenceProfileUpdatedEventSchema,
   ConversationNoticeEventSchema,
   ConversationTitleUpdatedEventSchema,
+  DesktopActivityChangedEventSchema,
   DiskPressureStatusChangedEventSchema,
   DocumentCommentCreatedEventSchema,
   DocumentCommentDeletedEventSchema,

package/src/api/responses/conversation-message.ts

@@ -51,6 +51,9 @@ export const ConversationMessageAttachmentSchema = z.object({
   thumbnailData: z.string().optional(),
   /** True when the attachment bytes are backed by a file on disk. */
   fileBacked: z.boolean().optional(),
+  /** True when this computer-use screenshot was placed on the reply
+   *  automatically. Missing or false identifies legacy or explicit placement. */
+  computerUseScreenshot: z.boolean().optional(),
 });
 export type ConversationMessageAttachment = z.infer<
   typeof ConversationMessageAttachmentSchema

package/src/approvals/approval-primitive.ts

@@ -213,7 +213,10 @@ function consumeGrantSync(params: ConsumeGrantParams): ConsumeGrantResult {
       return { ok: true, grant: reqResult.grant };
     }
 
-    log.info(
+    // Debug, not info: `consumeGrantForInvocation` and the inline grant wait
+    // poll this function, so a miss is the expected steady state while a
+    // guardian decides. Hits and the wait's outcome are logged at info.
+    log.debug(
       {
         event: "approval_primitive_consume_miss",
         mode: "request_id",
@@ -255,7 +258,7 @@ function consumeGrantSync(params: ConsumeGrantParams): ConsumeGrantResult {
     return { ok: true, grant: sigResult.grant };
   }
 
-  log.info(
+  log.debug(
     {
       event: "approval_primitive_consume_miss",
       mode: "tool_signature",

package/src/approvals/scoped-approval-grants.ts

@@ -193,7 +193,10 @@ function consumeScopedApprovalGrantByRequestId(
       .get();
 
     if (!candidate) {
-      log.info(
+      // Debug, not info: the inline grant wait and the voice retry loop call
+      // this every poll, so a miss is the expected steady state while a
+      // guardian decides. The caller logs the outcome of the wait.
+      log.debug(
         {
           event: "scoped_grant_consume_miss",
           requestId,
@@ -364,7 +367,8 @@ function consumeScopedApprovalGrantByToolSignature(
       .get();
 
     if (!candidate) {
-      log.info(
+      // Debug for the same reason as the request-id miss above: polled.
+      log.debug(
         {
           event: "scoped_grant_consume_miss",
           toolName: params.toolName,

package/src/browser/virtual-desktop-target.ts

@@ -1,4 +1,3 @@
-import { getConfig } from "../config/loader.js";
 import { isVirtualDesktopEnabled } from "../desktop/virtual-desktop-feature.js";
 import { browserManager } from "../tools/browser/browser-manager.js";
 import { normalizeBrowserMode } from "../tools/browser/browser-mode.js";
@@ -30,5 +29,5 @@ export function shouldUseVirtualDesktopBrowser(
   ) {
     return false;
   }
-  return isVirtualDesktopEnabled(getConfig());
+  return isVirtualDesktopEnabled();
 }

package/src/cli/commands/__tests__/cli-test-harness.ts

@@ -6,7 +6,10 @@
  * `process.stdout.write`, `process.stderr.write`, `console.log`, and
  * `console.error` are captured for the duration of the run, so command output
  * lands in the result regardless of which sink the command writes to;
- * `process.exitCode` is reset afterwards.
+ * `process.exitCode` is reset afterwards. A write callback is honoured the
+ * way the real stream honours it, and `process.exit` records its code as the
+ * run's exit code instead of ending the test process, so a command that exits
+ * itself once its output has drained is observed rather than fatal.
  * The caller passes its own (possibly mock-backed) registration function, so
  * this helper imports nothing from `src/` beyond what any test file may
  * import itself (see the test-machinery isolation rules in assistant/CLAUDE.md).
@@ -34,18 +37,32 @@ export async function runCliCommand(
   const stderrChunks: string[] = [];
   const events: string[] = [];
 
-  process.stdout.write = ((chunk: unknown) => {
+  const originalExit = process.exit;
+  const invokeCallback = (rest: unknown[]): void => {
+    const callback = rest.find((arg) => typeof arg === "function");
+    if (callback) {
+      (callback as () => void)();
+    }
+  };
+  process.stdout.write = ((chunk: unknown, ...rest: unknown[]) => {
     const text = typeof chunk === "string" ? chunk : String(chunk);
     stdoutChunks.push(text);
     events.push(text);
+    invokeCallback(rest);
     return true;
   }) as typeof process.stdout.write;
-  process.stderr.write = ((chunk: unknown) => {
+  process.stderr.write = ((chunk: unknown, ...rest: unknown[]) => {
     const text = typeof chunk === "string" ? chunk : String(chunk);
     stderrChunks.push(text);
     events.push(text);
+    invokeCallback(rest);
     return true;
   }) as typeof process.stderr.write;
+  process.exit = ((code?: number) => {
+    if (code !== undefined) {
+      process.exitCode = code;
+    }
+  }) as typeof process.exit;
   console.log = (...logArgs: unknown[]) => {
     const text = logArgs.map(String).join(" ") + "\n";
     stdoutChunks.push(text);
@@ -75,6 +92,7 @@ export async function runCliCommand(
   } finally {
     process.stdout.write = originalStdoutWrite;
     process.stderr.write = originalStderrWrite;
+    process.exit = originalExit;
     console.log = originalConsoleLog;
     console.error = originalConsoleError;
   }

package/src/cli/commands/__tests__/plugins.test.ts

@@ -65,6 +65,7 @@ let installPluginCalls: InstallPluginOptions[] = [];
 let platformInstallCalls: Array<{ name: string; force?: boolean }> = [];
 let upgradePluginCalls: UpgradePluginOptions[] = [];
 let catalogMatches: PluginSearchMatch[] = [];
+let catalogError: Error | null = null;
 
 /**
  * Queued daemon IPC responses. The default (empty queue) is a transport
@@ -162,7 +163,12 @@ mock.module("../../lib/install-from-platform.js", () => ({
 }));
 
 mock.module("../../lib/plugin-catalog-cache.js", () => ({
-  getPluginCatalog: async () => ({ ref: "main", matches: catalogMatches }),
+  getPluginCatalog: async () => {
+    if (catalogError) {
+      throw catalogError;
+    }
+    return { ref: "main", matches: catalogMatches };
+  },
 }));
 
 mock.module("../../lib/inspect-plugin.js", () => ({
@@ -264,6 +270,7 @@ beforeEach(() => {
   platformInstallCalls = [];
   upgradePluginCalls = [];
   catalogMatches = [];
+  catalogError = null;
   ipcResults = [];
   inspectResult = null;
   installTarget = null;
@@ -466,6 +473,18 @@ describe("plugins install - declared-schedules consent", () => {
     });
     expect(r.exitCode).toBe(0);
   });
+
+  test("falls back to the platform installer when catalog discovery fails", async () => {
+    catalogError = new Error("catalog unavailable");
+
+    const r = await runCommand(["plugins", "install", "example"]);
+
+    expect(installPluginCalls).toHaveLength(0);
+    expect(platformInstallCalls).toEqual([
+      { name: "example", force: undefined },
+    ]);
+    expect(r.exitCode).toBe(0);
+  });
 });
 
 describe("plugins upgrade - declared-schedules consent (local fallback)", () => {

package/src/cli/commands/__tests__/schedules.test.ts

@@ -380,6 +380,7 @@ describe("schedules get", () => {
     mode: "execute",
     status: "active",
     routingIntent: "all_channels",
+    quiet: false,
     reuseConversation: false,
     wakeConversationId: null,
     isOneShot: false,
@@ -436,9 +437,22 @@ describe("schedules get", () => {
     expect(output).toContain("Every 30 minutes (UTC)");
     expect(output).toContain("run heartbeat");
     expect(output).toContain("all_channels");
+    expect(output).toMatch(/Quiet:\s+no/);
     expect(output).toContain("conv-abc");
   });
 
+  test("prints Quiet: yes when the schedule suppresses completion notifications", async () => {
+    mockIpcResult = {
+      ok: true,
+      result: { schedule: { ...scheduleFixture, quiet: true } },
+    };
+
+    const { exitCode } = await runCommand(["schedules", "get", "schedule-1"]);
+
+    expect(exitCode).toBe(0);
+    expect(logLines.join("\n")).toMatch(/Quiet:\s+yes/);
+  });
+
   test("emits JSON result when --json is set", async () => {
     mockIpcResult = { ok: true, result: { schedule: scheduleFixture } };
 

package/src/cli/commands/bash.help.ts

@@ -16,9 +16,10 @@ export const bashHelp: CliCommandHelp = {
   ],
   helpText: `
 Spawns the command with the same sanitized environment, working directory,
-and platform shell the bash tool uses for tool-call subprocesses. Vault
-bearers such as CES_SERVICE_TOKEN are stripped; CES_LOCAL_SOCKET and workspace
-paths are forwarded. The command does not go through the assistant HTTP or IPC
+and platform shell the bash tool uses for tool-call subprocesses. CES
+bootstrap and workspace paths are forwarded so children can reach CES over
+IPC. CES HTTP credentials are also forwarded. The command does not go through
+the assistant HTTP or IPC
 API, and does not require a running assistant process.
 
 Arguments:

package/src/cli/commands/browser.help.ts

@@ -17,6 +17,7 @@ import type {
   BrowserOperationMeta,
   OperationField,
 } from "../../browser/types.js";
+import { DESKTOP_HELP_GUIDANCE } from "../../util/browser-human-verification.js";
 import type {
   CliCommandHelp,
   CliOptionHelp,
@@ -158,7 +159,10 @@ or --use-active-tab. Download waiting is unavailable on this target.
 Users can interact directly with the expanded desktop. If they ask you to pause,
 stop and wait. Take a fresh snapshot before resuming. Closing the viewer does not
 end automation. Run assistant browser --virtual-desktop detach when finished or
-blocked, including before asking a question. Chrome stays running.
+blocked. Chrome stays running.
+For logins, use saved credentials first. Securely collect missing credentials
+with assistant credentials prompt, then fill the login form yourself.
+${DESKTOP_HELP_GUIDANCE}
 Each subcommand maps to a browser operation and communicates
 with the assistant process.
 

package/src/cli/commands/credentials.help.ts

@@ -74,9 +74,9 @@ path or connection details. Run this to diagnose credential lookup mismatches
 for example, when the CLI and the daemon are reading from different stores.
 
 Backend types:
-  encrypted-store   Direct file read from keys.enc (standalone CLI, no daemon)
-  ces-rpc           Delegates to the running CES process via stdio RPC (daemon)
-  ces-http          Delegates to CES sidecar over HTTP (containerized/Docker mode)
+  encrypted-store   Direct file read from keys.enc (standalone CLI, no assistant)
+  ces-rpc           Delegates to the running CES process via socket RPC
+  ces-http          Managed failover when the CES socket is unavailable
 
 Also shows the CREDENTIAL_SECURITY_DIR, GATEWAY_SECURITY_DIR, and
 VELLUM_WORKSPACE_DIR env vars so you can confirm which instance directory this

package/src/cli/commands/oauth/index.help.ts

@@ -258,6 +258,11 @@ Examples:
               description:
                 "Dot-notation path to a boolean field that must be truthy for the response to be valid",
             },
+            {
+              flags: "--response-ok-field <field>",
+              description:
+                "Dot-notation path to the boolean every response body carries to report success (Slack: ok); an explicit false under a 2xx fails the request",
+            },
             {
               flags: "--setup-notes <json>",
               description:
@@ -430,6 +435,11 @@ Examples:
               flags: "--identity-ok-field <field>",
               description: "Dot-notation path to a boolean ok field",
             },
+            {
+              flags: "--response-ok-field <field>",
+              description:
+                "Dot-notation path to the boolean every response body carries to report success",
+            },
             {
               flags: "--setup-notes <json>",
               description: "JSON array of setup instruction notes",

package/src/cli/commands/oauth/providers.ts

@@ -49,6 +49,7 @@ interface SerializedProvider {
   identityResponsePaths?: string[] | null;
   identityFormat?: string | null;
   identityOkField?: string | null;
+  responseOkField?: string | null;
   availableScopes?: unknown;
   setupNotes?: string[] | unknown;
   featureFlag?: string | null;
@@ -217,6 +218,9 @@ function formatProviderDetail(p: SerializedProvider): string {
   if (p.identityOkField) {
     lines.push(`  Identity ok field: ${p.identityOkField}`);
   }
+  if (p.responseOkField) {
+    lines.push(`  Response ok field: ${p.responseOkField}`);
+  }
   if (p.setupNotes) {
     if (Array.isArray(p.setupNotes)) {
       lines.push(
@@ -403,6 +407,7 @@ export function registerProviderCommands(oauth: Command): void {
         identityResponsePaths?: string;
         identityFormat?: string;
         identityOkField?: string;
+        responseOkField?: string;
         setupNotes?: string;
         availableScopes?: string;
       },
@@ -505,6 +510,9 @@ export function registerProviderCommands(oauth: Command): void {
         if (opts.identityOkField !== undefined) {
           body.identity_ok_field = opts.identityOkField;
         }
+        if (opts.responseOkField !== undefined) {
+          body.response_ok_field = opts.responseOkField;
+        }
         if (opts.setupNotes !== undefined) {
           body.setup_notes = JSON.parse(opts.setupNotes);
         }
@@ -578,6 +586,7 @@ export function registerProviderCommands(oauth: Command): void {
         identityResponsePaths?: string;
         identityFormat?: string;
         identityOkField?: string;
+        responseOkField?: string;
         setupNotes?: string;
         availableScopes?: string;
       },
@@ -686,6 +695,9 @@ export function registerProviderCommands(oauth: Command): void {
         if (opts.identityOkField !== undefined) {
           body.identity_ok_field = opts.identityOkField;
         }
+        if (opts.responseOkField !== undefined) {
+          body.response_ok_field = opts.responseOkField;
+        }
         if (opts.setupNotes !== undefined) {
           body.setup_notes = JSON.parse(opts.setupNotes);
         }