@vellumai/assistant 0.12.2-staging.7 → 0.12.2

package/src/plugin-api/index.ts

@@ -286,11 +286,6 @@ export {
 // writes files under the workspace (e.g. its own `plugins/<name>/data/`
 // directory) resolves them against this instead of hardcoding a base path.
 export { getWorkspaceDir } from "../util/platform.js";
-// `String.prototype.slice` that never cuts a UTF-16 surrogate pair in half.
-// Any text a plugin truncates by character budget and hands to a model must
-// go through this: an orphaned half is invalid UTF-16 that strict provider
-// parsers reject.
-export { safeStringSlice } from "../util/unicode.js";
 // Declarative help for the top-level `assistant` CLI commands that have adopted
 // the static-help split. Plugins (e.g. the memory capability indexer) read this
 // to embed CLI command capabilities without importing the CLI action graph.
@@ -364,8 +359,7 @@ export {
   stringifyMessageContent,
 } from "../persistence/message-content.js";
 // Conversation history — reads and writes on the host conversation store
-// (rows, message history, processing state, the recorded wire tool surface,
-// disk-view paths) plus the lexical
+// (rows, message history, processing state, disk-view paths) plus the lexical
 // message-search surface. Every operation takes explicit parameters; nothing
 // is resolved from config. Async because the facade loads the DB store graph
 // lazily on first call.
@@ -377,7 +371,6 @@ export {
   getConversation,
   getConversationDirPath,
   getConversationProcessingStartedAt,
-  getConversationToolSurface,
   getMessages,
   hasLexicalTokens,
   isConversationProcessing,
@@ -445,7 +438,6 @@ export type {
   RunConversationTurnResult,
 } from "./conversation-turn.js";
 export { runConversationTurn } from "./conversation-turn.js";
-export { PluginTurnNotAdmittedError } from "./plugin-channel-turn-trust.js";
 // Live voice — drive a single client's real-time voice session (STT → agent
 // turn → TTS, with server-VAD turn-taking, pauses, and barge-in) over a
 // transport the plugin owns. The plugin brings only a `send` callback (e.g.

package/src/plugins/defaults/memory/AGENTS.md

@@ -68,13 +68,6 @@ Everything else under the plugin root is **spine**:
   the writer plus the one matcher every reader uses. It lives at the root
   precisely so `substrate/`, `graph/`, and `graph-topology/` can all reach it
   without a tier importing spine. Do not add a second matcher anywhere),
-  `buffer-file` (the two writers of `memory/buffer.md`: the append every
-  `remember()`-shaped path uses and the consume the consolidation job runs
-  after a pass. Do not write the buffer from anywhere else, and never
-  rewrite it from a read that is not inside `consumeBufferEntries`'s
-  synchronous critical section), `memory-run-evidence` (readers of what a
-  background memory run durably produced from its persisted messages; every
-  job that gates a state transition on a verified write uses them),
   `segmenter`, `message-media`, `worker`, `worker-control`,
   `memory-recall-log-store`, `activation-session-store` (the onboarding
   activation rail — **not** a memory tier despite the name),
@@ -414,13 +407,8 @@ per distinct matched section, at most `memory.v3.finderSectionsPerPage` in
 surfacing order (needle, dense, reply, span) plus its entity and rare-term
 lines, and selecting a line selects that section; the selection log keeps
 one row per slug, so the pool row is where the per-section verdicts live. A
-turn whose selector never judged a pool persists it with `selector_ran = 0`:
-an empty pool when the injection gate hard-skipped it or nothing was pooled,
-and the pool as the selector was given it, stable-prefix cards chosen and
-finder lines not, when the selector's provider failed and the orchestrator
-kept that prefix unjudged. That turn writes no `memory_v3_selections` rows:
-the hot set's frecency and the learned-edge graph read that table as
-judgments, and an unjudged page is not one. A
+turn whose selector never judged a pool (the injection gate hard-skipped it,
+or nothing was pooled) persists an empty pool with `selector_ran = 0`, and a
 turn that logged no selections is still reachable by its stamped
 `message_id`, so the inspector shows negative verdicts too. The pool row and
 the turn's `memory_v3_selections` rows are

package/src/plugins/defaults/memory/__tests__/buffer-format.test.ts

@@ -10,13 +10,10 @@
 import { describe, expect, test } from "bun:test";
 
 import {
-  bufferEntryText,
   formatBufferTimestamp,
   formatRememberEntry,
   isBufferEntryStart,
-  joinBufferEntries,
   matchBufferEntryStart,
-  splitBufferContent,
   splitBufferEntries,
 } from "../buffer-format.js";
 
@@ -205,43 +202,3 @@ describe("splitBufferEntries", () => {
     expect(splitBufferEntries([])).toEqual([]);
   });
 });
-
-describe("splitBufferContent / joinBufferEntries", () => {
-  const content =
-    formatRememberEntry("Alice prefers dark mode", new Date(2026, 0, 1, 9, 0)) +
-    formatRememberEntry(
-      "Bob's plan:\n- [ ] step one\n\nend",
-      new Date(2026, 0, 1, 9, 1),
-    );
-
-  test("round-trips newline-terminated content byte for byte", () => {
-    expect(joinBufferEntries(splitBufferContent(content))).toBe(content);
-  });
-
-  test("an entry's text is the same whether or not it is last in the file", () => {
-    const [first] = splitBufferContent(content);
-    const [alone] = splitBufferContent(
-      formatRememberEntry(
-        "Alice prefers dark mode",
-        new Date(2026, 0, 1, 9, 0),
-      ),
-    );
-    expect(bufferEntryText(alone!)).toBe(bufferEntryText(first!));
-    expect(bufferEntryText(alone!)).toBe(
-      "- [Jan 1, 9:00 AM] Alice prefers dark mode",
-    );
-  });
-
-  test("empty content has no entries and joins back to empty", () => {
-    expect(splitBufferContent("")).toEqual([]);
-    expect(joinBufferEntries([])).toBe("");
-  });
-
-  test("content without a terminating newline keeps its last line intact", () => {
-    const entries = splitBufferContent("- [Jan 1, 9:00 AM] partial appe");
-    expect(entries).toHaveLength(1);
-    expect(bufferEntryText(entries[0]!)).toBe(
-      "- [Jan 1, 9:00 AM] partial appe",
-    );
-  });
-});

package/src/plugins/defaults/memory/__tests__/memory-retrospective-job.test.ts

@@ -117,17 +117,6 @@ let loadedConversations: Record<string, { processing: boolean }> = {};
 // the stale-flag override's age check. Absent ids read as null (stampless).
 let processingStartedAtById: Record<string, number | null> = {};
 
-// The source conversation's recorded wire tool surface (what its last live
-// turn sent to the provider). `null` = no live turn has recorded one yet.
-let mockSourceToolSurface: Array<Record<string, unknown>> | null = null;
-let toolSurfaceReads: string[] = [];
-mock.module("../../../../persistence/conversation-tool-surface.js", () => ({
-  getConversationToolSurface: (conversationId: string) => {
-    toolSurfaceReads.push(conversationId);
-    return mockSourceToolSurface;
-  },
-}));
-
 const watchdogEvents: Array<{
   checkName: string;
   value?: number | null;
@@ -520,8 +509,6 @@ describe("memoryRetrospectiveJob", () => {
     resolveUserSlugCalls = [];
     mockV3TierActive = true;
     mockSkillImprovementActive = false;
-    mockSourceToolSurface = null;
-    toolSurfaceReads = [];
   });
 
   test("first-run happy path: no state row, no prior retrospective, both pointer fields set on success", async () => {
@@ -1855,39 +1842,6 @@ describe("memoryRetrospectiveJob", () => {
     });
   });
 
-  test("replays the source's recorded wire tool surface verbatim on the fork wake", async () => {
-    mockSourceToolSurface = [
-      { name: "bash", description: "Run", input_schema: {} },
-      { name: "remember", description: "Save", input_schema: {} },
-      { name: "bell_jingle", description: "Ring", input_schema: {} },
-      { type: "web_search_20250305", name: "web_search", max_uses: 5 },
-    ];
-
-    await memoryRetrospectiveJob(makeJob(), stubConfig);
-
-    expect(toolSurfaceReads).toEqual(["src-conv-1"]);
-    expect(wakeCalls).toHaveLength(1);
-    // The exact recorded array rides to the wake; the fork sends it in place
-    // of the surface it would resolve for itself.
-    expect(wakeCalls[0]!.opts.wireToolDefinitions).toEqual(
-      mockSourceToolSurface,
-    );
-    // The execution-side pin still rides alongside it.
-    expect(wakeCalls[0]!.opts.toolGateMode).toBe("execution");
-    expect(wakeCalls[0]!.opts.toolContextPin).toBeDefined();
-  });
-
-  test("no recorded source surface → no wireToolDefinitions; the pin alone shapes the wire", async () => {
-    mockSourceToolSurface = null;
-
-    await memoryRetrospectiveJob(makeJob(), stubConfig);
-
-    expect(toolSurfaceReads).toEqual(["src-conv-1"]);
-    expect(wakeCalls).toHaveLength(1);
-    expect("wireToolDefinitions" in wakeCalls[0]!.opts).toBe(false);
-    expect(wakeCalls[0]!.opts.toolContextPin).toBeDefined();
-  });
-
   test("execution mode is unconditional → toolContextPin rides even without a resolved profile", async () => {
     await memoryRetrospectiveJob(
       makeJob(),

package/src/plugins/defaults/memory/buffer-format.ts

@@ -154,46 +154,6 @@ export function splitBufferEntries(
   return groups;
 }
 
-/**
- * Split a whole buffer FILE into entries. The file is newline-terminated
- * (every append ends in `\n`), so the terminator ends the last line rather
- * than opening an empty one: an entry's lines are the same whether it is
- * currently last in the file or has since been followed by more entries.
- * That stability is what lets a consumer match an entry it snapshotted
- * earlier against the live file by exact text.
- */
-export function splitBufferContent(content: string): BufferEntryLines[] {
-  if (content.length === 0) {
-    return [];
-  }
-  const lines = content.split("\n");
-  if (lines[lines.length - 1] === "") {
-    lines.pop();
-  }
-  return splitBufferEntries(lines);
-}
-
-/**
- * One entry's verbatim text: its lines joined, without a terminating
- * newline. The identity a consumer matches on.
- */
-export function bufferEntryText(entry: BufferEntryLines): string {
-  return entry.lines.join("\n");
-}
-
-/**
- * Inverse of {@link splitBufferContent}: entries back to newline-terminated
- * file content, or the empty string when there are none.
- */
-export function joinBufferEntries(
-  entries: readonly BufferEntryLines[],
-): string {
-  if (entries.length === 0) {
-    return "";
-  }
-  return `${entries.map(bufferEntryText).join("\n")}\n`;
-}
-
 /** One entry's verbatim lines, as returned by {@link splitBufferEntries}. */
 export interface BufferEntryLines {
   /** `null` for the headless group before the first entry opening. */

package/src/plugins/defaults/memory/context-search/agent-runner.ts

@@ -4,9 +4,10 @@ import type {
   ProviderResponse,
   ToolUseContent,
 } from "@vellumai/plugin-api";
-import { getConfiguredProvider, safeStringSlice } from "@vellumai/plugin-api";
+import { getConfiguredProvider } from "@vellumai/plugin-api";
 
 import { redactSecrets } from "../../../../security/secret-scanner.js";
+import { safeStringSlice } from "../host-utils.js";
 import {
   buildRecallAgentPromptBundle,
   FINISH_RECALL_TOOL_DEFINITION,

package/src/plugins/defaults/memory/context-search/format.ts

@@ -1,5 +1,4 @@
-import { safeStringSlice } from "@vellumai/plugin-api";
-
+import { safeStringSlice } from "../host-utils.js";
 import type {
   DeterministicRecallSearchResult,
   DeterministicRecallSourceNote,

package/src/plugins/defaults/memory/context-search/sources/memory-v2.ts

@@ -26,9 +26,8 @@
 import { readdir, readFile, realpath, stat } from "node:fs/promises";
 import { extname, join } from "node:path";
 
-import { safeStringSlice } from "@vellumai/plugin-api";
-
 import { embedWithRetry } from "../../../../../persistence/embeddings/embed.js";
+import { safeStringSlice } from "../../host-utils.js";
 import { getLogger } from "../../logging.js";
 import { isPathInsideRoot } from "../../path-containment.js";
 import { getEdgeIndex } from "../../substrate/edge-index.js";

package/src/plugins/defaults/memory/context-search/sources/workspace.ts

@@ -1,8 +1,7 @@
 import { readdir, readFile, realpath, stat } from "node:fs/promises";
 import { extname, isAbsolute, join, relative, sep } from "node:path";
 
-import { safeStringSlice } from "@vellumai/plugin-api";
-
+import { safeStringSlice } from "../../host-utils.js";
 import { isPathInsideRoot } from "../../path-containment.js";
 import type {
   RecallEvidence,

package/src/plugins/defaults/memory/graph/capability-seed.ts

@@ -5,7 +5,7 @@
 // semantic retrieval.
 // ---------------------------------------------------------------------------
 
-import { CLI_COMMAND_HELP, safeStringSlice } from "@vellumai/plugin-api";
+import { CLI_COMMAND_HELP } from "@vellumai/plugin-api";
 import { and, eq, like, sql } from "drizzle-orm";
 
 import { isAssistantFeatureFlagEnabled } from "../../../../config/assistant-feature-flags.js";
@@ -26,6 +26,7 @@ import {
   getCachedCatalogSync,
   getCatalog,
 } from "../../../../skills/catalog-cache.js";
+import { safeStringSlice } from "../host-utils.js";
 import { getLogger } from "../logging.js";
 import { memoryDbOrNull } from "../memory-db.js";
 import type { SkillCapabilityInput } from "../substrate/skill-content.js";

package/src/plugins/defaults/memory/graph/tool-handlers.ts

@@ -6,6 +6,7 @@
 // into concept pages.
 // ---------------------------------------------------------------------------
 
+import { appendFileSync, existsSync, mkdirSync } from "node:fs";
 import { join } from "node:path";
 
 import {
@@ -14,7 +15,6 @@ import {
 } from "../../../../config/memory-v3-gate.js";
 import type { AssistantConfig } from "../../../../config/types.js";
 import { enqueueMemoryJob } from "../../../../persistence/jobs-store.js";
-import { appendBufferAndArchive } from "../buffer-file.js";
 import { formatRememberEntry } from "../buffer-format.js";
 import { getWorkspaceDir } from "../paths.js";
 import type { GraphStats } from "./store.js";
@@ -99,6 +99,47 @@ export function handleRemember(
   return { success: true, message };
 }
 
+/**
+ * Append `entry` to `<rootDir>/buffer.md` and `<rootDir>/archive/<today>.md`,
+ * creating the archive directory and seeding the archive header if missing.
+ *
+ * Returns the absolute paths of both files so callers can fan out follow-up
+ * work.
+ *
+ * Exported so background jobs (`sweep`, future LLM-driven extractors) can
+ * append to `memory/buffer.md` + `memory/archive/<today>.md` with exactly the
+ * same format `remember()` produces, keeping the two write paths
+ * byte-compatible for downstream consumers (consolidation, search).
+ */
+export function appendBufferAndArchive(args: {
+  rootDir: string;
+  entry: string;
+  now: Date;
+}): { bufferPath: string; archivePath: string } {
+  const { rootDir, entry, now } = args;
+  const archiveDir = join(rootDir, "archive");
+  mkdirSync(archiveDir, { recursive: true });
+
+  const bufferPath = join(rootDir, "buffer.md");
+  appendFileSync(bufferPath, entry, "utf-8");
+
+  const yyyy = now.getFullYear();
+  const mm = String(now.getMonth() + 1).padStart(2, "0");
+  const dd = String(now.getDate()).padStart(2, "0");
+  const archivePath = join(archiveDir, `${yyyy}-${mm}-${dd}.md`);
+  if (!existsSync(archivePath)) {
+    const month = now.toLocaleString("en-US", { month: "short" });
+    appendFileSync(
+      archivePath,
+      `# ${month} ${now.getDate()}, ${yyyy}\n\n`,
+      "utf-8",
+    );
+  }
+  appendFileSync(archivePath, entry, "utf-8");
+
+  return { bufferPath, archivePath };
+}
+
 // ---------------------------------------------------------------------------
 // Shared helpers for delete / update / list
 // ---------------------------------------------------------------------------

package/src/plugins/defaults/memory/host-utils.ts

@@ -25,6 +25,7 @@ import type { SqliteRetryOptions } from "../../../util/sqlite-retry.js";
 import * as hostSqliteRetry from "../../../util/sqlite-retry.js";
 import * as hostStripCommentLines from "../../../util/strip-comment-lines.js";
 import * as hostTruncate from "../../../util/truncate.js";
+import * as hostUnicode from "../../../util/unicode.js";
 import * as hostWorkerCompute from "../../../util/worker-compute.js";
 import * as hostWorkerMemory from "../../../util/worker-memory.js";
 
@@ -76,6 +77,15 @@ export function truncate(str: string, maxLen: number, suffix?: string): string {
     : hostTruncate.truncate(str, maxLen, suffix);
 }
 
+/** `String.prototype.slice` that never cuts a UTF-16 surrogate pair in half. */
+export function safeStringSlice(
+  str: string,
+  start?: number,
+  end?: number,
+): string {
+  return hostUnicode.safeStringSlice(str, start, end);
+}
+
 export function workerMemoryEnv(): Record<string, string | undefined> {
   return hostWorkerMemory.workerMemoryEnv();
 }

package/src/plugins/defaults/memory/injectors.ts

@@ -374,10 +374,9 @@ const memoryV2StaticInjector: Injector = {
     if (mode !== "full") {
       return null;
     }
-    // The consolidation run already carries its pass's buffer entries in
-    // the prompt itself, and the job removes them from memory/buffer.md
-    // after the run; injecting the buffer section here would duplicate the
-    // pass and hand the agent entries that are not its to file.
+    // The consolidation agent reads and rewrites memory/buffer.md through
+    // file tools; injecting the buffer section here would duplicate the
+    // entire backlog into its context (and go stale as it edits the file).
     const content = readGatedMemoryV2Static(ctx.trust, {
       excludeBuffer: ctx.callSite === "memoryV2Consolidation",
     });