@vellumai/assistant 0.12.1 → 0.12.2-staging.2

package/src/plugins/defaults/memory/__tests__/memory-retrospective-cursor-backfill.test.ts

@@ -0,0 +1,118 @@
+import { beforeEach, describe, expect, test } from "bun:test";
+
+import { setConfig } from "../../../../__tests__/helpers/set-config.js";
+
+// Disable memory so persistence writes don't index into the real memory
+// pipeline (both flags default true under the real loader).
+setConfig("memory", { enabled: false, v2: { enabled: false } });
+
+import { createConversation } from "../../../../persistence/conversation-crud.js";
+import {
+  getDb,
+  getMemorySqlite,
+} from "../../../../persistence/db-connection.js";
+import { initializeDb } from "../../../../persistence/db-init.js";
+import { messages } from "../../../../persistence/schema/index.js";
+import { backfillRetrospectiveCursorTimestamps } from "../memory-retrospective-cursor-backfill.js";
+import {
+  ensureRetrospectiveCursorColumn,
+  getRetrospectiveState,
+} from "../memory-retrospective-state.js";
+
+await initializeDb();
+
+function resetTables(): void {
+  const db = getDb();
+  db.run(`DELETE FROM messages`);
+  db.run(`DELETE FROM conversations`);
+  getMemorySqlite()!.exec(`DELETE FROM memory_retrospective_state`);
+}
+
+/** A state row as written before the timestamp column existed. */
+function insertLegacyState(conversationId: string, messageId: string): void {
+  ensureRetrospectiveCursorColumn("test");
+  getMemorySqlite()!
+    .query(
+      `INSERT INTO memory_retrospective_state
+         (conversation_id, last_processed_message_id, last_run_at, remembered_log, last_processed_created_at)
+       VALUES (?, ?, 1, NULL, NULL)`,
+    )
+    .run(conversationId, messageId);
+}
+
+function insertMessage(
+  conversationId: string,
+  id: string,
+  createdAt: number,
+): void {
+  getDb()
+    .insert(messages)
+    .values({
+      id,
+      conversationId,
+      role: "user",
+      content: "[]",
+      createdAt,
+      metadata: null,
+    })
+    .run();
+}
+
+describe("backfillRetrospectiveCursorTimestamps", () => {
+  beforeEach(() => {
+    resetTables();
+  });
+
+  test("fills the timestamp from the cursor's message, leaves vanished cursors NULL, and is idempotent", async () => {
+    createConversation({ id: "conv-a" });
+    createConversation({ id: "conv-b" });
+    createConversation({ id: "conv-c" });
+    insertMessage("conv-a", "a-m1", 1_000);
+    insertLegacyState("conv-a", "a-m1");
+    // Cursor row already deleted: nothing left to recover.
+    insertLegacyState("conv-b", "gone");
+    // The failure-only sentinel is never a cursor, so it is never scanned.
+    insertLegacyState("conv-c", "");
+
+    const first = await backfillRetrospectiveCursorTimestamps();
+
+    expect(first).toEqual({ scanned: 2, backfilled: 1, unrecoverable: 1 });
+    expect(getRetrospectiveState("conv-a")?.lastProcessedCreatedAt).toBe(1_000);
+    expect(getRetrospectiveState("conv-b")?.lastProcessedCreatedAt).toBeNull();
+    expect(getRetrospectiveState("conv-c")?.lastProcessedCreatedAt).toBeNull();
+
+    const second = await backfillRetrospectiveCursorTimestamps();
+
+    expect(second).toEqual({ scanned: 1, backfilled: 0, unrecoverable: 1 });
+  });
+
+  test("pages through the backlog by conversation id, advancing past unrecoverable rows", async () => {
+    for (const id of ["conv-1", "conv-2", "conv-3", "conv-4", "conv-5"]) {
+      createConversation({ id });
+    }
+    insertMessage("conv-1", "m-1", 1_000);
+    insertLegacyState("conv-1", "m-1");
+    insertLegacyState("conv-2", "gone-2");
+    insertMessage("conv-3", "m-3", 3_000);
+    insertLegacyState("conv-3", "m-3");
+    insertLegacyState("conv-4", "gone-4");
+    insertMessage("conv-5", "m-5", 5_000);
+    insertLegacyState("conv-5", "m-5");
+
+    const result = await backfillRetrospectiveCursorTimestamps({ pageSize: 2 });
+
+    expect(result).toEqual({ scanned: 5, backfilled: 3, unrecoverable: 2 });
+    expect(getRetrospectiveState("conv-1")?.lastProcessedCreatedAt).toBe(1_000);
+    expect(getRetrospectiveState("conv-3")?.lastProcessedCreatedAt).toBe(3_000);
+    expect(getRetrospectiveState("conv-5")?.lastProcessedCreatedAt).toBe(5_000);
+    expect(getRetrospectiveState("conv-4")?.lastProcessedCreatedAt).toBeNull();
+  });
+
+  test("a table with nothing to fill is a clean no-op", async () => {
+    expect(await backfillRetrospectiveCursorTimestamps()).toEqual({
+      scanned: 0,
+      backfilled: 0,
+      unrecoverable: 0,
+    });
+  });
+});

package/src/plugins/defaults/memory/__tests__/memory-retrospective-cursor-preserve.test.ts

@@ -0,0 +1,83 @@
+import { beforeEach, describe, expect, test } from "bun:test";
+
+import { setConfig } from "../../../../__tests__/helpers/set-config.js";
+
+// Disable memory so persistence writes don't index into the real memory
+// pipeline (both flags default true under the real loader).
+setConfig("memory", { enabled: false, v2: { enabled: false } });
+
+import { getMemorySqlite } from "../../../../persistence/db-connection.js";
+import { initializeDb } from "../../../../persistence/db-init.js";
+import { preserveRetrospectiveCursorTimestamps } from "../memory-retrospective-cursor-preserve.js";
+import {
+  ensureRetrospectiveCursorColumn,
+  getRetrospectiveState,
+  upsertRetrospectiveState,
+} from "../memory-retrospective-state.js";
+
+await initializeDb();
+
+/** A state row as written before the timestamp column existed. */
+function insertLegacyState(conversationId: string, messageId: string): void {
+  ensureRetrospectiveCursorColumn("test");
+  getMemorySqlite()!
+    .query(
+      `INSERT INTO memory_retrospective_state
+         (conversation_id, last_processed_message_id, last_run_at, remembered_log, last_processed_created_at)
+       VALUES (?, ?, 1, NULL, NULL)`,
+    )
+    .run(conversationId, messageId);
+}
+
+describe("preserveRetrospectiveCursorTimestamps", () => {
+  beforeEach(() => {
+    getMemorySqlite()!.exec(`DELETE FROM memory_retrospective_state`);
+  });
+
+  test("records the timestamp of a legacy cursor whose row is about to be deleted", async () => {
+    insertLegacyState("conv-a", "reply-1");
+
+    await preserveRetrospectiveCursorTimestamps("conv-a", [
+      { id: "tool-1", createdAt: 1_500 },
+      { id: "reply-1", createdAt: 2_000 },
+    ]);
+
+    expect(getRetrospectiveState("conv-a")?.lastProcessedCreatedAt).toBe(2_000);
+  });
+
+  test("leaves a cursor that already has a timestamp, points elsewhere, or does not exist untouched", async () => {
+    await upsertRetrospectiveState({
+      conversationId: "conv-stamped",
+      lastProcessedMessageId: "reply-1",
+      lastProcessedCreatedAt: 1_000,
+      lastRunAt: 1,
+    });
+    insertLegacyState("conv-elsewhere", "older-reply");
+
+    await preserveRetrospectiveCursorTimestamps("conv-stamped", [
+      { id: "reply-1", createdAt: 9_999 },
+    ]);
+    await preserveRetrospectiveCursorTimestamps("conv-elsewhere", [
+      { id: "reply-1", createdAt: 9_999 },
+    ]);
+    await preserveRetrospectiveCursorTimestamps("conv-missing", [
+      { id: "reply-1", createdAt: 9_999 },
+    ]);
+
+    expect(getRetrospectiveState("conv-stamped")?.lastProcessedCreatedAt).toBe(
+      1_000,
+    );
+    expect(
+      getRetrospectiveState("conv-elsewhere")?.lastProcessedCreatedAt,
+    ).toBeNull();
+    expect(getRetrospectiveState("conv-missing")).toBeNull();
+  });
+
+  test("an empty row list is a no-op", async () => {
+    insertLegacyState("conv-a", "reply-1");
+
+    await preserveRetrospectiveCursorTimestamps("conv-a", []);
+
+    expect(getRetrospectiveState("conv-a")?.lastProcessedCreatedAt).toBeNull();
+  });
+});

package/src/plugins/defaults/memory/__tests__/memory-retrospective-enqueue.test.ts

@@ -1,5 +1,7 @@
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
+import type { MessagesAfterRef } from "../../../../persistence/message-cursor.js";
+
 // ---------------------------------------------------------------------------
 // Mock state — reset between tests.
 // ---------------------------------------------------------------------------
@@ -17,6 +19,7 @@ let cfgThrows = false;
 let mockStateRow: {
   conversationId: string;
   lastProcessedMessageId: string;
+  lastProcessedCreatedAt: number | null;
   lastRunAt: number;
   rememberedLog: string[];
 } | null = null;
@@ -24,7 +27,7 @@ let tailQualifies = true;
 let gateProbeThrows = false;
 let gateProbeCalls: Array<{
   conversationId: string;
-  afterMessageId: string | null;
+  after: MessagesAfterRef;
 }> = [];
 
 mock.module("../../../../persistence/conversation-crud.js", () => ({
@@ -68,9 +71,9 @@ mock.module("../memory-retrospective-state.js", () => ({
 mock.module("../memory-retrospective-accounting.js", () => ({
   hasQualifyingUserMessageAfter: (
     conversationId: string,
-    afterMessageId: string | null,
+    after: MessagesAfterRef,
   ) => {
-    gateProbeCalls.push({ conversationId, afterMessageId });
+    gateProbeCalls.push({ conversationId, after });
     if (gateProbeThrows) {
       throw new Error("messages table unavailable");
     }
@@ -170,10 +173,11 @@ describe("enqueueMemoryRetrospectiveIfEnabled", () => {
     expect(gateProbeCalls).toHaveLength(0);
   });
 
-  test("gate probes the tail from the state row's cursor", () => {
+  test("gate probes the tail from the state row's cursor, timestamp included", () => {
     mockStateRow = {
       conversationId: "c1",
       lastProcessedMessageId: "m9",
+      lastProcessedCreatedAt: 9_000,
       lastRunAt: 1,
       rememberedLog: [],
     };
@@ -183,7 +187,7 @@ describe("enqueueMemoryRetrospectiveIfEnabled", () => {
     });
 
     expect(gateProbeCalls).toEqual([
-      { conversationId: "c1", afterMessageId: "m9" },
+      { conversationId: "c1", after: { id: "m9", createdAt: 9_000 } },
     ]);
   });
 

package/src/plugins/defaults/memory/__tests__/memory-retrospective-job.test.ts

@@ -20,6 +20,7 @@ let mockState: StateRow = null;
 let stateUpserts: Array<{
   conversationId: string;
   lastProcessedMessageId: string;
+  lastProcessedCreatedAt?: number | null;
   lastRunAt: number;
   rememberedLog?: string[];
 }> = [];
@@ -149,6 +150,7 @@ mock.module("../memory-retrospective-state.js", () => ({
   upsertRetrospectiveState: (args: {
     conversationId: string;
     lastProcessedMessageId: string;
+    lastProcessedCreatedAt?: number | null;
     lastRunAt: number;
     rememberedLog?: string[];
   }) => {
@@ -332,15 +334,16 @@ mock.module("../../../../persistence/jobs-store.js", () => ({
   },
 }));
 
-// The v3-tier gate. Drives both `buildForkInstruction`'s skill-authoring
-// section (proc-to-skills) and the wake's origin pin behavior. Default inactive
-// (remember-only), matching a stock install; tests flip it on to assert the
-// authoring section.
-let mockV3TierActive = false;
+// Retrospective skill improvement is distinct from the v3 tier. Keep v3 live
+// while flipping the authoring gate so these tests prove the job reads the
+// dedicated predicate rather than using the broader tier predicate.
+let mockV3TierActive = true;
+let mockSkillImprovementActive = false;
 mock.module("../../../../config/memory-v3-gate.js", () => ({
   isMemoryEnabled: (config?: { memory?: { enabled?: boolean } }) =>
     config?.memory?.enabled !== false,
   isV3TierActive: () => mockV3TierActive,
+  isSkillImprovementActive: () => mockSkillImprovementActive,
   isMemoryV3Live: () => mockV3TierActive,
   usesConceptPageMemory: (memory?: {
     enabled?: boolean;
@@ -504,7 +507,8 @@ describe("memoryRetrospectiveJob", () => {
     processingStartedAtById = {};
     mockResolvedUserSlug = "alice";
     resolveUserSlugCalls = [];
-    mockV3TierActive = false;
+    mockV3TierActive = true;
+    mockSkillImprovementActive = false;
   });
 
   test("first-run happy path: no state row, no prior retrospective, both pointer fields set on success", async () => {
@@ -518,6 +522,11 @@ describe("memoryRetrospectiveJob", () => {
     }
     expect(stateUpserts).toHaveLength(1);
     expect(stateUpserts[0]!.lastProcessedMessageId).toBe("m3");
+    // The cutoff's `createdAt` rides along so the cursor keeps bounding reads
+    // after a regenerate deletes m3.
+    expect(stateUpserts[0]!.lastProcessedCreatedAt).toBe(
+      Date.parse("2026-05-11T10:10:00Z"),
+    );
     expect(lastRunAtBumps).toHaveLength(0);
     expect(wakeCalls).toHaveLength(1);
     // Forks off the source so future runs can find it via
@@ -1308,7 +1317,7 @@ describe("memoryRetrospectiveJob", () => {
   });
 
   test("wake allows memory saves + skill authoring and suppresses the internal wake surface", async () => {
-    mockV3TierActive = true;
+    mockSkillImprovementActive = true;
     await memoryRetrospectiveJob(makeJob(), stubConfig);
 
     expect(forkCalls).toHaveLength(1);
@@ -1331,8 +1340,9 @@ describe("memoryRetrospectiveJob", () => {
     expect(opts.hintRole).toBe("user");
   });
 
-  test("wake is remember-only when proc-to-skills is inactive", async () => {
-    mockV3TierActive = false;
+  test("wake is remember-only when skill improvement is disabled on a live v3 tier", async () => {
+    mockV3TierActive = true;
+    mockSkillImprovementActive = false;
     await memoryRetrospectiveJob(makeJob(), stubConfig);
 
     expect(wakeCalls).toHaveLength(1);
@@ -2538,7 +2548,7 @@ describe("memoryRetrospectiveJob", () => {
   });
 
   test("proc-to-skills active: instruction carries the pre-check + dedup + companion-file directives", async () => {
-    mockV3TierActive = true;
+    mockSkillImprovementActive = true;
 
     await memoryRetrospectiveJob(makeJob(), stubConfig);
 

package/src/plugins/defaults/memory/__tests__/memory-retrospective-prompt.test.ts

@@ -115,6 +115,11 @@ For everything else in your review window, use the \`remember\` tool on facts, p
     expect(out).toContain(
       "\n---\n\nIf your review window contains a PROCEDURE you actually carried out",
     );
+    // An UPDATE is announced by a notice whose only account of the change is
+    // what the pass passes here, so the instruction has to ask for it.
+    expect(out).toContain(
+      "and pass `change_summary` (the update is rejected without it): one or two short sentences (under 200 characters)",
+    );
     expect(
       out.endsWith(
         "skills are for executed, reusable procedures, not for facts.\n",

package/src/plugins/defaults/memory/__tests__/memory-retrospective-state.test.ts

@@ -6,16 +6,22 @@ import { setConfig } from "../../../../__tests__/helpers/set-config.js";
 // pipeline (both flags default true under the real loader).
 setConfig("memory", { enabled: false, v2: { enabled: false } });
 
+import { createConversation } from "../../../../persistence/conversation-crud.js";
 import {
   getDb,
   getMemorySqlite,
+  resetDb,
 } from "../../../../persistence/db-connection.js";
 import { initializeDb } from "../../../../persistence/db-init.js";
+import { messages } from "../../../../persistence/schema/index.js";
 import {
+  _resetRetrospectiveCursorColumnForTests,
   appendToRememberedLog,
   bumpRetrospectiveLastRunAt,
+  ensureRetrospectiveCursorColumn,
   forkRetrospectiveState,
   getRetrospectiveState,
+  listRetrospectiveStates,
   REMEMBERED_LOG_MAX_BYTES,
   REMEMBERED_LOG_MAX_ENTRIES,
   upsertRetrospectiveState,
@@ -176,6 +182,219 @@ describe("memory-retrospective-state remembered log persistence", () => {
   });
 });
 
+describe("memory-retrospective-state cursor timestamp", () => {
+  beforeEach(() => {
+    resetTables();
+  });
+
+  test("upsert persists lastProcessedCreatedAt and both reads return it", async () => {
+    await upsertRetrospectiveState({
+      conversationId: "conv-ts",
+      lastProcessedMessageId: "m1",
+      lastProcessedCreatedAt: 1_234,
+      lastRunAt: 1000,
+    });
+
+    expect(getRetrospectiveState("conv-ts")?.lastProcessedCreatedAt).toBe(
+      1_234,
+    );
+    expect(
+      listRetrospectiveStates(10).find((s) => s.conversationId === "conv-ts")
+        ?.lastProcessedCreatedAt,
+    ).toBe(1_234);
+  });
+
+  test("an upsert that omits the timestamp records unknown for the new pointer", async () => {
+    await upsertRetrospectiveState({
+      conversationId: "conv-ts",
+      lastProcessedMessageId: "m1",
+      lastProcessedCreatedAt: 1_234,
+      lastRunAt: 1000,
+    });
+    await upsertRetrospectiveState({
+      conversationId: "conv-ts",
+      lastProcessedMessageId: "m2",
+      lastRunAt: 2000,
+    });
+
+    const state = getRetrospectiveState("conv-ts");
+    expect(state?.lastProcessedMessageId).toBe("m2");
+    expect(state?.lastProcessedCreatedAt).toBeNull();
+  });
+
+  test("bumpRetrospectiveLastRunAt leaves the timestamp untouched", async () => {
+    await upsertRetrospectiveState({
+      conversationId: "conv-ts",
+      lastProcessedMessageId: "m1",
+      lastProcessedCreatedAt: 1_234,
+      lastRunAt: 1000,
+    });
+    await bumpRetrospectiveLastRunAt("conv-ts", 5000);
+
+    const state = getRetrospectiveState("conv-ts");
+    expect(state?.lastRunAt).toBe(5000);
+    expect(state?.lastProcessedCreatedAt).toBe(1_234);
+  });
+
+  test("forking carries the forked pointer's createdAt, read through the main handle", async () => {
+    const db = getDb();
+    createConversation({ id: "conv-fork-ts-src" });
+    createConversation({ id: "conv-fork-ts-dst" });
+    for (const [id, conversationId] of [
+      ["src-m1", "conv-fork-ts-src"],
+      ["dst-m1", "conv-fork-ts-dst"],
+    ] as const) {
+      db.insert(messages)
+        .values({
+          id,
+          conversationId,
+          role: "user",
+          content: "[]",
+          createdAt: 4_000,
+          metadata: null,
+        })
+        .run();
+    }
+    await upsertRetrospectiveState({
+      conversationId: "conv-fork-ts-src",
+      lastProcessedMessageId: "src-m1",
+      lastProcessedCreatedAt: 4_000,
+      lastRunAt: 1,
+    });
+
+    forkRetrospectiveState({
+      database: db,
+      sourceConversationId: "conv-fork-ts-src",
+      forkedConversationId: "conv-fork-ts-dst",
+      forkedMessageIds: new Map([["src-m1", "dst-m1"]]),
+      lastCopiedSourceMessageId: "src-m1",
+    });
+
+    const child = getRetrospectiveState("conv-fork-ts-dst");
+    expect(child?.lastProcessedMessageId).toBe("dst-m1");
+    expect(child?.lastProcessedCreatedAt).toBe(4_000);
+
+    db.run(`DELETE FROM messages`);
+    db.run(`DELETE FROM conversations`);
+  });
+
+  test("a source cursor whose row was regenerated away is placed by its stored bound, not clamped past the copies", async () => {
+    const db = getDb();
+    createConversation({ id: "conv-fork-bound-src" });
+    createConversation({ id: "conv-fork-bound-dst" });
+    // src-m2 (createdAt 2_000) was the cursor; a regenerate deleted it and
+    // src-m3 replaced it. The fork copies src-m1 and src-m3.
+    for (const [id, conversationId, createdAt] of [
+      ["src-m1", "conv-fork-bound-src", 1_000],
+      ["src-m3", "conv-fork-bound-src", 3_000],
+      ["dst-m1", "conv-fork-bound-dst", 1_000],
+      ["dst-m3", "conv-fork-bound-dst", 3_000],
+    ] as const) {
+      db.insert(messages)
+        .values({
+          id,
+          conversationId,
+          role: "user",
+          content: "[]",
+          createdAt,
+          metadata: null,
+        })
+        .run();
+    }
+    await upsertRetrospectiveState({
+      conversationId: "conv-fork-bound-src",
+      lastProcessedMessageId: "src-m2",
+      lastProcessedCreatedAt: 2_000,
+      lastRunAt: 1,
+    });
+
+    forkRetrospectiveState({
+      database: db,
+      sourceConversationId: "conv-fork-bound-src",
+      forkedConversationId: "conv-fork-bound-dst",
+      forkedMessageIds: new Map([
+        ["src-m1", "dst-m1"],
+        ["src-m3", "dst-m3"],
+      ]),
+      lastCopiedSourceMessageId: "src-m3",
+    });
+
+    const child = getRetrospectiveState("conv-fork-bound-dst");
+    expect(child?.lastProcessedMessageId).toBe("dst-m1");
+    expect(child?.lastProcessedCreatedAt).toBe(1_000);
+
+    // A bound before every copied row leaves the child with nothing processed.
+    await upsertRetrospectiveState({
+      conversationId: "conv-fork-bound-src",
+      lastProcessedMessageId: "src-m0",
+      lastProcessedCreatedAt: 500,
+      lastRunAt: 1,
+    });
+    forkRetrospectiveState({
+      database: db,
+      sourceConversationId: "conv-fork-bound-src",
+      forkedConversationId: "conv-fork-bound-dst",
+      forkedMessageIds: new Map([
+        ["src-m1", "dst-m1"],
+        ["src-m3", "dst-m3"],
+      ]),
+      lastCopiedSourceMessageId: "src-m3",
+    });
+    expect(
+      getRetrospectiveState("conv-fork-bound-dst")?.lastProcessedMessageId,
+    ).toBe("");
+
+    db.run(`DELETE FROM messages`);
+    db.run(`DELETE FROM conversations`);
+  });
+
+  test("ensureRetrospectiveCursorColumn adds the column to a legacy table once and is a no-op after", () => {
+    const raw = getMemorySqlite()!;
+    raw.exec("DROP TABLE memory_retrospective_state");
+    raw.exec(`
+      CREATE TABLE memory_retrospective_state (
+        conversation_id TEXT PRIMARY KEY,
+        last_processed_message_id TEXT NOT NULL,
+        last_run_at INTEGER NOT NULL,
+        remembered_log TEXT
+      )
+    `);
+    _resetRetrospectiveCursorColumnForTests();
+
+    expect(ensureRetrospectiveCursorColumn("test")).toBe(true);
+    expect(ensureRetrospectiveCursorColumn("test")).toBe(true);
+
+    const columns = raw
+      .query("PRAGMA table_info(memory_retrospective_state)")
+      .all() as Array<{ name: string }>;
+    expect(
+      columns.filter((c) => c.name === "last_processed_created_at"),
+    ).toHaveLength(1);
+  });
+
+  test("a replaced memory connection is probed again, so a restored database without the column gets it", () => {
+    expect(ensureRetrospectiveCursorColumn("test")).toBe(true);
+
+    // What a restore or import does: the stored connections are dropped and
+    // reopened. Strip the column on the reopened file to stand in for an
+    // older database.
+    resetDb();
+    const reopened = getMemorySqlite()!;
+    reopened.exec(
+      "ALTER TABLE memory_retrospective_state DROP COLUMN last_processed_created_at",
+    );
+
+    expect(getRetrospectiveState("conv-none")).toBeNull();
+    expect(ensureRetrospectiveCursorColumn("test")).toBe(true);
+    const columns = reopened
+      .query("PRAGMA table_info(memory_retrospective_state)")
+      .all() as Array<{ name: string }>;
+    expect(columns.some((c) => c.name === "last_processed_created_at")).toBe(
+      true,
+    );
+  });
+});
+
 describe("fail-soft when the underlying statement fails", () => {
   // The memory connection is present, but the relocated table is gone (a
   // corrupt/dropped table, SQLITE_FULL, I/O error, or SQLITE_BUSY after

package/src/plugins/defaults/memory/__tests__/memory-retrospective-sweep.test.ts

@@ -412,3 +412,34 @@ describe("listSweepCandidateConversationIds", () => {
     ]);
   });
 });
+
+describe("runRetrospectiveSweep: cursor survives a regenerated reply", () => {
+  beforeEach(() => {
+    resetTables();
+    enqueueCalls = [];
+    enqueueDeclines = new Set();
+  });
+
+  test("a stale conversation whose cursor row was regenerated away is still swept", async () => {
+    const conv = createConversation({ id: "conv-a" });
+    insertMessage(conv.id, { createdAt: 1_000 });
+    const reply = insertMessage(conv.id, {
+      role: "assistant",
+      createdAt: 2_000,
+    });
+    await upsertRetrospectiveState({
+      conversationId: conv.id,
+      lastProcessedMessageId: reply,
+      lastProcessedCreatedAt: 2_000,
+      lastRunAt: Date.now() - SWEEP_INTERVAL_MS - 60_000,
+    });
+    getDb().delete(messages).where(eq(messages.id, reply)).run();
+    insertMessage(conv.id, { role: "assistant", createdAt: 3_000 });
+
+    await runRetrospectiveSweep(makeConfig());
+
+    expect(enqueueCalls).toEqual([
+      { conversationId: conv.id, trigger: "sweep" },
+    ]);
+  });
+});