@vellumai/assistant 0.12.1-staging.1 → 0.12.1

package/src/notifications/home-feed-side-effect.ts

@@ -23,10 +23,7 @@ import {
   getMessageById,
   updateMessageContent,
 } from "../persistence/conversation-crud.js";
-import {
-  ASSISTANT_INITIATED_SOURCE,
-  isBackgroundConversationType,
-} from "../persistence/conversation-types.js";
+import { isBackgroundConversationType } from "../persistence/conversation-types.js";
 import { publishConversationMessagesChanged } from "../runtime/sync/resource-sync-events.js";
 import { getLogger } from "../util/logger.js";
 import { normalizeTitle, stripMarkdown } from "../util/short-title.js";
@@ -275,11 +272,6 @@ async function resolveOwnedConversationMessageId(
   sourceConversationId: string | undefined,
   summary: string,
 ): Promise<string | undefined> {
-  // The completed reply is already the source conversation's canonical row.
-  // This signal's body is a compact push preview, not conversation content.
-  if (signal.sourceEventName === "chat.assistant_reply") {
-    return undefined;
-  }
   if (vellumDelivery?.conversationId) {
     return vellumDelivery.conversationId === sourceConversationId
       ? vellumDelivery.messageId
@@ -503,18 +495,6 @@ function deriveDetailPanelKind(
  * `isAsyncBackground` hint. `chat.assistant_reply` also mirrors: it is the
  * durable in-app record for the push sent after a user leaves a chat, while
  * retaining the normal interactive conversation as its navigation target.
- *
- * A delivery that materialized an assistant-initiated thread never mirrors.
- * Under the `assistant-initiated-threads` flag, `conversation-pairing.ts`
- * promotes a background `assistant.share` into a standard conversation
- * stamped {@link ASSISTANT_INITIATED_SOURCE}, and that thread's row in the
- * sidebar's assistant section is the share's one surface. Mirroring it here
- * as well put the same share in the bell a second time, labeled by its
- * source channel ("Heartbeat"). The check reads the paired conversation's
- * `source` rather than re-deriving the promotion rule, so it holds however
- * that rule narrows or widens. Guardian requests are checked first on
- * purpose: the bell is their canonical home whatever conversation they pair
- * with.
  */
 function resolveHomeFeedMirror(
   signal: NotificationSignal,
@@ -545,15 +525,6 @@ function resolveHomeFeedMirror(
     : fallbackConversationId;
   const sourceScheduleJobId = sourceRow?.scheduleJobId ?? undefined;
 
-  // Guardian requests always project into the feed: the "Needs
-  // attention" item is the request's canonical home, and the request
-  // blocks on the guardian whatever kind of conversation raised it.
-  if (isGuardianRequestSignalEvent(signal.sourceEventName)) {
-    return { mirror: true, sourceConversationId, sourceScheduleJobId };
-  }
-  if (isAssistantInitiatedThreadDelivery(fallbackConversationId)) {
-    return { mirror: false };
-  }
   if (
     signal.sourceChannel === "assistant_tool" ||
     signal.sourceEventName === "chat.assistant_reply"
@@ -563,37 +534,18 @@ function resolveHomeFeedMirror(
   if (signal.attentionHints.isAsyncBackground) {
     return { mirror: true, sourceConversationId, sourceScheduleJobId };
   }
+  // Guardian requests always project into the feed: the "Needs
+  // attention" item is the request's canonical home, and the request
+  // blocks on the guardian whatever kind of conversation raised it.
+  if (isGuardianRequestSignalEvent(signal.sourceEventName)) {
+    return { mirror: true, sourceConversationId, sourceScheduleJobId };
+  }
   if (isBackgroundConversationType(sourceRow?.conversationType)) {
     return { mirror: true, sourceConversationId, sourceScheduleJobId };
   }
   return { mirror: false };
 }
 
-/**
- * Whether the vellum delivery this signal produced landed in a thread the
- * sidebar's assistant section already shows.
- *
- * Best-effort like the source lookup above: a missing id, a missing row, or
- * a lookup failure all read as "not an assistant thread", so a storage
- * hiccup degrades to the pre-existing behavior (a bell row) rather than
- * dropping the notification everywhere.
- */
-function isAssistantInitiatedThreadDelivery(
-  deliveryConversationId: string | undefined,
-): boolean {
-  if (!deliveryConversationId) {
-    return false;
-  }
-  try {
-    return (
-      getConversation(deliveryConversationId)?.source ===
-      ASSISTANT_INITIATED_SOURCE
-    );
-  } catch {
-    return false;
-  }
-}
-
 /**
  * Routing-intent enforcement can prune `selectedChannels` without also
  * pruning `renderedCopy`, so iterating `renderedCopy` directly risks

package/src/outbound-proxy/certs.ts

@@ -2,8 +2,6 @@ import { X509Certificate } from "node:crypto";
 import { chmod, mkdir, readFile, stat, writeFile } from "node:fs/promises";
 import { join } from "node:path";
 
-import { writeCombinedCABundle } from "../util/ca-bundle.js";
-
 const CA_CERT_FILENAME = "ca.pem";
 const CA_KEY_FILENAME = "ca-key.pem";
 const COMBINED_CA_FILENAME = "combined-ca-bundle.pem";
@@ -265,7 +263,11 @@ export async function ensureCombinedCABundle(
   }
 
   try {
-    await writeCombinedCABundle(systemBundlePath, caCertPath, combinedPath);
+    const [systemCAs, proxyCACert] = await Promise.all([
+      readFile(systemBundlePath, "utf-8"),
+      readFile(caCertPath, "utf-8"),
+    ]);
+    await writeFile(combinedPath, systemCAs + "\n" + proxyCACert);
     return combinedPath;
   } catch {
     return null;

package/src/permissions/checker.test.ts

@@ -15,16 +15,13 @@ mock.module("../config/assistant-feature-flags.js", () => ({
 }));
 
 // `buildPolicyContext` (used by the integration tests below) precomputes the
-// retrospective skill-improvement gate. Keep the v3 tier active while the
-// dedicated gate changes so the production threading test covers the new
-// opt-out rather than the old v3 condition.
+// proc-to-skills gate via `isV3TierActive`. Drive it through this slot so a
+// test can put the production threading path in the active / inactive state.
 let mockV3TierActive = true;
-let mockSkillImprovementActive = true;
 mock.module("../config/memory-v3-gate.js", () => ({
   isMemoryEnabled: (config?: { memory?: { enabled?: boolean } }) =>
     config?.memory?.enabled !== false,
   isV3TierActive: () => mockV3TierActive,
-  isSkillImprovementActive: () => mockSkillImprovementActive,
   isMemoryV3Live: () => mockV3TierActive,
   usesConceptPageMemory: (memory?: {
     enabled?: boolean;
@@ -222,7 +219,6 @@ describe("Permission Checker (gateway IPC)", () => {
     mockCachedThreshold = "low";
     mockRefreshedThreshold = null;
     mockV3TierActive = true;
-    mockSkillImprovementActive = true;
     thresholdCallLog.length = 0;
     mockSkillCatalog = [];
     mockResolvedSkill = null;
@@ -1177,11 +1173,10 @@ describe("Permission Checker (gateway IPC)", () => {
     });
 
     test("grant does NOT fire when proc-to-skills is inactive, even for the retrospective turn", async () => {
-      // The retrospective keeps its live v3 tier, but this independent flag is
-      // off. buildPolicyContext stamps `procToSkillsActive: false`, so the
-      // grant is dead and the high-risk scaffold prompts.
-      mockV3TierActive = true;
-      mockSkillImprovementActive = false;
+      // Same retrospective ToolContext, but the feature is inactive (flag off
+      // or v3 not live). buildPolicyContext stamps `procToSkillsActive: false`,
+      // so the grant is dead and the high-risk scaffold prompts.
+      mockV3TierActive = false;
       mockIpcClassifyRiskResult = {
         risk: "high",
         reason: "Skill scaffold",

package/src/persistence/compaction-log-store-clickhouse.ts

@@ -26,7 +26,6 @@
  */
 import type { AgentEvent } from "../agent/loop.js";
 import { getConfig } from "../config/loader.js";
-import { resolvePlatformAssistantIdOrNull } from "../config/platform-identity.js";
 import type { CompactionLogsClickHouseConfig } from "../config/schemas/compaction-logs.js";
 import { credentialKey } from "../security/credential-key.js";
 import { getSecureKeyAsync } from "../security/secure-keys.js";
@@ -137,7 +136,7 @@ export interface ClickHouseCompactionLogStoreDeps {
   resolveUrl?: () => Promise<string | null>;
   /** Override the credential read for `clickhouse:password`. */
   resolvePassword?: () => Promise<string | null>;
-  /** Override the platform assistant id (in-memory identity, then vault). */
+  /** Override the credential read for `vellum:platform_assistant_id`. */
   resolveAssistantId?: () => Promise<string | null>;
   /** Override fetch for testing. */
   fetchImpl?: CompactionLogFetch;
@@ -164,7 +163,8 @@ export class ClickHouseCompactionLogStore {
       deps.resolvePassword ??
       (() => readCredentialOrNull("clickhouse", "password"));
     this.resolveAssistantId =
-      deps.resolveAssistantId ?? resolvePlatformAssistantIdOrNull;
+      deps.resolveAssistantId ??
+      (() => readCredentialOrNull("vellum", "platform_assistant_id"));
     this.fetchImpl = deps.fetchImpl ?? globalThis.fetch.bind(globalThis);
   }
 

package/src/persistence/conversation-crud.ts

@@ -35,10 +35,7 @@ import { findConversation } from "../daemon/conversation-registry.js";
 import { conversationMetadataSyncTag } from "../daemon/message-types/sync.js";
 import type { TrustContext } from "../daemon/trust-context-types.js";
 import { clearAllConversationIds } from "../home/feed-writer.js";
-import type {
-  ConversationDeletedInputContext,
-  MessageDeletedInputContext,
-} from "../hooks/types.js";
+import type { ConversationDeletedInputContext } from "../hooks/types.js";
 import { readProviderMetadata } from "../messaging/read-provider-metadata.js";
 import { HOOKS } from "../plugin-api/constants.js";
 import { forkConversationMemory } from "../plugins/defaults/memory/fork-conversation-memory.js";
@@ -84,6 +81,7 @@ import { ensureDisplayOrderMigration } from "./conversation-display-order-migrat
 import { ensureGroupMigration } from "./conversation-group-migration.js";
 import {
   isReferentialFork,
+  type LineageBound,
   type LineageConversationRow,
   lineageMessageFilter,
   lineageMessagesAfterFilter,
@@ -123,11 +121,6 @@ import {
 } from "./job-handlers/message-lexical.js";
 import { buildLifecycleTelemetryEvent } from "./lifecycle-events-store.js";
 import { resolveMessageContentBlocks } from "./message-content-file.js";
-import {
-  loadMessageBound,
-  type MessagesAfterRef,
-  resolveMessagesAfterBound,
-} from "./message-cursor.js";
 import { mergeMessageMetadata } from "./message-metadata.js";
 import {
   rawAll,
@@ -2648,6 +2641,16 @@ function loadLineageRow(id: string): LineageConversationRow | null {
   return row ?? null;
 }
 
+/** The `(createdAt, id)` bound of a single message, or null when it is gone. */
+function loadMessageBound(messageId: string): LineageBound | null {
+  const row = getDb()
+    .select({ createdAt: messages.createdAt, id: messages.id })
+    .from(messages)
+    .where(eq(messages.id, messageId))
+    .get();
+  return row ?? null;
+}
+
 /**
  * The segments making up a conversation's logical message set. Non-forks and
  * copied forks resolve to a single unbounded segment after one row lookup, so
@@ -2969,67 +2972,81 @@ export function selectNewestSightFrameCapture(
 }
 
 /**
- * Count messages in a conversation created strictly after the `after`
- * reference. `null`, `""`, or a cursor with an empty id counts every message.
- * The reference resolves through `resolveMessagesAfterBound`: a live row's
- * `(createdAt, id)` is authoritative, a `MessageCursor` whose row has been
- * deleted still bounds the count from the `createdAt` it carries, and a bare
- * id whose row is gone counts 0: a caller holding only an id has no
- * defensible starting point, and the conservative answer is "no new work."
+ * Count messages in a conversation that were created strictly after the
+ * `afterMessageId` reference message. If `afterMessageId` is `null` or empty,
+ * counts all messages in the conversation. If the referenced message no
+ * longer exists (e.g. deleted by a separate flow), returns 0 — callers
+ * decide how to react to a vanished reference, and the conservative answer
+ * here is "no new work."
  *
  * Used by the memory-retrospective trigger check to decide whether to fire
  * the message-count trigger without loading message bodies.
  */
 export function countMessagesAfter(
   conversationId: string,
-  after: MessagesAfterRef,
+  afterMessageId: string | null,
 ): number {
   const db = getDb();
   const segments = resolveLineage(conversationId);
-  const start = resolveMessagesAfterBound(after);
-  if (start.kind === "vanished") {
+  if (afterMessageId === null || afterMessageId === "") {
+    const row = db
+      .select({ c: count() })
+      .from(messages)
+      .where(lineageMessageFilter(segments))
+      .get();
+    return row?.c ?? 0;
+  }
+  const ref = loadMessageBound(afterMessageId);
+  if (!ref) {
     return 0;
   }
+  // Tie-breaker on `messages.id` so rows that share a millisecond timestamp
+  // with the reference are not permanently skipped. Mirrors the
+  // `(createdAt, id)` cursor pattern used by the backfill job-handler and
+  // turn-events-store.
   const row = db
     .select({ c: count() })
     .from(messages)
-    .where(
-      start.kind === "all"
-        ? lineageMessageFilter(segments)
-        : lineageMessagesAfterFilter(segments, start.bound),
-    )
+    .where(lineageMessagesAfterFilter(segments, ref))
     .get();
   return row?.c ?? 0;
 }
 
 /**
- * Return messages in a conversation created strictly after the `after`
- * reference, in `(createdAt, id)` order. Resolves the reference exactly as
- * `countMessagesAfter` does, returning an empty array where that returns 0.
- * Used by the memory-retrospective job handler to load the message slice it
- * processes.
+ * Return messages in a conversation created strictly after the
+ * `afterMessageId` reference. If the reference is `null`/empty, returns all
+ * messages. If the reference doesn't exist, returns an empty array (mirrors
+ * `countMessagesAfter`'s conservative semantics). Used by the
+ * memory-retrospective job handler to load the message slice it processes.
  */
 export function getMessagesAfter(
   conversationId: string,
-  after: MessagesAfterRef,
+  afterMessageId: string | null,
 ): MessageRow[] {
   const db = getDb();
   const segments = resolveLineage(conversationId);
-  const start = resolveMessagesAfterBound(after);
-  if (start.kind === "vanished") {
+  if (afterMessageId === null || afterMessageId === "") {
+    // Secondary `asc(messages.id)` matches the non-null path's cursor
+    // ordering, so callers tracking `cutoffMessageId` across runs see a
+    // consistent ordering when multiple rows share a millisecond timestamp.
+    return db
+      .select()
+      .from(messages)
+      .where(lineageMessageFilter(segments))
+      .orderBy(asc(messages.createdAt), asc(messages.id))
+      .all()
+      .map(parseMessage);
+  }
+  const ref = loadMessageBound(afterMessageId);
+  if (!ref) {
     return [];
   }
-  // Secondary `asc(messages.id)` mirrors the bound's tie-breaker, so callers
-  // tracking `cutoffMessageId` across runs see a consistent ordering when
-  // multiple rows share a millisecond timestamp.
+  // Same `(createdAt, id)` cursor as `countMessagesAfter` — rows sharing
+  // the reference's millisecond timestamp would otherwise be skipped.
   return db
     .select()
     .from(messages)
-    .where(
-      start.kind === "all"
-        ? lineageMessageFilter(segments)
-        : lineageMessagesAfterFilter(segments, start.bound),
-    )
+    .where(lineageMessagesAfterFilter(segments, ref))
     .orderBy(asc(messages.createdAt), asc(messages.id))
     .all()
     .map(parseMessage);
@@ -4287,12 +4304,12 @@ export function deleteLastExchange(conversationId: string): number {
 
   // Collect attachment IDs linked to the messages being deleted so we can
   // scope orphan cleanup to only those candidates (not freshly uploaded ones).
-  const deletedRows = db
-    .select({ id: messages.id, createdAt: messages.createdAt })
+  const messageIds = db
+    .select({ id: messages.id })
     .from(messages)
     .where(condition)
-    .all();
-  const messageIds = deletedRows.map((r) => r.id);
+    .all()
+    .map((r) => r.id);
   const candidateAttachmentIds =
     messageIds.length > 0
       ? db
@@ -4339,17 +4356,6 @@ export function deleteLastExchange(conversationId: string): number {
     enqueueDeleteMessageLexical(deletedMessageId);
   }
 
-  // Notify `message-deleted` hooks for each removed row, as the
-  // single-message primitive does: undo removes the same tail a regenerate
-  // does, and a hook keeping a cursor on one of these rows needs its position.
-  for (const row of deletedRows) {
-    void runHook(HOOKS.MESSAGE_DELETED, {
-      conversationId,
-      messageId: row.id,
-      createdAt: row.createdAt,
-    } satisfies MessageDeletedInputContext);
-  }
-
   return deleted;
 }
 
@@ -4588,13 +4594,9 @@ export function deleteMessageById(
     .map((r) => r.attachmentId)
     .filter((id): id is string => id !== undefined);
 
-  // Look up the conversation before the transaction so we can recalculate
-  // lastMessageAt, and the row's createdAt for the `message-deleted` hook.
+  // Look up the conversation before the transaction so we can recalculate lastMessageAt.
   const msgRow = db
-    .select({
-      conversationId: messages.conversationId,
-      createdAt: messages.createdAt,
-    })
+    .select({ conversationId: messages.conversationId })
     .from(messages)
     .where(eq(messages.id, messageId))
     .get();
@@ -4650,16 +4652,6 @@ export function deleteMessageById(
   // not go through the conversation-level purge.
   if (msgRow) {
     enqueueDeleteMessageLexical(messageId);
-
-    // Notify `message-deleted` hooks (e.g. the memory plugin stamping a
-    // retrospective cursor that sat on this row). Fire-and-forget from this
-    // synchronous primitive, like `conversation-deleted`; the context carries
-    // the row's position because the row itself is gone.
-    void runHook(HOOKS.MESSAGE_DELETED, {
-      conversationId: msgRow.conversationId,
-      messageId,
-      createdAt: msgRow.createdAt,
-    } satisfies MessageDeletedInputContext);
   }
 
   return result;

package/src/persistence/conversation-lineage.ts

@@ -227,17 +227,9 @@ export function lineageMessagesAfterFilter(
 ): SQL {
   return and(
     lineageMessageFilter(segments),
-    messagesAfterBoundFilter(after),
-  ) as SQL;
-}
-
-/**
- * Predicate for rows strictly after a `(createdAt, id)` bound, with the id
- * tie-breaker so rows sharing the bound's millisecond keep their order.
- */
-export function messagesAfterBoundFilter(after: LineageBound): SQL {
-  return or(
-    gt(messages.createdAt, after.createdAt),
-    and(eq(messages.createdAt, after.createdAt), gt(messages.id, after.id)),
+    or(
+      gt(messages.createdAt, after.createdAt),
+      and(eq(messages.createdAt, after.createdAt), gt(messages.id, after.id)),
+    ),
   ) as SQL;
 }

package/src/persistence/conversation-title-service.ts

@@ -8,7 +8,6 @@
  */
 
 import { SEND_USER_MESSAGE_DELIVERED_ACK } from "../config/send-user-message-constants.js";
-import { MESSAGE_KEYS } from "../i18n/index.js";
 import {
   requestShortLabel,
   type ShortLabelTool,
@@ -25,11 +24,8 @@ import {
   type MessageRow,
   updateConversationTitle,
 } from "./conversation-crud.js";
-import { isReplaceableTitle } from "./conversation-title-placeholders.js";
 import { projectPersistedAssistantContent } from "./user-facing-content.js";
 
-export { isReplaceableTitle } from "./conversation-title-placeholders.js";
-
 const log = getLogger("conversation-title-service");
 
 // ── Types ────────────────────────────────────────────────────────────
@@ -69,8 +65,8 @@ export interface TitleContext {
 
 // ── Placeholder / loading state ──────────────────────────────────────
 
-export const GENERATING_TITLE = MESSAGE_KEYS.CONVERSATION_TITLE_GENERATING;
-const UNTITLED_FALLBACK = MESSAGE_KEYS.CONVERSATION_TITLE_UNTITLED;
+export const GENERATING_TITLE = "Generating title...";
+const UNTITLED_FALLBACK = "Untitled Conversation";
 
 // ── `conversations.isAutoTitle` values ───────────────────────────────
 //
@@ -87,6 +83,28 @@ export const AUTO_TITLE_LLM = 1;
  */
 export const AUTO_TITLE_DETERMINISTIC = 2;
 
+// ── Replaceability check ─────────────────────────────────────────────
+
+const REPLACEABLE_PATTERNS = [
+  /^Runtime:\s/,
+  /^New Conversation$/,
+  /^Untitled$/,
+  /^Untitled Conversation$/,
+  /^Generating title\.\.\.$/,
+];
+
+/**
+ * Check whether a title is a system-generated placeholder that can be
+ * safely overwritten by auto-generated titles. Returns `false` for
+ * user-provided custom titles.
+ */
+export function isReplaceableTitle(title: string | null): boolean {
+  if (title == null || title.trim() === "") {
+    return true;
+  }
+  return REPLACEABLE_PATTERNS.some((pattern) => pattern.test(title));
+}
+
 /**
  * Whether auto-generation may overwrite the conversation's current title.
  * True for placeholder/system titles and for deterministic bootstrap titles
@@ -237,7 +255,7 @@ function settleForDeterministicTitle(
  * conversation creation (e.g. 5 new chats in quick succession) fires N
  * concurrent requests that can hit provider rate limits or contend for
  * API capacity, causing later calls to time out and fall back to
- * the untitled catalog key.
+ * "Untitled Conversation".
  *
  * A serial queue ensures at most one title-generation LLM call is
  * in-flight at a time. Each call is lightweight (~1–3 s for a ≤5-word
@@ -271,7 +289,7 @@ export function queueGenerateConversationTitle(
       // Replace loading placeholder with a retryable fallback.
       try {
         const conversation = getConversation(params.conversationId);
-        if (conversation && isReplaceableTitle(conversation.title)) {
+        if (conversation && conversation.title === GENERATING_TITLE) {
           const fallback =
             deriveFallbackTitle(params.context) ?? UNTITLED_FALLBACK;
           updateConversationTitle(
@@ -406,7 +424,6 @@ function buildTitleSystemPrompt(): string {
     "- Think: what would make a scannable sidebar label?",
     "- Do NOT echo back what the user asked you to do",
     "- Do NOT respond to the conversation content",
-    "- Write the title in the same language as the conversation content",
     "- Do NOT assess feasibility or comment on capabilities",
     "- If input is sparse or references external context, extract a topic from the words that ARE present (e.g. 'so about that t-shirt...' → 'T-Shirt Discussion'). Never describe the absence, emptiness, or insufficiency of context — titles like 'Missing Context', 'Unclear Request', 'No Topic' are forbidden",
   ].join("\n");

package/src/persistence/llm-request-log-sink-clickhouse.ts

@@ -30,7 +30,6 @@
  * can never abort a turn.
  */
 import { getConfigReadOnly } from "../config/loader.js";
-import { resolvePlatformAssistantIdOrNull } from "../config/platform-identity.js";
 import type { LlmRequestLogsClickHouseConfig } from "../config/schemas/llm-request-logs.js";
 import { credentialKey } from "../security/credential-key.js";
 import { getSecureKeyAsync } from "../security/secure-keys.js";
@@ -72,7 +71,7 @@ export interface ClickHouseLlmRequestLogSinkDeps {
   resolveUrl?: () => Promise<string | null>;
   /** Override the credential read for `clickhouse:password`. */
   resolvePassword?: () => Promise<string | null>;
-  /** Override the platform assistant id (in-memory identity, then vault). */
+  /** Override the credential read for `vellum:platform_assistant_id`. */
   resolveAssistantId?: () => Promise<string | null>;
   /** Override fetch for testing. */
   fetchImpl?: ClickHouseSinkFetch;
@@ -99,7 +98,8 @@ export class ClickHouseLlmRequestLogSink implements LlmRequestLogWriter {
       deps.resolvePassword ??
       (() => readCredentialOrNull("clickhouse", "password"));
     this.resolveAssistantId =
-      deps.resolveAssistantId ?? resolvePlatformAssistantIdOrNull;
+      deps.resolveAssistantId ??
+      (() => readCredentialOrNull("vellum", "platform_assistant_id"));
     this.fetchImpl = deps.fetchImpl ?? globalThis.fetch.bind(globalThis);
   }
 

package/src/persistence/llm-request-log-source-clickhouse.ts

@@ -15,7 +15,6 @@
  * than the local source. Acceptable for the "internal use while we
  * finetune prompts" use case; revisit when mirror updates are added.
  */
-import { resolvePlatformAssistantIdOrNull } from "../config/platform-identity.js";
 import type { LlmRequestLogsClickHouseConfig } from "../config/schemas/llm-request-logs.js";
 import { credentialKey } from "../security/credential-key.js";
 import { getSecureKeyAsync } from "../security/secure-keys.js";
@@ -105,7 +104,7 @@ export interface ClickHouseLlmRequestLogSourceDeps {
   resolveUrl?: () => Promise<string | null>;
   /** Override the credential read for `clickhouse:password`. */
   resolvePassword?: () => Promise<string | null>;
-  /** Override the platform assistant id (in-memory identity, then vault). */
+  /** Override the credential read for `vellum:platform_assistant_id`. */
   resolveAssistantId?: () => Promise<string | null>;
   /** Override the turn-id resolver (default: `getAssistantMessageIdsInTurn`). */
   resolveTurnMessageIds?: (messageId: string) => string[];
@@ -139,7 +138,8 @@ export class ClickHouseLlmRequestLogSource implements LlmRequestLogSource {
       deps.resolvePassword ??
       (() => readCredentialOrNull("clickhouse", "password"));
     this.resolveAssistantId =
-      deps.resolveAssistantId ?? resolvePlatformAssistantIdOrNull;
+      deps.resolveAssistantId ??
+      (() => readCredentialOrNull("vellum", "platform_assistant_id"));
     this.resolveTurnMessageIds =
       deps.resolveTurnMessageIds ?? getAssistantMessageIdsInTurn;
     this.resolveMessage = deps.resolveMessage ?? getMessageById;

package/src/persistence/message-reads.ts

@@ -190,36 +190,6 @@ export function existingMessageIds(
   );
 }
 
-/**
- * `createdAt` of each of `messageIds` that exists as a row, keyed by id, in
- * any state.
- *
- * Any-state deliberately: a row's `createdAt` is fixed at insert, so its
- * completeness does not change the answer, and the callers (retrospective
- * cursor bookkeeping) hold ids taken from rows they have already reviewed.
- * An empty input returns an empty map without querying.
- */
-export function messageCreatedAtByIds(
-  messageIds: readonly string[],
-  opts?: { db?: MessageReadHandle },
-): Map<string, number> {
-  const db = opts?.db ?? getDb();
-  const result = new Map<string, number>();
-  // Chunked so a whole-conversation id list stays under SQLite's bound
-  // parameter limit.
-  for (let offset = 0; offset < messageIds.length; offset += 500) {
-    const rows = db
-      .select({ id: messages.id, createdAt: messages.createdAt })
-      .from(messages)
-      .where(inArray(messages.id, messageIds.slice(offset, offset + 500)))
-      .all();
-    for (const row of rows) {
-      result.set(row.id, row.createdAt);
-    }
-  }
-  return result;
-}
-
 /**
  * The conversation that owns `messageId`, in any state, or null when the
  * message does not exist.