@vellumai/assistant 0.12.0 → 0.12.1-staging.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (406) hide show
  1. package/AGENTS.md +5 -1
  2. package/ARCHITECTURE.md +11 -12
  3. package/docs/architecture/turn-actor.md +15 -8
  4. package/openapi.yaml +292 -2
  5. package/package.json +1 -1
  6. package/scripts/smoke-desktop-window-theme.ts +186 -0
  7. package/src/__tests__/always-loaded-tools-guard.test.ts +18 -10
  8. package/src/__tests__/app-compiler.test.ts +6 -0
  9. package/src/__tests__/app-control-tool-schemas.test.ts +5 -2
  10. package/src/__tests__/app-dir-path-guard.test.ts +1 -3
  11. package/src/__tests__/computer-use-skill-proxy-bridge.test.ts +5 -2
  12. package/src/__tests__/computer-use-tools.test.ts +17 -5
  13. package/src/__tests__/config-schema-cmd.test.ts +2 -2
  14. package/src/__tests__/config-schema.test.ts +28 -29
  15. package/src/__tests__/config-watcher.test.ts +23 -8
  16. package/src/__tests__/connection-model-compat.test.ts +2 -2
  17. package/src/__tests__/conversation-key-store-disk-view.test.ts +1 -1
  18. package/src/__tests__/conversation-pairing.test.ts +26 -0
  19. package/src/__tests__/conversation-process-app-control-preactivation.test.ts +4 -10
  20. package/src/__tests__/conversation-queue.test.ts +48 -207
  21. package/src/__tests__/conversation-retry-discard.test.ts +54 -1
  22. package/src/__tests__/conversation-skill-tools.test.ts +27 -0
  23. package/src/__tests__/conversation-surfaces-app-control.test.ts +8 -3
  24. package/src/__tests__/conversation-surfaces-task-progress.test.ts +67 -0
  25. package/src/__tests__/conversation-title-service.test.ts +14 -10
  26. package/src/__tests__/conversation-tool-setup-app-refresh.test.ts +3 -5
  27. package/src/__tests__/conversation-tool-setup-attribution.test.ts +51 -0
  28. package/src/__tests__/credential-record-retire.test.ts +171 -1
  29. package/src/__tests__/credential-routes.test.ts +212 -3
  30. package/src/__tests__/credential-security-invariants.test.ts +2 -1
  31. package/src/__tests__/cu-unified-flow.test.ts +8 -2
  32. package/src/__tests__/drain-kick-guard.test.ts +0 -2
  33. package/src/__tests__/drain-requeue-on-contention.test.ts +0 -6
  34. package/src/__tests__/evict-conversations-for-reload.test.ts +1 -1
  35. package/src/__tests__/git-porcelain.test.ts +47 -0
  36. package/src/__tests__/helpers/set-workspace-mcp.ts +11 -0
  37. package/src/__tests__/host-bash-proxy.test.ts +26 -45
  38. package/src/__tests__/host-browser-proxy.test.ts +6 -17
  39. package/src/__tests__/host-file-proxy-targeted.test.ts +23 -0
  40. package/src/__tests__/host-file-proxy.test.ts +11 -23
  41. package/src/__tests__/host-transfer-proxy-targeted.test.ts +30 -9
  42. package/src/__tests__/llm-catalog-parity.test.ts +25 -0
  43. package/src/__tests__/mcp-auth-routes.test.ts +6 -9
  44. package/src/__tests__/mcp-config-secret-boundary.test.ts +78 -136
  45. package/src/__tests__/mcp-health-check.test.ts +8 -11
  46. package/src/__tests__/mcp-list-plugin-servers.test.ts +8 -10
  47. package/src/__tests__/message-deleted-hook-dispatch.test.ts +119 -0
  48. package/src/__tests__/messages-after-tiebreaker.test.ts +91 -0
  49. package/src/__tests__/messages-read-boundary-guard.test.ts +1 -1
  50. package/src/__tests__/messaging-send-tool.test.ts +355 -548
  51. package/src/__tests__/model-intents.test.ts +3 -0
  52. package/src/__tests__/outlook-messaging-provider.test.ts +6 -6
  53. package/src/__tests__/platform-client-verify-credential.test.ts +2 -0
  54. package/src/__tests__/plugin-import-boundary-guard.test.ts +13 -0
  55. package/src/__tests__/resolve-app.test.ts +135 -0
  56. package/src/__tests__/script-proxy-certs.test.ts +35 -0
  57. package/src/__tests__/skill-feature-flags-integration.test.ts +1 -1
  58. package/src/__tests__/skill-feature-flags.test.ts +2 -2
  59. package/src/__tests__/source-fingerprint.test.ts +184 -0
  60. package/src/__tests__/subagent-tool-gate-mode.test.ts +19 -3
  61. package/src/__tests__/subagent-tools.test.ts +3 -2
  62. package/src/__tests__/telephony-tts-guard.test.ts +38 -3
  63. package/src/__tests__/vellum-self-knowledge-inline-command.test.ts +4 -0
  64. package/src/__tests__/watch-retro-tool-availability.test.ts +8 -17
  65. package/src/__tests__/workspace-git-service.test.ts +26 -0
  66. package/src/__tests__/workspace-migration-154-repair-retired-codex-gpt-5-4-model-ids.test.ts +336 -0
  67. package/src/acp/__tests__/agent-process.test.ts +258 -4
  68. package/src/acp/__tests__/auth-required.test.ts +96 -0
  69. package/src/acp/__tests__/client-handler.test.ts +90 -2
  70. package/src/acp/__tests__/helpers/acp-model-option.ts +51 -0
  71. package/src/acp/__tests__/session-manager-persistence.test.ts +5 -1
  72. package/src/acp/__tests__/session-manager-resume.test.ts +270 -6
  73. package/src/acp/__tests__/session-manager-usage.test.ts +4 -2
  74. package/src/acp/__tests__/session-manager.test.ts +895 -4
  75. package/src/acp/agent-process.test.ts +4 -1
  76. package/src/acp/agent-process.ts +94 -9
  77. package/src/acp/auth-required.ts +50 -1
  78. package/src/acp/auto-install.test.ts +9 -7
  79. package/src/acp/client-handler.ts +16 -3
  80. package/src/acp/model-config.test.ts +166 -0
  81. package/src/acp/model-config.ts +138 -0
  82. package/src/acp/resolve-agent.test.ts +220 -6
  83. package/src/acp/resolve-agent.ts +88 -23
  84. package/src/acp/session-manager.test.ts +196 -3
  85. package/src/acp/session-manager.ts +441 -18
  86. package/src/acp/types.ts +50 -5
  87. package/src/api/events/acp-session-model-update.test.ts +88 -0
  88. package/src/api/events/acp-session-model-update.ts +46 -0
  89. package/src/api/events/app-files-changed.ts +4 -3
  90. package/src/api/index.ts +6 -0
  91. package/src/apps/app-store.ts +1 -1
  92. package/src/apps/resolve-app.ts +81 -0
  93. package/src/apps/source-fingerprint.ts +266 -0
  94. package/src/bundler/app-compiler.ts +15 -0
  95. package/src/calls/__tests__/barge-in-guard.test.ts +81 -0
  96. package/src/{__tests__ → calls/__tests__}/call-controller.test.ts +503 -82
  97. package/src/{__tests__ → calls/__tests__}/media-stream-audio-transcode.test.ts +1 -1
  98. package/src/{__tests__ → calls/__tests__}/media-stream-output.test.ts +37 -8
  99. package/src/{__tests__ → calls/__tests__}/media-stream-parser.test.ts +1 -1
  100. package/src/{__tests__ → calls/__tests__}/media-stream-server-integration.test.ts +150 -57
  101. package/src/{__tests__ → calls/__tests__}/media-stream-stt-session.test.ts +5 -5
  102. package/src/{__tests__ → calls/__tests__}/media-turn-detector.test.ts +1 -1
  103. package/src/{live-voice → calls}/__tests__/progress-narration.test.ts +4 -4
  104. package/src/{live-voice → calls}/__tests__/progress-phrases.test.ts +1 -1
  105. package/src/calls/__tests__/voice-control-protocol.test.ts +58 -25
  106. package/src/calls/__tests__/voice-leg-coordinator.test.ts +229 -0
  107. package/src/calls/__tests__/voice-progress-cadence.test.ts +274 -0
  108. package/src/{__tests__/voice-session-bridge.test.ts → calls/__tests__/voice-session-bridge-turn-flow.test.ts} +20 -12
  109. package/src/calls/__tests__/voice-session-bridge.test.ts +37 -1
  110. package/src/calls/__tests__/voice-triage-escalate.test.ts +105 -0
  111. package/src/calls/barge-in-guard.ts +118 -0
  112. package/src/calls/call-constants.ts +24 -4
  113. package/src/calls/call-controller.ts +499 -199
  114. package/src/calls/call-transport.ts +16 -0
  115. package/src/calls/media-stream-output.ts +32 -0
  116. package/src/calls/media-stream-server.ts +82 -30
  117. package/src/calls/media-stream-stt-session.ts +15 -0
  118. package/src/{live-voice → calls}/progress-narration.ts +2 -2
  119. package/src/calls/resolve-call-tts-provider.ts +33 -2
  120. package/src/calls/tts-call-strategy.ts +9 -5
  121. package/src/calls/types.ts +2 -0
  122. package/src/calls/voice-control-protocol.ts +53 -21
  123. package/src/calls/voice-leg-coordinator.ts +189 -0
  124. package/src/calls/voice-progress-cadence.ts +423 -0
  125. package/src/calls/voice-session-bridge.ts +59 -46
  126. package/src/calls/voice-triage-escalate.ts +175 -56
  127. package/src/cli/commands/__tests__/apps.test.ts +245 -0
  128. package/src/cli/commands/__tests__/roadmap.help.test.ts +19 -0
  129. package/src/cli/commands/apps.help.ts +67 -13
  130. package/src/cli/commands/apps.ts +183 -0
  131. package/src/cli/commands/channels/__tests__/send.test.ts +218 -0
  132. package/src/cli/commands/channels/index.help.ts +70 -2
  133. package/src/cli/commands/channels/index.ts +16 -3
  134. package/src/cli/commands/channels/send.ts +128 -0
  135. package/src/cli/commands/credentials.help.ts +6 -2
  136. package/src/cli/commands/credentials.ts +2 -2
  137. package/src/cli/commands/mcp.help.ts +8 -8
  138. package/src/cli/commands/mcp.ts +1 -1
  139. package/src/cli/commands/roadmap.help.ts +5 -1
  140. package/src/cli/commands/roadmap.ts +1 -1
  141. package/src/cli/lib/bundled-marketplace.json +103 -90
  142. package/src/config/__tests__/default-profile-catalog.test.ts +22 -0
  143. package/src/config/__tests__/memory-retrospective-schema.test.ts +15 -1
  144. package/src/config/__tests__/platform-identity.test.ts +117 -0
  145. package/src/config/__tests__/platform-rehydration.test.ts +93 -0
  146. package/src/config/acp-agent-write.ts +43 -0
  147. package/src/config/acp-defaults.test.ts +13 -3
  148. package/src/config/acp-defaults.ts +23 -6
  149. package/src/config/acp-schema.test.ts +81 -0
  150. package/src/config/acp-schema.ts +30 -2
  151. package/src/config/bundled-skills/acp/SKILL.md +22 -14
  152. package/src/config/bundled-skills/acp/TOOLS.json +5 -1
  153. package/src/config/bundled-skills/app-builder/SKILL.md +12 -9
  154. package/src/config/bundled-skills/app-builder/references/CUSTOM_ROUTES.md +1 -1
  155. package/src/config/bundled-skills/messaging/TOOLS.json +3 -3
  156. package/src/config/bundled-skills/messaging/tools/messaging-send.ts +67 -139
  157. package/src/config/bundled-skills/phone-calls/references/TRANSCRIPTS.md +1 -1
  158. package/src/config/bundled-skills/screen-annotation/SKILL.md +8 -1
  159. package/src/config/bundled-skills/screen-annotation/tools/screen-annotation.test.ts +4 -1
  160. package/src/config/bundled-skills/skill-management/TOOLS.json +2 -2
  161. package/src/config/default-profile-catalog.ts +1 -1
  162. package/src/config/env.ts +2 -2
  163. package/src/config/feature-flag-registry.json +8 -12
  164. package/src/config/memory-v3-gate.test.ts +31 -0
  165. package/src/config/memory-v3-gate.ts +20 -16
  166. package/src/config/platform-identity.ts +144 -0
  167. package/src/config/platform-rehydration.ts +75 -21
  168. package/src/config/schema.ts +2 -2
  169. package/src/config/schemas/__tests__/live-voice.test.ts +8 -158
  170. package/src/config/schemas/__tests__/voice.test.ts +148 -0
  171. package/src/config/schemas/calls.ts +1 -28
  172. package/src/config/schemas/live-voice.ts +1 -173
  173. package/src/config/schemas/mcp.ts +1 -1
  174. package/src/config/schemas/memory-retrospective.ts +10 -0
  175. package/src/config/schemas/skills.ts +0 -14
  176. package/src/config/schemas/voice.ts +150 -0
  177. package/src/credential-execution/process-manager.test.ts +18 -19
  178. package/src/daemon/__tests__/conversation-tool-setup.test.ts +66 -121
  179. package/src/daemon/__tests__/plugin-mcp-reconcile.test.ts +4 -1
  180. package/src/daemon/__tests__/skill-memory-refresh-mtime.test.ts +133 -0
  181. package/src/daemon/app-change-notify.ts +45 -0
  182. package/src/daemon/config-watcher.ts +13 -194
  183. package/src/daemon/conversation-process.ts +35 -64
  184. package/src/daemon/conversation-skill-tools.ts +13 -31
  185. package/src/daemon/conversation-store.ts +1 -1
  186. package/src/daemon/conversation-surfaces.ts +10 -8
  187. package/src/daemon/conversation-tool-setup.ts +37 -43
  188. package/src/daemon/conversation.ts +0 -3
  189. package/src/daemon/host-bash-proxy.ts +8 -12
  190. package/src/daemon/host-browser-proxy.ts +15 -1
  191. package/src/daemon/host-file-proxy.ts +8 -10
  192. package/src/daemon/host-transfer-proxy.ts +14 -18
  193. package/src/daemon/lifecycle.ts +0 -5
  194. package/src/daemon/mcp-reload-service.ts +5 -5
  195. package/src/daemon/message-types/sync.ts +1 -0
  196. package/src/daemon/providers-setup.ts +1 -1
  197. package/src/daemon/shutdown-handlers.ts +1 -9
  198. package/src/daemon/skill-memory-refresh.ts +64 -0
  199. package/src/daemon/tool-side-effects.ts +7 -18
  200. package/src/desktop/__tests__/fake-desktop.ts +119 -0
  201. package/src/desktop/desktop-chrome-policy.test.ts +71 -0
  202. package/src/desktop/desktop-chrome-policy.ts +42 -0
  203. package/src/desktop/desktop-dependencies.test.ts +102 -0
  204. package/src/desktop/desktop-dependencies.ts +306 -0
  205. package/src/desktop/desktop-feature.test.ts +18 -0
  206. package/src/desktop/desktop-feature.ts +19 -0
  207. package/src/desktop/desktop-panel-config.test.ts +135 -0
  208. package/src/desktop/desktop-panel-config.ts +149 -0
  209. package/src/desktop/desktop-session-manager.test.ts +627 -0
  210. package/src/desktop/desktop-session-manager.ts +814 -0
  211. package/src/desktop/desktop-stream-bridge.test.ts +395 -0
  212. package/src/desktop/desktop-stream-bridge.ts +214 -0
  213. package/src/desktop/desktop-wallpaper.test.ts +191 -0
  214. package/src/desktop/desktop-wallpaper.ts +113 -0
  215. package/src/desktop/desktop-window-theme.ts +170 -0
  216. package/src/hooks/types.ts +33 -0
  217. package/src/i18n/AGENTS.md +22 -0
  218. package/src/i18n/__tests__/i18n.test.ts +108 -0
  219. package/src/i18n/index.ts +16 -0
  220. package/src/i18n/locales.ts +93 -0
  221. package/src/i18n/messages.ts +61 -0
  222. package/src/i18n/title.ts +25 -0
  223. package/src/inbound/platform-callback-registration.ts +4 -5
  224. package/src/live-voice/__tests__/live-voice-metrics.test.ts +0 -3
  225. package/src/live-voice/__tests__/live-voice-progress.test.ts +15 -15
  226. package/src/live-voice/__tests__/live-voice-vad.test.ts +2 -2
  227. package/src/live-voice/__tests__/runtime-websocket-shell.test.ts +13 -69
  228. package/src/live-voice/live-voice-session.ts +213 -693
  229. package/src/live-voice/protocol.ts +0 -2
  230. package/src/mcp/__tests__/effective-config.test.ts +2 -2
  231. package/src/mcp/__tests__/workspace-mcp-config.test.ts +135 -0
  232. package/src/mcp/effective-config.ts +3 -3
  233. package/src/mcp/mcp-header-store.ts +29 -45
  234. package/src/mcp/spec-schema.ts +111 -0
  235. package/src/mcp/startup.ts +8 -4
  236. package/src/mcp/workspace-mcp-config.ts +188 -0
  237. package/src/messaging/provider.ts +10 -3
  238. package/src/messaging/providers/__tests__/proactive-address.test.ts +95 -0
  239. package/src/messaging/providers/callback-routing.ts +18 -0
  240. package/src/messaging/providers/channel-transport.ts +56 -0
  241. package/src/messaging/providers/discord/transport.ts +17 -0
  242. package/src/messaging/providers/slack/__tests__/adapter-token-routing.test.ts +6 -17
  243. package/src/messaging/providers/slack/adapter.ts +7 -44
  244. package/src/messaging/providers/slack/transport.ts +16 -0
  245. package/src/messaging/providers/telegram-bot/adapter.ts +1 -48
  246. package/src/messaging/providers/telegram-bot/client.ts +0 -26
  247. package/src/messaging/providers/telegram-bot/transport.ts +20 -0
  248. package/src/messaging/providers/whatsapp/adapter.ts +1 -48
  249. package/src/messaging/providers/whatsapp/transport.ts +18 -0
  250. package/src/monitoring/__tests__/workspace-git-heartbeat.test.ts +8 -0
  251. package/src/notifications/__tests__/assistant-reply-producer.test.ts +55 -0
  252. package/src/notifications/__tests__/home-feed-side-effect.test.ts +153 -3
  253. package/src/notifications/assistant-reply-producer.ts +8 -3
  254. package/src/notifications/conversation-pairing.ts +36 -16
  255. package/src/notifications/delivered-post-record.ts +11 -1
  256. package/src/notifications/home-feed-side-effect.ts +55 -7
  257. package/src/outbound-proxy/certs.ts +3 -5
  258. package/src/permissions/checker.test.ts +11 -6
  259. package/src/persistence/compaction-log-store-clickhouse.ts +3 -3
  260. package/src/persistence/conversation-crud.ts +71 -63
  261. package/src/persistence/conversation-lineage.ts +12 -4
  262. package/src/persistence/conversation-title-placeholders.ts +23 -0
  263. package/src/persistence/conversation-title-service.ts +9 -26
  264. package/src/persistence/llm-request-log-sink-clickhouse.ts +3 -3
  265. package/src/persistence/llm-request-log-source-clickhouse.ts +3 -3
  266. package/src/persistence/message-cursor.ts +78 -0
  267. package/src/persistence/message-reads.ts +30 -0
  268. package/src/persistence/migrations/157-invite-contact-id.ts +18 -6
  269. package/src/persistence/migrations/__tests__/157-invite-contact-id.test.ts +149 -0
  270. package/src/persistence/schema/memory-core.ts +5 -0
  271. package/src/platform/client.test.ts +2 -0
  272. package/src/platform/client.ts +2 -10
  273. package/src/plugin-api/constants.ts +2 -0
  274. package/src/plugin-api/index.ts +1 -0
  275. package/src/plugin-api/types.ts +2 -0
  276. package/src/plugins/defaults/index.ts +2 -0
  277. package/src/plugins/defaults/memory/__tests__/memory-retrospective-accounting.test.ts +46 -0
  278. package/src/plugins/defaults/memory/__tests__/memory-retrospective-cursor-backfill.test.ts +118 -0
  279. package/src/plugins/defaults/memory/__tests__/memory-retrospective-cursor-preserve.test.ts +83 -0
  280. package/src/plugins/defaults/memory/__tests__/memory-retrospective-enqueue.test.ts +9 -5
  281. package/src/plugins/defaults/memory/__tests__/memory-retrospective-job.test.ts +20 -10
  282. package/src/plugins/defaults/memory/__tests__/memory-retrospective-state.test.ts +219 -0
  283. package/src/plugins/defaults/memory/__tests__/memory-retrospective-sweep.test.ts +31 -0
  284. package/src/plugins/defaults/memory/__tests__/memory-retrospective-trigger-check.test.ts +63 -0
  285. package/src/plugins/defaults/memory/__tests__/shutdown-hook.test.ts +4 -0
  286. package/src/plugins/defaults/memory/graph/capability-seed.ts +4 -6
  287. package/src/plugins/defaults/memory/hooks/init.ts +10 -0
  288. package/src/plugins/defaults/memory/hooks/message-deleted.ts +21 -0
  289. package/src/plugins/defaults/memory/hooks/shutdown.ts +2 -0
  290. package/src/plugins/defaults/memory/jobs-worker.ts +13 -0
  291. package/src/plugins/defaults/memory/memory-retrospective-accounting.ts +34 -60
  292. package/src/plugins/defaults/memory/memory-retrospective-cursor-backfill.ts +126 -0
  293. package/src/plugins/defaults/memory/memory-retrospective-cursor-preserve.ts +79 -0
  294. package/src/plugins/defaults/memory/memory-retrospective-cursor.ts +28 -0
  295. package/src/plugins/defaults/memory/memory-retrospective-enqueue.ts +3 -5
  296. package/src/plugins/defaults/memory/memory-retrospective-job.ts +12 -3
  297. package/src/plugins/defaults/memory/memory-retrospective-state.ts +312 -71
  298. package/src/plugins/defaults/memory/memory-retrospective-sweep.ts +2 -1
  299. package/src/plugins/defaults/memory/memory-retrospective-trigger-check.ts +5 -3
  300. package/src/plugins/defaults/memory/skill-md-mtime-poll.ts +9 -0
  301. package/src/plugins/defaults/memory/startup.ts +6 -1
  302. package/src/plugins/defaults/memory/substrate/__tests__/skill-content.test.ts +7 -9
  303. package/src/plugins/defaults/memory/substrate/skill-content.ts +2 -2
  304. package/src/plugins/defaults/memory/v3/__tests__/pool-select.test.ts +89 -0
  305. package/src/plugins/defaults/memory/worker.ts +6 -0
  306. package/src/plugins/mcp-servers.ts +15 -75
  307. package/src/providers/__tests__/connection-model-compat.test.ts +3 -3
  308. package/src/providers/gemini/client.ts +9 -23
  309. package/src/providers/gemini-thought-signature.test.ts +63 -0
  310. package/src/providers/gemini-thought-signature.ts +44 -0
  311. package/src/providers/model-catalog.ts +34 -0
  312. package/src/providers/model-intents.ts +10 -5
  313. package/src/providers/openai/__tests__/chat-completions-provider-reasoning.test.ts +146 -18
  314. package/src/providers/openai/__tests__/chat-completions-provider-thought-signature.test.ts +613 -0
  315. package/src/providers/openai/__tests__/google-thought-signature.test.ts +235 -0
  316. package/src/providers/openai/__tests__/tool-choice-mapping.test.ts +83 -1
  317. package/src/providers/openai/chat-completions-provider.ts +192 -78
  318. package/src/providers/openai/codex-models.ts +0 -4
  319. package/src/providers/openai/google-thought-signature.ts +320 -0
  320. package/src/runtime/AGENTS.md +2 -0
  321. package/src/runtime/__tests__/channel-send.test.ts +443 -0
  322. package/src/runtime/__tests__/desktop-stream-upgrade.test.ts +89 -0
  323. package/src/runtime/__tests__/live-voice-upgrade.test.ts +58 -0
  324. package/src/runtime/__tests__/runtime-ws-test-utils.ts +72 -0
  325. package/src/runtime/__tests__/watch-stream-upgrade.test.ts +59 -0
  326. package/src/runtime/auth/same-actor.ts +38 -3
  327. package/src/runtime/channel-send.ts +316 -0
  328. package/src/runtime/http-server.ts +160 -151
  329. package/src/runtime/routes/__tests__/acp-routes.test.ts +159 -4
  330. package/src/runtime/routes/__tests__/apps-refresh-route.test.ts +205 -0
  331. package/src/runtime/routes/__tests__/channel-send-routes.test.ts +127 -0
  332. package/src/runtime/routes/__tests__/conversation-query-routes.test.ts +108 -1
  333. package/src/runtime/routes/__tests__/dictation-cleanup-guard.test.ts +107 -0
  334. package/src/runtime/routes/__tests__/mcp-add-default-risk.test.ts +16 -12
  335. package/src/runtime/routes/acp-routes.test.ts +15 -0
  336. package/src/runtime/routes/acp-routes.ts +72 -9
  337. package/src/runtime/routes/app-management-routes.ts +73 -0
  338. package/src/runtime/routes/app-routes.ts +1 -1
  339. package/src/runtime/routes/channel-send-routes.ts +85 -0
  340. package/src/runtime/routes/conversation-list-routes.ts +14 -3
  341. package/src/runtime/routes/conversation-query-routes.ts +40 -0
  342. package/src/runtime/routes/credential-routes.ts +19 -10
  343. package/src/runtime/routes/desktop-setup-routes.test.ts +74 -0
  344. package/src/runtime/routes/desktop-setup-routes.ts +35 -0
  345. package/src/runtime/routes/diagnostics-routes.ts +55 -3
  346. package/src/runtime/routes/index.ts +4 -0
  347. package/src/runtime/routes/log-export-routes.ts +2 -0
  348. package/src/runtime/routes/mcp-auth-routes.ts +39 -47
  349. package/src/runtime/routes/migration-routes.ts +8 -21
  350. package/src/runtime/routes/platform-routes.ts +18 -15
  351. package/src/runtime/services/__tests__/conversation-serializer.test.ts +28 -0
  352. package/src/runtime/services/conversation-serializer.ts +16 -3
  353. package/src/runtime/sync/resource-sync-events.ts +2 -1
  354. package/src/schedule/worker.ts +1 -1
  355. package/src/security/__tests__/ces-http-record-backend.test.ts +137 -0
  356. package/src/security/ces-http-record-backend.ts +120 -0
  357. package/src/security/ces-rpc-record-backend.ts +7 -0
  358. package/src/skills/__tests__/workspace-skill-md-signature.test.ts +60 -0
  359. package/src/skills/workspace-skill-md-signature.ts +50 -0
  360. package/src/subagent/consult-context.ts +12 -25
  361. package/src/tools/acp/list-agents.test.ts +3 -1
  362. package/src/tools/acp/spawn.test.ts +146 -11
  363. package/src/tools/acp/spawn.ts +21 -3
  364. package/src/tools/acp/status.test.ts +94 -0
  365. package/src/tools/acp/status.ts +40 -3
  366. package/src/tools/app-control/skill-proxy-bridge.ts +2 -1
  367. package/src/tools/capability-offer.test.ts +22 -2
  368. package/src/tools/capability-offer.ts +16 -1
  369. package/src/tools/computer-use/definitions.ts +4 -2
  370. package/src/tools/computer-use/skill-proxy-bridge.ts +2 -1
  371. package/src/tools/credentials/metadata-store.ts +100 -0
  372. package/src/tools/host-filesystem/edit.test.ts +2 -1
  373. package/src/tools/host-filesystem/edit.ts +2 -2
  374. package/src/tools/host-filesystem/read.test.ts +2 -1
  375. package/src/tools/host-filesystem/read.ts +2 -2
  376. package/src/tools/host-filesystem/transfer.test.ts +2 -1
  377. package/src/tools/host-filesystem/transfer.ts +2 -2
  378. package/src/tools/host-filesystem/write.test.ts +2 -1
  379. package/src/tools/host-filesystem/write.ts +2 -2
  380. package/src/tools/host-terminal/host-shell.test.ts +16 -0
  381. package/src/tools/host-terminal/host-shell.ts +4 -20
  382. package/src/tools/policy-context.ts +6 -7
  383. package/src/tools/subagent/spawn.ts +5 -8
  384. package/src/tools/terminal/__tests__/safe-env.test.ts +6 -6
  385. package/src/tools/terminal/safe-env.ts +23 -3
  386. package/src/tools/watch/watch-retro-report.ts +0 -8
  387. package/src/util/__tests__/language-subtag.test.ts +23 -1
  388. package/src/util/ca-bundle.ts +13 -0
  389. package/src/util/language-subtag.ts +16 -0
  390. package/src/util/platform.ts +8 -0
  391. package/src/workspace/git-porcelain.ts +66 -0
  392. package/src/workspace/git-service.ts +5 -54
  393. package/src/workspace/migrations/154-repair-retired-codex-gpt-5-4-model-ids.ts +258 -0
  394. package/src/workspace/migrations/155-move-front-model-config-to-voice.ts +78 -0
  395. package/src/workspace/migrations/156-extract-workspace-mcp-json.ts +214 -0
  396. package/src/workspace/migrations/__tests__/155-move-front-model-config-to-voice.test.ts +102 -0
  397. package/src/workspace/migrations/__tests__/156-extract-workspace-mcp-json.test.ts +199 -0
  398. package/src/workspace/migrations/registry.ts +6 -0
  399. package/src/__tests__/app-source-watcher.test.ts +0 -218
  400. package/src/__tests__/config-watcher-skill-reseed.test.ts +0 -359
  401. package/src/__tests__/speaker-identification.test.ts +0 -56
  402. package/src/calls/speaker-identification.ts +0 -233
  403. package/src/daemon/app-source-watcher.ts +0 -218
  404. package/src/messaging/providers/whatsapp/client.ts +0 -29
  405. package/src/util/fs-watcher-error.ts +0 -36
  406. /package/src/{live-voice → calls}/progress-phrases.ts +0 -0
@@ -1,9 +1,9 @@
1
1
  import { getConfig } from "../config/loader.js";
2
2
  import { assistantEventHub } from "../runtime/assistant-event-hub.js";
3
3
  import {
4
- ambiguousSameUserError,
5
4
  enforceSameActorOrErrorResult,
6
- pickSameUserAutoResolve,
5
+ pickMostRecentSameUserClient,
6
+ unavailableSameUserClientError,
7
7
  } from "../runtime/auth/same-actor.js";
8
8
  import * as pendingInteractions from "../runtime/pending-interactions.js";
9
9
  import { formatShellOutput } from "../tools/shared/shell-output.js";
@@ -93,21 +93,17 @@ export class HostBashProxy extends HostProxyBase<
93
93
  }
94
94
  resolvedTargetClientId = input.targetClientId;
95
95
  } else {
96
- // Auto-resolve to the unique same-user client. Reject (rather than
97
- // broadcast) when multiple same-user clients are connected so that
98
- // a single targeted-style request cannot fan out across every one
99
- // of the user's machines. Zero same-user matches falls through to
100
- // the existing untargeted code path.
101
- const resolved = pickSameUserAutoResolve({
96
+ resolvedTargetClientId = pickMostRecentSameUserClient({
102
97
  hub: assistantEventHub,
103
98
  capability: "host_bash",
104
99
  sourceActorPrincipalId,
105
100
  });
106
- if (resolved.kind === "ambiguous") {
107
- return ambiguousSameUserError("host_bash");
101
+ if (
102
+ resolvedTargetClientId === undefined &&
103
+ sourceActorPrincipalId !== undefined
104
+ ) {
105
+ return unavailableSameUserClientError("host_bash");
108
106
  }
109
- resolvedTargetClientId =
110
- resolved.kind === "match" ? resolved.clientId : undefined;
111
107
  }
112
108
 
113
109
  // Targeted requests must be bound to the same authenticated user as the
@@ -5,7 +5,10 @@ import {
5
5
  assistantEventHub,
6
6
  broadcastMessage,
7
7
  } from "../runtime/assistant-event-hub.js";
8
- import { enforceSameActorOrErrorResult } from "../runtime/auth/same-actor.js";
8
+ import {
9
+ enforceSameActorOrErrorResult,
10
+ unavailableSameUserClientError,
11
+ } from "../runtime/auth/same-actor.js";
9
12
  import * as pendingInteractions from "../runtime/pending-interactions.js";
10
13
  import type { ToolExecutionResult } from "../tools/types.js";
11
14
  import { AssistantError, ErrorCode } from "../util/errors.js";
@@ -284,6 +287,17 @@ export class HostBrowserProxy {
284
287
  targetClientId,
285
288
  );
286
289
 
290
+ if (
291
+ preferredClient === undefined &&
292
+ sourceActorPrincipalId !== undefined &&
293
+ targetClientId === undefined
294
+ ) {
295
+ if (isExtensionOnlyMethod(input.cdpMethod)) {
296
+ return Promise.resolve(extensionRequiredResult(input.cdpMethod));
297
+ }
298
+ return Promise.resolve(unavailableSameUserClientError("host_browser"));
299
+ }
300
+
287
301
  // Same-user enforcement: when the caller's actor is known, refuse to
288
302
  // dispatch to a client owned by a different actor. This covers the
289
303
  // cross-client exposure case where a web/iOS turn for actor A would
@@ -6,10 +6,10 @@ import {
6
6
  broadcastMessage,
7
7
  } from "../runtime/assistant-event-hub.js";
8
8
  import {
9
- ambiguousSameUserError,
10
9
  enforceSameActorOrErrorResult,
11
- pickSameUserAutoResolve,
10
+ pickMostRecentSameUserClient,
12
11
  snapshotHostProxyActorPrincipalId,
12
+ unavailableSameUserClientError,
13
13
  } from "../runtime/auth/same-actor.js";
14
14
  import * as pendingInteractions from "../runtime/pending-interactions.js";
15
15
  import { readAudioBase64 } from "../tools/shared/filesystem/audio-read.js";
@@ -102,19 +102,17 @@ export class HostFileProxy {
102
102
  });
103
103
  }
104
104
  } else {
105
- // Auto-resolve to the unique same-user client. Reject ambiguous
106
- // (multi-machine) cases so a single targeted-style request cannot
107
- // fan out across the user's machines.
108
- const resolved = pickSameUserAutoResolve({
105
+ resolvedTargetClientId = pickMostRecentSameUserClient({
109
106
  hub: assistantEventHub,
110
107
  capability: "host_file",
111
108
  sourceActorPrincipalId,
112
109
  });
113
- if (resolved.kind === "ambiguous") {
114
- return Promise.resolve(ambiguousSameUserError("host_file"));
110
+ if (
111
+ resolvedTargetClientId === undefined &&
112
+ sourceActorPrincipalId !== undefined
113
+ ) {
114
+ return Promise.resolve(unavailableSameUserClientError("host_file"));
115
115
  }
116
- resolvedTargetClientId =
117
- resolved.kind === "match" ? resolved.clientId : undefined;
118
116
  }
119
117
 
120
118
  // Same-user check: targeted host_file requests must be bound to the same
@@ -10,10 +10,10 @@ import {
10
10
  broadcastMessage,
11
11
  } from "../runtime/assistant-event-hub.js";
12
12
  import {
13
- ambiguousSameUserError,
14
13
  enforceSameActorOrErrorResult,
15
- pickSameUserAutoResolve,
14
+ pickMostRecentSameUserClient,
16
15
  snapshotHostProxyActorPrincipalId,
16
+ unavailableSameUserClientError,
17
17
  } from "../runtime/auth/same-actor.js";
18
18
  import * as pendingInteractions from "../runtime/pending-interactions.js";
19
19
  import type { ToolExecutionResult } from "../tools/types.js";
@@ -162,19 +162,17 @@ export class HostTransferProxy {
162
162
  });
163
163
  }
164
164
  } else {
165
- // Auto-resolve to the unique same-user client; reject ambiguous
166
- // (multi-machine) cases so a single targeted-style transfer cannot
167
- // fan out across the user's machines.
168
- const resolved = pickSameUserAutoResolve({
165
+ resolvedTargetClientId = pickMostRecentSameUserClient({
169
166
  hub: assistantEventHub,
170
167
  capability: "host_file",
171
168
  sourceActorPrincipalId,
172
169
  });
173
- if (resolved.kind === "ambiguous") {
174
- return Promise.resolve(ambiguousSameUserError("host_file"));
170
+ if (
171
+ resolvedTargetClientId === undefined &&
172
+ sourceActorPrincipalId !== undefined
173
+ ) {
174
+ return Promise.resolve(unavailableSameUserClientError("host_file"));
175
175
  }
176
- resolvedTargetClientId =
177
- resolved.kind === "match" ? resolved.clientId : undefined;
178
176
  }
179
177
 
180
178
  if (resolvedTargetClientId != null) {
@@ -364,19 +362,17 @@ export class HostTransferProxy {
364
362
  });
365
363
  }
366
364
  } else {
367
- // Auto-resolve to the unique same-user client; reject ambiguous
368
- // (multi-machine) cases so a single targeted-style transfer cannot
369
- // fan out across the user's machines.
370
- const resolved = pickSameUserAutoResolve({
365
+ resolvedTargetClientId = pickMostRecentSameUserClient({
371
366
  hub: assistantEventHub,
372
367
  capability: "host_file",
373
368
  sourceActorPrincipalId,
374
369
  });
375
- if (resolved.kind === "ambiguous") {
376
- return Promise.resolve(ambiguousSameUserError("host_file"));
370
+ if (
371
+ resolvedTargetClientId === undefined &&
372
+ sourceActorPrincipalId !== undefined
373
+ ) {
374
+ return Promise.resolve(unavailableSameUserClientError("host_file"));
377
375
  }
378
- resolvedTargetClientId =
379
- resolved.kind === "match" ? resolved.clientId : undefined;
380
376
  }
381
377
 
382
378
  if (resolvedTargetClientId != null) {
@@ -71,7 +71,6 @@ import { ensureCompleteCustomProfiles } from "../workspace/custom-profile-ensure
71
71
  import { ensureDefaultProvider } from "../workspace/default-provider-ensure.js";
72
72
  import { WORKSPACE_MIGRATIONS } from "../workspace/migrations/registry.js";
73
73
  import { runWorkspaceMigrations } from "../workspace/migrations/runner.js";
74
- import { startAppSourceWatcher } from "./app-source-watcher.js";
75
74
  import { startConfigWatcher } from "./config-watcher.js";
76
75
  import { startConversationEvictor } from "./conversation-evictor.js";
77
76
  import { writePid } from "./daemon-control.js";
@@ -706,10 +705,6 @@ export async function runDaemon(): Promise<void> {
706
705
  // config, and broadcast the relevant resource-changed events to clients.
707
706
  startConfigWatcher();
708
707
 
709
- // Watch app source directories so edits recompile + refresh surfaces across
710
- // all conversations.
711
- startAppSourceWatcher();
712
-
713
708
  // Start the CLI IPC server. Throws on EADDRINUSE to abort startup when another
714
709
  // daemon already holds the socket, so this process never runs background jobs
715
710
  // against the shared database as an unmanageable duplicate.
@@ -1,11 +1,11 @@
1
1
  /**
2
2
  * Shared MCP reload business logic.
3
3
  *
4
- * Called by the ConfigWatcher when config.json changes or a reload signal
4
+ * Called by the ConfigWatcher when mcp.json changes or a reload signal
5
5
  * file is detected, so the daemon automatically reconnects MCP servers.
6
6
  */
7
7
 
8
- import { getConfig, invalidateConfigCache } from "../config/loader.js";
8
+ import { invalidateConfigCache } from "../config/loader.js";
9
9
  import {
10
10
  buildEffectiveMcpConfig,
11
11
  pluginMcpServersChangedSinceLastBuild,
@@ -13,6 +13,7 @@ import {
13
13
  import { getMcpServerManager } from "../mcp/manager.js";
14
14
  import { migrateLegacyMcpHeaders } from "../mcp/mcp-header-store.js";
15
15
  import { signalMcpReloaded } from "../mcp/reload-signal.js";
16
+ import { loadWorkspaceMcpConfig } from "../mcp/workspace-mcp-config.js";
16
17
  import { createMcpToolsFromServer } from "../tools/mcp/mcp-tool-factory.js";
17
18
  import { registerMcpTools, unregisterAllMcpTools } from "../tools/registry.js";
18
19
  import { getLogger } from "../util/logger.js";
@@ -95,16 +96,15 @@ async function doReload(): Promise<McpReloadResult> {
95
96
  // If the config is broken we abort early, preserving the current
96
97
  // working MCP setup instead of leaving zero servers.
97
98
  invalidateConfigCache();
98
- const config = getConfig();
99
99
 
100
100
  // 2. Stop existing MCP servers + unregister their tools
101
101
  await manager.stop();
102
102
  unregisterAllMcpTools();
103
103
 
104
104
  // Plugins are re-read here too: installing or removing one changes the
105
- // server set exactly like editing config.json does, and both arrive
105
+ // server set exactly like editing mcp.json does, and both arrive
106
106
  // through this same reload.
107
- const mcpConfig = buildEffectiveMcpConfig(config.mcp);
107
+ const mcpConfig = buildEffectiveMcpConfig(loadWorkspaceMcpConfig());
108
108
  const serverIds = Object.keys(mcpConfig.servers);
109
109
 
110
110
  // 3. Restart MCP servers
@@ -13,6 +13,7 @@ export const SYNC_TAGS = {
13
13
  assistantConfig: "assistant:self:config",
14
14
  assistantSounds: "assistant:self:sounds",
15
15
  assistantSchedules: "assistant:self:schedules",
16
+ assistantDesktop: "assistant:self:desktop",
16
17
  assistantTheme: "assistant:self:theme",
17
18
  appsList: "apps:list",
18
19
  documentsList: "documents:list",
@@ -63,7 +63,7 @@ export async function initializeProvidersAndTools(
63
63
  // Start MCP servers — workspace-configured and plugin-declared alike —
64
64
  // and register their tools. Shared with the schedule worker, which hosts
65
65
  // agent turns in its own process and so needs its own connections.
66
- await startConfiguredMcpServers(config.mcp);
66
+ await startConfiguredMcpServers();
67
67
 
68
68
  log.info("Daemon startup: providers and tools initialized");
69
69
  }
@@ -24,11 +24,7 @@ import { browserManager } from "../tools/browser/browser-manager.js";
24
24
  import { getLogger } from "../util/logger.js";
25
25
  import { APP_VERSION } from "../version.js";
26
26
  import { getEnrichmentService } from "../workspace/commit-message-enrichment-service.js";
27
- import {
28
- commitAllPendingWorkspaceChanges,
29
- stopWorkspaceHeartbeatService,
30
- } from "../workspace/heartbeat-service.js";
31
- import { stopAppSourceWatcher } from "./app-source-watcher.js";
27
+ import { commitAllPendingWorkspaceChanges } from "../workspace/heartbeat-service.js";
32
28
  import { stopConfigWatcher } from "./config-watcher.js";
33
29
  import { stopConversationEvictor } from "./conversation-evictor.js";
34
30
  import { stopConversations } from "./conversation-store.js";
@@ -98,9 +94,6 @@ async function shutdown(): Promise<void> {
98
94
  }, 30_000);
99
95
  forceTimer.unref();
100
96
 
101
- // Workspace git heartbeat timer lives in the monitor process. This
102
- // in-process stop is a no-op unless the singleton was started here.
103
- await stopWorkspaceHeartbeatService();
104
97
  await stopHeartbeatService();
105
98
 
106
99
  // Stop the periodic consent-cache refresh (a daemon-owned interval).
@@ -134,7 +127,6 @@ async function shutdown(): Promise<void> {
134
127
  disposeAcpSessionManager();
135
128
  stopConversationEvictor();
136
129
  stopConfigWatcher();
137
- stopAppSourceWatcher();
138
130
  stopCliIpcServer();
139
131
  stopConversations();
140
132
  await stopCes();
@@ -8,16 +8,24 @@ import {
8
8
  maybeSeedCapabilitySkills,
9
9
  maybeSeedCliCommandCards,
10
10
  } from "../plugins/defaults/memory/substrate/boot-maintenance.js";
11
+ import { readWorkspaceSkillMdSignature } from "../skills/workspace-skill-md-signature.js";
11
12
  import { getLogger } from "../util/logger.js";
12
13
 
13
14
  const log = getLogger("skill-memory-refresh");
14
15
 
16
+ /** Poll interval for workspace `SKILL.md` mtimes. Stats only, no tree walk. */
17
+ export const SKILL_MD_MTIME_POLL_MS = 1_500;
18
+
19
+ let lastSignature: string | undefined;
20
+ let pollTimer: ReturnType<typeof setInterval> | undefined;
21
+
15
22
  export function refreshSkillCapabilityMemories(
16
23
  config: AssistantConfig = getConfig(),
17
24
  ): void {
18
25
  seedSkillGraphNodes();
19
26
  maybeSeedCapabilitySkills(config);
20
27
  maybeSeedCliCommandCards(config);
28
+ lastSignature = readWorkspaceSkillMdSignature();
21
29
  void seedUninstalledCatalogSkillMemories()
22
30
  .then(() => {
23
31
  // Re-run after the async catalog fetch populates the cache so stale
@@ -31,3 +39,59 @@ export function refreshSkillCapabilityMemories(
31
39
  ),
32
40
  );
33
41
  }
42
+
43
+ /**
44
+ * Reseed skill capability memories when the workspace `SKILL.md` set or
45
+ * mtimes have changed since the last refresh in this process. No-op when the
46
+ * signature is unchanged. First call in a process always reseeds so the
47
+ * memory worker, whose in-process skill cache starts empty, picks up the
48
+ * catalog without waiting for an install path.
49
+ */
50
+ export function maybeRefreshSkillCapabilityMemoriesFromMtime(): boolean {
51
+ const signature = readWorkspaceSkillMdSignature();
52
+ if (lastSignature !== undefined && signature === lastSignature) {
53
+ return false;
54
+ }
55
+ if (lastSignature !== undefined) {
56
+ log.info("Workspace SKILL.md set changed, reseeding capability memories");
57
+ }
58
+ refreshSkillCapabilityMemories();
59
+ return true;
60
+ }
61
+
62
+ function pollOnce(): void {
63
+ try {
64
+ maybeRefreshSkillCapabilityMemoriesFromMtime();
65
+ } catch (err) {
66
+ log.warn({ err }, "SKILL.md mtime poll failed");
67
+ }
68
+ }
69
+
70
+ /**
71
+ * Start a per-process poll of workspace `SKILL.md` mtimes. Idempotent.
72
+ * The memory worker and the assistant each run this against their own
73
+ * in-process skill caches. Runs once immediately so a worker that has never
74
+ * seeded picks up the catalog without waiting a tick.
75
+ */
76
+ export function startWorkspaceSkillMdMtimePoll(): void {
77
+ if (pollTimer !== undefined) {
78
+ return;
79
+ }
80
+ pollOnce();
81
+ pollTimer = setInterval(pollOnce, SKILL_MD_MTIME_POLL_MS);
82
+ pollTimer.unref?.();
83
+ }
84
+
85
+ export function stopWorkspaceSkillMdMtimePoll(): void {
86
+ if (pollTimer === undefined) {
87
+ return;
88
+ }
89
+ clearInterval(pollTimer);
90
+ pollTimer = undefined;
91
+ }
92
+
93
+ /** @internal Test-only: clear the in-process signature and poll timer. */
94
+ export function _resetSkillMdMtimeStateForTests(): void {
95
+ lastSignature = undefined;
96
+ stopWorkspaceSkillMdMtimePoll();
97
+ }
@@ -18,17 +18,15 @@ import { invalidateEdgeIndex } from "../plugins/defaults/memory/substrate/edge-i
18
18
  import { invalidatePageIndex } from "../plugins/defaults/memory/substrate/page-index.js";
19
19
  import { getConceptsDir } from "../plugins/defaults/memory/substrate/page-store.js";
20
20
  import { broadcastMessage } from "../runtime/assistant-event-hub.js";
21
- import {
22
- publishAppsChanged,
23
- publishDocumentsChanged,
24
- } from "../runtime/sync/resource-sync-events.js";
25
- import { updatePublishedAppDeployment } from "../services/published-app-updater.js";
21
+ import { publishDocumentsChanged } from "../runtime/sync/resource-sync-events.js";
26
22
  import type { ToolExecutionResult } from "../tools/types.js";
27
23
  import { getLogger } from "../util/logger.js";
28
24
  import { getWorkspaceDir } from "../util/platform.js";
29
- import { ensureAppSourceWatcher } from "./app-source-watcher.js";
25
+ import {
26
+ broadcastAppFilesChanged,
27
+ notifyAppSurfacesChanged,
28
+ } from "./app-change-notify.js";
30
29
  import type { Conversation } from "./conversation.js";
31
- import { refreshSurfacesForApp } from "./conversation-surfaces.js";
32
30
  import { isDoordashCommand, updateDoordashProgress } from "./doordash-steps.js";
33
31
 
34
32
  const log = getLogger("tool-side-effects");
@@ -54,7 +52,7 @@ export type PostExecutionHook = (
54
52
  * Compilation is the responsibility of the tool executor (see
55
53
  * `executeAppCreate`, `executeAppRefresh`): executors own the source→dist
56
54
  * transform and surface `compile_errors` in their result when it fails.
57
- * Post-execution hooks only observe the outcome and notify — they must
55
+ * Post-execution hooks only observe the outcome and notify. They must
58
56
  * not re-run a compile because `compileApp()` begins with `rm -rf dist/`
59
57
  * and would race with the executor's own output (LUM-1153).
60
58
  */
@@ -63,14 +61,7 @@ function notifyAppChanged(
63
61
  appId: string,
64
62
  opts?: { fileChange?: boolean; status?: string },
65
63
  ): void {
66
- refreshSurfacesForApp(ctx, appId, opts);
67
- broadcastAppFilesChanged(appId);
68
- void updatePublishedAppDeployment(appId);
69
- }
70
-
71
- function broadcastAppFilesChanged(appId: string): void {
72
- broadcastMessage({ type: "app_files_changed", appId });
73
- publishAppsChanged();
64
+ notifyAppSurfacesChanged(appId, opts, ctx);
74
65
  }
75
66
 
76
67
  /**
@@ -128,8 +119,6 @@ registerHook("app_create", (_name, _input, result, { ctx }) => {
128
119
  log.warn({ err, appId }, "Failed to track conversation ID on app_create");
129
120
  }
130
121
 
131
- ensureAppSourceWatcher();
132
-
133
122
  notifyAppChanged(ctx, appId);
134
123
 
135
124
  // Seed background icon generation from the created app's canonical record
@@ -0,0 +1,119 @@
1
+ import { join } from "node:path";
2
+
3
+ import { sleep } from "../../util/retry.js";
4
+ import {
5
+ type DesktopChild,
6
+ type DesktopChildRole,
7
+ type DesktopLoss,
8
+ DesktopSessionManager,
9
+ type DesktopSpawnRequest,
10
+ } from "../desktop-session-manager.js";
11
+
12
+ /** A child the test exits by hand. */
13
+ class FakeChild implements DesktopChild {
14
+ private static nextPid = 1000;
15
+ readonly pid = FakeChild.nextPid++;
16
+ readonly exited: Promise<number>;
17
+ private settle!: (code: number) => void;
18
+
19
+ constructor(
20
+ readonly role: DesktopChildRole,
21
+ readonly request: DesktopSpawnRequest,
22
+ ) {
23
+ this.exited = new Promise((resolve) => {
24
+ this.settle = resolve;
25
+ });
26
+ }
27
+
28
+ kill(): void {}
29
+
30
+ exit(code = 0): void {
31
+ this.settle(code);
32
+ }
33
+ }
34
+
35
+ export const LINGER_MS = 20;
36
+ export const KILL_GRACE_MS = 20;
37
+
38
+ export interface FakeDesktopOptions {
39
+ profileDir: string;
40
+ /** Defaults inside `profileDir`, for tests that ignore the dock's config. */
41
+ panelConfigDir?: string;
42
+ /** Roles whose spawn throws, to exercise a start that fails partway. */
43
+ failSpawn?: DesktopChildRole[];
44
+ /** Binaries `which` cannot find. */
45
+ missingBinaries?: string[];
46
+ /** Whether a SIGTERM makes the fake child exit on its own. */
47
+ exitOnTerm?: boolean;
48
+ /** Whether a SIGKILL does; without either the child survives both. */
49
+ exitOnKill?: boolean;
50
+ sourceEnv?: NodeJS.ProcessEnv;
51
+ renderWallpaper?: (width: number, height: number) => Promise<Buffer | null>;
52
+ }
53
+
54
+ export function newFakeDesktop(options: FakeDesktopOptions) {
55
+ const spawned: FakeChild[] = [];
56
+ const killed: { child: FakeChild; signal: string }[] = [];
57
+ let vncReady = true;
58
+ let chromiumPath: () => Promise<string> = async () => "/fake/chromium";
59
+ const manager = new DesktopSessionManager({
60
+ spawn: (role, request) => {
61
+ if (options.failSpawn?.includes(role)) {
62
+ throw new Error(`spawn ${role} failed`);
63
+ }
64
+ const child = new FakeChild(role, request);
65
+ spawned.push(child);
66
+ return child;
67
+ },
68
+ which: (binary) =>
69
+ options.missingBinaries?.includes(binary) ? null : `/usr/bin/${binary}`,
70
+ probeVncPort: async () => vncReady,
71
+ resolveChromePath: () => chromiumPath(),
72
+ renderWallpaper: options.renderWallpaper ?? (async () => null),
73
+ killProcessGroup: (child, signal) => {
74
+ killed.push({ child: child as FakeChild, signal });
75
+ const exits =
76
+ signal === "SIGTERM" ? options.exitOnTerm : options.exitOnKill;
77
+ if (exits) {
78
+ (child as FakeChild).exit(0);
79
+ }
80
+ },
81
+ lingerMs: LINGER_MS,
82
+ readyDeadlineMs: 30,
83
+ killGraceMs: KILL_GRACE_MS,
84
+ profileDir: options.profileDir,
85
+ panelConfigDir:
86
+ options.panelConfigDir ?? join(options.profileDir, "desktop-panel"),
87
+ sourceEnv: options.sourceEnv,
88
+ });
89
+ return {
90
+ manager,
91
+ spawned,
92
+ killed,
93
+ /** Children that got a SIGTERM, in order. */
94
+ terminated: () =>
95
+ killed.filter((k) => k.signal === "SIGTERM").map((k) => k.child),
96
+ setVncReady: (ready: boolean) => {
97
+ vncReady = ready;
98
+ },
99
+ setChromiumPath: (resolve: () => Promise<string>) => {
100
+ chromiumPath = resolve;
101
+ },
102
+ child: (role: DesktopChildRole) =>
103
+ spawned.filter((c) => c.role === role).at(-1)!,
104
+ roles: () => spawned.map((c) => c.role),
105
+ count: (role: DesktopChildRole) =>
106
+ spawned.filter((c) => c.role === role).length,
107
+ };
108
+ }
109
+
110
+ /** Let one awaited step (a path resolution, an exit callback) land. */
111
+ export const settle = (): Promise<void> => sleep(0);
112
+
113
+ export function newViewer() {
114
+ const lost: DesktopLoss[] = [];
115
+ return {
116
+ lost,
117
+ viewer: { onDesktopLost: (loss: DesktopLoss) => lost.push(loss) },
118
+ };
119
+ }
@@ -0,0 +1,71 @@
1
+ import {
2
+ mkdtempSync,
3
+ readdirSync,
4
+ readFileSync,
5
+ rmSync,
6
+ statSync,
7
+ writeFileSync,
8
+ } from "node:fs";
9
+ import { tmpdir } from "node:os";
10
+ import { join } from "node:path";
11
+ import { afterEach, expect, test } from "bun:test";
12
+
13
+ import { writeDesktopChromePolicy } from "./desktop-chrome-policy.js";
14
+
15
+ const directories: string[] = [];
16
+ function policyDirectory(): string {
17
+ const path = mkdtempSync(join(tmpdir(), "desktop-chrome-policy-"));
18
+ directories.push(path);
19
+ return path;
20
+ }
21
+
22
+ afterEach(() => {
23
+ for (const path of directories.splice(0)) {
24
+ rmSync(path, { recursive: true, force: true });
25
+ }
26
+ });
27
+
28
+ test("preserves unrelated policies and does not rewrite on repeated startup", () => {
29
+ const directory = policyDirectory();
30
+ const path = join(directory, "vellum-desktop.json");
31
+ const otherPath = join(directory, "organization.json");
32
+ const unrelated = '{ "HomepageLocation": "https://example.com" }\n';
33
+ writeFileSync(otherPath, unrelated);
34
+ writeFileSync(path, JSON.stringify({ DownloadRestrictions: 1 }));
35
+
36
+ writeDesktopChromePolicy(directory);
37
+ const content = readFileSync(path, "utf8");
38
+ expect(JSON.parse(content).DownloadRestrictions).toBe(1);
39
+ expect(readFileSync(otherPath, "utf8")).toBe(unrelated);
40
+ expect(readdirSync(directory).sort()).toEqual([
41
+ "organization.json",
42
+ "vellum-desktop.json",
43
+ ]);
44
+
45
+ const before = statSync(path);
46
+ writeDesktopChromePolicy(directory);
47
+ expect(readFileSync(path, "utf8")).toBe(content);
48
+ expect(statSync(path).ino).toBe(before.ino);
49
+ expect(statSync(path).mtimeMs).toBe(before.mtimeMs);
50
+ });
51
+
52
+ test("creates missing policy directories for a fresh desktop", () => {
53
+ const directory = join(policyDirectory(), "policies", "managed");
54
+ writeDesktopChromePolicy(directory);
55
+ expect(readdirSync(directory)).toEqual(["vellum-desktop.json"]);
56
+ expect(statSync(join(directory, "vellum-desktop.json")).mode & 0o777).toBe(
57
+ 0o644,
58
+ );
59
+ });
60
+
61
+ test.each(["{broken", "[]", "null", "false"])(
62
+ "leaves invalid existing policy content untouched: %s",
63
+ (content) => {
64
+ const directory = policyDirectory();
65
+ const path = join(directory, "vellum-desktop.json");
66
+ writeFileSync(path, content);
67
+ expect(() => writeDesktopChromePolicy(directory)).toThrow();
68
+ expect(readFileSync(path, "utf8")).toBe(content);
69
+ expect(readdirSync(directory)).toEqual(["vellum-desktop.json"]);
70
+ },
71
+ );
@@ -0,0 +1,42 @@
1
+ import {
2
+ mkdirSync,
3
+ mkdtempSync,
4
+ readFileSync,
5
+ renameSync,
6
+ rmSync,
7
+ writeFileSync,
8
+ } from "node:fs";
9
+ import { join } from "node:path";
10
+
11
+ export function writeDesktopChromePolicy(policyDir: string): void {
12
+ const path = join(policyDir, "vellum-desktop.json");
13
+ let policy: Record<string, unknown> = {};
14
+ try {
15
+ const value: unknown = JSON.parse(readFileSync(path, "utf8"));
16
+ if (!value || typeof value !== "object" || Array.isArray(value)) {
17
+ throw new Error("Desktop Chrome policy must be a JSON object");
18
+ }
19
+ policy = value as Record<string, unknown>;
20
+ } catch (err) {
21
+ if ((err as NodeJS.ErrnoException).code !== "ENOENT") {
22
+ throw err;
23
+ }
24
+ }
25
+ if (policy.CommandLineFlagSecurityWarningsEnabled === false) {
26
+ return;
27
+ }
28
+
29
+ // This suppresses command-line warnings; Chrome's sandbox stays unchanged.
30
+ policy.CommandLineFlagSecurityWarningsEnabled = false;
31
+ mkdirSync(policyDir, { recursive: true });
32
+ const staging = mkdtempSync(join(policyDir, ".vellum-desktop-"));
33
+ try {
34
+ const temporaryPath = join(staging, "policy.json");
35
+ writeFileSync(temporaryPath, JSON.stringify(policy, null, 2) + "\n", {
36
+ mode: 0o644,
37
+ });
38
+ renameSync(temporaryPath, path);
39
+ } finally {
40
+ rmSync(staging, { recursive: true, force: true });
41
+ }
42
+ }