@vellumai/assistant 0.12.0 → 0.12.1-dev.202609141913.5e16607

package/src/__tests__/model-intents.test.ts

@@ -28,6 +28,9 @@ describe("model intents", () => {
     expect(resolveModelIntent("openai", "latency-optimized")).toBe(
       "gpt-5.6-luna",
     );
+    expect(resolveModelIntent("gemini", "cost-optimized")).toBe(
+      "gemini-3.1-flash-lite",
+    );
     expect(resolveModelIntent("gemini", "latency-optimized")).toBe(
       "gemini-3.1-flash-lite",
     );

package/src/__tests__/notification-vellum-adapter.test.ts

@@ -3,6 +3,11 @@ import { beforeEach, describe, expect, mock, test } from "bun:test";
 // ── Mocks: declared before imports that depend on them ──────────────
 
 let updateMessageContentShouldThrow = false;
+let assistantName: string | null = null;
+
+mock.module("../daemon/identity-helpers.js", () => ({
+  getAssistantName: () => assistantName,
+}));
 
 const updateMessageContentMock = mock(
   (_messageId: string, _content: string) => {
@@ -55,12 +60,21 @@ function makeDestination(
 function captureBroadcast(): {
   adapter: VellumAdapter;
   sent: AssistantEvent[];
+  conversationIds: Array<string | undefined>;
 } {
   const sent: AssistantEvent[] = [];
-  const adapter = new VellumAdapter((msg) => sent.push(msg));
-  return { adapter, sent };
+  const conversationIds: Array<string | undefined> = [];
+  const adapter = new VellumAdapter((msg, conversationId) => {
+    sent.push(msg);
+    conversationIds.push(conversationId);
+  });
+  return { adapter, sent, conversationIds };
 }
 
+beforeEach(() => {
+  assistantName = null;
+});
+
 describe("VellumAdapter silent flag", () => {
   test("non-urgent (low) urgency broadcasts silent: true", async () => {
     const { adapter, sent } = captureBroadcast();
@@ -181,6 +195,75 @@ describe("VellumAdapter remotePushDispatched pass-through", () => {
   });
 });
 
+describe("VellumAdapter assistant name", () => {
+  test("broadcasts the current verified assistant name after trimming it", async () => {
+    assistantName = "  Example Assistant  ";
+    const { adapter, sent } = captureBroadcast();
+
+    await adapter.send(makePayload(), makeDestination());
+
+    const intent = sent[0] as Extract<
+      AssistantEvent,
+      { type: "notification_intent" }
+    >;
+    expect(intent.assistantName).toBe("Example Assistant");
+  });
+
+  test("omits the assistant name when it is unavailable", async () => {
+    const { adapter, sent } = captureBroadcast();
+
+    await adapter.send(makePayload(), makeDestination());
+
+    const intent = sent[0] as Extract<
+      AssistantEvent,
+      { type: "notification_intent" }
+    >;
+    expect(intent.assistantName).toBeUndefined();
+    expect("assistantName" in intent).toBe(false);
+  });
+
+  test("omits a blank assistant name", async () => {
+    assistantName = " \t\n ";
+    const { adapter, sent } = captureBroadcast();
+
+    await adapter.send(makePayload(), makeDestination());
+
+    const intent = sent[0] as Extract<
+      AssistantEvent,
+      { type: "notification_intent" }
+    >;
+    expect(intent.assistantName).toBeUndefined();
+    expect("assistantName" in intent).toBe(false);
+  });
+
+  test("reflects a renamed assistant on the next intent", async () => {
+    assistantName = "Assistant A";
+    const { adapter, sent } = captureBroadcast();
+    await adapter.send(makePayload(), makeDestination());
+
+    assistantName = "Assistant B";
+    await adapter.send(makePayload(), makeDestination());
+
+    const intents = sent as Array<
+      Extract<AssistantEvent, { type: "notification_intent" }>
+    >;
+    expect(intents.map((intent) => intent.assistantName)).toEqual([
+      "Assistant A",
+      "Assistant B",
+    ]);
+  });
+
+  test("keeps notification intents outside conversation replay scope", async () => {
+    assistantName = "Example Assistant";
+    const { adapter, sent, conversationIds } = captureBroadcast();
+
+    await adapter.send(makePayload(), makeDestination());
+
+    expect(conversationIds).toEqual([undefined]);
+    expect("conversationId" in sent[0]!).toBe(false);
+  });
+});
+
 describe("VellumAdapter update", () => {
   beforeEach(() => {
     updateMessageContentMock.mockClear();

package/src/__tests__/outlook-messaging-provider.test.ts

@@ -429,7 +429,7 @@ describe("Outlook messaging provider", () => {
   describe("sendMessage", () => {
     test("sends a new message with correct recipient, subject, and body", async () => {
       const conn = createMockConnection();
-      const result = await outlookMessagingProvider.sendMessage(
+      const result = await outlookMessagingProvider.sendMessage!(
         conn,
         "recipient@example.com",
         "Hello!",
@@ -452,7 +452,7 @@ describe("Outlook messaging provider", () => {
 
     test("uses empty string for subject when not provided", async () => {
       const conn = createMockConnection();
-      await outlookMessagingProvider.sendMessage(
+      await outlookMessagingProvider.sendMessage!(
         conn,
         "recipient@example.com",
         "Hello!",
@@ -471,7 +471,7 @@ describe("Outlook messaging provider", () => {
 
     test("calls replyToMessage when inReplyTo is provided", async () => {
       const conn = createMockConnection();
-      const result = await outlookMessagingProvider.sendMessage(
+      const result = await outlookMessagingProvider.sendMessage!(
         conn,
         "conv-id",
         "Reply text",
@@ -493,7 +493,7 @@ describe("Outlook messaging provider", () => {
 
     test("attaches files to a new message as Graph file attachments", async () => {
       const conn = createMockConnection();
-      await outlookMessagingProvider.sendMessage(
+      await outlookMessagingProvider.sendMessage!(
         conn,
         "recipient@example.com",
         "See attached",
@@ -530,7 +530,7 @@ describe("Outlook messaging provider", () => {
 
     test("forwards attachments to replyToMessage when replying", async () => {
       const conn = createMockConnection();
-      await outlookMessagingProvider.sendMessage(
+      await outlookMessagingProvider.sendMessage!(
         conn,
         "conv-id",
         "Reply body",
@@ -563,7 +563,7 @@ describe("Outlook messaging provider", () => {
 
     test("throws when connection is undefined", async () => {
       await expect(
-        outlookMessagingProvider.sendMessage(
+        outlookMessagingProvider.sendMessage!(
           undefined,
           "recipient@example.com",
           "Hello!",

package/src/__tests__/platform-callback-registration.test.ts

@@ -110,8 +110,7 @@ describe("platform callback registration", () => {
   test("resolves managed callback context from stored credentials", async () => {
     mockSecureKeys[credentialKey("vellum", "platform_base_url")] =
       "https://platform.example.com";
-    mockSecureKeys[credentialKey("vellum", "platform_assistant_id")] =
-      "11111111-2222-4333-8444-555555555555";
+    mockPlatformAssistantId = "11111111-2222-4333-8444-555555555555";
     mockSecureKeys[credentialKey("vellum", "assistant_api_key")] =
       "ast-managed-key";
 
@@ -129,8 +128,7 @@ describe("platform callback registration", () => {
     mockIsPlatform = false;
     mockSecureKeys[credentialKey("vellum", "platform_base_url")] =
       "https://platform.example.com";
-    mockSecureKeys[credentialKey("vellum", "platform_assistant_id")] =
-      "22222222-3333-4444-8555-666666666666";
+    mockPlatformAssistantId = "22222222-3333-4444-8555-666666666666";
     mockSecureKeys[credentialKey("vellum", "assistant_api_key")] =
       "ast-self-hosted-key";
 
@@ -161,8 +159,7 @@ describe("platform callback registration", () => {
   test("registerCallbackRoute falls back to assistant API key auth", async () => {
     mockSecureKeys[credentialKey("vellum", "platform_base_url")] =
       "https://platform.example.com";
-    mockSecureKeys[credentialKey("vellum", "platform_assistant_id")] =
-      "11111111-2222-4333-8444-555555555555";
+    mockPlatformAssistantId = "11111111-2222-4333-8444-555555555555";
     mockSecureKeys[credentialKey("vellum", "assistant_api_key")] =
       "ast-managed-key";
 
@@ -209,8 +206,7 @@ describe("platform callback registration", () => {
     };
     mockSecureKeys[credentialKey("vellum", "platform_base_url")] =
       "https://platform.example.com";
-    mockSecureKeys[credentialKey("vellum", "platform_assistant_id")] =
-      "22222222-3333-4444-8555-666666666666";
+    mockPlatformAssistantId = "22222222-3333-4444-8555-666666666666";
     mockSecureKeys[credentialKey("vellum", "assistant_api_key")] =
       "ast-self-hosted-key";
 
@@ -251,8 +247,7 @@ describe("platform callback registration", () => {
     setIngressPublicBaseUrl("https://detected.example.com/");
     mockSecureKeys[credentialKey("vellum", "platform_base_url")] =
       "https://platform.example.com";
-    mockSecureKeys[credentialKey("vellum", "platform_assistant_id")] =
-      "22222222-3333-4444-8555-666666666666";
+    mockPlatformAssistantId = "22222222-3333-4444-8555-666666666666";
     mockSecureKeys[credentialKey("vellum", "assistant_api_key")] =
       "ast-self-hosted-key";
 
@@ -292,8 +287,7 @@ describe("platform callback registration", () => {
     mockConfig = {};
     mockSecureKeys[credentialKey("vellum", "platform_base_url")] =
       "https://platform.example.com";
-    mockSecureKeys[credentialKey("vellum", "platform_assistant_id")] =
-      "22222222-3333-4444-8555-666666666666";
+    mockPlatformAssistantId = "22222222-3333-4444-8555-666666666666";
     mockSecureKeys[credentialKey("vellum", "assistant_api_key")] =
       "ast-self-hosted-key";
 
@@ -334,8 +328,7 @@ describe("platform callback registration", () => {
     mockConfig = { ingress: { publicBaseUrl: "https://velay.example.com" } };
     mockSecureKeys[credentialKey("vellum", "platform_base_url")] =
       "https://platform.example.com";
-    mockSecureKeys[credentialKey("vellum", "platform_assistant_id")] =
-      "11111111-2222-4333-8444-555555555555";
+    mockPlatformAssistantId = "11111111-2222-4333-8444-555555555555";
     mockSecureKeys[credentialKey("vellum", "assistant_api_key")] =
       "ast-managed-key";
 
@@ -396,8 +389,7 @@ describe("resolveCallbackUrl resolution order", () => {
   function seedPlatformCredentials(): void {
     mockSecureKeys[credentialKey("vellum", "platform_base_url")] =
       "https://platform.example.com";
-    mockSecureKeys[credentialKey("vellum", "platform_assistant_id")] =
-      "11111111-2222-4333-8444-555555555555";
+    mockPlatformAssistantId = "11111111-2222-4333-8444-555555555555";
     mockSecureKeys[credentialKey("vellum", "assistant_api_key")] =
       "ast-managed-key";
   }

package/src/__tests__/platform-client-verify-credential.test.ts

@@ -19,7 +19,9 @@ mock.module("../providers/platform-proxy/context.js", () => ({
   }),
 }));
 
+const actualEnv = await import("../config/env.js");
 mock.module("../config/env.js", () => ({
+  ...actualEnv,
   getPlatformAssistantId: () => platformAssistantId,
 }));
 

package/src/__tests__/plugin-import-boundary-guard.test.ts

@@ -129,6 +129,9 @@ const BASELINE: Record<string, readonly string[]> = {
     "../../../../daemon/embedding-reconcile.js",
     "../../../../daemon/trust-context.js",
     "../../../../daemon/turn-latency-sub-spans.js",
+    // mcp-setup capability cards list configured server names from the
+    // workspace mcp.json document. No plugin-api equivalent.
+    "../../../../mcp/workspace-mcp-config.js",
     "../../../../notifications/background-failure-signal.js",
     "../../../../persistence/checkpoints.js",
     "../../../../persistence/conversation-types.js",
@@ -210,6 +213,16 @@ const BASELINE: Record<string, readonly string[]> = {
     "../../../persistence/job-handlers/message-lexical.js",
     "../../../persistence/job-utils.js",
     "../../../persistence/jobs-store.js",
+    // The retrospective cursor is a `(createdAt, id)` bound that must keep
+    // working after its message row is deleted. The resolver lives beside
+    // the persistence after-reads it also drives, so the plugin's
+    // accounting imports it rather than re-deriving the bound. No
+    // plugin-api equivalent.
+    "../../../persistence/message-cursor.js",
+    // Named any-state `createdAt` lookup the cursor bookkeeping uses for
+    // forks and the timestamp backfill; the messages-read boundary guard
+    // requires the read to live in persistence. No plugin-api equivalent.
+    "../../../persistence/message-reads.js",
     "../../../persistence/raw-query.js",
     "../../../persistence/schema/index.js",
     "../../../prompts/persona-resolver.js",

package/src/__tests__/resolve-app.test.ts

@@ -0,0 +1,135 @@
+/**
+ * Tests for resolving an app query by name, slug, or id.
+ */
+
+import { mkdirSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+
+import { createApp } from "../apps/app-store.js";
+import { resolveAppQuery } from "../apps/resolve-app.js";
+import { getWorkspacePluginsDir } from "../util/platform.js";
+
+let workspaceDir: string;
+let previousWorkspaceDir: string | undefined;
+
+function freshWorkspace(): string {
+  return join(
+    tmpdir(),
+    `vellum-resolve-app-${Date.now()}-${Math.random().toString(36).slice(2)}`,
+  );
+}
+
+function installPlugin(name: string): string {
+  const pluginDir = join(getWorkspacePluginsDir(), name);
+  mkdirSync(pluginDir, { recursive: true });
+  writeFileSync(
+    join(pluginDir, "package.json"),
+    JSON.stringify({ name, version: "1.0.0" }),
+  );
+  return pluginDir;
+}
+
+function bundleApp(pluginDir: string, app: string): void {
+  const appDir = join(pluginDir, "apps", app);
+  mkdirSync(appDir, { recursive: true });
+  writeFileSync(join(appDir, "index.html"), "<h1>Plugin app</h1>");
+}
+
+beforeEach(() => {
+  previousWorkspaceDir = process.env.VELLUM_WORKSPACE_DIR;
+  workspaceDir = freshWorkspace();
+  process.env.VELLUM_WORKSPACE_DIR = workspaceDir;
+});
+
+afterEach(() => {
+  rmSync(workspaceDir, { recursive: true, force: true });
+  if (previousWorkspaceDir === undefined) {
+    delete process.env.VELLUM_WORKSPACE_DIR;
+  } else {
+    process.env.VELLUM_WORKSPACE_DIR = previousWorkspaceDir;
+  }
+});
+
+describe("resolveAppQuery", () => {
+  test("resolves a workspace app by display name, slug, and id", () => {
+    const created = createApp({
+      name: "Budget",
+      schemaJson: "{}",
+      htmlDefinition: "<h1>Budget</h1>",
+    });
+
+    const byName = resolveAppQuery("Budget");
+    expect(byName.ok).toBe(true);
+    if (byName.ok) {
+      expect(byName.app.id).toBe(created.id);
+    }
+
+    const byNameCase = resolveAppQuery("budget");
+    expect(byNameCase.ok).toBe(true);
+    if (byNameCase.ok) {
+      expect(byNameCase.app.id).toBe(created.id);
+    }
+
+    const slug = created.dirName ?? "";
+    expect(slug.length).toBeGreaterThan(0);
+    const bySlug = resolveAppQuery(slug);
+    expect(bySlug.ok).toBe(true);
+    if (bySlug.ok) {
+      expect(bySlug.app.id).toBe(created.id);
+    }
+
+    const byId = resolveAppQuery(created.id);
+    expect(byId.ok).toBe(true);
+    if (byId.ok) {
+      expect(byId.app.id).toBe(created.id);
+    }
+  });
+
+  test("returns not_found for an unknown name", () => {
+    const result = resolveAppQuery("missing");
+    expect(result).toEqual({
+      ok: false,
+      reason: "not_found",
+      query: "missing",
+    });
+  });
+
+  test("returns ambiguous when two apps share a display name", () => {
+    const first = createApp({
+      name: "Notes",
+      schemaJson: "{}",
+      htmlDefinition: "<h1>One</h1>",
+    });
+    const second = createApp({
+      name: "Notes",
+      schemaJson: "{}",
+      htmlDefinition: "<h1>Two</h1>",
+    });
+
+    const result = resolveAppQuery("Notes");
+    expect(result.ok).toBe(false);
+    if (!result.ok && result.reason === "ambiguous") {
+      const ids = result.matches.map((m) => m.id).sort();
+      expect(ids).toEqual([first.id, second.id].sort());
+    } else {
+      throw new Error("expected ambiguous resolution");
+    }
+  });
+
+  test("resolves a plugin app by directory name", () => {
+    const pluginDir = installPlugin("charts");
+    bundleApp(pluginDir, "viewer");
+
+    const result = resolveAppQuery("viewer");
+    expect(result.ok).toBe(true);
+    if (result.ok) {
+      expect(result.app.origin).toEqual({
+        kind: "plugin",
+        pluginName: "charts",
+      });
+      expect(result.app.id).toBe("plugins~charts~viewer");
+    }
+  });
+});

package/src/__tests__/script-proxy-certs.test.ts

@@ -8,6 +8,7 @@ import {
   getCAPath,
   issueLeafCert,
 } from "../outbound-proxy/index.js";
+import { writeCombinedCABundle } from "../util/ca-bundle.js";
 
 let dataDir: string;
 
@@ -19,6 +20,40 @@ afterAll(async () => {
   await rm(dataDir, { recursive: true, force: true });
 });
 
+test("combined trust verifies certificates from both CA sources", async () => {
+  const roots = [join(dataDir, "system"), join(dataDir, "extra")];
+  const leaves: string[] = [];
+  for (const root of roots) {
+    await ensureLocalCA(root);
+    const caDir = join(root, "proxy-ca");
+    await issueLeafCert(caDir, "example.com");
+    leaves.push(join(caDir, "issued", "example.com.pem"));
+  }
+  const bundle = join(dataDir, "combined.pem");
+  await writeCombinedCABundle(
+    getCAPath(roots[0]!),
+    getCAPath(roots[1]!),
+    bundle,
+  );
+  const verify = Bun.spawn(
+    ["openssl", "verify", "-CAfile", bundle, ...leaves],
+    {
+      stdout: "pipe",
+      stderr: "pipe",
+      windowsHide: true,
+    },
+  );
+  const [code, output, error] = await Promise.all([
+    verify.exited,
+    new Response(verify.stdout).text(),
+    new Response(verify.stderr).text(),
+  ]);
+  expect({ code, error }).toEqual({ code: 0, error: "" });
+  for (const leaf of leaves) {
+    expect(output).toContain(`${leaf}: OK`);
+  }
+});
+
 describe("ensureLocalCA", () => {
   test("creates CA cert and key with correct permissions", async () => {
     await ensureLocalCA(dataDir);