@vellumai/assistant 0.11.8 → 0.11.9-staging.2

package/src/live-voice/__tests__/live-voice-sight-frame-inline.test.ts

@@ -208,8 +208,8 @@ import { initializeDb } from "../../persistence/db-init.js";
 import { attachments } from "../../persistence/schema.js";
 import { mediaBlockAttachmentId, type Message } from "../../providers/types.js";
 import {
+  persistAmbientSightFrame,
   persistLiveVoicePhoto,
-  persistLiveVoiceSightFrame,
 } from "../live-voice-photo.js";
 
 await initializeDb();
@@ -291,9 +291,9 @@ describe("a camera frame that falls back to inline bytes", () => {
     try {
       const inlineFrame = await uploadUnstorableFrame("inline.png");
 
-      expect((await persistLiveVoiceSightFrame(live.id, inlineFrame)).ok).toBe(
-        true,
-      );
+      expect(
+        (await persistAmbientSightFrame(live.id, inlineFrame, "voice")).ok,
+      ).toBe(true);
 
       const [row] = getMessages(live.id);
       // The scenario really fired: bytes in the row, no reference to a row of
@@ -321,14 +321,14 @@ describe("a camera frame that falls back to inline bytes", () => {
     const live = liveConversation("Live voice inline fallback retention");
     try {
       const inlineFrame = await uploadUnstorableFrame("inline-aged.png");
-      expect((await persistLiveVoiceSightFrame(live.id, inlineFrame)).ok).toBe(
-        true,
-      );
+      expect(
+        (await persistAmbientSightFrame(live.id, inlineFrame, "voice")).ok,
+      ).toBe(true);
       for (const name of ["fresh-a.png", "fresh-b.png"]) {
         const fresh = await uploadFrame(name);
-        expect((await persistLiveVoiceSightFrame(live.id, fresh)).ok).toBe(
-          true,
-        );
+        expect(
+          (await persistAmbientSightFrame(live.id, fresh, "voice")).ok,
+        ).toBe(true);
       }
 
       const assembled: Message[] = getMessages(live.id).map((row) => ({
@@ -372,9 +372,9 @@ describe("a camera frame whose message link fails", () => {
       realStore.linkAttachmentToMessage(elsewhere.id, arrivedAs, 0);
 
       failNextLink = true;
-      expect((await persistLiveVoiceSightFrame(live.id, arrivedAs)).ok).toBe(
-        true,
-      );
+      expect(
+        (await persistAmbientSightFrame(live.id, arrivedAs, "voice")).ok,
+      ).toBe(true);
       expect(failNextLink).toBe(false);
 
       const [row] = getMessages(live.id);
@@ -411,7 +411,7 @@ describe("a camera frame whose persist throws", () => {
       messagesChangedFor.length = 0;
       failNextLink = true;
       failNextContentUpdate = true;
-      const result = await persistLiveVoiceSightFrame(live.id, frame);
+      const result = await persistAmbientSightFrame(live.id, frame, "voice");
       expect(failNextLink).toBe(false);
       expect(failNextContentUpdate).toBe(false);
 
@@ -469,7 +469,7 @@ describe("a camera frame whose persist throws", () => {
       const frame = await uploadFrame("throws-early.png");
 
       failNextResolve = true;
-      expect(await persistLiveVoiceSightFrame(live.id, frame)).toEqual({
+      expect(await persistAmbientSightFrame(live.id, frame, "voice")).toEqual({
         ok: false,
       });
       expect(failNextResolve).toBe(false);
@@ -492,7 +492,7 @@ describe("a camera frame whose persist throws", () => {
       failNextResolve = true;
       failNextMessageLookup = true;
       // No success claim either: doubt blocks the delete and the ok alike.
-      expect(await persistLiveVoiceSightFrame(live.id, frame)).toEqual({
+      expect(await persistAmbientSightFrame(live.id, frame, "voice")).toEqual({
         ok: false,
       });
       expect(failNextMessageLookup).toBe(false);
@@ -535,7 +535,9 @@ describe("attachments a failed persist attempt cloned for itself", () => {
       scopedAttachmentIds.length = 0;
 
       failNextAddMessage = true;
-      expect(await persistLiveVoiceSightFrame(live.id, arrivedAs)).toEqual({
+      expect(
+        await persistAmbientSightFrame(live.id, arrivedAs, "voice"),
+      ).toEqual({
         ok: false,
       });
       expect(failNextAddMessage).toBe(false);
@@ -571,9 +573,9 @@ describe("attachments a failed persist attempt cloned for itself", () => {
       failNextLink = true;
       failNextContentUpdate = true;
       // Committed despite the throw, which is what makes the clone the row's.
-      expect((await persistLiveVoiceSightFrame(live.id, arrivedAs)).ok).toBe(
-        true,
-      );
+      expect(
+        (await persistAmbientSightFrame(live.id, arrivedAs, "voice")).ok,
+      ).toBe(true);
       expect(failNextLink).toBe(false);
       expect(failNextContentUpdate).toBe(false);
 
@@ -605,7 +607,9 @@ describe("attachments a failed persist attempt cloned for itself", () => {
       scopedAttachmentIds.length = 0;
 
       failNextContentRead = true;
-      expect(await persistLiveVoiceSightFrame(live.id, arrivedAs)).toEqual({
+      expect(
+        await persistAmbientSightFrame(live.id, arrivedAs, "voice"),
+      ).toEqual({
         ok: false,
       });
       expect(failNextContentRead).toBe(false);
@@ -692,9 +696,9 @@ describe("a clone whose materialization fails", () => {
       mkdirSync(dirname(attachDir), { recursive: true });
       writeFileSync(attachDir, "");
 
-      expect((await persistLiveVoiceSightFrame(live.id, arrivedAs)).ok).toBe(
-        true,
-      );
+      expect(
+        (await persistAmbientSightFrame(live.id, arrivedAs, "voice")).ok,
+      ).toBe(true);
 
       // The recovery is unchanged: the frame still lands, inline.
       const [row] = getMessages(live.id);
@@ -756,7 +760,9 @@ describe("ambient frames stay out of the indexing pipeline", () => {
       const frame = await uploadFrame("not-indexed.png");
 
       lexicallyIndexed.length = 0;
-      expect((await persistLiveVoiceSightFrame(live.id, frame)).ok).toBe(true);
+      expect((await persistAmbientSightFrame(live.id, frame, "voice")).ok).toBe(
+        true,
+      );
 
       const [row] = getMessages(live.id);
       expect(row).toBeDefined();

package/src/live-voice/__tests__/live-voice-sight-frame.test.ts

@@ -9,7 +9,9 @@
  * The two neighbouring contracts are pinned by their own suites: a deliberate
  * snap persists standalone and untagged (`live-voice-attach-image.test.ts`), a
  * parked frame persists nothing and rides the next turn
- * (`live-voice-attach-frame.test.ts`).
+ * (`live-voice-attach-frame.test.ts`). One photo case does live here, because
+ * it pins the edge of something this suite owns: the refusal's attachment
+ * echo, which is the keep stream's alone.
  */
 
 import { describe, expect, mock, test } from "bun:test";
@@ -276,6 +278,9 @@ describe("live-voice camera frames kept mid-call", () => {
       ).toMatchObject({
         type: "error",
         frameType: "sight_frame",
+        // The id it refused, so the client retires that keep rather than
+        // guessing among the sends it has not heard back on.
+        attachmentId: "att-missing",
         recoverable: true,
       });
       // Nothing landed and the call carries on.
@@ -286,6 +291,70 @@ describe("live-voice camera frames kept mid-call", () => {
     }
   });
 
+  test("each refused keep names its own attachment", async () => {
+    // The point of the echo: keeps overlap, so a shared `frameType` cannot
+    // tell two outstanding sends apart.
+    const harness = createSessionHarness("Sight keep two refusals");
+    try {
+      await harness.session.start();
+      const before = harness.frames.length;
+
+      await harness.session.handleClientFrame({
+        type: "sight_frame",
+        attachmentId: "att-missing-1",
+      });
+      await harness.session.handleClientFrame({
+        type: "sight_frame",
+        attachmentId: "att-missing-2",
+      });
+      await waitFor(
+        () =>
+          harness.frames.slice(before).filter((frame) => frame.type === "error")
+            .length === 2,
+        { message: "Timed out waiting for both refusals" },
+      );
+
+      const refused = harness.frames
+        .slice(before)
+        .filter((frame) => frame.type === "error")
+        .map((frame) => frame.attachmentId);
+      expect(refused.sort()).toEqual(["att-missing-1", "att-missing-2"]);
+    } finally {
+      harness.dispose();
+    }
+  });
+
+  test("a photo that cannot be stored names no attachment", async () => {
+    // Scope pin: the echo is the keep stream's, where sends overlap. A photo
+    // is one deliberate snap at a time, and its receipt strip already knows
+    // which one it is waiting on.
+    const harness = createSessionHarness("Sight keep photo scope");
+    try {
+      await harness.session.start();
+      const before = harness.frames.length;
+
+      await harness.session.handleClientFrame({
+        type: "attach_image",
+        attachmentId: "att-missing",
+      });
+      await waitFor(() => harness.frames.length > before, {
+        message: "Timed out waiting for the rejected photo's error",
+      });
+
+      const error = harness.frames
+        .slice(before)
+        .find((frame) => frame.type === "error");
+      expect(error).toMatchObject({
+        type: "error",
+        frameType: "attach_image",
+        recoverable: true,
+      });
+      expect(error?.attachmentId).toBeUndefined();
+    } finally {
+      harness.dispose();
+    }
+  });
+
   test("refuses an unknown id while a turn is running, without waiting it out", async () => {
     // The id is checked before the persist is scheduled. Behind the persist it
     // would be answered only once the turn released the lock, long after the