@vellumai/assistant 0.11.7 → 0.11.8-staging.1

package/src/__tests__/conversation-pairing.test.ts

@@ -1302,4 +1302,58 @@ describe("pairDeliveryWithConversation", () => {
       expect(result.conversationId).toBeNull();
     }
   });
+  // ── Guardian delivery projections (channel cards pair nothing) ────
+
+  test.each(["slack", "telegram", "discord"])(
+    "a guardian card delivered to a channel pairs no conversation",
+    async (channel) => {
+      const signal = makeSignal({
+        sourceEventName: "guardian.question",
+        contextPayload: { requestKind: "tool_approval", requestId: "req-1" },
+      });
+
+      const result = await pairDeliveryWithConversation(
+        signal,
+        channel as NotificationChannel,
+        makeCopy(),
+      );
+
+      expect(result.conversationId).toBeNull();
+      expect(result.messageId).toBeNull();
+      expect(createConversationMock).not.toHaveBeenCalled();
+      expect(addMessageMock).not.toHaveBeenCalled();
+    },
+  );
+
+  test("an access-request card delivered to a channel pairs no conversation", async () => {
+    const signal = makeSignal({
+      sourceEventName: "ingress.access_request",
+      contextPayload: { requestId: "req-a" },
+    });
+
+    const result = await pairDeliveryWithConversation(
+      signal,
+      "telegram" as NotificationChannel,
+      makeCopy(),
+    );
+
+    expect(result.conversationId).toBeNull();
+    expect(createConversationMock).not.toHaveBeenCalled();
+  });
+
+  test("the vellum delivery of a guardian card still pairs its conversation", async () => {
+    const signal = makeSignal({
+      sourceEventName: "guardian.question",
+      contextPayload: { requestKind: "tool_approval", requestId: "req-1" },
+    });
+
+    const result = await pairDeliveryWithConversation(
+      signal,
+      "vellum" as NotificationChannel,
+      makeCopy(),
+    );
+
+    expect(result.conversationId).toBe("conv-001");
+    expect(result.messageId).toBe("msg-001");
+  });
 });

package/src/__tests__/conversation-process-callsite.test.ts

@@ -134,18 +134,6 @@ mock.module("../persistence/conversation-queries.js", () => ({
   listConversations: () => [],
 }));
 
-mock.module("../memory/retriever.js", () => ({
-  buildMemoryRecall: async () => ({
-    enabled: false,
-    degraded: false,
-    injectedText: "",
-    semanticHits: 0,
-    injectedTokens: 0,
-    latencyMs: 0,
-  }),
-  injectMemoryRecallAsUserBlock: (msgs: Message[]) => msgs,
-}));
-
 // Mock AgentLoop to capture the callSite argument that runAgentLoopImpl passes
 // via the options object (see assistant/src/agent/loop.ts → AgentLoopConstructorOptions).
 mock.module("../agent/loop.js", () => ({

package/src/__tests__/conversation-provider-retry-repair.test.ts

@@ -73,19 +73,6 @@ mock.module("../memory/archive-store.js", () => ({
   insertCompactionEpisode: () => {},
 }));
 
-mock.module("../memory/retriever.js", () => ({
-  buildMemoryRecall: async () => ({
-    enabled: false,
-    degraded: false,
-    injectedText: "",
-
-    semanticHits: 0,
-    injectedTokens: 0,
-    latencyMs: 0,
-  }),
-  injectMemoryRecallAsUserBlock: (msgs: Message[]) => msgs,
-}));
-
 mock.module("../plugins/defaults/compaction/window-manager.js", () => ({
   ContextWindowManager: class {
     estimateInputTokens() {

package/src/__tests__/conversation-queue.test.ts

@@ -88,6 +88,10 @@ mock.module("../persistence/conversation-crud.js", () => ({
   getConversationOriginInterface: () => null,
   getConversationOriginChannel: () => null,
   getMessages: () => [],
+  // The batched-drain attachment cases put real image blocks in the history,
+  // which is what makes the camera-frame retention pass read rows. None of
+  // them is tagged, so an empty map is the answer the real accessor gives.
+  selectSightFrameCaptureTimes: () => new Map<string, number>(),
   getConversation: () => ({
     id: "conv-1",
     contextSummary: null,
@@ -217,19 +221,6 @@ mock.module("../persistence/attachments-store.js", () => ({
   setAttachmentThumbnail: () => {},
 }));
 
-mock.module("../memory/retriever.js", () => ({
-  buildMemoryRecall: async () => ({
-    enabled: false,
-    degraded: false,
-    injectedText: "",
-
-    semanticHits: 0,
-    injectedTokens: 0,
-    latencyMs: 0,
-  }),
-  injectMemoryRecallAsUserBlock: (msgs: Message[]) => msgs,
-}));
-
 mock.module("../plugins/defaults/compaction/window-manager.js", () => ({
   ContextWindowManager: class {
     estimateInputTokens() {

package/src/__tests__/conversation-retry-route.test.ts

@@ -115,7 +115,12 @@ mock.module("../schedule/schedule-store.js", () => ({
   deleteSchedule: async () => {},
 }));
 
+// Spread the actual module so transitive importers of names this
+// factory does not stub keep resolving (a partial factory breaks at
+// import time when the graph gains a new named import).
+const actualFeedWriter = await import("../home/feed-writer.js");
 mock.module("../home/feed-writer.js", () => ({
+  ...actualFeedWriter,
   stripConversationIds: async () => {},
 }));
 

package/src/__tests__/conversation-routes-disk-view.test.ts

@@ -299,7 +299,7 @@ beforeEach(() => {
 // These tests verify the route-level wiring that enables the CDP factory's
 // fallback chain on macOS-originated turns:
 //
-//   1. Extension connected  → extension backend (tested in host-browser-e2e-cloud.test.ts)
+//   1. Extension connected  → extension backend
 //   2. Extension absent, cdp-inspect unavailable → local Playwright fallback
 //
 // Specifically, we verify that when a macOS message enters through

package/src/__tests__/conversation-routes-enabled-plugins.test.ts

@@ -78,7 +78,7 @@ mock.module("../persistence/conversation-disk-view.js", () => ({
 
 mock.module("../persistence/attachments-store.js", () => ({
   getAttachmentsByIds: () => [],
-  getSourcePathsForAttachments: () => new Map(),
+  resolveAttachmentsForPersist: () => [],
   attachmentExists: () => false,
   linkAttachmentToMessage: () => {},
   attachInlineAttachmentToMessage: () => {},

package/src/__tests__/conversation-routes-hidden-queue.test.ts

@@ -67,7 +67,7 @@ mock.module("../persistence/conversation-disk-view.js", () => ({
 
 mock.module("../persistence/attachments-store.js", () => ({
   getAttachmentsByIds: () => [],
-  getSourcePathsForAttachments: () => new Map(),
+  resolveAttachmentsForPersist: () => [],
   attachmentExists: () => false,
   linkAttachmentToMessage: () => {},
   attachInlineAttachmentToMessage: () => {},

package/src/__tests__/conversation-routes-slash-commands.test.ts

@@ -106,7 +106,7 @@ mock.module("../persistence/conversation-disk-view.js", () => ({
 
 mock.module("../persistence/attachments-store.js", () => ({
   getAttachmentsByIds: () => [],
-  getSourcePathsForAttachments: () => new Map(),
+  resolveAttachmentsForPersist: () => [],
   attachmentExists: () => false,
   linkAttachmentToMessage: () => {},
   attachInlineAttachmentToMessage: () => {},