@vellumai/assistant 0.11.3 → 0.11.4-staging.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/ARCHITECTURE.md +11 -6
- package/docs/architecture/memory.md +11 -0
- package/docs/architecture/turn-actor.md +70 -0
- package/docs/flux-turn-detection-spike.md +243 -0
- package/docs/stt-provider-onboarding.md +3 -1
- package/node_modules/@vellumai/ces-client/node_modules/@vellumai/service-contracts/src/channels.ts +11 -0
- package/node_modules/@vellumai/gateway-client/node_modules/@vellumai/service-contracts/src/channels.ts +11 -0
- package/node_modules/@vellumai/gateway-client/src/admission-policy-contract.ts +34 -0
- package/node_modules/@vellumai/gateway-client/src/index.ts +2 -0
- package/node_modules/@vellumai/service-contracts/src/channels.ts +11 -0
- package/openapi.yaml +140 -38
- package/package.json +1 -1
- package/scripts/voice-ttft-spike.ts +3 -3
- package/src/__tests__/app-compiler.test.ts +38 -3
- package/src/__tests__/attachments-store.test.ts +21 -12
- package/src/__tests__/byok-default-profile-ensure.test.ts +2 -0
- package/src/__tests__/call-setup-flow-name-capture.test.ts +0 -1
- package/src/__tests__/call-site-routing-provider.test.ts +1 -1
- package/src/__tests__/channel-availability-routes.test.ts +14 -1
- package/src/__tests__/channel-capabilities-dedupe.test.ts +214 -0
- package/src/__tests__/channel-delivery-store.test.ts +14 -14
- package/src/__tests__/config-loader-backfill.test.ts +3 -3
- package/src/__tests__/config-schema.test.ts +25 -10
- package/src/__tests__/conversation-agent-loop-inference-profile.test.ts +8 -11
- package/src/__tests__/conversation-agent-loop-overflow.test.ts +8 -11
- package/src/__tests__/conversation-agent-loop.test.ts +28 -20
- package/src/__tests__/conversation-attention-store.test.ts +63 -0
- package/src/__tests__/conversation-delete-schedule-cleanup.test.ts +0 -4
- package/src/__tests__/conversation-fork-crud.test.ts +69 -0
- package/src/__tests__/conversation-fork-referential.test.ts +67 -0
- package/src/__tests__/conversation-fork-retrospective.test.ts +24 -0
- package/src/__tests__/conversation-notifiers-provenance.test.ts +59 -0
- package/src/__tests__/conversation-queue.test.ts +55 -4
- package/src/__tests__/conversation-runtime-assembly.test.ts +134 -102
- package/src/__tests__/conversation-runtime-workspace.test.ts +14 -10
- package/src/__tests__/credential-prompt-route.test.ts +7 -10
- package/src/__tests__/custom-profile-ensure.test.ts +5 -1
- package/src/__tests__/discord-access-request-privacy.test.ts +5 -1
- package/src/__tests__/discord-requester-notice-privacy.test.ts +3 -3
- package/src/__tests__/document-append-idempotency.test.ts +233 -0
- package/src/__tests__/edit-propagation.test.ts +0 -7
- package/src/__tests__/helpers/mock-actor-context.ts +49 -0
- package/src/__tests__/helpers/mock-conversation.ts +13 -1
- package/src/__tests__/injector-chain.test.ts +63 -41
- package/src/__tests__/injector-disk-pressure.test.ts +11 -23
- package/src/__tests__/llm-context-resolution.test.ts +73 -1
- package/src/__tests__/llm-schema.test.ts +5 -2
- package/src/__tests__/mcp-list-plugin-servers.test.ts +250 -0
- package/src/__tests__/memory-retrieval-hook.test.ts +6 -5
- package/src/__tests__/messages-read-boundary-guard.test.ts +134 -0
- package/src/__tests__/mtime-cache.test.ts +1 -1
- package/src/__tests__/non-member-access-request.test.ts +0 -20
- package/src/__tests__/outbound-slack-persistence.test.ts +40 -1
- package/src/__tests__/plugin-import-boundary-guard.test.ts +5 -0
- package/src/__tests__/plugin-secret-pattern-contribution.test.ts +1 -1
- package/src/__tests__/post-compaction-reinjection-idempotency.test.ts +14 -7
- package/src/__tests__/provider-commit-message-generator.test.ts +20 -0
- package/src/__tests__/run-conversation-turn-persistence.test.ts +434 -105
- package/src/__tests__/scoped-approval-grants.test.ts +11 -6
- package/src/__tests__/secret-ingress-channel.test.ts +0 -1
- package/src/__tests__/skills.test.ts +32 -0
- package/src/__tests__/slack-edit-ordering-characterization.test.ts +0 -1
- package/src/__tests__/subagent-call-site-routing.test.ts +31 -19
- package/src/__tests__/subagent-spawn-and-await.test.ts +14 -10
- package/src/__tests__/turn-events-store.test.ts +43 -0
- package/src/__tests__/user-plugin-loader.test.ts +1 -1
- package/src/__tests__/visible-app-context.test.ts +16 -9
- package/src/__tests__/worker-entrypoint-guards.test.ts +54 -0
- package/src/__tests__/worker-plugin-surface.test.ts +77 -0
- package/src/__tests__/workspace-migration-142-consolidate-voice-front-door.test.ts +158 -0
- package/src/__tests__/workspace-migration-143-repair-deprecated-codex-model-id.test.ts +133 -0
- package/src/__tests__/workspace-migration-144-convert-stranded-subscription-openai-profiles.test.ts +316 -0
- package/src/__tests__/workspace-migration-145-collapse-profile-bindings-to-entries.test.ts +325 -0
- package/src/acp/__tests__/acp-claude-oauth.test.ts +10 -2
- package/src/acp/__tests__/auth-required.test.ts +161 -0
- package/src/acp/acp-claude-oauth.ts +19 -2
- package/src/acp/agent-process.test.ts +100 -0
- package/src/acp/agent-process.ts +29 -26
- package/src/acp/auth-required.ts +102 -0
- package/src/acp/session-manager.test.ts +119 -0
- package/src/acp/session-manager.ts +68 -2
- package/src/api/events/acp-auth-required.ts +55 -0
- package/src/api/index.ts +7 -0
- package/src/apps/app-store.ts +3 -0
- package/src/bundler/package-resolver.ts +2 -30
- package/src/calls/__tests__/voice-session-bridge.test.ts +173 -1
- package/src/calls/__tests__/voice-triage-escalate.test.ts +94 -0
- package/src/calls/call-controller.ts +9 -2
- package/src/calls/call-setup-flow.ts +0 -1
- package/src/calls/media-stream-stt-session.ts +15 -0
- package/src/calls/voice-session-bridge.ts +71 -16
- package/src/calls/voice-triage-escalate.ts +104 -2
- package/src/channels/__tests__/plugin-channel-declarations.test.ts +161 -0
- package/src/channels/config.ts +13 -0
- package/src/channels/plugin-channel-declarations.ts +108 -0
- package/src/channels/types.ts +30 -0
- package/src/cli/AGENTS.md +5 -2
- package/src/cli/commands/credentials.help.ts +2 -2
- package/src/cli/commands/inference-providers.ts +1 -1
- package/src/cli/commands/mcp.help.ts +13 -4
- package/src/cli/commands/mcp.ts +9 -0
- package/src/cli/commands/memory/__tests__/memory-v3.test.ts +128 -5
- package/src/cli/commands/memory/index.help.ts +43 -1
- package/src/cli/commands/memory/memory-v3.ts +64 -0
- package/src/cli/commands/stt.help.ts +27 -2
- package/src/cli/lib/__tests__/upgrade-plugin.test.ts +39 -0
- package/src/cli/lib/bundled-marketplace.json +13 -0
- package/src/cli/lib/upgrade-plugin.ts +42 -0
- package/src/config/__tests__/default-profile-catalog.test.ts +34 -2
- package/src/config/__tests__/default-provider.test.ts +6 -1
- package/src/config/__tests__/profile-materialization.test.ts +75 -19
- package/src/config/bundled-skills/acp/SKILL.md +6 -7
- package/src/config/bundled-skills/document-editor/SKILL.md +2 -2
- package/src/config/bundled-skills/document-editor/TOOLS.json +2 -2
- package/src/config/bundled-skills/media-processing/services/preprocess.ts +14 -4
- package/src/config/bundled-skills/settings/TOOLS.json +3 -3
- package/src/config/bundled-skills/transcribe/tools/transcribe-media.test.ts +22 -1
- package/src/config/bundled-skills/transcribe/tools/transcribe-media.ts +9 -2
- package/src/config/call-site-defaults.ts +4 -5
- package/src/config/default-profile-catalog.ts +82 -11
- package/src/config/default-profile-names.ts +4 -1
- package/src/config/default-provider-resolution.ts +4 -0
- package/src/config/llm-context-resolution.ts +11 -3
- package/src/config/llm-resolver.ts +28 -1
- package/src/config/profile-materialization.ts +70 -22
- package/src/config/schemas/__tests__/live-voice.test.ts +107 -4
- package/src/config/schemas/call-site-catalog.ts +4 -4
- package/src/config/schemas/live-voice.ts +57 -23
- package/src/config/schemas/llm.ts +59 -32
- package/src/config/schemas/mcp.ts +23 -0
- package/src/config/schemas/plugin-updates.ts +6 -2
- package/src/config/schemas/stt.ts +1 -0
- package/src/context/outbound-sanitize.ts +96 -1
- package/src/daemon/__tests__/plugin-mcp-reconcile.test.ts +82 -0
- package/src/daemon/conversation-agent-loop-handlers.ts +15 -10
- package/src/daemon/conversation-agent-loop.ts +17 -6
- package/src/daemon/conversation-messaging.ts +5 -1
- package/src/daemon/conversation-notifiers.ts +9 -1
- package/src/daemon/conversation-process.ts +9 -6
- package/src/daemon/conversation-runtime-assembly.ts +3 -4
- package/src/daemon/conversation-tool-setup.ts +1 -2
- package/src/daemon/conversation.ts +48 -0
- package/src/daemon/mcp-reload-service.ts +36 -6
- package/src/daemon/process-message.ts +13 -3
- package/src/daemon/providers-setup.ts +6 -3
- package/src/daemon/trust-context-types.ts +29 -0
- package/src/daemon/wake-conversation-ops.ts +3 -2
- package/src/documents/document-store.ts +138 -5
- package/src/hooks/hook-loader.ts +3 -3
- package/src/hooks/registry.ts +50 -6
- package/src/inbound/__tests__/oauth-callback-url.test.ts +83 -0
- package/src/inbound/oauth-callback-url.ts +61 -0
- package/src/live-voice/__tests__/live-voice-agent-turn.test.ts +1 -104
- package/src/live-voice/__tests__/live-voice-events.test.ts +7 -8
- package/src/live-voice/__tests__/live-voice-flux-turn-end.test.ts +932 -0
- package/src/live-voice/__tests__/live-voice-metrics.test.ts +115 -8
- package/src/live-voice/__tests__/live-voice-photo.test.ts +100 -0
- package/src/live-voice/__tests__/live-voice-progress.test.ts +60 -194
- package/src/live-voice/__tests__/live-voice-stt.test.ts +14 -0
- package/src/live-voice/__tests__/live-voice-triage-escalate.test.ts +29 -0
- package/src/live-voice/__tests__/live-voice-tts-session.test.ts +0 -483
- package/src/live-voice/__tests__/live-voice-vad.test.ts +0 -16
- package/src/live-voice/__tests__/progress-narration.test.ts +214 -0
- package/src/live-voice/live-voice-archive.ts +2 -0
- package/src/live-voice/live-voice-metrics.ts +57 -32
- package/src/live-voice/live-voice-photo.ts +1 -2
- package/src/live-voice/live-voice-session.ts +535 -314
- package/src/live-voice/progress-narration.ts +277 -0
- package/src/live-voice/protocol.ts +21 -1
- package/src/mcp/__tests__/effective-config.test.ts +238 -0
- package/src/mcp/__tests__/mcp-auth-orchestrator.test.ts +0 -1
- package/src/mcp/__tests__/mcp-oauth-client-registration.test.ts +200 -0
- package/src/mcp/__tests__/mcp-oauth-provider.test.ts +9 -9
- package/src/mcp/__tests__/plugin-server-credential-isolation.test.ts +95 -0
- package/src/mcp/client.ts +16 -11
- package/src/mcp/effective-config.ts +113 -0
- package/src/mcp/manager.ts +11 -6
- package/src/mcp/mcp-auth-orchestrator.ts +13 -22
- package/src/mcp/mcp-oauth-provider.ts +205 -240
- package/src/monitoring/__tests__/plugin-auto-update.test.ts +166 -3
- package/src/monitoring/plugin-auto-update.ts +128 -24
- package/src/notifications/signal.ts +1 -0
- package/src/permissions/confirmation-guardian-request.test.ts +15 -11
- package/src/permissions/confirmation-guardian-request.ts +2 -2
- package/src/permissions/question-guardian-request.test.ts +14 -6
- package/src/permissions/question-guardian-request.ts +1 -2
- package/src/persistence/attachments-store.ts +8 -1
- package/src/persistence/bookmark-crud.ts +3 -7
- package/src/persistence/conversation-attention-store.ts +16 -45
- package/src/persistence/conversation-crud.ts +33 -4
- package/src/persistence/conversation-lineage.ts +9 -0
- package/src/persistence/conversation-queries.ts +108 -41
- package/src/persistence/delivery-crud.ts +38 -29
- package/src/persistence/external-conversation-store.ts +32 -4
- package/src/persistence/llm-request-log-store.ts +4 -10
- package/src/persistence/llm-usage-store.ts +8 -3
- package/src/persistence/message-reads.test.ts +197 -0
- package/src/persistence/message-reads.ts +211 -0
- package/src/persistence/migrations/366-chatgpt-subscription-row-identity.test.ts +120 -0
- package/src/persistence/migrations/366-chatgpt-subscription-row-identity.ts +62 -0
- package/src/persistence/real-user-turn-filter.ts +27 -3
- package/src/persistence/steps.ts +9 -0
- package/src/plugin-api/__tests__/oauth-callback-url-export.test.ts +29 -0
- package/src/plugin-api/conversation-turn.ts +168 -5
- package/src/plugin-api/index.ts +21 -5
- package/src/plugins/__tests__/mcp-servers.test.ts +371 -0
- package/src/plugins/defaults/memory/AGENTS.md +4 -0
- package/src/plugins/defaults/memory/__tests__/buffer-format.test.ts +204 -0
- package/src/plugins/defaults/memory/__tests__/memory-retrospective-accounting.test.ts +72 -0
- package/src/plugins/defaults/memory/__tests__/memory-retrospective-job.test.ts +4 -1
- package/src/plugins/defaults/memory/__tests__/memory-retrospective-provider-path.test.ts +4 -1
- package/src/plugins/defaults/memory/buffer-format.ts +165 -0
- package/src/plugins/defaults/memory/context-search/sources/conversations.ts +6 -0
- package/src/plugins/defaults/memory/graph/image-ref-utils.ts +3 -0
- package/src/plugins/defaults/memory/graph/tool-handlers.ts +1 -30
- package/src/plugins/defaults/memory/graph-topology/pending-buffer.test.ts +34 -0
- package/src/plugins/defaults/memory/graph-topology/pending-buffer.ts +8 -12
- package/src/plugins/defaults/memory/hooks/post-compact.ts +1 -4
- package/src/plugins/defaults/memory/indexer.ts +3 -1
- package/src/plugins/defaults/memory/memory-retrospective-accounting.ts +19 -7
- package/src/plugins/defaults/memory/src/__tests__/memory-v3-gate-stats.test.ts +281 -0
- package/src/plugins/defaults/memory/src/memory-v3-routes.ts +207 -0
- package/src/plugins/defaults/memory/substrate/__tests__/consolidation-job.test.ts +33 -0
- package/src/plugins/defaults/memory/substrate/__tests__/static-context.test.ts +199 -2
- package/src/plugins/defaults/memory/substrate/consolidation-job.ts +25 -18
- package/src/plugins/defaults/memory/substrate/skill-content.ts +8 -1
- package/src/plugins/defaults/memory/substrate/static-context.ts +160 -4
- package/src/plugins/defaults/memory/substrate/sweep-job.ts +2 -4
- package/src/plugins/defaults/memory/v1/graph/extraction.ts +3 -1
- package/src/plugins/defaults/memory/v3/prune.ts +2 -0
- package/src/plugins/defaults/memory/v3/selection-log-store.ts +2 -0
- package/src/plugins/defaults/memory/worker.ts +6 -3
- package/src/plugins/external-plugin-loader.ts +47 -0
- package/src/plugins/mcp-servers.ts +361 -0
- package/src/plugins/mtime-cache.ts +23 -49
- package/src/plugins/worker-plugin-surface.ts +33 -0
- package/src/providers/__tests__/connection-model-compat.test.ts +1 -1
- package/src/providers/__tests__/dispatch-connection-routing.test.ts +214 -2
- package/src/providers/__tests__/preflight-resolved-config.test.ts +57 -0
- package/src/providers/__tests__/retry-callsite.test.ts +5 -2
- package/src/providers/call-site-routing.ts +30 -3
- package/src/providers/connection-resolution.ts +194 -11
- package/src/providers/inference/auth.ts +6 -0
- package/src/providers/inference/connection-availability.ts +24 -2
- package/src/providers/inference/connections.ts +2 -0
- package/src/providers/model-intents.ts +26 -6
- package/src/providers/openai/codex-models.ts +2 -1
- package/src/providers/provider-send-message.ts +32 -3
- package/src/providers/speech-to-text/__tests__/deepgram-flux-frames.test.ts +433 -0
- package/src/providers/speech-to-text/__tests__/deepgram-flux-realtime.test.ts +620 -0
- package/src/providers/speech-to-text/__tests__/provider-catalog.test.ts +34 -0
- package/src/providers/speech-to-text/__tests__/resolve.test.ts +285 -6
- package/src/providers/speech-to-text/deepgram-flux-frames.ts +395 -0
- package/src/providers/speech-to-text/deepgram-flux-realtime.ts +719 -0
- package/src/providers/speech-to-text/provider-catalog.ts +99 -8
- package/src/providers/speech-to-text/resolve.ts +25 -2
- package/src/routes/worker.ts +17 -5
- package/src/runtime/access-request-helper.ts +9 -12
- package/src/runtime/agent-wake.ts +3 -3
- package/src/runtime/pre-first-message-gate.ts +4 -0
- package/src/runtime/routes/__tests__/acp-claude-auth-routes.test.ts +12 -4
- package/src/runtime/routes/__tests__/conversation-list-routes.test.ts +219 -1
- package/src/runtime/routes/__tests__/conversation-query-routes.test.ts +52 -0
- package/src/runtime/routes/__tests__/default-provider-routes.test.ts +61 -0
- package/src/runtime/routes/__tests__/inference-profiles-routes.test.ts +44 -0
- package/src/runtime/routes/__tests__/inference-provider-connection-routes.test.ts +102 -1
- package/src/runtime/routes/__tests__/plugins-routes.test.ts +44 -0
- package/src/runtime/routes/__tests__/stt-routes.test.ts +25 -0
- package/src/runtime/routes/__tests__/user-route-dispatcher.test.ts +62 -1
- package/src/runtime/routes/channel-availability-routes.ts +32 -14
- package/src/runtime/routes/channel-route-shared.ts +0 -6
- package/src/runtime/routes/chatgpt-subscription-auth-routes.ts +6 -6
- package/src/runtime/routes/conversation-list-routes.ts +112 -1
- package/src/runtime/routes/conversation-query-routes.ts +40 -27
- package/src/runtime/routes/credential-prompt-routes.ts +4 -7
- package/src/runtime/routes/default-provider-routes.ts +15 -0
- package/src/runtime/routes/inbound-message-handler.ts +17 -41
- package/src/runtime/routes/inbound-stages/acl-enforcement.test.ts +0 -1
- package/src/runtime/routes/inbound-stages/acl-enforcement.ts +0 -9
- package/src/runtime/routes/inbound-stages/admission-policy.ts +1 -17
- package/src/runtime/routes/inbound-stages/bootstrap-intercept.test.ts +0 -1
- package/src/runtime/routes/inbound-stages/bootstrap-intercept.ts +2 -3
- package/src/runtime/routes/inbound-stages/edit-intercept.ts +1 -3
- package/src/runtime/routes/inbound-stages/guardian-reply-intercept.test.ts +0 -1
- package/src/runtime/routes/inbound-stages/guardian-reply-intercept.ts +3 -4
- package/src/runtime/routes/inbound-stages/reaction-intercept.test.ts +0 -1
- package/src/runtime/routes/inbound-stages/reaction-intercept.ts +11 -20
- package/src/runtime/routes/inbound-stages/secret-ingress-check.ts +2 -3
- package/src/runtime/routes/inference-profiles-routes.ts +20 -11
- package/src/runtime/routes/inference-provider-connection-routes.ts +77 -15
- package/src/runtime/routes/log-export-routes.ts +3 -0
- package/src/runtime/routes/mcp-auth-routes.ts +148 -57
- package/src/runtime/routes/plugins-routes.ts +21 -3
- package/src/runtime/routes/stt-routes.ts +31 -25
- package/src/runtime/routes/surface-conversation-resolver.ts +3 -0
- package/src/runtime/routes/user-route-dispatcher.ts +39 -14
- package/src/runtime/routes/user-route-import.ts +108 -0
- package/src/schedule/worker.ts +6 -0
- package/src/security/oauth2.ts +6 -22
- package/src/stt/__tests__/daemon-batch-transcriber.test.ts +22 -0
- package/src/stt/__tests__/types.test.ts +94 -0
- package/src/stt/daemon-batch-transcriber.ts +10 -0
- package/src/stt/stt-stream-session.ts +8 -4
- package/src/stt/types.ts +103 -0
- package/src/subagent/manager.ts +1 -3
- package/src/subagent/types.ts +7 -6
- package/src/tools/acp/spawn.test.ts +97 -0
- package/src/tools/acp/spawn.ts +32 -0
- package/src/tools/document/document-tool.ts +12 -3
- package/src/tools/registry.ts +2 -1
- package/src/tools/workflows/run-workflow.ts +1 -2
- package/src/tts/__tests__/reasoning-tag-filter.test.ts +63 -0
- package/src/tts/reasoning-tag-filter.ts +110 -0
- package/src/workspace/byok-default-profile-ensure.ts +61 -18
- package/src/workspace/custom-profile-ensure.ts +4 -24
- package/src/workspace/migrations/142-consolidate-voice-front-door.ts +70 -0
- package/src/workspace/migrations/143-repair-deprecated-codex-model-id.ts +134 -0
- package/src/workspace/migrations/144-convert-stranded-subscription-openai-profiles.ts +265 -0
- package/src/workspace/migrations/145-collapse-profile-bindings-to-entries.ts +328 -0
- package/src/workspace/migrations/__tests__/141-stt-english-default-to-multilingual.test.ts +0 -10
- package/src/workspace/migrations/registry.ts +8 -0
- package/src/workspace/provider-commit-message-generator.ts +7 -5
- package/src/live-voice/__tests__/front-decision.test.ts +0 -645
- package/src/live-voice/front-decision.ts +0 -476
|
@@ -0,0 +1,161 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Channels that installed plugins bring.
|
|
3
|
+
*
|
|
4
|
+
* `getWorkspacePluginsDir` is mocked to a scratch directory so these read real
|
|
5
|
+
* files off disk without touching the machine's workspace.
|
|
6
|
+
*/
|
|
7
|
+
|
|
8
|
+
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
|
9
|
+
import { tmpdir } from "node:os";
|
|
10
|
+
import { join } from "node:path";
|
|
11
|
+
import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
|
|
12
|
+
|
|
13
|
+
const workspacePluginsDir = mkdtempSync(join(tmpdir(), "plugin-channels-"));
|
|
14
|
+
|
|
15
|
+
const realPlatform = await import("../../util/platform.js");
|
|
16
|
+
|
|
17
|
+
mock.module("../../util/platform.js", () => ({
|
|
18
|
+
...realPlatform,
|
|
19
|
+
getWorkspacePluginsDir: () => workspacePluginsDir,
|
|
20
|
+
}));
|
|
21
|
+
|
|
22
|
+
const { discoverPluginChannels } = await import(
|
|
23
|
+
"../plugin-channel-declarations.js"
|
|
24
|
+
);
|
|
25
|
+
|
|
26
|
+
interface PluginOptions {
|
|
27
|
+
/** Contents of `channels/ingress.json`; omit for a plugin with no ingress. */
|
|
28
|
+
ingress?: string;
|
|
29
|
+
manifest?: Record<string, unknown>;
|
|
30
|
+
}
|
|
31
|
+
|
|
32
|
+
const INGRESS = JSON.stringify({
|
|
33
|
+
routes: [{ path: "events", kind: "http", description: "inbound" }],
|
|
34
|
+
});
|
|
35
|
+
|
|
36
|
+
function writePlugin(name: string, options: PluginOptions = {}): string {
|
|
37
|
+
const dir = join(workspacePluginsDir, name);
|
|
38
|
+
mkdirSync(dir, { recursive: true });
|
|
39
|
+
writeFileSync(
|
|
40
|
+
join(dir, "package.json"),
|
|
41
|
+
JSON.stringify({ name, ...options.manifest }),
|
|
42
|
+
);
|
|
43
|
+
if (options.ingress !== undefined) {
|
|
44
|
+
mkdirSync(join(dir, "channels"), { recursive: true });
|
|
45
|
+
writeFileSync(join(dir, "channels", "ingress.json"), options.ingress);
|
|
46
|
+
}
|
|
47
|
+
return dir;
|
|
48
|
+
}
|
|
49
|
+
|
|
50
|
+
beforeEach(() => {
|
|
51
|
+
rmSync(workspacePluginsDir, { recursive: true, force: true });
|
|
52
|
+
mkdirSync(workspacePluginsDir, { recursive: true });
|
|
53
|
+
});
|
|
54
|
+
|
|
55
|
+
afterAll(() => {
|
|
56
|
+
rmSync(workspacePluginsDir, { recursive: true, force: true });
|
|
57
|
+
});
|
|
58
|
+
|
|
59
|
+
describe("discoverPluginChannels", () => {
|
|
60
|
+
test("a plugin is a channel because it declares ingress", async () => {
|
|
61
|
+
writePlugin("courier", {
|
|
62
|
+
ingress: INGRESS,
|
|
63
|
+
manifest: {
|
|
64
|
+
displayName: "Courier",
|
|
65
|
+
description: "Reach the assistant by carrier pigeon.",
|
|
66
|
+
icon: "send",
|
|
67
|
+
},
|
|
68
|
+
});
|
|
69
|
+
|
|
70
|
+
expect(await discoverPluginChannels()).toEqual([
|
|
71
|
+
{
|
|
72
|
+
id: "courier",
|
|
73
|
+
source: "plugin:courier",
|
|
74
|
+
label: "Courier",
|
|
75
|
+
subtitle: "Reach the assistant by carrier pigeon.",
|
|
76
|
+
icon: "send",
|
|
77
|
+
supportsVerification: false,
|
|
78
|
+
setupMessages: {
|
|
79
|
+
guardian: "I want to set up Courier. Can you help me?",
|
|
80
|
+
contact:
|
|
81
|
+
"I'd like to reach you on Courier. Can you help me get set up?",
|
|
82
|
+
},
|
|
83
|
+
},
|
|
84
|
+
]);
|
|
85
|
+
});
|
|
86
|
+
|
|
87
|
+
test("ignores a plugin that declares no ingress", async () => {
|
|
88
|
+
// Presentation alone does not make a channel: reaching the assistant from
|
|
89
|
+
// outside is what one is, and ingress is where that is declared.
|
|
90
|
+
writePlugin("notes", { manifest: { displayName: "Notes", icon: "send" } });
|
|
91
|
+
|
|
92
|
+
expect(await discoverPluginChannels()).toEqual([]);
|
|
93
|
+
});
|
|
94
|
+
|
|
95
|
+
test("surfaces a channel whose ingress the gateway would reject", async () => {
|
|
96
|
+
// Validation belongs to the gateway, which owns the schema. A plugin with
|
|
97
|
+
// a broken declaration is a channel with broken ingress, and saying so
|
|
98
|
+
// beats dropping it off the page a guardian would look at.
|
|
99
|
+
writePlugin("courier", {
|
|
100
|
+
ingress: "{ not json",
|
|
101
|
+
manifest: { displayName: "Courier" },
|
|
102
|
+
});
|
|
103
|
+
|
|
104
|
+
expect((await discoverPluginChannels())[0]?.label).toBe("Courier");
|
|
105
|
+
});
|
|
106
|
+
|
|
107
|
+
test("skips a disabled plugin", async () => {
|
|
108
|
+
// Same source of truth the loader uses for hooks, tools and routes: a
|
|
109
|
+
// disabled plugin would otherwise offer a setup flow that cannot run.
|
|
110
|
+
const dir = writePlugin("courier", { ingress: INGRESS });
|
|
111
|
+
writeFileSync(join(dir, ".disabled"), "");
|
|
112
|
+
|
|
113
|
+
expect(await discoverPluginChannels()).toEqual([]);
|
|
114
|
+
});
|
|
115
|
+
|
|
116
|
+
test("refuses to let a plugin take a built-in channel's id", async () => {
|
|
117
|
+
// Two rows sharing an id would be ambiguous to any client keying on one,
|
|
118
|
+
// and letting the plugin win would let it impersonate a built-in.
|
|
119
|
+
writePlugin("slack", {
|
|
120
|
+
ingress: INGRESS,
|
|
121
|
+
manifest: { displayName: "Slack" },
|
|
122
|
+
});
|
|
123
|
+
|
|
124
|
+
expect(await discoverPluginChannels()).toEqual([]);
|
|
125
|
+
});
|
|
126
|
+
|
|
127
|
+
test("titles a plugin that names no display name", async () => {
|
|
128
|
+
// Presentation is best-effort, so a bare manifest costs a nicer title and
|
|
129
|
+
// never the row itself.
|
|
130
|
+
writePlugin("meeting-bot", { ingress: INGRESS });
|
|
131
|
+
|
|
132
|
+
expect(await discoverPluginChannels()).toMatchObject([
|
|
133
|
+
{
|
|
134
|
+
id: "meeting-bot",
|
|
135
|
+
source: "plugin:meeting-bot",
|
|
136
|
+
label: "Meeting Bot",
|
|
137
|
+
subtitle: "Provided by the Meeting Bot plugin",
|
|
138
|
+
icon: "message-square",
|
|
139
|
+
},
|
|
140
|
+
]);
|
|
141
|
+
});
|
|
142
|
+
|
|
143
|
+
test("still lists a channel whose manifest cannot be read", async () => {
|
|
144
|
+
// The directory is the plugin's identity, so an unparseable manifest
|
|
145
|
+
// costs its presentation and not its existence.
|
|
146
|
+
const dir = writePlugin("courier", { ingress: INGRESS });
|
|
147
|
+
writeFileSync(join(dir, "package.json"), "{ not json");
|
|
148
|
+
|
|
149
|
+
expect((await discoverPluginChannels())[0]?.label).toBe("Courier");
|
|
150
|
+
});
|
|
151
|
+
|
|
152
|
+
test("never claims a plugin channel supports verification", async () => {
|
|
153
|
+
// There is no client-side verification flow for one, so clients render it
|
|
154
|
+
// display-only rather than pre-warming a status that cannot arrive.
|
|
155
|
+
writePlugin("courier", { ingress: INGRESS });
|
|
156
|
+
|
|
157
|
+
expect((await discoverPluginChannels())[0]?.supportsVerification).toBe(
|
|
158
|
+
false,
|
|
159
|
+
);
|
|
160
|
+
});
|
|
161
|
+
});
|
package/src/channels/config.ts
CHANGED
|
@@ -86,6 +86,19 @@ const CHANNEL_POLICIES = {
|
|
|
86
86
|
conversationStrategy: "continue_existing_conversation",
|
|
87
87
|
},
|
|
88
88
|
},
|
|
89
|
+
plugin: {
|
|
90
|
+
notification: {
|
|
91
|
+
// Every plugin-brought channel shares this row, so the answer has to
|
|
92
|
+
// hold for all of them. A reply to an inbound plugin message routes by
|
|
93
|
+
// `replyCallbackUrl` and does not read this flag; proactive notification
|
|
94
|
+
// does, and it needs a guardian binding plus a destination resolver to
|
|
95
|
+
// reach. Neither exists per-plugin, and `NotificationChannel` is derived
|
|
96
|
+
// from this flag, so enabling it would let the decision engine pick a
|
|
97
|
+
// channel that resolves to nothing for whichever plugin it landed on.
|
|
98
|
+
deliveryEnabled: false,
|
|
99
|
+
conversationStrategy: "continue_existing_conversation",
|
|
100
|
+
},
|
|
101
|
+
},
|
|
89
102
|
} as const satisfies Record<ChannelId, ChannelNotificationPolicy>;
|
|
90
103
|
|
|
91
104
|
export type ChannelPolicies = typeof CHANNEL_POLICIES;
|
|
@@ -0,0 +1,108 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Channels that installed plugins bring.
|
|
3
|
+
*
|
|
4
|
+
* A plugin is a channel because it declares ingress: `channels/ingress.json`
|
|
5
|
+
* is the list of routes the outside world may reach it on, and reaching the
|
|
6
|
+
* assistant from outside is what being a channel means. There is no second
|
|
7
|
+
* file saying so, and nothing a plugin can set to claim the status without
|
|
8
|
+
* declaring the reach that constitutes it.
|
|
9
|
+
*
|
|
10
|
+
* What the gateway does with that file is a separate matter, and stays the
|
|
11
|
+
* gateway's: validating the routes, digesting them, holding them behind a
|
|
12
|
+
* guardian's approval. This reads its presence and nothing else, so a
|
|
13
|
+
* declaration the gateway rejects still surfaces here. That is the honest
|
|
14
|
+
* report, the plugin is a channel and its ingress is broken, and it keeps a
|
|
15
|
+
* schema this module does not own from deciding what a settings page lists.
|
|
16
|
+
*
|
|
17
|
+
* Presentation comes from the plugin's own manifest, where a plugin's title,
|
|
18
|
+
* description and icon already belong. All three are optional and none gate
|
|
19
|
+
* anything: a plugin with ingress and a bare `package.json` still appears,
|
|
20
|
+
* titled from its directory.
|
|
21
|
+
*/
|
|
22
|
+
|
|
23
|
+
import { statSync } from "node:fs";
|
|
24
|
+
import { join } from "node:path";
|
|
25
|
+
|
|
26
|
+
import { isPluginDisabled } from "../plugins/disabled-state.js";
|
|
27
|
+
import { parsePluginPresentation } from "../plugins/external-plugin-loader.js";
|
|
28
|
+
import { listInstalledPluginDirs } from "../plugins/installed-plugin-dirs.js";
|
|
29
|
+
import { type AvailableChannel, isChannelId } from "./types.js";
|
|
30
|
+
|
|
31
|
+
/**
|
|
32
|
+
* The declaration that makes a plugin a channel. Owned by the gateway, which
|
|
33
|
+
* parses it; named here only to test for it.
|
|
34
|
+
*/
|
|
35
|
+
export const PLUGIN_INGRESS_MANIFEST_RELPATH = "channels/ingress.json";
|
|
36
|
+
|
|
37
|
+
/** Icon for a plugin naming none. The generic "a message arrives here" glyph. */
|
|
38
|
+
const FALLBACK_ICON = "message-square";
|
|
39
|
+
|
|
40
|
+
/**
|
|
41
|
+
* Title for a plugin with no `displayName`.
|
|
42
|
+
*
|
|
43
|
+
* Derived rather than defaulted to the raw directory name so `meeting-bot`
|
|
44
|
+
* reads as "Meeting Bot" beside "Slack" and "Telegram". A plugin whose casing
|
|
45
|
+
* matters sets `displayName` and this never runs.
|
|
46
|
+
*/
|
|
47
|
+
function titleFromDirectory(name: string): string {
|
|
48
|
+
return name
|
|
49
|
+
.split(/[-_]/)
|
|
50
|
+
.filter((part) => part.length > 0)
|
|
51
|
+
.map((part) => part.charAt(0).toUpperCase() + part.slice(1))
|
|
52
|
+
.join(" ");
|
|
53
|
+
}
|
|
54
|
+
|
|
55
|
+
/** True when the plugin declares ingress routes. */
|
|
56
|
+
function declaresIngress(pluginDir: string): boolean {
|
|
57
|
+
return (
|
|
58
|
+
statSync(join(pluginDir, PLUGIN_INGRESS_MANIFEST_RELPATH), {
|
|
59
|
+
throwIfNoEntry: false,
|
|
60
|
+
})?.isFile() === true
|
|
61
|
+
);
|
|
62
|
+
}
|
|
63
|
+
|
|
64
|
+
/**
|
|
65
|
+
* Every channel brought by an installed, enabled plugin.
|
|
66
|
+
*
|
|
67
|
+
* A plugin whose directory name is one of the assistant's own channels is
|
|
68
|
+
* skipped: two rows sharing an id would be ambiguous to any client keying on
|
|
69
|
+
* one, and the resolution that lets a plugin win would let it impersonate a
|
|
70
|
+
* built-in channel. The assistant's keep the name.
|
|
71
|
+
*
|
|
72
|
+
* Disabled plugins are skipped too, matching the source of truth the loader
|
|
73
|
+
* uses for hooks, tools and routes: a disabled plugin holds no ingress either,
|
|
74
|
+
* and one that reappeared here would offer a setup flow that cannot run.
|
|
75
|
+
*
|
|
76
|
+
* Order follows the plugins directory, and is stable for a stable install set.
|
|
77
|
+
*/
|
|
78
|
+
export async function discoverPluginChannels(): Promise<AvailableChannel[]> {
|
|
79
|
+
const channels: AvailableChannel[] = [];
|
|
80
|
+
|
|
81
|
+
for (const { name, dir } of listInstalledPluginDirs()) {
|
|
82
|
+
if (isPluginDisabled(name) || isChannelId(name) || !declaresIngress(dir)) {
|
|
83
|
+
continue;
|
|
84
|
+
}
|
|
85
|
+
const presentation = await parsePluginPresentation(dir);
|
|
86
|
+
const label = presentation?.displayName ?? titleFromDirectory(name);
|
|
87
|
+
channels.push({
|
|
88
|
+
id: name,
|
|
89
|
+
source: `plugin:${name}`,
|
|
90
|
+
label,
|
|
91
|
+
subtitle: presentation?.description ?? `Provided by the ${label} plugin`,
|
|
92
|
+
icon: presentation?.icon ?? FALLBACK_ICON,
|
|
93
|
+
// No client-side verification flow exists for a plugin channel, so
|
|
94
|
+
// clients render it display-only and never pre-warm a status for it.
|
|
95
|
+
supportsVerification: false,
|
|
96
|
+
// Openers for a setup conversation, which is what this field is for.
|
|
97
|
+
// Deliberately not the verification copy the built-ins carry: there is
|
|
98
|
+
// no identity to verify here, and inventing that wording would send
|
|
99
|
+
// someone down a flow that does not exist.
|
|
100
|
+
setupMessages: {
|
|
101
|
+
guardian: `I want to set up ${label}. Can you help me?`,
|
|
102
|
+
contact: `I'd like to reach you on ${label}. Can you help me get set up?`,
|
|
103
|
+
},
|
|
104
|
+
});
|
|
105
|
+
}
|
|
106
|
+
|
|
107
|
+
return channels;
|
|
108
|
+
}
|
package/src/channels/types.ts
CHANGED
|
@@ -51,6 +51,32 @@ export interface ChannelInfo {
|
|
|
51
51
|
};
|
|
52
52
|
}
|
|
53
53
|
|
|
54
|
+
/**
|
|
55
|
+
* Source that contributes a channel, in the `<kind>[:<id>]` form the tool
|
|
56
|
+
* catalog and process tree already use: `default` for one the assistant ships,
|
|
57
|
+
* `plugin:<name>` for one an installed plugin brings.
|
|
58
|
+
*
|
|
59
|
+
* Composed from the plugin's install directory rather than from anything it
|
|
60
|
+
* declares, so a manifest cannot claim to be another source or pass itself off
|
|
61
|
+
* as built in.
|
|
62
|
+
*/
|
|
63
|
+
export type ChannelSource = "default" | `plugin:${string}`;
|
|
64
|
+
|
|
65
|
+
/**
|
|
66
|
+
* A channel as `/v1/channels/available` reports it: the display metadata plus
|
|
67
|
+
* where it came from.
|
|
68
|
+
*
|
|
69
|
+
* `id` widens to a string here because a plugin channel's id is its plugin
|
|
70
|
+
* name, which is not a member of the closed {@link ChannelId} union. The union
|
|
71
|
+
* still governs everything the assistant routes, verifies and applies
|
|
72
|
+
* admission policy to; `source` is what tells a client which kind it is
|
|
73
|
+
* holding, so nothing has to infer it from the id.
|
|
74
|
+
*/
|
|
75
|
+
export interface AvailableChannel extends Omit<ChannelInfo, "id"> {
|
|
76
|
+
id: string;
|
|
77
|
+
source: ChannelSource;
|
|
78
|
+
}
|
|
79
|
+
|
|
54
80
|
/**
|
|
55
81
|
* Per-channel display metadata for the channels the gateway can currently
|
|
56
82
|
* surface to clients. Add an entry here when surfacing a new channel via
|
|
@@ -155,6 +181,10 @@ export const INTERFACE_IDS = [
|
|
|
155
181
|
// device/service callbacks). Non-interactive — permission prompts route
|
|
156
182
|
// through the guardian system, not an interactive client — and non-host-proxy.
|
|
157
183
|
"route",
|
|
184
|
+
// Turns a plugin-brought channel delivered through the gateway. One id for
|
|
185
|
+
// every plugin, matching the `plugin` channel; which plugin it was is in
|
|
186
|
+
// `sourceMetadata.plugin`.
|
|
187
|
+
"plugin",
|
|
158
188
|
] as const;
|
|
159
189
|
|
|
160
190
|
export type InterfaceId = (typeof INTERFACE_IDS)[number];
|
package/src/cli/AGENTS.md
CHANGED
|
@@ -123,10 +123,13 @@ registerFooCommand(program);
|
|
|
123
123
|
_synchronously_ at command registration (so it can't be a lazy
|
|
124
124
|
`import()`) may stay hoisted behind a scoped
|
|
125
125
|
`// eslint-disable-next-line cli/no-daemon-internals` with a comment
|
|
126
|
-
explaining why. The
|
|
126
|
+
explaining why. The current cases are `browser/operation-meta`, in
|
|
127
127
|
`commands/browser.ts` (it drives synchronous subcommand generation and
|
|
128
128
|
deliberately pulls no Playwright graph) and `commands/browser.help.ts`
|
|
129
|
-
(which derives the declarative help from the same contract)
|
|
129
|
+
(which derives the declarative help from the same contract); and
|
|
130
|
+
`providers/speech-to-text/provider-catalog`, in `commands/stt.help.ts`
|
|
131
|
+
(a literal map behind type-only imports, which the help text reads to
|
|
132
|
+
name the providers that serve the batch transcription boundary).
|
|
130
133
|
|
|
131
134
|
2. **Lazy-import daemon functionality inside the action.** Running daemon
|
|
132
135
|
logic in-process is encouraged where it avoids an IPC round-trip (which
|
|
@@ -293,8 +293,8 @@ encrypted vault with the specified metadata.
|
|
|
293
293
|
Requires the assistant to be running with at least one connected client.
|
|
294
294
|
|
|
295
295
|
This command BLOCKS until the user answers the prompt, so it returns only once
|
|
296
|
-
the prompt has already closed. Tell the user what to paste BEFORE running it
|
|
297
|
-
|
|
296
|
+
the prompt has already closed. Tell the user what to paste BEFORE running it.
|
|
297
|
+
Anything said afterwards reaches them after the input is gone, and pointing
|
|
298
298
|
them at a closed prompt makes them re-submit a value that was already received.
|
|
299
299
|
The --label and --description text renders inside the prompt itself, so put the
|
|
300
300
|
instructions there rather than in a follow-up message.
|
|
@@ -7,7 +7,8 @@ export const mcpHelp: CliCommandHelp = {
|
|
|
7
7
|
description: "Manage MCP (Model Context Protocol) servers",
|
|
8
8
|
helpText: `
|
|
9
9
|
MCP servers extend the assistant's capabilities with external tools. Servers
|
|
10
|
-
are configured in the assistant's config.json under the mcp.servers key
|
|
10
|
+
are configured in the assistant's config.json under the mcp.servers key, or
|
|
11
|
+
declared by an installed plugin in its root mcp.json. Each
|
|
11
12
|
server uses one of three transport types:
|
|
12
13
|
|
|
13
14
|
stdio Local process communicating over stdin/stdout
|
|
@@ -28,13 +29,21 @@ Examples:
|
|
|
28
29
|
description: "List configured MCP servers and their status",
|
|
29
30
|
options: [{ flags: "--json", description: "Output as JSON" }],
|
|
30
31
|
helpText: `
|
|
31
|
-
Shows each
|
|
32
|
+
Shows each MCP server with its current status and configuration. Servers come
|
|
33
|
+
from two places: the mcp.servers key in config.json, and the root mcp.json of
|
|
34
|
+
any installed plugin that declares one.
|
|
32
35
|
|
|
33
|
-
Name The server identifier
|
|
34
|
-
Status Health check result:
|
|
36
|
+
Name The server identifier
|
|
37
|
+
Status Health check result for workspace servers:
|
|
35
38
|
✓ Connected and responding
|
|
36
39
|
✗ Error or disabled
|
|
37
40
|
! Needs authentication (OAuth required)
|
|
41
|
+
Plugin-declared servers report "declared" instead. They are
|
|
42
|
+
listed but not connected by the assistant, and they are not
|
|
43
|
+
health-checked, so no stored credential can reach a URL a
|
|
44
|
+
plugin chose.
|
|
45
|
+
Source Shown only for plugin-declared servers, naming the plugin.
|
|
46
|
+
Servers from config.json print no Source line.
|
|
38
47
|
Transport stdio, sse, or streamable-http
|
|
39
48
|
URL/Command The server URL (sse/streamable-http) or command (stdio)
|
|
40
49
|
Risk Default risk level: low, medium, or high
|
package/src/cli/commands/mcp.ts
CHANGED
|
@@ -24,6 +24,10 @@ interface McpServerEntry {
|
|
|
24
24
|
defaultRiskLevel: string;
|
|
25
25
|
allowedTools?: string[];
|
|
26
26
|
blockedTools?: string[];
|
|
27
|
+
/** Workspace `config.json` or a plugin's `mcp.json`. */
|
|
28
|
+
source?: "workspace" | "plugin";
|
|
29
|
+
/** Plugin that declared the server, when `source` is `plugin`. */
|
|
30
|
+
pluginName?: string;
|
|
27
31
|
}
|
|
28
32
|
|
|
29
33
|
// ---------------------------------------------------------------------------
|
|
@@ -81,6 +85,11 @@ async function pollMcpAuthStatus(
|
|
|
81
85
|
function printServerEntry(entry: McpServerEntry): void {
|
|
82
86
|
log.info(` ${entry.id}`);
|
|
83
87
|
log.info(` Status: ${entry.status}`);
|
|
88
|
+
// Only plugin-declared servers name a source. A workspace server is the
|
|
89
|
+
// default case and printing "workspace" on every one of them is noise.
|
|
90
|
+
if (entry.source === "plugin") {
|
|
91
|
+
log.info(` Source: plugin (${entry.pluginName ?? "unknown"})`);
|
|
92
|
+
}
|
|
84
93
|
log.info(` Transport: ${entry.transport?.type ?? "unknown"}`);
|
|
85
94
|
if (entry.transport?.type === "stdio") {
|
|
86
95
|
log.info(
|
|
@@ -2,12 +2,13 @@
|
|
|
2
2
|
* Tests for the `assistant memory v3` CLI subgroup (section-lane model).
|
|
3
3
|
*
|
|
4
4
|
* Validates:
|
|
5
|
-
* - Subcommand registration (rebuild-index, backfill-sections)
|
|
6
|
-
* `memory v3`.
|
|
7
|
-
* -
|
|
5
|
+
* - Subcommand registration (rebuild-index, backfill-sections, gate-stats)
|
|
6
|
+
* under `memory v3`.
|
|
7
|
+
* - `rebuild-index` and `backfill-sections` route through IPC to the daemon.
|
|
8
8
|
* - `backfill-sections` passes a long IPC timeout (the one-time full-corpus
|
|
9
|
-
* embed easily outlasts the default 60s)
|
|
10
|
-
* -
|
|
9
|
+
* embed easily outlasts the default 60s).
|
|
10
|
+
* - `gate-stats` calls handleMemoryV3GateStats directly — no daemon required.
|
|
11
|
+
* - Error paths return a non-zero exit code without throwing.
|
|
11
12
|
*/
|
|
12
13
|
|
|
13
14
|
import { beforeEach, describe, expect, mock, test } from "bun:test";
|
|
@@ -39,6 +40,47 @@ let mockIpcResult: {
|
|
|
39
40
|
/** Captured log output for assertion. */
|
|
40
41
|
let logOutput: string[] = [];
|
|
41
42
|
|
|
43
|
+
/** Shared fake gate-stats payload used across gate-stats tests. */
|
|
44
|
+
const fakeGateStats = {
|
|
45
|
+
lookbackDays: 30,
|
|
46
|
+
totalRuns: 10,
|
|
47
|
+
buckets: [
|
|
48
|
+
{
|
|
49
|
+
pageCountRange: "0–9",
|
|
50
|
+
total: 2,
|
|
51
|
+
scored: 1,
|
|
52
|
+
passed: 2,
|
|
53
|
+
scoredPassRate: 1,
|
|
54
|
+
reasons: { dense_pass: 1, dense_disabled: 1 },
|
|
55
|
+
},
|
|
56
|
+
{
|
|
57
|
+
pageCountRange: "10–49",
|
|
58
|
+
total: 5,
|
|
59
|
+
scored: 4,
|
|
60
|
+
passed: 3,
|
|
61
|
+
scoredPassRate: 0.75,
|
|
62
|
+
reasons: { dense_pass: 3, fail_no_signal: 1 },
|
|
63
|
+
},
|
|
64
|
+
{
|
|
65
|
+
pageCountRange: "50–199",
|
|
66
|
+
total: 2,
|
|
67
|
+
scored: 2,
|
|
68
|
+
passed: 1,
|
|
69
|
+
scoredPassRate: 0.5,
|
|
70
|
+
reasons: { dense_pass: 1, fail_no_signal: 1 },
|
|
71
|
+
},
|
|
72
|
+
{
|
|
73
|
+
pageCountRange: "200+",
|
|
74
|
+
total: 1,
|
|
75
|
+
scored: 1,
|
|
76
|
+
passed: 0,
|
|
77
|
+
scoredPassRate: 0,
|
|
78
|
+
reasons: { fail_no_signal: 1 },
|
|
79
|
+
},
|
|
80
|
+
],
|
|
81
|
+
unknownPageCount: { total: 0, passed: 0, reasons: {} },
|
|
82
|
+
};
|
|
83
|
+
|
|
42
84
|
// ---------------------------------------------------------------------------
|
|
43
85
|
// Mocks
|
|
44
86
|
// ---------------------------------------------------------------------------
|
|
@@ -68,6 +110,33 @@ mock.module("../../../../util/logger.js", () => ({
|
|
|
68
110
|
getCliLogger: () => fakeLogger,
|
|
69
111
|
}));
|
|
70
112
|
|
|
113
|
+
// ---------------------------------------------------------------------------
|
|
114
|
+
// gate-stats direct-invocation mocks
|
|
115
|
+
// ---------------------------------------------------------------------------
|
|
116
|
+
|
|
117
|
+
/** Args captured from the last handleMemoryV3GateStats call. */
|
|
118
|
+
let lastGateStatsArgs: { lookbackDays: number; db: unknown } | null = null;
|
|
119
|
+
|
|
120
|
+
/** What handleMemoryV3GateStats returns, or an error to throw. */
|
|
121
|
+
let gateStatsImpl: (() => unknown) | null = null;
|
|
122
|
+
|
|
123
|
+
mock.module(
|
|
124
|
+
"../../../../plugins/defaults/memory/src/memory-v3-routes.js",
|
|
125
|
+
() => ({
|
|
126
|
+
handleMemoryV3GateStats: (lookbackDays: number, db: unknown) => {
|
|
127
|
+
lastGateStatsArgs = { lookbackDays, db };
|
|
128
|
+
if (gateStatsImpl) {
|
|
129
|
+
return gateStatsImpl();
|
|
130
|
+
}
|
|
131
|
+
return fakeGateStats;
|
|
132
|
+
},
|
|
133
|
+
}),
|
|
134
|
+
);
|
|
135
|
+
|
|
136
|
+
mock.module("../../../../persistence/db-connection.js", () => ({
|
|
137
|
+
getTelemetrySqlite: () => ({}),
|
|
138
|
+
}));
|
|
139
|
+
|
|
71
140
|
// ---------------------------------------------------------------------------
|
|
72
141
|
// Import modules under test (after mocks)
|
|
73
142
|
// ---------------------------------------------------------------------------
|
|
@@ -135,6 +204,8 @@ beforeEach(() => {
|
|
|
135
204
|
ok: true,
|
|
136
205
|
result: { articles: 3, sections: 12, failures: 0 },
|
|
137
206
|
};
|
|
207
|
+
lastGateStatsArgs = null;
|
|
208
|
+
gateStatsImpl = null;
|
|
138
209
|
logOutput = [];
|
|
139
210
|
process.exitCode = 0;
|
|
140
211
|
});
|
|
@@ -155,6 +226,7 @@ describe("subcommand registration", () => {
|
|
|
155
226
|
"backfill-sections",
|
|
156
227
|
"eval",
|
|
157
228
|
"eval-tally",
|
|
229
|
+
"gate-stats",
|
|
158
230
|
"rebuild-index",
|
|
159
231
|
]);
|
|
160
232
|
});
|
|
@@ -236,3 +308,54 @@ describe("memory v3 backfill-sections", () => {
|
|
|
236
308
|
expect(exitCode).toBe(1);
|
|
237
309
|
});
|
|
238
310
|
});
|
|
311
|
+
|
|
312
|
+
// ---------------------------------------------------------------------------
|
|
313
|
+
// gate-stats (direct invocation — no daemon required)
|
|
314
|
+
// ---------------------------------------------------------------------------
|
|
315
|
+
|
|
316
|
+
describe("memory v3 gate-stats", () => {
|
|
317
|
+
test("calls handleMemoryV3GateStats directly with default lookback (no IPC)", async () => {
|
|
318
|
+
const { exitCode } = await runCommand(["memory", "v3", "gate-stats"]);
|
|
319
|
+
|
|
320
|
+
expect(exitCode).toBe(0);
|
|
321
|
+
// Must NOT have gone through IPC.
|
|
322
|
+
expect(lastIpcCall).toBeNull();
|
|
323
|
+
// Must have called the handler directly with the default lookback.
|
|
324
|
+
expect(lastGateStatsArgs!.lookbackDays).toBe(30);
|
|
325
|
+
});
|
|
326
|
+
|
|
327
|
+
test("forwards --lookback-days directly to handleMemoryV3GateStats", async () => {
|
|
328
|
+
await runCommand(["memory", "v3", "gate-stats", "--lookback-days", "7"]);
|
|
329
|
+
|
|
330
|
+
expect(lastIpcCall).toBeNull();
|
|
331
|
+
expect(lastGateStatsArgs!.lookbackDays).toBe(7);
|
|
332
|
+
});
|
|
333
|
+
|
|
334
|
+
test("prints formatted table on success (no --json)", async () => {
|
|
335
|
+
await runCommand(["memory", "v3", "gate-stats"]);
|
|
336
|
+
|
|
337
|
+
expect(logOutput.some((l) => l.includes("Gate-stats"))).toBe(true);
|
|
338
|
+
expect(logOutput.some((l) => l.includes("10–49"))).toBe(true);
|
|
339
|
+
expect(logOutput.some((l) => l.includes("75.0%"))).toBe(true);
|
|
340
|
+
});
|
|
341
|
+
|
|
342
|
+
test("emits raw JSON with --json", async () => {
|
|
343
|
+
await runCommand(["memory", "v3", "gate-stats", "--json"]);
|
|
344
|
+
|
|
345
|
+
const raw = logOutput.join("");
|
|
346
|
+
const parsed = JSON.parse(raw) as typeof fakeGateStats;
|
|
347
|
+
expect(parsed.totalRuns).toBe(10);
|
|
348
|
+
expect(parsed.buckets).toHaveLength(4);
|
|
349
|
+
});
|
|
350
|
+
|
|
351
|
+
test("exits with code 1 when handleMemoryV3GateStats throws", async () => {
|
|
352
|
+
gateStatsImpl = () => {
|
|
353
|
+
throw new Error("telemetry DB locked");
|
|
354
|
+
};
|
|
355
|
+
|
|
356
|
+
const { exitCode } = await runCommand(["memory", "v3", "gate-stats"]);
|
|
357
|
+
|
|
358
|
+
expect(exitCode).toBe(1);
|
|
359
|
+
expect(logOutput.some((l) => l.includes("telemetry DB locked"))).toBe(true);
|
|
360
|
+
});
|
|
361
|
+
});
|
|
@@ -606,7 +606,9 @@ that live state safely.
|
|
|
606
606
|
|
|
607
607
|
Examples:
|
|
608
608
|
$ assistant memory v3 rebuild-index
|
|
609
|
-
$ assistant memory v3 backfill-sections
|
|
609
|
+
$ assistant memory v3 backfill-sections
|
|
610
|
+
$ assistant memory v3 gate-stats
|
|
611
|
+
$ assistant memory v3 gate-stats --lookback-days 7 --json`,
|
|
610
612
|
subcommands: [
|
|
611
613
|
{
|
|
612
614
|
name: "rebuild-index",
|
|
@@ -716,6 +718,46 @@ Examples:
|
|
|
716
718
|
$ assistant memory v3 eval --snapshot .mv3/snapshot/concepts --staging .mv3/staging --out .mv3/eval
|
|
717
719
|
$ assistant memory v3 eval --snapshot .mv3/snapshot/concepts --staging .mv3/staging --out .mv3/eval --turns-file .mv3/eval/key.json
|
|
718
720
|
$ assistant memory v3 eval --snapshot .mv3/snapshot/concepts --staging .mv3/staging --out .mv3/eval --exclude-conversation <migration-conv-id>`,
|
|
721
|
+
},
|
|
722
|
+
{
|
|
723
|
+
name: "gate-stats",
|
|
724
|
+
description:
|
|
725
|
+
"Show injection gate pass rates bucketed by corpus size (read-only)",
|
|
726
|
+
options: [
|
|
727
|
+
{
|
|
728
|
+
flags: "--lookback-days <n>",
|
|
729
|
+
description: "Days of telemetry to aggregate (1–90, default 30)",
|
|
730
|
+
defaultValue: "30",
|
|
731
|
+
},
|
|
732
|
+
{
|
|
733
|
+
flags: "--json",
|
|
734
|
+
description: "Emit raw JSON instead of a formatted table",
|
|
735
|
+
},
|
|
736
|
+
],
|
|
737
|
+
helpText: `
|
|
738
|
+
Reads the memory v3 injection gate telemetry outbox and prints pass rates
|
|
739
|
+
and reason distributions grouped by concept page count bucket
|
|
740
|
+
(0–9 / 10–49 / 50–199 / 200+). Scored runs (dense lane was available and
|
|
741
|
+
actually weighed scores) are reported separately from pass-open shortcuts
|
|
742
|
+
(dense disabled / unavailable / gate threw) so scoredPassRate reflects
|
|
743
|
+
only contested gate decisions — the signal relevant for threshold calibration.
|
|
744
|
+
|
|
745
|
+
Coverage is limited to runs still pending platform flush. In a healthy system
|
|
746
|
+
the outbox holds only the last few minutes to hours of events, so
|
|
747
|
+
--lookback-days is an upper bound, not a guarantee; long-window aggregation
|
|
748
|
+
lives on the platform side on top of flushed watchdog events.
|
|
749
|
+
|
|
750
|
+
Reads the telemetry database directly — the assistant does not need to be
|
|
751
|
+
running.
|
|
752
|
+
|
|
753
|
+
Intended use: verify that gate firing rates shift as expected after a
|
|
754
|
+
config or threshold change, and check whether the bm25-auto-calibration
|
|
755
|
+
flag is worth enabling for large corpora.
|
|
756
|
+
|
|
757
|
+
Examples:
|
|
758
|
+
$ assistant memory v3 gate-stats
|
|
759
|
+
$ assistant memory v3 gate-stats --lookback-days 7
|
|
760
|
+
$ assistant memory v3 gate-stats --json | jq '.buckets[] | select(.pageCountRange == "200+")'`,
|
|
719
761
|
},
|
|
720
762
|
{
|
|
721
763
|
name: "eval-tally",
|