@vellumai/assistant 0.11.1 → 0.11.2-staging.2

package/src/workspace/migrations/138-backfill-home-feed-titles.ts

@@ -0,0 +1,179 @@
+/**
+ * Workspace migration `138-backfill-home-feed-titles`.
+ *
+ * Gives every item in `<workspace>/data/home-feed.json` a non-empty
+ * `title`. The feed writer sets one on every item it appends; stored
+ * items that lack the field get a headline derived from their own
+ * `summary`, so the field is uniformly present across the file.
+ *
+ * Behaviour:
+ *   - Missing file, unparseable JSON, or a non-object root: no-op.
+ *   - Item that already has a non-empty `title`: untouched.
+ *   - Item without one: title derived from `summary` (markdown and
+ *     newlines flattened, first sentence, capped at 60 characters with
+ *     an ellipsis).
+ *   - `version`, `updatedAt`, and every other item field are preserved.
+ *
+ * Idempotent: a second run finds every item titled, so it writes
+ * nothing. The runner's checkpoint also skips re-runs, but this in-file
+ * guard keeps the migration safe even if the checkpoint is wiped.
+ */
+
+import { existsSync, readFileSync, renameSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+
+import { getLogger } from "../../util/logger.js";
+import type { WorkspaceMigration } from "./types.js";
+
+const log = getLogger("workspace-migration-138-backfill-home-feed-titles");
+
+const HOME_FEED_RELATIVE_PATH = join("data", "home-feed.json");
+
+/**
+ * Matches `NOTIFICATION_TITLE_MAX_LENGTH` in
+ * `notifications/notification-utils.ts`, the cap on the headline the feed
+ * writer derives from a summary, so a backfilled item and a freshly
+ * written one with the same summary carry the same title.
+ */
+const MAX_TITLE_LENGTH = 60;
+
+/**
+ * The persisted item fields this migration touches. Inlined rather than
+ * imported from `home/feed-types.ts` so the migration stays
+ * self-contained per the migrations AGENTS.md.
+ */
+interface PersistedFeedItem {
+  /** Missing, empty, or non-string on the items repaired here. */
+  title?: unknown;
+  /** Source text for the derived title. */
+  summary?: unknown;
+  /** Every other persisted field is carried through untouched. */
+  [key: string]: unknown;
+}
+
+export const backfillHomeFeedTitlesMigration: WorkspaceMigration = {
+  id: "138-backfill-home-feed-titles",
+  description:
+    "Backfill a summary-derived title on home-feed items that lack one",
+
+  run(workspaceDir: string): void {
+    const path = join(workspaceDir, HOME_FEED_RELATIVE_PATH);
+    if (!existsSync(path)) {
+      return;
+    }
+
+    // Read outside the parse catch: a transient filesystem error (EIO,
+    // EACCES) must reach the runner so the migration retries, while
+    // malformed JSON is a permanent state this migration cannot repair.
+    const rawText = readFileSync(path, "utf-8");
+
+    let feed: Record<string, unknown>;
+    try {
+      const parsed = JSON.parse(rawText);
+      if (!isPlainObject(parsed)) {
+        return;
+      }
+      feed = parsed;
+    } catch (err) {
+      log.warn(
+        { err, path },
+        "Failed to parse home-feed.json; skipping title backfill",
+      );
+      return;
+    }
+
+    const rawItems = Array.isArray(feed.items) ? feed.items : [];
+    let backfilled = 0;
+    for (const entry of rawItems) {
+      if (!isPlainObject(entry)) {
+        continue;
+      }
+      const item: PersistedFeedItem = entry;
+      if (typeof item.title === "string" && item.title.trim().length > 0) {
+        continue;
+      }
+      if (typeof item.summary !== "string") {
+        continue;
+      }
+      const derived = deriveTitle(item.summary);
+      if (derived.length === 0) {
+        continue;
+      }
+      item.title = derived;
+      backfilled++;
+    }
+
+    if (backfilled === 0) {
+      return;
+    }
+
+    // Write-then-rename so an interrupted write cannot leave
+    // home-feed.json truncated: the reader treats an unparseable file as
+    // an empty feed, so a torn in-place write would discard the user's
+    // notification history outright.
+    const tmpPath = `${path}.migration-138.tmp`;
+    writeFileSync(tmpPath, JSON.stringify(feed, null, 2), "utf-8");
+    renameSync(tmpPath, path);
+
+    log.info({ path, backfilled }, "Backfilled titles on home-feed items");
+  },
+
+  // Deriving a title from the summary is idempotent, so a transient
+  // failure (full disk, I/O error) is safe to retry on later startups.
+  retryFailedCheckpoint: true,
+
+  down(_workspaceDir: string): void {
+    // Forward-only: a derived title is indistinguishable from an
+    // authored one, so there is nothing safe to strip back out.
+  },
+};
+
+// ---------------------------------------------------------------------------
+// Helpers: self-contained per the workspace migrations AGENTS.md
+// ---------------------------------------------------------------------------
+
+/**
+ * Derive a short headline from a summary: the markdown is flattened to a
+ * single line of plain text, the first sentence is taken when the text
+ * has a terminator, and the result is capped at `MAX_TITLE_LENGTH`
+ * characters with an ellipsis. Returns "" when nothing usable survives.
+ *
+ * Inlined rather than imported from the notification pipeline so the
+ * migration stays self-contained per the migrations AGENTS.md.
+ */
+function deriveTitle(summary: string): string {
+  const text = flattenToPlainText(summary);
+  const firstSentenceEnd = text.search(/[.!?](\s|$)/);
+  const candidate =
+    firstSentenceEnd > 0 ? text.slice(0, firstSentenceEnd + 1) : text;
+  return candidate.length > MAX_TITLE_LENGTH
+    ? candidate.slice(0, MAX_TITLE_LENGTH).trim() + "…"
+    : candidate.trim();
+}
+
+/**
+ * Reduce markdown-rich summary text to a single line of plain prose:
+ * block structure (code fences, headings, blockquotes, list markers) is
+ * dropped, inline formatting is unwrapped, and every run of whitespace,
+ * newlines included, collapses to one space.
+ */
+function flattenToPlainText(text: string): string {
+  return text
+    .replace(/^\s{0,3}(?:```|~~~).*$/gm, "")
+    .replace(/^\s{0,3}#{1,6}\s+/gm, "")
+    .replace(/^\s{0,3}>\s?/gm, "")
+    .replace(/^\s{0,3}(?:[-*+]|\d+[.)])\s+/gm, "")
+    .replace(/\*\*(.+?)\*\*/g, "$1")
+    .replace(/__(.+?)__/g, "$1")
+    .replace(/\*(.+?)\*/g, "$1")
+    .replace(/(?<!\w)_(.+?)_(?!\w)/g, "$1")
+    .replace(/~~(.+?)~~/g, "$1")
+    .replace(/`(.+?)`/g, "$1")
+    .replace(/\[(.+?)\]\(.*?\)/g, "$1")
+    .replace(/\s+/g, " ")
+    .trim();
+}
+
+function isPlainObject(value: unknown): value is Record<string, unknown> {
+  return typeof value === "object" && value !== null && !Array.isArray(value);
+}

package/src/workspace/migrations/139-clear-renamed-cost-profile-label.ts

@@ -0,0 +1,92 @@
+import { existsSync, readFileSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+
+import type { WorkspaceMigration } from "./types.js";
+
+/**
+ * Clear the machinery-written `"Speed"` label off the `cost-optimized`
+ * profile so the code catalog's new label ("Cost") reaches existing installs.
+ *
+ * `label` is workspace-owned overlay state: a managed-source entry's label
+ * wins over the code default (`WORKSPACE_OWNED_DEFAULT_FIELDS` in
+ * `config/default-profile-catalog.ts`). Migration 082 and the pre-catalog
+ * seeder both wrote `"Speed"` onto `cost-optimized`, and migration 126
+ * carried it onto the thin stub, so without this the picker would show two
+ * profiles named "Speed": `cost-optimized`'s stale overlay and
+ * `latency-optimized`, the user-facing Speed profile.
+ *
+ * Deleting the key (rather than writing "Cost") returns the label to code
+ * ownership, so later renames ship with a release instead of a migration.
+ *
+ * Only the exact string `"Speed"` is cleared. A user rename to anything else
+ * survives, as does an explicit `null` (label deliberately cleared). A rename
+ * that happened to be "Speed" is indistinguishable from the seeded value and
+ * is cleared too.
+ *
+ * Deliberately does NOT touch the `"Speed (Managed)"` label on BYOK hatch
+ * stubs: `ensureByokDefaultProfiles` matches that exact string to recognize a
+ * hatch stub and delete it (which is what re-enables the profile). Clearing
+ * it here would strand those installs with `cost-optimized` disabled. Once
+ * that pass removes the stub, the code label applies.
+ */
+export const clearRenamedCostProfileLabelMigration: WorkspaceMigration = {
+  id: "139-clear-renamed-cost-profile-label",
+  description:
+    'Clear the seeded "Speed" label on cost-optimized so the code catalog label applies',
+  run(workspaceDir: string): void {
+    const configPath = join(workspaceDir, "config.json");
+    if (!existsSync(configPath)) {
+      return;
+    }
+
+    // Read outside the parse catch: a transient filesystem error must reach
+    // the runner so the migration retries, while malformed JSON is a
+    // permanent state this migration cannot repair.
+    const rawText = readFileSync(configPath, "utf-8");
+
+    let config: Record<string, unknown>;
+    try {
+      const parsed = JSON.parse(rawText);
+      if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) {
+        return;
+      }
+      config = parsed as Record<string, unknown>;
+    } catch {
+      return;
+    }
+
+    const llm = readObject(config.llm);
+    if (llm === null) {
+      return;
+    }
+    const profiles = readObject(llm.profiles);
+    if (profiles === null) {
+      return;
+    }
+    const entry = readObject(profiles["cost-optimized"]);
+    if (entry === null) {
+      return;
+    }
+    // Only a managed-source entry carries a machinery-written label. Anything
+    // else, a source-less legacy entry included, shadows the default outright
+    // (see `getEffectiveProfile`), so its label is the user's.
+    if (entry.source !== "managed") {
+      return;
+    }
+    if (entry.label !== "Speed") {
+      return;
+    }
+
+    delete entry.label;
+    writeFileSync(configPath, JSON.stringify(config, null, 2) + "\n");
+  },
+  down(_workspaceDir: string): void {
+    // Forward-only: the label is code-owned once cleared.
+  },
+};
+
+function readObject(value: unknown): Record<string, unknown> | null {
+  return value !== null && typeof value === "object" && !Array.isArray(value)
+    ? (value as Record<string, unknown>)
+    : null;
+}

package/src/workspace/migrations/registry.ts

@@ -134,6 +134,9 @@ import { collapseProviderConnectionsMigration } from "./133-collapse-provider-co
 import { imageGenerationModeToProviderMigration } from "./134-image-generation-mode-to-provider.js";
 import { copySubstrateTunablesMigration } from "./135-copy-substrate-tunables.js";
 import { repairStaleFireworksKimiModelIdMigration } from "./136-repair-stale-fireworks-kimi-model-id.js";
+import { repairRetiredFireworksMinimaxModelIdMigration } from "./137-repair-retired-fireworks-minimax-model-id.js";
+import { backfillHomeFeedTitlesMigration } from "./138-backfill-home-feed-titles.js";
+import { clearRenamedCostProfileLabelMigration } from "./139-clear-renamed-cost-profile-label.js";
 import { migrateToWorkspaceVolumeMigration } from "./migrate-to-workspace-volume.js";
 import type { WorkspaceMigration } from "./types.js";
 
@@ -283,4 +286,7 @@ export const WORKSPACE_MIGRATIONS: WorkspaceMigration[] = [
   imageGenerationModeToProviderMigration,
   copySubstrateTunablesMigration,
   repairStaleFireworksKimiModelIdMigration,
+  repairRetiredFireworksMinimaxModelIdMigration,
+  backfillHomeFeedTitlesMigration,
+  clearRenamedCostProfileLabelMigration,
 ];

package/src/plugins/defaults/memory/substrate/constants.ts

@@ -1,8 +0,0 @@
-/**
- * Canonical `conversations.source` string for background memory v2
- * consolidation runs. Lives in a tiny constants module so the route layer can
- * recognize consolidation conversations without importing the consolidation
- * job (which pulls in agent-wake + bootstrap dependencies).
- */
-// FROZEN: persisted `conversations.source` value — never rename it.
-export const MEMORY_V2_CONSOLIDATION_SOURCE = "memory_v2_consolidation";