@vellumai/assistant 0.10.7-dev.202607101554.2aa9767 → 0.10.7-dev.202607101836.11f2eba

package/docs/workspace-tools.md

@@ -127,12 +127,11 @@ on the incoming tool.
 ## Lifecycle position
 
 ```
+loadUserPlugins()             # populates the plugin mtime-cache (no registry writes)
 initializeTools()             # core tools register
   → loadWorkspaceTools()      # initial workspace tool reconcile
+  → loadPluginTools()         # registry pulls the active user-plugin tool set
     → MCP tool registration
-    → loadUserPlugins()       # populates the plugin mtime-cache (no registry writes)
-    → loadPluginTools()       # registry pulls the active user-plugin tool set
-    → bootstrapPlugins()
 
 # on every conversation turn (createResolveToolsCallback):
 resolveTools(history)

package/eslint-rules/__tests__/cli-no-daemon-internals.test.ts

@@ -11,410 +11,112 @@ const tester = new RuleTester({
   },
 });
 
+// A command file two levels under src/cli (src/cli/commands/<file>.ts) and a
+// nested one (src/cli/commands/oauth/<file>.ts) — the rule anchors `src/` off
+// the `.../src/cli/` prefix, so a realistic absolute filename is required.
+const FILE = "/repo/assistant/src/cli/commands/example.ts";
+const NESTED = "/repo/assistant/src/cli/commands/oauth/example.ts";
+
 tester.run("cli/no-daemon-internals", rule, {
   valid: [
-    // ipc-tagged file importing only allowed sources
-    {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-        import { log } from "../logger.js";
-        import { printTable } from "../output.js";
-
-        registerCommand(program, {
-          name: "example",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
-    },
-    // local-tagged file importing allowed sources
-    {
-      code: `
-        import type { Command } from "commander";
-        import { loadRawConfig } from "../../config/loader.js";
-        import { getWorkspaceDir } from "../../util/platform.js";
-
-        registerCommand(program, {
-          name: "local-example",
-          transport: "local",
-          build: () => {},
-        });
-      `,
-    },
-    // bootstrap-tagged file importing allowed sources
+    // Node/npm/scoped packages are always hoistable.
     {
+      filename: FILE,
       code: `
-        import type { Command } from "commander";
-        import { AssistantConfigSchema } from "../../config/schema.js";
-
-        registerCommand(program, {
-          name: "bootstrap-example",
-          transport: "bootstrap",
-          build: () => {},
-        });
+        import { writeFileSync } from "node:fs";
+        import { Command } from "commander";
+        import { something } from "@vellumai/service-contracts";
       `,
     },
-    // ipc-tagged file importing from ../lib/ prefix (shared lib)
+    // The IPC client and socket path (src/ipc) are shared leaf transport.
     {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-        import { readFileSync } from "../lib/daemon-credential-client.js";
-
-        registerCommand(program, {
-          name: "lib-example",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
+      filename: FILE,
+      code: `import { cliIpcCall } from "../../ipc/cli-client.js";`,
     },
-    // File with zero imports and no registerCommand — utility file
     {
-      code: `
-        function utilHelper() {
-          return 42;
-        }
-        export { utilHelper };
-      `,
+      filename: FILE,
+      code: `import { getAssistantSocketPath } from "../../ipc/socket-path.js";`,
     },
-    // Helper module — has imports but does not call registerCommand directly.
-    // Helper modules under commands/ (e.g. oauth/shared.ts, lib/cache-fs.ts)
-    // are not command entries and the rule must not fire on them, even when
-    // they import from outside the registrar allowlists.
+    // The CLI's own tree (../logger, ../output, ../lib, sibling files).
     {
+      filename: FILE,
       code: `
-        import type { Command } from "commander";
-        import { getProvider } from "../../../oauth/oauth-store.js";
-
-        export function buildAuthFlow(program) {
-          // helper module — no registerCommand call here; the actual
-          // command file imports this and calls registerCommand itself.
-        }
-      `,
-    },
-    // local-tagged file importing ../logger and ../output — both must be on
-    // the local allowlist (regression test for the allowlist gap that
-    // false-positived autonomy/config/completions/keys/credential-execution).
-    {
-      code: `
-        import type { Command } from "commander";
         import { log } from "../logger.js";
         import { writeOutput } from "../output.js";
-
-        registerCommand(program, {
-          name: "local-with-output",
-          transport: "local",
-          build: () => {},
-        });
+        import { registerCommand } from "../lib/register-command.js";
+        import { helper } from "./sibling.js";
       `,
     },
-    // Type-only imports are erased at compile time and must not count as
-    // runtime boundary violations, even when the source path is outside the
-    // allowlist (e.g. `import type` from runtime/routes for response shapes).
+    // Shared leaf zones: util/, version.
     {
+      filename: FILE,
       code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-        import type { MemoryV2Result } from "../../runtime/routes/memory-v2-routes.js";
-
-        registerCommand(program, {
-          name: "ipc-with-type-import",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
-    },
-    // Inline `import { type X }` form: importKind is set per specifier,
-    // not on the declaration. When every specifier is type-only the import
-    // is erased and must not flag a forbidden-runtime-import violation.
-    {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-        import { type MemoryV2Result, type ScoreBreakdown } from "../../runtime/routes/memory-v2-routes.js";
-
-        registerCommand(program, {
-          name: "ipc-with-inline-type-import",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
-    },
-    // Chained registerCommand pattern: `registerCommand(...).command(...)`.
-    // The outer call's callee is a MemberExpression whose object is the
-    // inner registerCommand call. The AST walker must follow callee +
-    // MemberExpression.object so findTransport() locates the registerCommand
-    // call and applies the correct transport allowlist.
-    {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-
-        registerCommand(program, {
-          name: "ipc-chained",
-          transport: "ipc",
-          build: () => {},
-        }).command("subcmd").description("desc");
-      `,
-    },
-    // Sibling subcommand composition: an index file (e.g. oauth/index.ts)
-    // imports sibling subcommand files (./connect.js, ./disconnect.js) to
-    // attach them under a parent group. The imported file is itself a
-    // command and the rule checks its imports independently, so this can't
-    // smuggle daemon internals.
-    {
-      code: `
-        import type { Command } from "commander";
-        import { registerCommand } from "../../lib/register-command.js";
-        import { setupConnect } from "./connect.js";
-        import { setupDisconnect } from "./disconnect.js";
-
-        registerCommand(program, {
-          name: "ipc-index-composition",
-          transport: "ipc",
-          build: () => {},
-        });
+        import { getWorkspaceDir } from "../../util/platform.js";
+        import { readStdinSync } from "../../util/read-stdin.js";
+        import { APP_VERSION } from "../../version.js";
       `,
     },
-    // Nested command file (commands/oauth/foo.ts) needs deeper relative
-    // paths to the IPC client, lib/, logger, and output. Without the
-    // depth-2 entries the rule would false-positive on every nested
-    // command (oauth/*, platform/*).
+    // Nested command file reaching the same leaf zones one level deeper.
     {
+      filename: NESTED,
       code: `
-        import type { Command } from "commander";
         import { cliIpcCall } from "../../../ipc/cli-client.js";
-        import { registerCommand } from "../../lib/register-command.js";
-        import { log } from "../../logger.js";
-        import { writeOutput } from "../../output.js";
-
-        registerCommand(program, {
-          name: "ipc-nested",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
-    },
-    // Shared CLI utils (src/cli/utils/*) — sibling utility directory used
-    // by task/ui/conversations-defer for ID resolution and parsing. Lives
-    // alongside lib/ but historically wasn't on the allowlist.
-    {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-        import { resolveConversationId } from "../utils/conversation-id.js";
-        import { parseDuration } from "../utils/parse-duration.js";
-
-        registerCommand(program, {
-          name: "ipc-with-utils",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
-    },
-    // status.ts pattern: when the daemon is unreachable, the command falls
-    // back to a local socket-path probe + platform helpers. Both imports
-    // are part of the documented daemon-down fallback contract (§3.7).
-    {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-        import { getSocketPath } from "../../ipc/socket-path.js";
-        import { getWorkspaceDir } from "../../util/platform.js";
-
-        registerCommand(program, {
-          name: "ipc-status",
-          transport: "ipc",
-          build: () => {},
-        });
+        import { isWeakOpenModel } from "../../../util/weak-open-model.js";
       `,
     },
-    // local-tagged keys.ts pattern: the secure-key helpers are designed to
-    // run in-process (not over IPC), so direct security/* imports are part
-    // of the contract.
+    // Type-only imports from daemon internals are erased — always fine.
     {
-      code: `
-        import type { Command } from "commander";
-        import { credentialKey } from "../../security/credential-key.js";
-        import { getSecureKeyAsync } from "../../security/secure-keys.js";
-
-        registerCommand(program, {
-          name: "local-keys",
-          transport: "local",
-          build: () => {},
-        });
-      `,
+      filename: FILE,
+      code: `import type { ComparisonReport } from "../../runtime/harness/runner.js";`,
     },
-    // local-tagged credential-execution.ts pattern: speaks to the CES
-    // sidecar via service-contracts RPC; the daemon is not involved.
+    // Inline all-type import from a daemon module is also erased.
     {
-      code: `
-        import type { Command } from "commander";
-        import { credentialRpc } from "@vellumai/service-contracts/credential-rpc";
-        import { connect } from "../../credential-execution/client.js";
-
-        registerCommand(program, {
-          name: "local-ces",
-          transport: "local",
-          build: () => {},
-        });
-      `,
+      filename: FILE,
+      code: `import { type RepairContext } from "../../daemon/repair.js";`,
     },
-    // local-tagged config.ts uses zod for schema validation and reaches
-    // across to oauth/shared.ts for the managed-mode platform-connection
-    // check (documented cross-namespace helper).
+    // Dynamic import() of a daemon module is the encouraged pattern — the rule
+    // only inspects static ImportDeclarations, so this must not be flagged.
     {
+      filename: FILE,
       code: `
-        import type { Command } from "commander";
-        import { z } from "zod";
-        import { loadRawConfig } from "../../config/loader.js";
-        import { requirePlatformConnection } from "./oauth/shared.js";
-
-        registerCommand(program, {
-          name: "local-config",
-          transport: "local",
-          build: () => {},
-        });
+        async function run() {
+          const { doTheThing } = await import("../../runtime/foo.js");
+          await doTheThing();
+        }
       `,
     },
   ],
-
   invalid: [
-    // registerCommand called without a string transport prop — the actual
-    // missingTransport case (command-entry file forgot to declare its class).
+    // Hoisting a daemon runtime module.
     {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-
-        registerCommand(program, {
-          name: "no-transport",
-          build: () => {},
-        });
-      `,
-      errors: [
-        {
-          messageId: "missingTransport",
-        },
-      ],
+      filename: FILE,
+      code: `import { doTheThing } from "../../runtime/foo.js";`,
+      errors: [{ messageId: "hoistedDaemonImport" }],
     },
-    // ipc-tagged file importing a forbidden runtime route
+    // Hoisting the persistence schema.
     {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-        import { healthRoutes } from "../../runtime/routes/health-routes.js";
-
-        registerCommand(program, {
-          name: "bad-ipc",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
-      errors: [
-        {
-          messageId: "forbiddenImport",
-          data: {
-            transport: "ipc",
-            source: "../../runtime/routes/health-routes.js",
-          },
-        },
-      ],
+      filename: FILE,
+      code: `import { conversations } from "../../persistence/schema/conversations.js";`,
+      errors: [{ messageId: "hoistedDaemonImport" }],
     },
-    // ipc-tagged file importing a skills catalog module
+    // Hoisting the platform client.
     {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-        import { SkillsCatalog } from "../../skills/catalog.js";
-
-        registerCommand(program, {
-          name: "bad-ipc-skills",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
-      errors: [
-        {
-          messageId: "forbiddenImport",
-          data: {
-            transport: "ipc",
-            source: "../../skills/catalog.js",
-          },
-        },
-      ],
+      filename: NESTED,
+      code: `import { VellumPlatformClient } from "../../../platform/client.js";`,
+      errors: [{ messageId: "hoistedDaemonImport" }],
     },
-    // local-tagged file importing a forbidden runtime route
+    // A non-leaf module under providers/ is daemon-internal (only util/ etc.
+    // are exempt, not providers/).
     {
-      code: `
-        import type { Command } from "commander";
-        import { loadRawConfig } from "../../config/loader.js";
-        import { healthRoutes } from "../../runtime/routes/health-routes.js";
-
-        registerCommand(program, {
-          name: "bad-local",
-          transport: "local",
-          build: () => {},
-        });
-      `,
-      errors: [
-        {
-          messageId: "forbiddenImport",
-          data: {
-            transport: "local",
-            source: "../../runtime/routes/health-routes.js",
-          },
-        },
-      ],
-    },
-    // Nested command file (commands/oauth/foo.ts) STILL rejects runtime
-    // route imports. Locking in the boundary so the depth-2 allowlist
-    // additions don't accidentally open daemon-internal namespaces.
-    {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../../ipc/cli-client.js";
-        import { healthRoutes } from "../../../runtime/routes/health-routes.js";
-
-        registerCommand(program, {
-          name: "bad-ipc-nested",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
-      errors: [
-        {
-          messageId: "forbiddenImport",
-          data: {
-            transport: "ipc",
-            source: "../../../runtime/routes/health-routes.js",
-          },
-        },
-      ],
+      filename: FILE,
+      code: `import { resolveProvider } from "../../providers/registry.js";`,
+      errors: [{ messageId: "hoistedDaemonImport" }],
     },
-    // services/, agents/, llm/ namespaces remain forbidden for ipc commands.
+    // Value import mixed with a type specifier still counts (not all-type).
     {
-      code: `
-        import type { Command } from "commander";
-        import { cliIpcCall } from "../../ipc/cli-client.js";
-        import { dispatchAgent } from "../../agents/dispatcher.js";
-
-        registerCommand(program, {
-          name: "bad-ipc-agents",
-          transport: "ipc",
-          build: () => {},
-        });
-      `,
-      errors: [
-        {
-          messageId: "forbiddenImport",
-          data: {
-            transport: "ipc",
-            source: "../../agents/dispatcher.js",
-          },
-        },
-      ],
+      filename: FILE,
+      code: `import { run, type Opts } from "../../security/keys.js";`,
+      errors: [{ messageId: "hoistedDaemonImport" }],
     },
   ],
 });