@vellumai/assistant 0.10.4 → 0.10.5-dev.202607022329.d89bf2f

package/src/plugin-api/types.ts

@@ -134,20 +134,32 @@ export interface ModelProfileInfo {
 // ─── Shutdown context ────────────────────────────────────────────────────────
 
 /**
- * Context passed to the `shutdown` hook during daemon teardown. Kept
- * intentionally narrower than {@link InitContext} — most teardown
- * paths only need to know which assistant version they're shutting
- * down against (e.g. for version-conditional cleanup of state files
- * written by a previous boot).
+ * Why a plugin's `shutdown` hook is firing.
  *
- * Additional fields may be added as concrete plugin needs surface; the
- * `assistantVersion` field mirrors the init context's so plugins that
- * stash a version stamp at init can compare against the same name on
- * tear-down without keeping their own copy.
+ * - `shutdown` — the daemon is tearing down (process exit).
+ * - `uninstall` — the plugin's directory was removed at runtime.
+ * - `disable` — the plugin was disabled at runtime (e.g. a `.disabled`
+ *   sentinel was added, or a feature flag turned it off).
+ */
+export type ShutdownReason = "shutdown" | "uninstall" | "disable";
+
+/**
+ * Context passed to the `shutdown` hook. Kept intentionally narrower than
+ * {@link InitContext} — teardown paths only need to know which assistant
+ * version they're shutting down against (e.g. for version-conditional cleanup
+ * of state files written by a previous boot) and {@link ShutdownReason why}
+ * they're being torn down (so a plugin can, e.g., delete its state on
+ * `uninstall` but preserve it across a plain `shutdown`).
+ *
+ * The `assistantVersion` field mirrors the init context's so plugins that stash
+ * a version stamp at init can compare against the same name on tear-down
+ * without keeping their own copy.
  */
 export interface ShutdownContext {
   /** Assistant semver for compatibility checks inside the plugin. */
   assistantVersion: string;
+  /** Why the plugin is shutting down. */
+  reason: ShutdownReason;
 }
 
 // ─── User-prompt-submit hook context ─────────────────────────────────────────
@@ -182,6 +194,14 @@ export interface UserPromptSubmitContext {
    * attach turn-scoped metadata to the originating message (e.g. recording an
    * injected memory block so it survives a conversation reload) key off this
    * row id rather than the in-memory message arrays, whose entries carry no id.
+   *
+   * @deprecated This field is always identical to {@link requestId}; use
+   *   `requestId` instead. Every path that starts an agent loop persists the
+   *   triggering user message under the turn's request ID before running, so
+   *   the message row id and the request's correlation ID are the same UUID.
+   *   This holds for the standard submit, queue-drain, subagent, voice, wake,
+   *   and conversation-analysis paths alike. This field will be removed in a
+   *   future API version.
    */
   readonly userMessageId: string;
   /**
@@ -189,6 +209,10 @@ export interface UserPromptSubmitContext {
    * runtime injection forward it onto the injector turn context so the
    * assembled blocks are attributed to the originating request; it is fixed
    * for the turn and cannot be recovered from the message arrays.
+   *
+   * As of the requestId/userMessageId merge, this value is also the
+   * persisted row ID of the user message, so hooks that previously
+   * keyed off {@link userMessageId} can use `requestId` directly.
    */
   readonly requestId: string;
   /**
@@ -219,6 +243,13 @@ export interface UserPromptSubmitContext {
    * it from the message arrays.
    */
   readonly prompt: string;
+  /**
+   * True when the triggering message is a transcript-suppressed machine
+   * signal (`metadata.hidden` — e.g. the channel-setup wizard-close marker)
+   * rather than something the user typed. Hooks that treat `prompt` as
+   * user speech (e.g. title generation) should skip these turns.
+   */
+  readonly isHiddenPrompt?: boolean;
   /**
    * The user's original message list, immutable for the hook. Plugins
    * may snapshot or compare against this but MUST NOT mutate it.

package/src/plugins/defaults/default-plugin-names.ts

@@ -0,0 +1,60 @@
+/**
+ * Names of the first-party default plugins, as a leaf module.
+ *
+ * This deliberately imports ONLY each default plugin's `package.json` (pure
+ * JSON data, no code) rather than the `./index.js` barrel. The barrel statically
+ * pulls in every hook/injector implementation (the memory-v3 engine, caption
+ * caches, persistence hooks, …) and reaches back into `daemon/` modules, so
+ * importing it from `daemon/conversation-tool-setup.ts` forms a module-init
+ * cycle. Sourcing the names from this leaf keeps that consumer cycle-free while
+ * staying data-driven (names come from `package.json`, never hand-typed).
+ *
+ * The set is kept in lock-step with the canonical {@link getAllDefaultPlugins}
+ * list by a unit assertion in `daemon/conversation-tool-setup.test.ts`.
+ */
+
+import channelPkg from "./channel/package.json" with { type: "json" };
+import compactionPkg from "./compaction/package.json" with { type: "json" };
+import documentsPkg from "./documents/package.json" with { type: "json" };
+import emptyResponsePkg from "./empty-response/package.json" with { type: "json" };
+import explorationDriftPkg from "./exploration-drift/package.json" with { type: "json" };
+import historyRepairPkg from "./history-repair/package.json" with { type: "json" };
+import imageFallbackPkg from "./image-fallback/package.json" with { type: "json" };
+import imageRecoveryPkg from "./image-recovery/package.json" with { type: "json" };
+import maxTokensContinuePkg from "./max-tokens-continue/package.json" with { type: "json" };
+import memoryPkg from "./memory/package.json" with { type: "json" };
+import sessionPkg from "./session/package.json" with { type: "json" };
+import surfaceCompletionNudgePkg from "./surface-completion-nudge/package.json" with { type: "json" };
+import taskProgressNudgePkg from "./task-progress-nudge/package.json" with { type: "json" };
+import titleGeneratePkg from "./title-generate/package.json" with { type: "json" };
+import toolErrorPkg from "./tool-error/package.json" with { type: "json" };
+import toolResultTruncatePkg from "./tool-result-truncate/package.json" with { type: "json" };
+import turnContextPkg from "./turn-context/package.json" with { type: "json" };
+import workspacePkg from "./workspace/package.json" with { type: "json" };
+
+/**
+ * The set of first-party default plugin names — runtime infrastructure
+ * (memory, turn-context, workspace, session, history repair, title generation,
+ * …), not user-toggleable extensions. Used by per-chat plugin scoping to ensure
+ * these are never filtered out (see `getEffectiveEnabledPluginSet`).
+ */
+export const DEFAULT_PLUGIN_NAMES: ReadonlySet<string> = new Set([
+  memoryPkg.name,
+  turnContextPkg.name,
+  workspacePkg.name,
+  documentsPkg.name,
+  channelPkg.name,
+  sessionPkg.name,
+  imageFallbackPkg.name,
+  toolResultTruncatePkg.name,
+  emptyResponsePkg.name,
+  maxTokensContinuePkg.name,
+  toolErrorPkg.name,
+  explorationDriftPkg.name,
+  taskProgressNudgePkg.name,
+  surfaceCompletionNudgePkg.name,
+  historyRepairPkg.name,
+  imageRecoveryPkg.name,
+  compactionPkg.name,
+  titleGeneratePkg.name,
+]);

package/src/plugins/defaults/index.ts

@@ -33,10 +33,6 @@ import {
   clearInjectorRegistry,
   registerPluginInjectors,
 } from "../injector-registry.js";
-import {
-  clearJobHandlerRegistry,
-  registerPluginJobHandlers,
-} from "../job-handler-registry.js";
 import { registerPlugin, resetPluginRegistryForTests } from "../registry.js";
 import { type Plugin, PluginExecutionError } from "../types.js";
 import { channelInjectors } from "./channel/injectors.js";
@@ -74,7 +70,6 @@ import memoryPostCompact from "./memory/hooks/post-compact.js";
 import memoryShutdown from "./memory/hooks/shutdown.js";
 import memoryUserPromptSubmit from "./memory/hooks/user-prompt-submit.js";
 import { memoryInjectors } from "./memory/injectors.js";
-import { memoryJobHandlers } from "./memory/job-handlers.js";
 import memoryPkg from "./memory/package.json" with { type: "json" };
 import { memoryPersistenceHooks } from "./memory/persistence-hooks.js";
 import {
@@ -183,7 +178,6 @@ export const defaultMemoryPlugin: Plugin = {
     "post-compact": memoryPostCompact,
   },
   injectors: [...memoryInjectors, memoryV3Injector, memoryV3SpotlightInjector],
-  jobHandlers: memoryJobHandlers,
 };
 
 /**
@@ -485,32 +479,13 @@ export function registerDefaultPluginInjectors(): void {
   }
 }
 
-/**
- * Register every default plugin's background-job handlers into the global
- * job-handler registry — the job-handler analog of
- * {@link registerDefaultPluginInjectors}. `bootstrapPlugins` calls this before
- * the per-plugin init loop so a default plugin's handlers are present
- * regardless of its disabled-state. The standalone memory-worker process does
- * not run plugin bootstrap, so `registerMemoryJobHandlers`
- * (`jobs/register-job-handlers.ts`) calls this directly before forwarding the
- * registry union into the worker dispatch table. Idempotent:
- * `registerPluginJobHandlers` replaces a plugin's prior set, so the per-plugin
- * re-registration in `initializePlugin` is a harmless no-op replace.
- */
-export function registerDefaultPluginJobHandlers(): void {
-  for (const plugin of getAllDefaultPlugins()) {
-    if (plugin.jobHandlers && plugin.jobHandlers.length > 0) {
-      registerPluginJobHandlers(plugin.manifest.name, plugin.jobHandlers);
-    }
-  }
-}
-
 /**
  * Wrap a plugin's persistence hooks so its ACTIVE side-effect hooks no-op while
  * that plugin is disabled (`assistant plugins disable <name>`), mirroring the
  * read-time disabled-state filtering the injector/hook/job-handler/tool surfaces
  * apply. The sentinel is checked per call, so enable/disable takes effect on the
  * next write without a daemon restart. CLEANUP hooks (`onConversationWiped`,
+ * `onConversationDeleted`, `onMessagesDeleted`, `onAllConversationsCleared`,
  * `onWorkerStartup`) are intentionally NOT gated — they must run even when the
  * plugin is disabled so state created while it was enabled is not orphaned.
  */
@@ -527,12 +502,29 @@ export function guardPersistenceHooksByDisabledState(
       if (isPluginDisabled(pluginName)) return;
       return hooks.onConversationForked(event);
     },
+    // Gated like the active side effects above: a disabled plugin reports an
+    // empty buffer, so the maintenance scheduler treats it as "no buffered
+    // work" and skips consolidation — matching how disabled injectors/hooks go
+    // inert.
+    countMemoryBufferLines() {
+      if (isPluginDisabled(pluginName)) return 0;
+      return hooks.countMemoryBufferLines();
+    },
     // Cleanup hooks are NOT gated on disabled-state: they must run even while
     // the plugin is disabled, or jobs/conversations created while it was
     // enabled would be orphaned.
     onConversationWiped(conversationId) {
       return hooks.onConversationWiped(conversationId);
     },
+    onConversationDeleted(conversationId) {
+      return hooks.onConversationDeleted(conversationId);
+    },
+    onMessagesDeleted(messageIds) {
+      return hooks.onMessagesDeleted(messageIds);
+    },
+    onAllConversationsCleared() {
+      return hooks.onAllConversationsCleared();
+    },
     onWorkerStartup() {
       return hooks.onWorkerStartup();
     },
@@ -542,7 +534,7 @@ export function guardPersistenceHooksByDisabledState(
 /**
  * Install the memory feature's persistence-lifecycle handlers into the
  * persistence seam — the persistence-hooks analog of
- * {@link registerDefaultPluginJobHandlers}. `bootstrapPlugins` calls this
+ * {@link registerDefaultPluginInjectors}. `bootstrapPlugins` calls this
  * before the per-plugin init loop so the seam is wired up front; the handlers
  * are guarded by {@link guardPersistenceHooksByDisabledState} so a disabled
  * memory plugin drives no persistence side effects and re-enabling it takes
@@ -581,7 +573,5 @@ export function resetPluginRegistryAndRegisterDefaults(): void {
   registerDefaultPlugins();
   clearInjectorRegistry();
   registerDefaultPluginInjectors();
-  clearJobHandlerRegistry();
-  registerDefaultPluginJobHandlers();
   registerDefaultPluginPersistenceHooks();
 }

package/src/plugins/defaults/memory/__tests__/conversation-queries.test.ts

@@ -213,6 +213,7 @@ describe("countConversations", () => {
       createConversation("live-1");
       const archived = createConversation("archived-1");
       rawRun(
+        "test:archiveConversation",
         "UPDATE conversations SET archived_at = ? WHERE id = ?",
         Date.now(),
         archived.id,
@@ -226,6 +227,7 @@ describe("countConversations", () => {
       const a1 = createConversation("archived-1");
       const a2 = createConversation("archived-2");
       rawRun(
+        "test:archiveConversations",
         "UPDATE conversations SET archived_at = ? WHERE id IN (?, ?)",
         Date.now(),
         a1.id,
@@ -239,6 +241,7 @@ describe("countConversations", () => {
       createConversation("live-1");
       const archived = createConversation("archived-1");
       rawRun(
+        "test:archiveConversation",
         "UPDATE conversations SET archived_at = ? WHERE id = ?",
         Date.now(),
         archived.id,
@@ -301,6 +304,7 @@ describe("listConversations", () => {
     // GIVEN a conversation with group_id system:scheduled but conversationType standard
     const conv = createConversation("schedule-routed");
     rawRun(
+      "test:setGroupScheduled",
       "UPDATE conversations SET group_id = 'system:scheduled' WHERE id = ?",
       conv.id,
     );
@@ -335,6 +339,7 @@ describe("listConversations", () => {
     // GIVEN a standard conversation routed to system:scheduled
     const scheduledRouted = createConversation("schedule-routed");
     rawRun(
+      "test:setGroupScheduled",
       "UPDATE conversations SET group_id = 'system:scheduled' WHERE id = ?",
       scheduledRouted.id,
     );
@@ -342,6 +347,7 @@ describe("listConversations", () => {
     // AND a standard conversation routed to system:background
     const backgroundRouted = createConversation("background-routed");
     rawRun(
+      "test:setGroupBackground",
       "UPDATE conversations SET group_id = 'system:background' WHERE id = ?",
       backgroundRouted.id,
     );
@@ -375,6 +381,7 @@ describe("listConversations", () => {
       createConversation("live-1");
       const archived = createConversation("archived-1");
       rawRun(
+        "test:archiveConversation",
         "UPDATE conversations SET archived_at = ? WHERE id = ?",
         Date.now(),
         archived.id,
@@ -393,6 +400,7 @@ describe("listConversations", () => {
       createConversation("live-1");
       const archived = createConversation("archived-1");
       rawRun(
+        "test:archiveConversation",
         "UPDATE conversations SET archived_at = ? WHERE id = ?",
         Date.now(),
         archived.id,
@@ -411,6 +419,7 @@ describe("listConversations", () => {
       createConversation("live-1");
       const archived = createConversation("archived-1");
       rawRun(
+        "test:archiveConversation",
         "UPDATE conversations SET archived_at = ? WHERE id = ?",
         Date.now(),
         archived.id,
@@ -434,6 +443,7 @@ describe("listConversations", () => {
       });
       const archivedFg = createConversation("archived-fg");
       rawRun(
+        "test:archiveConversations",
         "UPDATE conversations SET archived_at = ? WHERE id IN (?, ?)",
         Date.now(),
         archivedBg.id,
@@ -490,9 +500,24 @@ describe("listConversationsBySource", () => {
       source: "memory_v2_consolidation",
     });
     // Force distinct createdAt regardless of ms-clock granularity.
-    rawRun("UPDATE conversations SET created_at = ? WHERE id = ?", 1000, a.id);
-    rawRun("UPDATE conversations SET created_at = ? WHERE id = ?", 3000, b.id);
-    rawRun("UPDATE conversations SET created_at = ? WHERE id = ?", 2000, c.id);
+    rawRun(
+      "test:setCreatedAt",
+      "UPDATE conversations SET created_at = ? WHERE id = ?",
+      1000,
+      a.id,
+    );
+    rawRun(
+      "test:setCreatedAt",
+      "UPDATE conversations SET created_at = ? WHERE id = ?",
+      3000,
+      b.id,
+    );
+    rawRun(
+      "test:setCreatedAt",
+      "UPDATE conversations SET created_at = ? WHERE id = ?",
+      2000,
+      c.id,
+    );
 
     const results = listConversationsBySource("memory_v2_consolidation");
 
@@ -518,6 +543,7 @@ describe("listConversationsBySource", () => {
       source: "memory_v2_consolidation",
     });
     rawRun(
+      "test:archiveConversation",
       "UPDATE conversations SET archived_at = ? WHERE id = ?",
       Date.now(),
       conv.id,
@@ -536,6 +562,7 @@ describe("listConversationsBySource", () => {
     });
     createConversation({ title: "live", source: "memory_v2_consolidation" });
     rawRun(
+      "test:archiveConversation",
       "UPDATE conversations SET archived_at = ? WHERE id = ?",
       Date.now(),
       archived.id,
@@ -562,112 +589,61 @@ describe("listConversationsBySource", () => {
   });
 });
 
+// Content-arm (lexical candidate) surfacing behavior is covered in
+// `persistence/__tests__/conversation-queries-search.test.ts`, which mocks the
+// lexical index; this suite covers the title arm's surfacing rules.
 describe("searchConversations · surfaced conversations", () => {
   beforeEach(() => {
     resetTables();
   });
 
-  function insertMessage(
-    conversationId: string,
-    content: string,
-    createdAt = 1000,
-  ): void {
-    rawRun(
-      "INSERT INTO messages (id, conversation_id, role, content, created_at) VALUES (?, ?, ?, ?, ?)",
-      `msg-${conversationId}-${createdAt}`,
-      conversationId,
-      "user",
-      content,
-      createdAt,
-    );
-  }
-
   function setSurfaced(conversationId: string): void {
     rawRun(
+      "test:setSurfaced",
       "UPDATE conversations SET surfaced_at = ? WHERE id = ?",
       Date.now(),
       conversationId,
     );
   }
 
-  test("a surfaced background conversation is found by title search", () => {
+  test("a surfaced background conversation is found by title search", async () => {
     const surfaced = createConversation({
       title: "Quarterly metrics rollup",
       conversationType: "background",
     });
     setSurfaced(surfaced.id);
 
-    const results = searchConversations("Quarterly metrics");
+    const results = await searchConversations("Quarterly metrics");
 
     expect(results.map((r) => r.conversationId)).toEqual([surfaced.id]);
   });
 
-  test("a surfaced background conversation is found by content search", () => {
-    const surfaced = createConversation({
-      title: "bg-run",
-      conversationType: "background",
-    });
-    setSurfaced(surfaced.id);
-    insertMessage(surfaced.id, "the flux capacitor needs recalibration");
-
-    const results = searchConversations("flux capacitor");
-
-    expect(results.map((r) => r.conversationId)).toEqual([surfaced.id]);
-    expect(results[0]!.matchingMessages).toHaveLength(1);
-  });
-
-  test("a non-surfaced background conversation stays excluded from search", () => {
-    const background = createConversation({
+  test("a non-surfaced background conversation stays excluded from title search", async () => {
+    createConversation({
       title: "Quarterly metrics rollup",
       conversationType: "background",
     });
-    insertMessage(background.id, "the flux capacitor needs recalibration");
 
-    expect(searchConversations("Quarterly metrics")).toEqual([]);
-    expect(searchConversations("flux capacitor")).toEqual([]);
+    expect(await searchConversations("Quarterly metrics")).toEqual([]);
   });
 
-  test("private conversations are never included, even with surfaced_at set", () => {
+  test("private conversations are never included, even with surfaced_at set", async () => {
     const priv = createConversation("Quarterly metrics rollup");
     setConversationType(priv.id, "private");
     setSurfaced(priv.id);
-    insertMessage(priv.id, "the flux capacitor needs recalibration");
 
-    expect(searchConversations("Quarterly metrics")).toEqual([]);
-    expect(searchConversations("flux capacitor")).toEqual([]);
+    expect(await searchConversations("Quarterly metrics")).toEqual([]);
   });
 
-  test("surfaced subagent runs stay excluded from search", () => {
+  test("surfaced subagent runs stay excluded from title search", async () => {
     const subagent = createConversation({
       title: "Quarterly metrics rollup",
       conversationType: "background",
       source: "subagent",
     });
     setSurfaced(subagent.id);
-    insertMessage(subagent.id, "the flux capacitor needs recalibration");
 
-    expect(searchConversations("Quarterly metrics")).toEqual([]);
-    expect(searchConversations("flux capacitor")).toEqual([]);
-  });
-
-  test("LIKE content fallback (non-FTS-tokenizable query) honors surfacing", () => {
-    // Single-char queries produce no FTS tokens, exercising the LIKE fallback.
-    const surfaced = createConversation({
-      title: "bg-run",
-      conversationType: "background",
-    });
-    setSurfaced(surfaced.id);
-    insertMessage(surfaced.id, "review the C§ draft");
-
-    const hidden = createConversation({
-      title: "bg-hidden",
-      conversationType: "background",
-    });
-    insertMessage(hidden.id, "another C§ mention", 2000);
-
-    const results = searchConversations("C§");
-
-    expect(results.map((r) => r.conversationId)).toEqual([surfaced.id]);
+    expect(await searchConversations("Quarterly metrics")).toEqual([]);
   });
 });
 
@@ -678,6 +654,7 @@ describe("listPinnedConversations · surfaced conversations", () => {
 
   function setSurfaced(conversationId: string): void {
     rawRun(
+      "test:setSurfaced",
       "UPDATE conversations SET surfaced_at = ? WHERE id = ?",
       Date.now(),
       conversationId,
@@ -686,6 +663,7 @@ describe("listPinnedConversations · surfaced conversations", () => {
 
   function setPinned(conversationId: string): void {
     rawRun(
+      "test:setPinned",
       "UPDATE conversations SET is_pinned = 1 WHERE id = ?",
       conversationId,
     );
@@ -747,6 +725,7 @@ describe("getMessageRoleStatsByConversation", () => {
     createdAt: number,
   ): void {
     rawRun(
+      "test:insertMessage",
       "INSERT INTO messages (id, conversation_id, role, content, created_at) VALUES (?, ?, ?, ?, ?)",
       `msg-${conversationId}-${role}-${createdAt}`,
       conversationId,

package/src/plugins/defaults/memory/__tests__/db-async-query.test.ts

@@ -16,13 +16,15 @@
  *   4. Errors from sqlite3 surface as `ok: false` with the stderr
  *      preserved in `error`.
  */
+import { statSync } from "node:fs";
 import { beforeEach, describe, expect, test } from "bun:test";
 
 const { getSqlite } = await import("../../../../persistence/db-connection.js");
 const { initializeDb } = await import("../../../../persistence/db-init.js");
-const { runAsyncSqlite, _resetFallbackWarning } =
+const { runAsyncSqlite, _resetFallbackWarning, spawnDetachedWalCheckpoint } =
   await import("../../../../persistence/db-async-query.js");
 const { findSqlite3 } = await import("../../../../util/sqlite3-runtime.js");
+const { getDbPath } = await import("../../../../util/platform.js");
 
 await initializeDb();
 
@@ -170,3 +172,36 @@ describe("runAsyncSqlite", () => {
     60_000,
   );
 });
+
+describe("spawnDetachedWalCheckpoint", () => {
+  test.if(sqlite3Available)(
+    "folds and truncates the WAL from a detached subprocess",
+    async () => {
+      const sqlite = getSqlite();
+      const walPath = `${getDbPath()}-wal`;
+
+      // Grow the WAL past zero without checkpointing.
+      sqlite.exec("CREATE TABLE IF NOT EXISTS detached_ckpt_probe (x TEXT)");
+      sqlite.exec("INSERT INTO detached_ckpt_probe VALUES ('row')");
+      expect(statSync(walPath).size).toBeGreaterThan(0);
+
+      expect(spawnDetachedWalCheckpoint()).toBe(true);
+
+      // The child is detached with no inherited stdio, so the only
+      // observable effect is the WAL file itself — poll for the truncate.
+      const deadline = Date.now() + 10_000;
+      let walSize = -1;
+      while (Date.now() < deadline) {
+        walSize = statSync(walPath).size;
+        if (walSize === 0) {
+          break;
+        }
+        await Bun.sleep(50);
+      }
+      expect(walSize).toBe(0);
+
+      sqlite.exec("DROP TABLE detached_ckpt_probe");
+    },
+    30_000,
+  );
+});

package/src/plugins/defaults/memory/__tests__/find-most-recent-retrospective-for.test.ts

@@ -9,13 +9,11 @@ mock.module("../../../../util/logger.js", () => ({
     }),
 }));
 
-import {
-  createConversation,
-  findMostRecentRetrospectiveFor,
-} from "../../../../persistence/conversation-crud.js";
+import { createConversation } from "../../../../persistence/conversation-crud.js";
 import { getDb } from "../../../../persistence/db-connection.js";
 import { initializeDb } from "../../../../persistence/db-init.js";
 import { conversations } from "../../../../persistence/schema/index.js";
+import { findMostRecentRetrospectiveFor } from "../find-most-recent-retrospective-for.js";
 import { MEMORY_RETROSPECTIVE_SOURCE } from "../memory-retrospective-constants.js";
 
 await initializeDb();

package/src/plugins/defaults/memory/__tests__/jobs-worker-v2-graph-trigger-embed.test.ts

@@ -67,17 +67,17 @@ const tmpWorkspace = mkdtempSync(
 const previousWorkspaceEnv = process.env.VELLUM_WORKSPACE_DIR;
 process.env.VELLUM_WORKSPACE_DIR = tmpWorkspace;
 
-import { registerMemoryJobHandlers } from "../../../../jobs/register-job-handlers.js";
 import { getMemoryDb } from "../../../../persistence/db-connection.js";
 import { initializeDb } from "../../../../persistence/db-init.js";
 import { _resetQdrantBreaker } from "../../../../persistence/embeddings/qdrant-circuit-breaker.js";
 import { enqueueMemoryJob } from "../../../../persistence/jobs-store.js";
 import { runMemoryJobsOnce } from "../../../../persistence/jobs-worker.js";
 import { memoryJobs } from "../../../../persistence/schema/index.js";
+import { registerMemoryPluginJobHandlers } from "../job-handler-registration.js";
 
 describe("graph_trigger_embed under memory v2", () => {
   beforeAll(async () => {
-    registerMemoryJobHandlers();
+    registerMemoryPluginJobHandlers();
     await initializeDb();
   });
 

package/src/plugins/defaults/memory/__tests__/jobs-worker-v2-schedule.test.ts

@@ -57,6 +57,7 @@ afterAll(() => {
     process.env.VELLUM_WORKSPACE_DIR = previousWorkspaceEnv;
   }
   rmSync(tmpWorkspace, { recursive: true, force: true });
+  resetMemoryPersistenceHooksForTests();
 });
 
 const { getMemoryDb } =
@@ -70,6 +71,14 @@ const { getMemoryCheckpoint, setMemoryCheckpoint, deleteMemoryCheckpoint } =
   await import("../../../../persistence/checkpoints.js");
 const { maybeEnqueueGraphMaintenanceJobs } =
   await import("../../../../persistence/jobs-worker.js");
+const { registerMemoryPersistenceHooks, resetMemoryPersistenceHooksForTests } =
+  await import("../../../../persistence/memory-lifecycle-hooks.js");
+const { memoryPersistenceHooks } = await import("../persistence-hooks.js");
+
+// The scheduler reads the memory buffer's line count through the persistence
+// seam; register the real memory implementation so `countMemoryBufferLines`
+// reflects the buffer files these tests write.
+registerMemoryPersistenceHooks(memoryPersistenceHooks);
 
 const CONSOLIDATE_CHECKPOINT_KEY = "memory_v2_consolidate_last_run";
 

package/src/plugins/defaults/memory/__tests__/memory-retrospective-job.test.ts

@@ -130,6 +130,13 @@ mock.module("../memory-retrospective-state.js", () => ({
   ],
 }));
 
+mock.module("../find-most-recent-retrospective-for.js", () => ({
+  findMostRecentRetrospectiveFor: (_id: string) =>
+    priorRetroId
+      ? { id: priorRetroId, forkParentConversationId: priorRetroOwnerId }
+      : null,
+}));
+
 mock.module("../../../../persistence/conversation-crud.js", () => ({
   getMessagesAfter: (_id: string, _afterId: string | null) => newMessages,
   getMessages: (id: string) => {
@@ -137,10 +144,6 @@ mock.module("../../../../persistence/conversation-crud.js", () => ({
     if (id === priorRetroId) return priorRetroMessages;
     return [];
   },
-  findMostRecentRetrospectiveFor: (_id: string) =>
-    priorRetroId
-      ? { id: priorRetroId, forkParentConversationId: priorRetroOwnerId }
-      : null,
   // The handler calls `getConversation(sourceConversationId)` to read the
   // source's title for the fork title. `collectPriorRetrospectiveRemembers`
   // also calls it with the prior retro id to discriminate legacy vs fork

package/src/plugins/defaults/memory/config.ts

@@ -0,0 +1,11 @@
+import { getConfig } from "../../../config/loader.js";
+import type { MemoryConfig } from "../../../config/types.js";
+
+/**
+ * The `memory` slice of the live assistant config. Memory code reads its own
+ * configuration through this accessor rather than the full `getConfig()`, so its
+ * config dependency is a narrow slice of `AssistantConfig`.
+ */
+export function getMemoryConfig(): MemoryConfig {
+  return getConfig().memory;
+}