@vellumai/assistant 0.10.3 → 0.10.4-staging.1

package/src/notifications/__tests__/connected-channels.test.ts

@@ -1,11 +1,9 @@
 /**
  * Tests for getConnectedChannels connectivity resolution.
  *
- * Connectivity must mirror destination-resolver's `resolveGuardian`:
- * gateway-first, with a LOCAL contacts fallback on ANY per-channel no-match
- * (gateway list null OR no active gateway entry for the channel). This keeps a
- * channel from being marked connected when it can't be delivered (and
- * vice-versa).
+ * Connectivity mirrors destination-resolver's `resolveGuardian`: guardian
+ * delivery is sourced solely from the gateway. A channel with no active gateway
+ * binding is not connected, keeping connectivity aligned with deliverability.
  */
 
 import { beforeEach, describe, expect, mock, test } from "bun:test";
@@ -20,7 +18,6 @@ mock.module("../../util/logger.js", () => ({
 
 let deliverableChannels: string[] = [];
 let gatewayGuardians: GuardianDelivery[] | null = null;
-let localChatId: string | null = null;
 
 const realConfig = await import("../../channels/config.js");
 
@@ -36,16 +33,6 @@ mock.module("../../contacts/guardian-delivery-reader.js", () => ({
   getGuardianDelivery: async () => gatewayGuardians,
 }));
 
-const realContactStore = await import("../../contacts/contact-store.js");
-
-mock.module("../../contacts/contact-store.js", () => ({
-  ...realContactStore,
-  findGuardianForChannel: (_channelType: string) =>
-    localChatId === null
-      ? null
-      : { contact: { principalId: "p1" }, channel: { externalChatId: localChatId } },
-}));
-
 const { getConnectedChannels } = await import("../emit-signal.js");
 
 function gatewayBinding(channelType: string, externalChatId: string): GuardianDelivery {
@@ -55,43 +42,28 @@ function gatewayBinding(channelType: string, externalChatId: string): GuardianDe
 beforeEach(() => {
   deliverableChannels = [];
   gatewayGuardians = null;
-  localChatId = null;
 });
 
-describe("getConnectedChannels gateway-first-then-local connectivity", () => {
-  test("marks telegram connected from a gateway-only binding", async () => {
+describe("getConnectedChannels gateway connectivity", () => {
+  test("marks telegram connected from a gateway binding", async () => {
     deliverableChannels = ["telegram"];
     gatewayGuardians = [gatewayBinding("telegram", "123")];
-    localChatId = null;
 
     expect(await getConnectedChannels()).toContain("telegram");
   });
 
-  test("falls back to a local binding when the gateway is unreachable (null)", async () => {
+  test("marks telegram disconnected when the gateway is unreachable (null)", async () => {
     deliverableChannels = ["telegram"];
     gatewayGuardians = null;
-    localChatId = "456";
-
-    expect(await getConnectedChannels()).toContain("telegram");
-  });
-
-  test("marks telegram disconnected when neither source has a binding", async () => {
-    deliverableChannels = ["telegram"];
-    gatewayGuardians = null;
-    localChatId = null;
 
     expect(await getConnectedChannels()).not.toContain("telegram");
   });
 
-  test("falls back to local when the gateway responds without that channel", async () => {
-    // Gateway present but with no active telegram entry ⇒ per-channel no-match,
-    // so connectivity falls back to the local mirror (mirrors
-    // destination-resolver's per-channel fallback).
+  test("marks telegram disconnected when the gateway has no binding", async () => {
     deliverableChannels = ["telegram"];
     gatewayGuardians = [];
-    localChatId = "789";
 
-    expect(await getConnectedChannels()).toContain("telegram");
+    expect(await getConnectedChannels()).not.toContain("telegram");
   });
 
   test("only marks slack connected for D-prefixed (DM) chat IDs", async () => {

package/src/notifications/__tests__/destination-resolver.test.ts

@@ -1,10 +1,10 @@
 /**
  * Verifies resolveDestinations resolves guardian delivery endpoints from the
- * gateway-provided guardian list, with shapes identical to the local read, and
- * falls back to the local contacts read when the list is null.
+ * gateway-provided guardian list, and omits a channel when the list is
+ * null/empty or carries no entry for it.
  */
 
-import { beforeEach, describe, expect, mock, test } from "bun:test";
+import { describe, expect, mock, test } from "bun:test";
 
 import type { GuardianDelivery } from "@vellumai/gateway-client";
 
@@ -15,15 +15,6 @@ mock.module("../../util/logger.js", () => ({
     }),
 }));
 
-// Local fallback read; mocked so the null-list path is deterministic.
-let localGuardian:
-  | { contact: { principalId?: string }; channel: { address: string; externalChatId?: string } }
-  | null = null;
-
-mock.module("../../contacts/contact-store.js", () => ({
-  findGuardianForChannel: (_channelType: string) => localGuardian,
-}));
-
 const { resolveDestinations } = await import("../destination-resolver.js");
 
 function guardian(
@@ -37,10 +28,6 @@ function guardian(
 }
 
 describe("resolveDestinations — gateway guardian list", () => {
-  beforeEach(() => {
-    localGuardian = null;
-  });
-
   test("vellum carries guardianPrincipalId from the gateway list", () => {
     const list = [
       guardian({ channelType: "vellum", address: "user@example.com", principalId: "prin-1" }),
@@ -137,120 +124,28 @@ describe("resolveDestinations — gateway guardian list", () => {
   });
 });
 
-describe("resolveDestinations — null list falls back to local read", () => {
-  beforeEach(() => {
-    localGuardian = null;
-  });
-
-  test("telegram resolves from the local contacts read", () => {
-    localGuardian = {
-      contact: {},
-      channel: { address: "tg-user", externalChatId: "12345" },
-    };
+describe("resolveDestinations — gateway empty or missing channel", () => {
+  test("null gateway list omits telegram", () => {
     const result = resolveDestinations(["telegram"], null);
-    expect(result.get("telegram")).toEqual({
-      channel: "telegram",
-      endpoint: "12345",
-      metadata: { externalUserId: "tg-user" },
-      bindingContext: {
-        sourceChannel: "telegram",
-        externalChatId: "12345",
-        externalUserId: "tg-user",
-      },
-    });
-  });
-
-  test("slack DM resolves from the local contacts read", () => {
-    localGuardian = {
-      contact: {},
-      channel: { address: "slack-user", externalChatId: "D123" },
-    };
-    const result = resolveDestinations(["slack"], null);
-    expect(result.get("slack")).toEqual({
-      channel: "slack",
-      endpoint: "D123",
-      metadata: { externalUserId: "slack-user" },
-      bindingContext: {
-        sourceChannel: "slack",
-        externalChatId: "D123",
-        externalUserId: "slack-user",
-      },
-    });
+    expect(result.has("telegram")).toBe(false);
   });
 
-  test("vellum carries principalId from the local contacts read", () => {
-    localGuardian = {
-      contact: { principalId: "prin-1" },
-      channel: { address: "user@example.com" },
-    };
+  test("null gateway list omits vellum principalId metadata", () => {
     const result = resolveDestinations(["vellum"], null);
-    expect(result.get("vellum")).toEqual({
-      channel: "vellum",
-      metadata: { guardianPrincipalId: "prin-1" },
-    });
+    expect(result.get("vellum")).toEqual({ channel: "vellum" });
   });
-});
 
-describe("resolveDestinations — gateway yields no channel match falls back to local", () => {
-  beforeEach(() => {
-    localGuardian = null;
-  });
-
-  test("empty gateway list falls back to local telegram binding", () => {
-    localGuardian = {
-      contact: {},
-      channel: { address: "tg-user", externalChatId: "12345" },
-    };
+  test("empty gateway list omits telegram", () => {
     const result = resolveDestinations(["telegram"], []);
-    expect(result.get("telegram")).toEqual({
-      channel: "telegram",
-      endpoint: "12345",
-      metadata: { externalUserId: "tg-user" },
-      bindingContext: {
-        sourceChannel: "telegram",
-        externalChatId: "12345",
-        externalUserId: "tg-user",
-      },
-    });
+    expect(result.has("telegram")).toBe(false);
   });
 
-  test("gateway list missing the channel falls back to local slack DM", () => {
-    localGuardian = {
-      contact: {},
-      channel: { address: "slack-user", externalChatId: "D123" },
-    };
+  test("gateway list missing the channel omits slack", () => {
     // Gateway returns a telegram guardian but no slack entry.
     const list = [
       guardian({ channelType: "telegram", address: "tg", externalChatId: "999" }),
     ];
     const result = resolveDestinations(["slack"], list);
-    expect(result.get("slack")).toEqual({
-      channel: "slack",
-      endpoint: "D123",
-      metadata: { externalUserId: "slack-user" },
-      bindingContext: {
-        sourceChannel: "slack",
-        externalChatId: "D123",
-        externalUserId: "slack-user",
-      },
-    });
-  });
-
-  test("empty gateway list falls back to local vellum principalId", () => {
-    localGuardian = {
-      contact: { principalId: "prin-1" },
-      channel: { address: "user@example.com" },
-    };
-    const result = resolveDestinations(["vellum"], []);
-    expect(result.get("vellum")).toEqual({
-      channel: "vellum",
-      metadata: { guardianPrincipalId: "prin-1" },
-    });
-  });
-
-  test("empty gateway list with no local binding omits telegram", () => {
-    localGuardian = null;
-    const result = resolveDestinations(["telegram"], []);
-    expect(result.has("telegram")).toBe(false);
+    expect(result.has("slack")).toBe(false);
   });
 });

package/src/notifications/destination-resolver.ts

@@ -15,7 +15,6 @@ import type { GuardianDelivery } from "@vellumai/gateway-client";
 
 import { isNotificationDeliverable } from "../channels/config.js";
 import type { ChannelId } from "../channels/types.js";
-import { findGuardianForChannel } from "../contacts/contact-store.js";
 import { guardianForChannel } from "../contacts/guardian-delivery-reader.js";
 import { getLogger } from "../util/logger.js";
 import type { ChannelDestination, NotificationChannel } from "./types.js";
@@ -29,13 +28,7 @@ interface ResolvedGuardian {
   externalChatId?: string;
 }
 
-/**
- * Resolve the guardian delivery endpoint for a channel: gateway list first,
- * else the local contacts read. The local read is the transitional
- * dual-written mirror and covers a transient gateway failure (null list) or a
- * gateway list missing this channel, so a soft-failed gateway read does not
- * drop a binding the local store still holds. Removed in Combo 11.
- */
+/** Resolve the guardian delivery endpoint for a channel from the gateway list. */
 function resolveGuardian(
   guardians: GuardianDelivery[] | null,
   channelType: string,
@@ -43,19 +36,11 @@ function resolveGuardian(
   const g = guardians
     ? guardianForChannel(guardians, channelType)
     : undefined;
-  if (g) {
-    return {
-      principalId: g.principalId ?? undefined,
-      address: g.address,
-      externalChatId: g.externalChatId ?? undefined,
-    };
-  }
-  const local = findGuardianForChannel(channelType);
-  if (!local) return undefined;
+  if (!g) return undefined;
   return {
-    principalId: local.contact.principalId ?? undefined,
-    address: local.channel.address,
-    externalChatId: local.channel.externalChatId ?? undefined,
+    principalId: g.principalId ?? undefined,
+    address: g.address,
+    externalChatId: g.externalChatId ?? undefined,
   };
 }
 
@@ -67,9 +52,8 @@ function resolveGuardian(
  * Returns a map keyed by `NotificationChannel`. Channels that cannot be
  * resolved (e.g. no Telegram binding configured) are omitted from the result.
  *
- * `guardians` is the gateway-resolved guardian list; per channel, a missing
- * match (null list or no entry for the channel) falls back to the local
- * contacts read for this release.
+ * `guardians` is the gateway-resolved guardian list; a channel with no entry
+ * in the list is omitted from the result.
  */
 export function resolveDestinations(
   channels: readonly (ChannelId | NotificationChannel)[],

package/src/notifications/emit-signal.ts

@@ -13,7 +13,6 @@ import type { GuardianDelivery } from "@vellumai/gateway-client";
 import { v4 as uuid } from "uuid";
 
 import { getDeliverableChannels } from "../channels/config.js";
-import { findGuardianForChannel } from "../contacts/contact-store.js";
 import {
   getGuardianDelivery,
   guardianForChannel,
@@ -96,22 +95,17 @@ export function getBroadcaster(): NotificationBroadcaster {
 
 /**
  * Resolve a binding-based channel's delivery endpoint (externalChatId) the
- * SAME way destination-resolver's `resolveGuardian` does: gateway match first,
- * falling back to the LOCAL contacts read on ANY per-channel no-match — gateway
- * list null (unreachable) OR no active gateway entry for this channel. The
- * local read is the transitional dual-written mirror, removed in Combo 11.
- * Keeping connectivity aligned with delivery prevents a channel being marked
- * connected but then skipped with no destination (or vice-versa).
+ * SAME way destination-resolver's `resolveGuardian` does: from the gateway
+ * guardian delivery for this channel. Keeping connectivity aligned with
+ * delivery prevents a channel being marked connected but then skipped with no
+ * destination (or vice-versa).
  */
 function resolveChannelChatId(
   guardians: GuardianDelivery[] | null,
   channelType: string,
 ): string | undefined {
   const g = guardians ? guardianForChannel(guardians, channelType) : undefined;
-  if (g) {
-    return g.externalChatId ?? undefined;
-  }
-  return findGuardianForChannel(channelType)?.channel.externalChatId ?? undefined;
+  return g?.externalChatId ?? undefined;
 }
 
 export async function getConnectedChannels(): Promise<NotificationChannel[]> {

package/src/plugins/defaults/index.ts

@@ -24,15 +24,8 @@
  * {@link registerDefaultPlugins} at call time.
  */
 
-import { finalizeTool } from "../../tools/tool-defaults.js";
 import { registerPlugin, resetPluginRegistryForTests } from "../registry.js";
 import { type Plugin, PluginExecutionError } from "../types.js";
-import { resetAdvisorStateForTests } from "./advisor/advisor-state-store.js";
-import advisorPostModelCall from "./advisor/hooks/post-model-call.js";
-import advisorPreModelCall from "./advisor/hooks/pre-model-call.js";
-import advisorUserPromptSubmit from "./advisor/hooks/user-prompt-submit.js";
-import advisorPkg from "./advisor/package.json" with { type: "json" };
-import advisorTool from "./advisor/tools/advisor.js";
 import compactionPkg from "./compaction/package.json" with { type: "json" };
 import emptyResponsePostModelCall from "./empty-response/hooks/post-model-call.js";
 import emptyResponseStop from "./empty-response/hooks/stop.js";
@@ -329,30 +322,6 @@ export const defaultToolResultTruncatePlugin: Plugin = {
   },
 };
 
-/**
- * `advisor` — adds the model-visible `advisor` tool: a no-argument tool the
- * model calls to consult a stronger inference profile (the `inference` call
- * site with a `quality-optimized` override) on the full transcript, routed
- * through the assistant's own inference. Three hooks feed it: `user-prompt-submit`
- * seeds the capture, `pre-model-call` records the executor's system prompt and
- * injects the steering that nudges the model to consult, and `post-model-call`
- * snapshots the transcript the tool reads. `finalizeTool` fills the tool's
- * defaults so it satisfies `Tool`, and `bootstrapPlugins` registers it into the
- * catalog.
- */
-export const defaultAdvisorPlugin: Plugin = {
-  manifest: {
-    name: advisorPkg.name,
-    version: advisorPkg.version,
-  },
-  hooks: {
-    "user-prompt-submit": advisorUserPromptSubmit,
-    "pre-model-call": advisorPreModelCall,
-    "post-model-call": advisorPostModelCall,
-  },
-  tools: [finalizeTool(advisorTool, "advisor")],
-};
-
 /**
  * Full set of first-party default plugins. Used by
  * {@link registerDefaultPlugins} to drive the registration loop; the array
@@ -375,9 +344,6 @@ function getAllDefaultPlugins(): readonly Plugin[] {
     defaultCompactionPlugin,
     defaultTitleGeneratePlugin,
     memoryV3ShadowPlugin,
-    // Registered last so its capture hooks observe the fully-processed turn
-    // (memory injections, history repair) that the executor actually sees.
-    defaultAdvisorPlugin,
   ];
 }
 
@@ -424,7 +390,6 @@ export function resetPluginRegistryAndRegisterDefaults(): void {
   resetExplorationDriftStateForTests();
   resetTaskProgressNudgeStateForTests();
   resetSurfaceCompletionNudgeStoreForTests();
-  resetAdvisorStateForTests();
   resetCaptionCacheForTests();
   registerDefaultPlugins();
 }

package/src/plugins/defaults/memory-v3-shadow/__tests__/dense.test.ts

@@ -7,17 +7,28 @@ mock.module("../../../../util/logger.js", () => ({
   getLogger: () => makeMockLogger(),
 }));
 
+// Keep the real exports (e.g. getQdrantClient) so this partial mock is harmless
+// when section-dense-store's transitive imports pull them in; only
+// resolveQdrantUrl is pinned to a fixed URL.
+const realQdrantClient = await import("../../../../memory/qdrant-client.js");
 mock.module("../../../../memory/qdrant-client.js", () => ({
+  ...realQdrantClient,
   resolveQdrantUrl: () => "http://127.0.0.1:6333",
 }));
 
 // Stub the shared embedding backend. Records the queries it was asked to embed
 // and returns one deterministic vector so `denseLane` can issue the search.
+// Keep the real exports (e.g. generateSparseEmbedding) so this partial mock is
+// harmless when section-dense-store's transitive imports pull them in; only
+// embedWithBackend is replaced.
+const realEmbeddingBackend =
+  await import("../../../../memory/embedding-backend.js");
 const embedState = {
   calls: [] as string[][],
   throws: null as Error | null,
 };
 mock.module("../../../../memory/embedding-backend.js", () => ({
+  ...realEmbeddingBackend,
   embedWithBackend: async (_config: unknown, inputs: string[]) => {
     embedState.calls.push(inputs);
     if (embedState.throws) throw embedState.throws;