@vellumai/assistant 0.10.3-dev.202606292136.ce8bf33 → 0.10.3-dev.202606292252.adea010

package/openapi.yaml

@@ -17599,6 +17599,16 @@ paths:
                             - label
                             - status
                           additionalProperties: false
+                        acpNotification:
+                          type: object
+                          properties:
+                            acpSessionId:
+                              type: string
+                            agent:
+                              type: string
+                          required:
+                            - acpSessionId
+                          additionalProperties: false
                         slackMessage:
                           type: object
                           properties:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vellumai/assistant",
-  "version": "0.10.3-dev.202606292136.ce8bf33",
+  "version": "0.10.3-dev.202606292252.adea010",
   "license": "MIT",
   "type": "module",
   "exports": {

package/src/__tests__/conversation-delete-schedule-cleanup.test.ts

@@ -69,8 +69,8 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     getRawDb().run("DELETE FROM conversations");
   });
 
-  test("deleting a conversation with a scheduleJobId removes the schedule", () => {
-    const schedule = createSchedule({
+  test("deleting a conversation with a scheduleJobId removes the schedule", async () => {
+    const schedule = await createSchedule({
       name: "Daily standup",
       expression: "0 9 * * 1-5",
       message: "Time for standup!",
@@ -83,7 +83,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
 
     expect(getSchedule(schedule.id)).not.toBeNull();
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},
@@ -93,8 +93,8 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     expect(getConversation(conv.id)).toBeNull();
   });
 
-  test("deleting a conversation without a scheduleJobId does not affect schedules", () => {
-    const schedule = createSchedule({
+  test("deleting a conversation without a scheduleJobId does not affect schedules", async () => {
+    const schedule = await createSchedule({
       name: "Unrelated schedule",
       expression: "0 12 * * *",
       message: "Noon check",
@@ -102,7 +102,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
 
     const conv = createConversation("no-schedule-conv");
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},
@@ -112,8 +112,8 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     expect(getConversation(conv.id)).toBeNull();
   });
 
-  test("deleting a conversation with a schedule also removes its cron_runs", () => {
-    const schedule = createSchedule({
+  test("deleting a conversation with a schedule also removes its cron_runs", async () => {
+    const schedule = await createSchedule({
       name: "Recurring job",
       expression: "0 9 * * *",
       message: "Daily task",
@@ -137,7 +137,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
       .get();
     expect(runBefore).not.toBeNull();
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},
@@ -150,8 +150,8 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     expect(runAfter).toBeNull();
   });
 
-  test("deleting one of multiple conversations sharing a schedule preserves the schedule", () => {
-    const schedule = createSchedule({
+  test("deleting one of multiple conversations sharing a schedule preserves the schedule", async () => {
+    const schedule = await createSchedule({
       name: "Recurring daily",
       expression: "0 9 * * *",
       message: "Daily task",
@@ -166,7 +166,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
       scheduleJobId: schedule.id,
     });
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: conv1.id },
       body: {},
       headers: {},
@@ -175,13 +175,13 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     expect(getSchedule(schedule.id)).not.toBeNull();
   });
 
-  test("deleting one scheduled conversation does not affect other schedules", () => {
-    const scheduleA = createSchedule({
+  test("deleting one scheduled conversation does not affect other schedules", async () => {
+    const scheduleA = await createSchedule({
       name: "Schedule A",
       expression: "0 9 * * *",
       message: "Task A",
     });
-    const scheduleB = createSchedule({
+    const scheduleB = await createSchedule({
       name: "Schedule B",
       expression: "0 17 * * *",
       message: "Task B",
@@ -196,7 +196,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
       scheduleJobId: scheduleB.id,
     });
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: convA.id },
       body: {},
       headers: {},
@@ -222,8 +222,8 @@ describe("POST /conversations/:id/wipe — schedule cleanup", () => {
     getRawDb().run("DELETE FROM conversations");
   });
 
-  test("wiping a conversation with a scheduleJobId removes the schedule", () => {
-    const schedule = createSchedule({
+  test("wiping a conversation with a scheduleJobId removes the schedule", async () => {
+    const schedule = await createSchedule({
       name: "Wipe-test schedule",
       expression: "0 9 * * 1-5",
       message: "Time for standup!",
@@ -236,7 +236,7 @@ describe("POST /conversations/:id/wipe — schedule cleanup", () => {
 
     expect(getSchedule(schedule.id)).not.toBeNull();
 
-    wipeRoute.handler({
+    await wipeRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},
@@ -245,8 +245,8 @@ describe("POST /conversations/:id/wipe — schedule cleanup", () => {
     expect(getSchedule(schedule.id)).toBeNull();
   });
 
-  test("wiping a conversation without a scheduleJobId does not affect schedules", () => {
-    const schedule = createSchedule({
+  test("wiping a conversation without a scheduleJobId does not affect schedules", async () => {
+    const schedule = await createSchedule({
       name: "Unrelated schedule",
       expression: "0 12 * * *",
       message: "Noon check",
@@ -254,7 +254,7 @@ describe("POST /conversations/:id/wipe — schedule cleanup", () => {
 
     const conv = createConversation("no-schedule-wipe");
 
-    wipeRoute.handler({
+    await wipeRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},

package/src/__tests__/conversation-queue.test.ts

@@ -3004,4 +3004,47 @@ describe("subagent notification user_message_echo suppression", () => {
     await resolveRun(1);
     await new Promise((r) => setTimeout(r, 10));
   });
+
+  test("drained acp-notification message persists and wakes the agent but emits no user_message_echo", async () => {
+    const conversation = makeConversation();
+    await conversation.loadFromDb();
+
+    const events1: ServerMessage[] = [];
+    const eventsNotif: ServerMessage[] = [];
+
+    // Occupy the conversation so the injected notification queues.
+    const p1 = conversation.processMessage({
+      content: "msg-1",
+      attachments: [],
+      onEvent: (e) => events1.push(e),
+      requestId: "req-1",
+    });
+    await waitForPendingRun(1);
+
+    // A daemon-injected ACP completion notification carries `acpNotification`.
+    conversation.enqueueMessage({
+      content: '[ACP agent "claude" completed]',
+      onEvent: (e) => eventsNotif.push(e),
+      requestId: "req-acp-notif",
+      metadata: {
+        acpNotification: { acpSessionId: "acp-1", agent: "claude" },
+      },
+    });
+
+    await resolveRun(0);
+    await p1;
+    await waitForPendingRun(2);
+
+    // Still persisted (so the orchestrator LLM sees it) and still wakes the
+    // agent...
+    expect(
+      capturedAddMessages.some((m) => m.content.includes("ACP agent")),
+    ).toBe(true);
+    expect(pendingRuns.length).toBe(2);
+    // ...but no user_message_echo, so the client never renders a live bubble.
+    expect(eventsNotif.some((e) => e.type === "user_message_echo")).toBe(false);
+
+    await resolveRun(1);
+    await new Promise((r) => setTimeout(r, 10));
+  });
 });

package/src/__tests__/job-handler-registry-guard.test.ts

@@ -0,0 +1,104 @@
+import { afterEach, beforeEach, describe, expect, it, spyOn } from "bun:test";
+
+import { registerMemoryJobHandlers } from "../jobs/register-job-handlers.js";
+import * as jobsWorker from "../persistence/jobs-worker.js";
+import { registerDefaultPluginJobHandlers } from "../plugins/defaults/index.js";
+import {
+  clearJobHandlerRegistry,
+  getRegisteredJobHandlers,
+  registerPluginJobHandlers,
+} from "../plugins/job-handler-registry.js";
+
+/**
+ * The exact job types the `default-memory` plugin contributes via its
+ * `jobHandlers` field. Locks the contribution against an accidental add/drop —
+ * the job-handler analog of the injector order guard.
+ */
+const MEMORY_JOB_TYPES = [
+  "embed_segment",
+  "embed_summary",
+  "backfill",
+  "rebuild_index",
+  "delete_qdrant_vectors",
+  "embed_media",
+  "embed_attachment",
+  "embed_graph_node",
+  "embed_pkb_file",
+  "graph_trigger_embed",
+  "graph_extract",
+  "graph_decay",
+  "graph_consolidate",
+  "graph_pattern_scan",
+  "graph_narrative_refine",
+  "graph_bootstrap",
+  "embed_concept_page",
+  "memory_v2_sweep",
+  "memory_v2_consolidate",
+  "memory_v2_migrate",
+  "memory_v2_reembed",
+  "memory_v2_activation_recompute",
+  "memory_v3_maintain",
+  "memory_retrospective",
+].sort();
+
+/**
+ * Job types wired directly by `registerMemoryJobHandlers` for domains that are
+ * not plugins (persistence cleanup, conversations, media, home, runtime).
+ */
+const NON_PLUGIN_JOB_TYPES = [
+  "prune_old_conversations",
+  "prune_old_llm_request_logs",
+  "prune_old_trace_events",
+  "build_conversation_summary",
+  "media_processing",
+  "conversation_analyze",
+  "generate_conversation_starters",
+].sort();
+
+describe("job-handler registry — memory plugin contribution", () => {
+  beforeEach(() => {
+    clearJobHandlerRegistry();
+  });
+  afterEach(() => {
+    clearJobHandlerRegistry();
+  });
+
+  it("default-memory contributes exactly the memory job types", () => {
+    registerDefaultPluginJobHandlers();
+    const types = getRegisteredJobHandlers()
+      .map((e) => e.type)
+      .sort();
+    expect(types).toEqual(MEMORY_JOB_TYPES);
+    // Globally unique types (the registry would have thrown on a dupe).
+    expect(new Set(types).size).toBe(types.length);
+  });
+
+  it("registerMemoryJobHandlers wires the full job-type set into the worker", () => {
+    const captured: string[] = [];
+    const spy = spyOn(jobsWorker, "registerJobHandler").mockImplementation(
+      (type: string) => {
+        captured.push(type);
+      },
+    );
+    try {
+      registerMemoryJobHandlers();
+    } finally {
+      spy.mockRestore();
+    }
+    const expected = [...MEMORY_JOB_TYPES, ...NON_PLUGIN_JOB_TYPES].sort();
+    expect(captured.slice().sort()).toEqual(expected);
+    // Each type registered exactly once — no plugin/non-plugin overlap, no drop.
+    expect(new Set(captured).size).toBe(captured.length);
+  });
+
+  it("rejects a duplicate job-handler type across plugins", () => {
+    registerPluginJobHandlers("plugin-a", [
+      { type: "graph_extract", handler: () => undefined },
+    ]);
+    expect(() =>
+      registerPluginJobHandlers("plugin-b", [
+        { type: "graph_extract", handler: () => undefined },
+      ]),
+    ).toThrow(/already registered by plugin "plugin-a"/);
+  });
+});

package/src/__tests__/plugin-import-boundary-guard.test.ts

@@ -125,16 +125,34 @@ const BASELINE: Record<string, readonly string[]> = {
     "../../../../util/strip-comment-lines.js",
     "../../../../util/truncate.js",
     "../../../config/loader.js",
+    "../../../config/types.js",
     "../../../context/strip-injections.js",
     "../../../daemon/pkb-context-tracker.js",
     "../../../daemon/pkb-reminder-builder.js",
     "../../../daemon/trust-context.js",
+    "../../../memory/graph/bootstrap.js",
+    "../../../memory/graph/consolidation.js",
     "../../../memory/graph/conversation-graph-memory.js",
+    "../../../memory/graph/decay.js",
+    "../../../memory/graph/extraction-job.js",
+    "../../../memory/graph/graph-search.js",
+    "../../../memory/graph/narrative.js",
+    "../../../memory/graph/pattern-scan.js",
+    "../../../memory/job-handlers/backfill.js",
+    "../../../memory/job-handlers/embedding.js",
+    "../../../memory/job-handlers/index-maintenance.js",
+    "../../../memory/jobs/embed-concept-page.js",
+    "../../../memory/jobs/embed-pkb-file.js",
+    "../../../memory/memory-retrospective-job.js",
     "../../../memory/pkb/autoinject.js",
     "../../../memory/pkb/context.js",
     "../../../memory/pkb/pkb-search.js",
     "../../../memory/pkb/types.js",
+    "../../../memory/v2/backfill-jobs.js",
+    "../../../memory/v2/consolidation-job.js",
     "../../../memory/v2/static-context.js",
+    "../../../memory/v2/sweep-job.js",
+    "../../../persistence/jobs-store.js",
     "../../../types.js",
     "../../../util/logger.js",
     "../../../util/platform.js",