@vellumai/assistant 0.10.3-dev.202606292136.ce8bf33 → 0.10.3-dev.202606292229.153e9b2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vellumai/assistant",
-  "version": "0.10.3-dev.202606292136.ce8bf33",
+  "version": "0.10.3-dev.202606292229.153e9b2",
   "license": "MIT",
   "type": "module",
   "exports": {

package/src/__tests__/conversation-delete-schedule-cleanup.test.ts

@@ -69,8 +69,8 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     getRawDb().run("DELETE FROM conversations");
   });
 
-  test("deleting a conversation with a scheduleJobId removes the schedule", () => {
-    const schedule = createSchedule({
+  test("deleting a conversation with a scheduleJobId removes the schedule", async () => {
+    const schedule = await createSchedule({
       name: "Daily standup",
       expression: "0 9 * * 1-5",
       message: "Time for standup!",
@@ -83,7 +83,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
 
     expect(getSchedule(schedule.id)).not.toBeNull();
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},
@@ -93,8 +93,8 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     expect(getConversation(conv.id)).toBeNull();
   });
 
-  test("deleting a conversation without a scheduleJobId does not affect schedules", () => {
-    const schedule = createSchedule({
+  test("deleting a conversation without a scheduleJobId does not affect schedules", async () => {
+    const schedule = await createSchedule({
       name: "Unrelated schedule",
       expression: "0 12 * * *",
       message: "Noon check",
@@ -102,7 +102,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
 
     const conv = createConversation("no-schedule-conv");
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},
@@ -112,8 +112,8 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     expect(getConversation(conv.id)).toBeNull();
   });
 
-  test("deleting a conversation with a schedule also removes its cron_runs", () => {
-    const schedule = createSchedule({
+  test("deleting a conversation with a schedule also removes its cron_runs", async () => {
+    const schedule = await createSchedule({
       name: "Recurring job",
       expression: "0 9 * * *",
       message: "Daily task",
@@ -137,7 +137,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
       .get();
     expect(runBefore).not.toBeNull();
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},
@@ -150,8 +150,8 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     expect(runAfter).toBeNull();
   });
 
-  test("deleting one of multiple conversations sharing a schedule preserves the schedule", () => {
-    const schedule = createSchedule({
+  test("deleting one of multiple conversations sharing a schedule preserves the schedule", async () => {
+    const schedule = await createSchedule({
       name: "Recurring daily",
       expression: "0 9 * * *",
       message: "Daily task",
@@ -166,7 +166,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
       scheduleJobId: schedule.id,
     });
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: conv1.id },
       body: {},
       headers: {},
@@ -175,13 +175,13 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
     expect(getSchedule(schedule.id)).not.toBeNull();
   });
 
-  test("deleting one scheduled conversation does not affect other schedules", () => {
-    const scheduleA = createSchedule({
+  test("deleting one scheduled conversation does not affect other schedules", async () => {
+    const scheduleA = await createSchedule({
       name: "Schedule A",
       expression: "0 9 * * *",
       message: "Task A",
     });
-    const scheduleB = createSchedule({
+    const scheduleB = await createSchedule({
       name: "Schedule B",
       expression: "0 17 * * *",
       message: "Task B",
@@ -196,7 +196,7 @@ describe("DELETE /conversations/:id — schedule cleanup", () => {
       scheduleJobId: scheduleB.id,
     });
 
-    deleteRoute.handler({
+    await deleteRoute.handler({
       pathParams: { id: convA.id },
       body: {},
       headers: {},
@@ -222,8 +222,8 @@ describe("POST /conversations/:id/wipe — schedule cleanup", () => {
     getRawDb().run("DELETE FROM conversations");
   });
 
-  test("wiping a conversation with a scheduleJobId removes the schedule", () => {
-    const schedule = createSchedule({
+  test("wiping a conversation with a scheduleJobId removes the schedule", async () => {
+    const schedule = await createSchedule({
       name: "Wipe-test schedule",
       expression: "0 9 * * 1-5",
       message: "Time for standup!",
@@ -236,7 +236,7 @@ describe("POST /conversations/:id/wipe — schedule cleanup", () => {
 
     expect(getSchedule(schedule.id)).not.toBeNull();
 
-    wipeRoute.handler({
+    await wipeRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},
@@ -245,8 +245,8 @@ describe("POST /conversations/:id/wipe — schedule cleanup", () => {
     expect(getSchedule(schedule.id)).toBeNull();
   });
 
-  test("wiping a conversation without a scheduleJobId does not affect schedules", () => {
-    const schedule = createSchedule({
+  test("wiping a conversation without a scheduleJobId does not affect schedules", async () => {
+    const schedule = await createSchedule({
       name: "Unrelated schedule",
       expression: "0 12 * * *",
       message: "Noon check",
@@ -254,7 +254,7 @@ describe("POST /conversations/:id/wipe — schedule cleanup", () => {
 
     const conv = createConversation("no-schedule-wipe");
 
-    wipeRoute.handler({
+    await wipeRoute.handler({
       pathParams: { id: conv.id },
       body: {},
       headers: {},

package/src/__tests__/job-handler-registry-guard.test.ts

@@ -0,0 +1,104 @@
+import { afterEach, beforeEach, describe, expect, it, spyOn } from "bun:test";
+
+import { registerMemoryJobHandlers } from "../jobs/register-job-handlers.js";
+import * as jobsWorker from "../persistence/jobs-worker.js";
+import { registerDefaultPluginJobHandlers } from "../plugins/defaults/index.js";
+import {
+  clearJobHandlerRegistry,
+  getRegisteredJobHandlers,
+  registerPluginJobHandlers,
+} from "../plugins/job-handler-registry.js";
+
+/**
+ * The exact job types the `default-memory` plugin contributes via its
+ * `jobHandlers` field. Locks the contribution against an accidental add/drop —
+ * the job-handler analog of the injector order guard.
+ */
+const MEMORY_JOB_TYPES = [
+  "embed_segment",
+  "embed_summary",
+  "backfill",
+  "rebuild_index",
+  "delete_qdrant_vectors",
+  "embed_media",
+  "embed_attachment",
+  "embed_graph_node",
+  "embed_pkb_file",
+  "graph_trigger_embed",
+  "graph_extract",
+  "graph_decay",
+  "graph_consolidate",
+  "graph_pattern_scan",
+  "graph_narrative_refine",
+  "graph_bootstrap",
+  "embed_concept_page",
+  "memory_v2_sweep",
+  "memory_v2_consolidate",
+  "memory_v2_migrate",
+  "memory_v2_reembed",
+  "memory_v2_activation_recompute",
+  "memory_v3_maintain",
+  "memory_retrospective",
+].sort();
+
+/**
+ * Job types wired directly by `registerMemoryJobHandlers` for domains that are
+ * not plugins (persistence cleanup, conversations, media, home, runtime).
+ */
+const NON_PLUGIN_JOB_TYPES = [
+  "prune_old_conversations",
+  "prune_old_llm_request_logs",
+  "prune_old_trace_events",
+  "build_conversation_summary",
+  "media_processing",
+  "conversation_analyze",
+  "generate_conversation_starters",
+].sort();
+
+describe("job-handler registry — memory plugin contribution", () => {
+  beforeEach(() => {
+    clearJobHandlerRegistry();
+  });
+  afterEach(() => {
+    clearJobHandlerRegistry();
+  });
+
+  it("default-memory contributes exactly the memory job types", () => {
+    registerDefaultPluginJobHandlers();
+    const types = getRegisteredJobHandlers()
+      .map((e) => e.type)
+      .sort();
+    expect(types).toEqual(MEMORY_JOB_TYPES);
+    // Globally unique types (the registry would have thrown on a dupe).
+    expect(new Set(types).size).toBe(types.length);
+  });
+
+  it("registerMemoryJobHandlers wires the full job-type set into the worker", () => {
+    const captured: string[] = [];
+    const spy = spyOn(jobsWorker, "registerJobHandler").mockImplementation(
+      (type: string) => {
+        captured.push(type);
+      },
+    );
+    try {
+      registerMemoryJobHandlers();
+    } finally {
+      spy.mockRestore();
+    }
+    const expected = [...MEMORY_JOB_TYPES, ...NON_PLUGIN_JOB_TYPES].sort();
+    expect(captured.slice().sort()).toEqual(expected);
+    // Each type registered exactly once — no plugin/non-plugin overlap, no drop.
+    expect(new Set(captured).size).toBe(captured.length);
+  });
+
+  it("rejects a duplicate job-handler type across plugins", () => {
+    registerPluginJobHandlers("plugin-a", [
+      { type: "graph_extract", handler: () => undefined },
+    ]);
+    expect(() =>
+      registerPluginJobHandlers("plugin-b", [
+        { type: "graph_extract", handler: () => undefined },
+      ]),
+    ).toThrow(/already registered by plugin "plugin-a"/);
+  });
+});

package/src/__tests__/plugin-import-boundary-guard.test.ts

@@ -125,16 +125,34 @@ const BASELINE: Record<string, readonly string[]> = {
     "../../../../util/strip-comment-lines.js",
     "../../../../util/truncate.js",
     "../../../config/loader.js",
+    "../../../config/types.js",
     "../../../context/strip-injections.js",
     "../../../daemon/pkb-context-tracker.js",
     "../../../daemon/pkb-reminder-builder.js",
     "../../../daemon/trust-context.js",
+    "../../../memory/graph/bootstrap.js",
+    "../../../memory/graph/consolidation.js",
     "../../../memory/graph/conversation-graph-memory.js",
+    "../../../memory/graph/decay.js",
+    "../../../memory/graph/extraction-job.js",
+    "../../../memory/graph/graph-search.js",
+    "../../../memory/graph/narrative.js",
+    "../../../memory/graph/pattern-scan.js",
+    "../../../memory/job-handlers/backfill.js",
+    "../../../memory/job-handlers/embedding.js",
+    "../../../memory/job-handlers/index-maintenance.js",
+    "../../../memory/jobs/embed-concept-page.js",
+    "../../../memory/jobs/embed-pkb-file.js",
+    "../../../memory/memory-retrospective-job.js",
     "../../../memory/pkb/autoinject.js",
     "../../../memory/pkb/context.js",
     "../../../memory/pkb/pkb-search.js",
     "../../../memory/pkb/types.js",
+    "../../../memory/v2/backfill-jobs.js",
+    "../../../memory/v2/consolidation-job.js",
     "../../../memory/v2/static-context.js",
+    "../../../memory/v2/sweep-job.js",
+    "../../../persistence/jobs-store.js",
     "../../../types.js",
     "../../../util/logger.js",
     "../../../util/platform.js",

package/src/__tests__/schedule-retry.test.ts

@@ -107,8 +107,8 @@ describe("schedule retry store", () => {
     db.run("DELETE FROM cron_jobs");
   });
 
-  test("scheduleRetry reverts one-shot from firing to active with future nextRunAt", () => {
-    const schedule = createSchedule({
+  test("scheduleRetry reverts one-shot from firing to active with future nextRunAt", async () => {
+    const schedule = await createSchedule({
       name: "One-shot retry",
       expression: null,
       nextRunAt: Date.now() - 1000,
@@ -122,15 +122,15 @@ describe("schedule retry store", () => {
     ]);
 
     const futureTime = Date.now() + 120_000;
-    scheduleRetry(schedule.id, futureTime);
+    await scheduleRetry(schedule.id, futureTime);
 
     const updated = getSchedule(schedule.id)!;
     expect(updated.status).toBe("active");
     expect(updated.nextRunAt).toBe(futureTime);
   });
 
-  test("scheduleRetry sets nextRunAt for recurring schedule without changing status", () => {
-    const schedule = createSchedule({
+  test("scheduleRetry sets nextRunAt for recurring schedule without changing status", async () => {
+    const schedule = await createSchedule({
       name: "Recurring retry",
       cronExpression: "0 * * * *",
       message: "test",
@@ -139,7 +139,7 @@ describe("schedule retry store", () => {
 
     const originalStatus = getSchedule(schedule.id)!.status;
     const futureTime = Date.now() + 120_000;
-    scheduleRetry(schedule.id, futureTime);
+    await scheduleRetry(schedule.id, futureTime);
 
     const updated = getSchedule(schedule.id)!;
     expect(updated.nextRunAt).toBe(futureTime);
@@ -147,8 +147,8 @@ describe("schedule retry store", () => {
     expect(updated.status).toBe(originalStatus);
   });
 
-  test("resetRetryCount resets retryCount to 0 after error", () => {
-    const schedule = createSchedule({
+  test("resetRetryCount resets retryCount to 0 after error", async () => {
+    const schedule = await createSchedule({
       name: "Reset test",
       cronExpression: "0 * * * *",
       message: "test",
@@ -156,20 +156,20 @@ describe("schedule retry store", () => {
     });
 
     // Simulate an error run which increments retryCount
-    const runId = createScheduleRun(schedule.id, "test-conv");
-    completeScheduleRun(runId, { status: "error", error: "boom" });
+    const runId = await createScheduleRun(schedule.id, "test-conv");
+    await completeScheduleRun(runId, { status: "error", error: "boom" });
 
     const afterError = getSchedule(schedule.id)!;
     expect(afterError.retryCount).toBe(1);
 
-    resetRetryCount(schedule.id);
+    await resetRetryCount(schedule.id);
 
     const afterReset = getSchedule(schedule.id)!;
     expect(afterReset.retryCount).toBe(0);
   });
 
-  test("createSchedule with custom maxRetries and retryBackoffMs", () => {
-    const schedule = createSchedule({
+  test("createSchedule with custom maxRetries and retryBackoffMs", async () => {
+    const schedule = await createSchedule({
       name: "Custom retry config",
       cronExpression: "0 * * * *",
       message: "test",
@@ -183,8 +183,8 @@ describe("schedule retry store", () => {
     expect(retrieved.retryBackoffMs).toBe(30000);
   });
 
-  test("createSchedule with defaults has maxRetries=3 and retryBackoffMs=60000", () => {
-    const schedule = createSchedule({
+  test("createSchedule with defaults has maxRetries=3 and retryBackoffMs=60000", async () => {
+    const schedule = await createSchedule({
       name: "Default retry config",
       cronExpression: "0 * * * *",
       message: "test",
@@ -213,7 +213,7 @@ describe("scheduler retry integration", () => {
   });
 
   test("execute mode failure retries with backoff", async () => {
-    const schedule = createSchedule({
+    const schedule = await createSchedule({
       name: "Failing hourly",
       cronExpression: "0 * * * *",
       message: "do work",
@@ -249,7 +249,7 @@ describe("scheduler retry integration", () => {
   });
 
   test("execute mode retry success resets retryCount", async () => {
-    const schedule = createSchedule({
+    const schedule = await createSchedule({
       name: "Flaky hourly",
       cronExpression: "0 * * * *",
       message: "do work",
@@ -283,7 +283,7 @@ describe("scheduler retry integration", () => {
   });
 
   test("execute mode exhaustion resets retryCount and resumes cadence", async () => {
-    const schedule = createSchedule({
+    const schedule = await createSchedule({
       name: "Exhaust hourly",
       cronExpression: "0 * * * *",
       message: "do work",
@@ -320,7 +320,7 @@ describe("scheduler retry integration", () => {
   });
 
   test("one-shot failure retries with backoff", async () => {
-    const schedule = createSchedule({
+    const schedule = await createSchedule({
       name: "One-shot failing",
       expression: null,
       nextRunAt: Date.now() - 1000,
@@ -347,7 +347,7 @@ describe("scheduler retry integration", () => {
   });
 
   test("one-shot exhaustion permanently cancels", async () => {
-    const schedule = createSchedule({
+    const schedule = await createSchedule({
       name: "One-shot exhaust",
       expression: null,
       nextRunAt: Date.now() - 1000,
@@ -379,7 +379,7 @@ describe("scheduler retry integration", () => {
   });
 
   test("notify one-shot failure creates schedule run", async () => {
-    const schedule = createSchedule({
+    const schedule = await createSchedule({
       name: "Notify one-shot",
       expression: null,
       nextRunAt: Date.now() - 1000,
@@ -406,7 +406,7 @@ describe("scheduler retry integration", () => {
   });
 
   test("recurring schedule retry blocks normal cadence", async () => {
-    const schedule = createSchedule({
+    const schedule = await createSchedule({
       name: "Cadence blocking",
       cronExpression: "0 * * * *",
       message: "do work",
@@ -444,8 +444,8 @@ describe("crash recovery", () => {
     db.run("DELETE FROM cron_jobs");
   });
 
-  test("recovers stale firing one-shot", () => {
-    const schedule = createSchedule({
+  test("recovers stale firing one-shot", async () => {
+    const schedule = await createSchedule({
       name: "Stale one-shot",
       expression: null,
       nextRunAt: Date.now() - 60_000,
@@ -460,7 +460,7 @@ describe("crash recovery", () => {
       [Date.now() - 60_000, schedule.id],
     );
 
-    const recovered = recoverStaleSchedules();
+    const recovered = await recoverStaleSchedules();
     expect(recovered).toBe(1);
 
     // A schedule run should be created with error
@@ -476,8 +476,8 @@ describe("crash recovery", () => {
     expect(updated.nextRunAt).toBeGreaterThan(Date.now() - 5000);
   });
 
-  test("recovers stale running cron_run", () => {
-    const schedule = createSchedule({
+  test("recovers stale running cron_run", async () => {
+    const schedule = await createSchedule({
       name: "Stale run",
       cronExpression: "0 * * * *",
       message: "test",
@@ -485,10 +485,10 @@ describe("crash recovery", () => {
     });
 
     // Create a "running" schedule run to simulate crash
-    const runId = createScheduleRun(schedule.id, "stale-conv");
+    const runId = await createScheduleRun(schedule.id, "stale-conv");
     // The run is now in "running" status by default
 
-    const recovered = recoverStaleSchedules();
+    const recovered = await recoverStaleSchedules();
     expect(recovered).toBe(1);
 
     const runs = getScheduleRuns(schedule.id);
@@ -498,8 +498,8 @@ describe("crash recovery", () => {
     expect(recoveredRun!.error).toContain("recovered on restart");
   });
 
-  test("respects maxRetries on recovery - cancels exhausted one-shot", () => {
-    const schedule = createSchedule({
+  test("respects maxRetries on recovery - cancels exhausted one-shot", async () => {
+    const schedule = await createSchedule({
       name: "Exhausted one-shot",
       expression: null,
       nextRunAt: Date.now() - 60_000,
@@ -514,15 +514,15 @@ describe("crash recovery", () => {
       [3, Date.now() - 60_000, schedule.id],
     );
 
-    recoverStaleSchedules();
+    await recoverStaleSchedules();
 
     const updated = getSchedule(schedule.id)!;
     expect(updated.status).toBe("cancelled");
     expect(updated.enabled).toBe(false);
   });
 
-  test("idempotent - second call returns 0", () => {
-    const schedule = createSchedule({
+  test("idempotent - second call returns 0", async () => {
+    const schedule = await createSchedule({
       name: "Idempotent test",
       expression: null,
       nextRunAt: Date.now() - 60_000,
@@ -535,15 +535,15 @@ describe("crash recovery", () => {
       [Date.now() - 60_000, schedule.id],
     );
 
-    const first = recoverStaleSchedules();
+    const first = await recoverStaleSchedules();
     expect(first).toBe(1);
 
-    const second = recoverStaleSchedules();
+    const second = await recoverStaleSchedules();
     expect(second).toBe(0);
   });
 
-  test("age threshold filters recent in-flight jobs", () => {
-    const schedule = createSchedule({
+  test("age threshold filters recent in-flight jobs", async () => {
+    const schedule = await createSchedule({
       name: "Recent firing",
       expression: null,
       nextRunAt: Date.now() - 1000,
@@ -585,7 +585,7 @@ describe("scheduler-recovery equivalence", () => {
 
   test("same retry state for identical recurring job inputs", async () => {
     // Create two identical recurring schedules
-    const scheduleA = createSchedule({
+    const scheduleA = await createSchedule({
       name: "Equiv A",
       cronExpression: "0 * * * *",
       message: "test",
@@ -594,7 +594,7 @@ describe("scheduler-recovery equivalence", () => {
       retryBackoffMs: 60000,
     });
 
-    const scheduleB = createSchedule({
+    const scheduleB = await createSchedule({
       name: "Equiv B",
       cronExpression: "0 * * * *",
       message: "test",
@@ -620,8 +620,8 @@ describe("scheduler-recovery equivalence", () => {
       scheduleB.id,
     ]);
     // Create a run and complete it with error (same as what scheduler does)
-    const runId = createScheduleRun(scheduleB.id, "recovery-conv");
-    completeScheduleRun(runId, {
+    const runId = await createScheduleRun(scheduleB.id, "recovery-conv");
+    await completeScheduleRun(runId, {
       status: "error",
       error: "Process terminated during execution (recovered on restart)",
     });
@@ -631,7 +631,7 @@ describe("scheduler-recovery equivalence", () => {
     const noopLogger = new Proxy({} as Record<string, unknown>, {
       get: () => () => {},
     });
-    applyRetryDecision({
+    await applyRetryDecision({
       job: jobB,
       isOneShot: false,
       errorMsg: "fail",
@@ -659,7 +659,7 @@ describe("scheduler-recovery equivalence", () => {
 
   test("same exhaust state for identical one-shot inputs", async () => {
     // Create two identical one-shot schedules at max retries
-    const scheduleA = createSchedule({
+    const scheduleA = await createSchedule({
       name: "Exhaust A",
       expression: null,
       nextRunAt: Date.now() - 1000,
@@ -669,7 +669,7 @@ describe("scheduler-recovery equivalence", () => {
       retryBackoffMs: 1000,
     });
 
-    const scheduleB = createSchedule({
+    const scheduleB = await createSchedule({
       name: "Exhaust B",
       expression: null,
       nextRunAt: Date.now() - 1000,
@@ -703,15 +703,15 @@ describe("scheduler-recovery equivalence", () => {
       "UPDATE cron_jobs SET status = 'firing', last_run_at = ? WHERE id = ?",
       [Date.now() - 60_000, scheduleB.id],
     );
-    const runB1 = createScheduleRun(scheduleB.id, "recovery-conv-1");
-    completeScheduleRun(runB1, { status: "error", error: "fail" });
+    const runB1 = await createScheduleRun(scheduleB.id, "recovery-conv-1");
+    await completeScheduleRun(runB1, { status: "error", error: "fail" });
     // decideRetry + apply for first failure
     const jobB1 = getSchedule(scheduleB.id)!;
     const decision1 = decideRetry(jobB1);
     const noopLogger = new Proxy({} as Record<string, unknown>, {
       get: () => () => {},
     });
-    applyRetryDecision({
+    await applyRetryDecision({
       job: jobB1,
       isOneShot: true,
       errorMsg: "fail",
@@ -734,11 +734,11 @@ describe("scheduler-recovery equivalence", () => {
       "UPDATE cron_jobs SET status = 'firing', last_run_at = ? WHERE id = ?",
       [Date.now() - 60_000, scheduleB.id],
     );
-    const runB2 = createScheduleRun(scheduleB.id, "recovery-conv-2");
-    completeScheduleRun(runB2, { status: "error", error: "fail" });
+    const runB2 = await createScheduleRun(scheduleB.id, "recovery-conv-2");
+    await completeScheduleRun(runB2, { status: "error", error: "fail" });
     const jobB2 = getSchedule(scheduleB.id)!;
     const decision2 = decideRetry(jobB2);
-    applyRetryDecision({
+    await applyRetryDecision({
       job: jobB2,
       isOneShot: true,
       errorMsg: "fail",