@vellumai/assistant 0.10.3-dev.202606260318.2a238d5 → 0.10.3-staging.2

package/openapi.yaml

@@ -4841,18 +4841,14 @@ paths:
                         type: string
                       role:
                         type: string
-                        enum:
-                          - guardian
-                          - contact
                       notes:
                         anyOf:
                           - type: string
                           - type: "null"
                       contactType:
-                        type: string
-                        enum:
-                          - human
-                          - assistant
+                        anyOf:
+                          - type: string
+                          - type: "null"
                       lastInteraction:
                         anyOf:
                           - type: number
@@ -4919,15 +4915,20 @@ paths:
                             - address
                             - isPrimary
                             - externalUserId
+                            - status
+                            - policy
+                            - verifiedAt
+                            - verifiedVia
                             - lastSeenAt
                             - interactionCount
                             - lastInteraction
+                            - revokedReason
+                            - blockedReason
                           additionalProperties: false
                     required:
                       - id
                       - displayName
                       - role
-                      - contactType
                       - interactionCount
                       - createdAt
                       - updatedAt
@@ -5001,18 +5002,14 @@ paths:
                           type: string
                         role:
                           type: string
-                          enum:
-                            - guardian
-                            - contact
                         notes:
                           anyOf:
                             - type: string
                             - type: "null"
                         contactType:
-                          type: string
-                          enum:
-                            - human
-                            - assistant
+                          anyOf:
+                            - type: string
+                            - type: "null"
                         lastInteraction:
                           anyOf:
                             - type: number
@@ -5079,15 +5076,20 @@ paths:
                               - address
                               - isPrimary
                               - externalUserId
+                              - status
+                              - policy
+                              - verifiedAt
+                              - verifiedVia
                               - lastSeenAt
                               - interactionCount
                               - lastInteraction
+                              - revokedReason
+                              - blockedReason
                             additionalProperties: false
                       required:
                         - id
                         - displayName
                         - role
-                        - contactType
                         - interactionCount
                         - createdAt
                         - updatedAt
@@ -5130,18 +5132,14 @@ paths:
                         type: string
                       role:
                         type: string
-                        enum:
-                          - guardian
-                          - contact
                       notes:
                         anyOf:
                           - type: string
                           - type: "null"
                       contactType:
-                        type: string
-                        enum:
-                          - human
-                          - assistant
+                        anyOf:
+                          - type: string
+                          - type: "null"
                       lastInteraction:
                         anyOf:
                           - type: number
@@ -5208,15 +5206,20 @@ paths:
                             - address
                             - isPrimary
                             - externalUserId
+                            - status
+                            - policy
+                            - verifiedAt
+                            - verifiedVia
                             - lastSeenAt
                             - interactionCount
                             - lastInteraction
+                            - revokedReason
+                            - blockedReason
                           additionalProperties: false
                     required:
                       - id
                       - displayName
                       - role
-                      - contactType
                       - interactionCount
                       - createdAt
                       - updatedAt
@@ -5504,18 +5507,14 @@ paths:
                         type: string
                       role:
                         type: string
-                        enum:
-                          - guardian
-                          - contact
                       notes:
                         anyOf:
                           - type: string
                           - type: "null"
                       contactType:
-                        type: string
-                        enum:
-                          - human
-                          - assistant
+                        anyOf:
+                          - type: string
+                          - type: "null"
                       lastInteraction:
                         anyOf:
                           - type: number
@@ -5582,15 +5581,20 @@ paths:
                             - address
                             - isPrimary
                             - externalUserId
+                            - status
+                            - policy
+                            - verifiedAt
+                            - verifiedVia
                             - lastSeenAt
                             - interactionCount
                             - lastInteraction
+                            - revokedReason
+                            - blockedReason
                           additionalProperties: false
                     required:
                       - id
                       - displayName
                       - role
-                      - contactType
                       - interactionCount
                       - createdAt
                       - updatedAt
@@ -5698,18 +5702,14 @@ paths:
                       type: string
                     role:
                       type: string
-                      enum:
-                        - guardian
-                        - contact
                     notes:
                       anyOf:
                         - type: string
                         - type: "null"
                     contactType:
-                      type: string
-                      enum:
-                        - human
-                        - assistant
+                      anyOf:
+                        - type: string
+                        - type: "null"
                     lastInteraction:
                       anyOf:
                         - type: number
@@ -5776,15 +5776,20 @@ paths:
                           - address
                           - isPrimary
                           - externalUserId
+                          - status
+                          - policy
+                          - verifiedAt
+                          - verifiedVia
                           - lastSeenAt
                           - interactionCount
                           - lastInteraction
+                          - revokedReason
+                          - blockedReason
                         additionalProperties: false
                   required:
                     - id
                     - displayName
                     - role
-                    - contactType
                     - interactionCount
                     - createdAt
                     - updatedAt
@@ -17426,30 +17431,6 @@ paths:
                                 webUrl:
                                   type: string
                               additionalProperties: false
-                            eventKind:
-                              type: string
-                              enum:
-                                - message
-                                - reaction
-                            reaction:
-                              type: object
-                              properties:
-                                emoji:
-                                  type: string
-                                op:
-                                  type: string
-                                  enum:
-                                    - added
-                                    - removed
-                                actorDisplayName:
-                                  type: string
-                                targetChannelTs:
-                                  type: string
-                              required:
-                                - emoji
-                                - op
-                                - targetChannelTs
-                              additionalProperties: false
                           required:
                             - channelId
                             - channelTs
@@ -17486,14 +17467,6 @@ paths:
                     anyOf:
                       - type: number
                       - type: "null"
-                  processing:
-                    description:
-                      "Whether the agent is currently mid-turn for this conversation, sourced authoritatively from the persisted
-                      `processing_started_at` column. `true` means a turn is in flight; `false` means the conversation
-                      is idle. Clients use this to recover from a dropped SSE stream: if a turn appears to be running
-                      locally but the server reports `processing: false`, the turn has ended (or died) and the UI should
-                      stop waiting rather than spin indefinitely. Absent on older daemons that predate this field."
-                    type: boolean
                 required:
                   - messages
                 additionalProperties: false
@@ -29715,6 +29688,12 @@ components:
                 - $ref: "#/components/schemas/ProfileStatus"
                 - type: "null"
             - type: "null"
+        advisorEnabled:
+          anyOf:
+            - anyOf:
+                - type: boolean
+                - type: "null"
+            - type: "null"
         mix:
           anyOf:
             - minItems: 2
@@ -30442,6 +30421,10 @@ components:
           anyOf:
             - $ref: "#/components/schemas/ProfileStatus"
             - type: "null"
+        advisorEnabled:
+          anyOf:
+            - type: boolean
+            - type: "null"
         mix:
           minItems: 2
           type: array

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vellumai/assistant",
-  "version": "0.10.3-dev.202606260318.2a238d5",
+  "version": "0.10.3-staging.2",
   "license": "MIT",
   "type": "module",
   "exports": {

package/src/__tests__/actor-trust-resolver-address-fallback.test.ts

@@ -7,18 +7,12 @@
  * and are discovered through the same path as every other channel.
  *
  * This suite verifies that address-based lookup returns the correct
- * `memberRecord` with the right ACL status so relay-setup-router
+ * `memberRecord` with the right channel/status so relay-setup-router
  * can emit the appropriate outcome (e.g. `unverified_caller`).
  */
 
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
-import type {
-  ChannelPolicy,
-  ChannelStatus,
-  ContactRole,
-} from "../contacts/types.js";
-
 // ── Logger mock (suppress output) ───────────────────────────────────────────
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -29,45 +23,18 @@ mock.module("../util/logger.js", () => ({
 let _byAddress: ReturnType<
   (typeof import("../contacts/contact-store.js"))["findContactByAddress"]
 > = null;
-// ACL view is carried on memberRecord, sourced from the member-verdict cache.
-// Seed it per test instead of seeding the DB.
-let _acl: { status: ChannelStatus; policy: ChannelPolicy; role: ContactRole } =
-  { status: "unverified", policy: "allow", role: "contact" };
+let _guardian: ReturnType<
+  (typeof import("../contacts/contact-store.js"))["findGuardianForChannel"]
+> = null;
 
 mock.module("../contacts/contact-store.js", () => ({
   findContactByAddress: (_type: string, _addr: string) => _byAddress,
-}));
-
-// Guardian resolution reads the gateway delivery cache; these suites only
-// exercise the member/address path, so the cache peek stays empty.
-mock.module("../contacts/guardian-delivery-reader.js", () => ({
-  peekCachedGuardianDelivery: () => undefined,
-  guardianForChannel: () => undefined,
+  findGuardianForChannel: (_channel: string) => _guardian,
 }));
 
 // ── Real import after mocks ───────────────────────────────────────────────────
 import type { ContactWithChannels } from "../contacts/types.js";
 import { resolveActorTrust } from "../runtime/actor-trust-resolver.js";
-import {
-  __resetMemberVerdictCacheForTest,
-  setMemberVerdict,
-} from "../runtime/member-verdict-cache.js";
-
-const CHANNEL_ID = "ch-test";
-const CONTACT_ID = "contact-test";
-
-// Seed the member-verdict cache so the sync fallback resolves the member with
-// the configured ACL view (mirrors a warmed gateway verdict).
-function seedAcl(): void {
-  setMemberVerdict("phone", PHONE, {
-    trustClass: _acl.role === "guardian" ? "guardian" : "unknown",
-    canonicalSenderId: PHONE,
-    contactId: CONTACT_ID,
-    channelId: CHANNEL_ID,
-    status: _acl.status,
-    policy: _acl.policy,
-  });
-}
 
 // ── Helpers ──────────────────────────────────────────────────────────────────
 
@@ -77,14 +44,13 @@ function makeContact(
   role: "guardian" | "contact" = "contact",
   status: "unverified" | "active" = "unverified",
 ): ContactWithChannels {
-  // ACL lives on memberRecord (carrier), sourced from the member-verdict cache —
-  // record the intended view so seedAcl() warms it before resolution.
-  _acl = { status, policy: "allow", role };
+  const channelId = "ch-test";
   return {
-    id: CONTACT_ID,
+    id: "contact-test",
     displayName: "Patrick Test",
-    notes: null,
     role,
+    principalId: null,
+    notes: null,
     lastInteraction: null,
     interactionCount: 0,
     contactType: "human" as const,
@@ -93,16 +59,22 @@ function makeContact(
     updatedAt: 0,
     channels: [
       {
-        id: CHANNEL_ID,
-        contactId: CONTACT_ID,
+        id: channelId,
+        contactId: "contact-test",
         type: "phone",
         address: PHONE,
         externalChatId: null,
         isPrimary: true,
-        inviteId: null,
-        lastSeenAt: null,
+        status,
+        policy: "allow",
+        verifiedAt: null,
+        verifiedVia: null,
+        revokedReason: null,
+        blockedReason: null,
         interactionCount: 0,
         lastInteraction: null,
+        lastSeenAt: null,
+        inviteId: null,
         createdAt: 0,
         updatedAt: 0,
       },
@@ -115,14 +87,12 @@ function makeContact(
 describe("resolveActorTrust — address fallback", () => {
   beforeEach(() => {
     _byAddress = null;
-    _acl = { status: "unverified", policy: "allow", role: "contact" };
-    __resetMemberVerdictCacheForTest();
+    _guardian = null;
   });
 
   test("finds unverified channel via address when externalUserId is null", () => {
     // Simulate a contact registered by name-capture: address set, externalUserId null.
     _byAddress = makeContact("contact", "unverified");
-    seedAcl();
 
     const result = resolveActorTrust({
       assistantId: "asst-1",
@@ -133,7 +103,7 @@ describe("resolveActorTrust — address fallback", () => {
 
     expect(result.memberRecord).not.toBeNull();
     expect(result.memberRecord?.contact.displayName).toBe("Patrick Test");
-    expect(result.memberRecord?.status).toBe("unverified");
+    expect(result.memberRecord?.channel.status).toBe("unverified");
     // trustClass is 'unverified_contact' for a member whose channel is
     // pending or unverified — known to the guardian but not yet verified.
     expect(result.trustClass).toBe("unverified_contact");
@@ -141,7 +111,6 @@ describe("resolveActorTrust — address fallback", () => {
 
   test("address lookup is the sole member resolution path", () => {
     _byAddress = makeContact("contact", "active");
-    seedAcl();
 
     const result = resolveActorTrust({
       assistantId: "asst-1",
@@ -150,7 +119,7 @@ describe("resolveActorTrust — address fallback", () => {
       actorExternalId: PHONE,
     });
 
-    expect(result.memberRecord?.status).toBe("active");
+    expect(result.memberRecord?.channel.status).toBe("active");
     expect(result.memberRecord?.channel.address).toBe(PHONE);
   });
 
@@ -168,28 +137,10 @@ describe("resolveActorTrust — address fallback", () => {
     expect(result.trustClass).toBe("unknown");
   });
 
-  test("fail-closed: contact found but verdict cache miss → unknown", () => {
-    // The sync fallback runs only when there is no live verdict; with no cached
-    // verdict either, the member stays unresolved and trust is fail-closed.
-    _byAddress = makeContact("contact", "active");
-    // No seedAcl() — the cache is a miss for this sender.
-
-    const result = resolveActorTrust({
-      assistantId: "asst-1",
-      sourceChannel: "phone",
-      conversationExternalId: PHONE,
-      actorExternalId: PHONE,
-    });
-
-    expect(result.memberRecord).toBeNull();
-    expect(result.trustClass).toBe("unknown");
-  });
-
   test("address-found active channel elevates trust to trusted_contact", () => {
     // An active channel found via address (e.g. after manual verify without externalUserId set)
     // should still yield trusted_contact trust class.
     _byAddress = makeContact("contact", "active");
-    seedAcl();
 
     const result = resolveActorTrust({
       assistantId: "asst-1",
@@ -199,7 +150,7 @@ describe("resolveActorTrust — address fallback", () => {
     });
 
     expect(result.memberRecord).not.toBeNull();
-    expect(result.memberRecord?.status).toBe("active");
+    expect(result.memberRecord?.channel.status).toBe("active");
     expect(result.trustClass).toBe("trusted_contact");
   });
 
@@ -207,10 +158,9 @@ describe("resolveActorTrust — address fallback", () => {
     // Mirrors the unverified branch but for `pending` status (e.g. a phone
     // contact registered by name-capture awaiting the DTMF challenge).
     const contact = makeContact("contact", "unverified");
-    // Override ACL status to "pending" — makeContact only accepts unverified/active.
-    _acl = { ..._acl, status: "pending" };
+    // Override status to "pending" — makeContact only accepts unverified/active
+    contact.channels[0]!.status = "pending";
     _byAddress = contact;
-    seedAcl();
 
     const result = resolveActorTrust({
       assistantId: "asst-1",
@@ -219,17 +169,16 @@ describe("resolveActorTrust — address fallback", () => {
       actorExternalId: PHONE,
     });
 
-    expect(result.memberRecord?.status).toBe("pending");
+    expect(result.memberRecord?.channel.status).toBe("pending");
     expect(result.trustClass).toBe("unverified_contact");
   });
 
   test("blocked-status member is classified as unknown (not unverified_contact)", () => {
     // Hard-deny statuses (blocked, revoked) stay `unknown` — admission-layer
-    // re-checks channel status and emits the hard-deny reasons.
+    // re-checks channel.status and emits the hard-deny reasons.
     const contact = makeContact("contact", "unverified");
-    _acl = { ..._acl, status: "blocked" };
+    contact.channels[0]!.status = "blocked";
     _byAddress = contact;
-    seedAcl();
 
     const result = resolveActorTrust({
       assistantId: "asst-1",
@@ -238,15 +187,14 @@ describe("resolveActorTrust — address fallback", () => {
       actorExternalId: PHONE,
     });
 
-    expect(result.memberRecord?.status).toBe("blocked");
+    expect(result.memberRecord?.channel.status).toBe("blocked");
     expect(result.trustClass).toBe("unknown");
   });
 
   test("revoked-status member is classified as unknown", () => {
     const contact = makeContact("contact", "unverified");
-    _acl = { ..._acl, status: "revoked" };
+    contact.channels[0]!.status = "revoked";
     _byAddress = contact;
-    seedAcl();
 
     const result = resolveActorTrust({
       assistantId: "asst-1",
@@ -255,7 +203,7 @@ describe("resolveActorTrust — address fallback", () => {
       actorExternalId: PHONE,
     });
 
-    expect(result.memberRecord?.status).toBe("revoked");
+    expect(result.memberRecord?.channel.status).toBe("revoked");
     expect(result.trustClass).toBe("unknown");
   });
 });

package/src/__tests__/assistant-stream-state.test.ts

@@ -12,7 +12,9 @@ import {
   _resetStreamStateForTesting,
   _simulateRestartForTesting,
   getCurrentSeq,
+  getPersistedSeq,
   getReplayWindow,
+  recordPersistedSeq,
   stampAndBuffer,
 } from "../runtime/assistant-stream-state.js";
 
@@ -569,9 +571,80 @@ describe("assistant-stream-state", () => {
     });
   });
 
-  // Per-conversation persisted seq now lives on the `conversations.seq`
-  // column (see conversation-crud `getConversationPersistedSeq` /
-  // `recordConversationPersistedSeq`); its tests live with that module.
+  describe("persisted seq", () => {
+    test("getPersistedSeq is null for an unknown conversation", () => {
+      expect(getPersistedSeq("conv_unknown")).toBeNull();
+    });
+
+    test("records and retrieves a per-conversation value", () => {
+      recordPersistedSeq("conv_a", 7);
+      expect(getPersistedSeq("conv_a")).toBe(7);
+      expect(getPersistedSeq("conv_b")).toBeNull();
+    });
+
+    test("tracks conversations independently", () => {
+      recordPersistedSeq("conv_a", 3);
+      recordPersistedSeq("conv_b", 9);
+      expect(getPersistedSeq("conv_a")).toBe(3);
+      expect(getPersistedSeq("conv_b")).toBe(9);
+    });
+
+    test("advances monotonically and never regresses", () => {
+      recordPersistedSeq("conv_a", 5);
+      recordPersistedSeq("conv_a", 12);
+      expect(getPersistedSeq("conv_a")).toBe(12);
+
+      // A lower seq (e.g. an out-of-order async commit) is clamped.
+      recordPersistedSeq("conv_a", 8);
+      expect(getPersistedSeq("conv_a")).toBe(12);
+    });
+
+    test("ignores non-positive and non-finite seq values", () => {
+      recordPersistedSeq("conv_a", 0);
+      recordPersistedSeq("conv_a", -3);
+      recordPersistedSeq("conv_a", Number.NaN);
+      recordPersistedSeq("conv_a", Number.POSITIVE_INFINITY);
+      expect(getPersistedSeq("conv_a")).toBeNull();
+    });
+
+    test("is cleared by reset", () => {
+      recordPersistedSeq("conv_a", 4);
+      _resetStreamStateForTesting();
+      expect(getPersistedSeq("conv_a")).toBeNull();
+    });
+
+    test("evicts the least-recently-recorded conversation past the cap", () => {
+      // The map is LRU-bounded at 1024 conversations. Fill to the cap,
+      // then one more insert evicts the oldest key.
+      const CAP = 1024;
+      for (let i = 0; i < CAP; i++) {
+        recordPersistedSeq(`conv_${i}`, i + 1);
+      }
+      // All present at the cap.
+      expect(getPersistedSeq("conv_0")).toBe(1);
+      expect(getPersistedSeq(`conv_${CAP - 1}`)).toBe(CAP);
+
+      // One more distinct conversation evicts the oldest (conv_0).
+      recordPersistedSeq("conv_overflow", 9999);
+      expect(getPersistedSeq("conv_0")).toBeNull();
+      expect(getPersistedSeq("conv_1")).toBe(2);
+      expect(getPersistedSeq("conv_overflow")).toBe(9999);
+    });
+
+    test("re-recording refreshes recency so a kept key is not evicted first", () => {
+      const CAP = 1024;
+      for (let i = 0; i < CAP; i++) {
+        recordPersistedSeq(`conv_${i}`, i + 1);
+      }
+      // Touch the oldest key so it moves to the most-recent end.
+      recordPersistedSeq("conv_0", 5000);
+
+      // The next insert now evicts conv_1 (the new oldest), not conv_0.
+      recordPersistedSeq("conv_overflow", 9999);
+      expect(getPersistedSeq("conv_0")).toBe(5000);
+      expect(getPersistedSeq("conv_1")).toBeNull();
+    });
+  });
 
   describe("seq persistence across restarts", () => {
     test("counter resumes above the persisted reservation after a restart", () => {

package/src/__tests__/background-workers-disk-pressure.test.ts

@@ -100,10 +100,8 @@ mock.module("../daemon/process-message.js", () => ({
 
 const createdConversations: Array<{ conversationType: string }> = [];
 mock.module("../memory/conversation-crud.js", () => ({
-  setConversationProcessingStartedAt: () => {},
-  isConversationProcessing: () => false,
-  recordConversationPersistedSeq: () => {},
-  getConversationPersistedSeq: () => null,
+    setConversationProcessingStartedAt: () => {},
+    isConversationProcessing: () => false,
   addMessage: mock(() => ({ id: "msg-1" })),
   archiveConversation: mock(() => true),
   batchSetDisplayOrders: mock(() => {}),