@vellumai/assistant 0.10.12 → 0.11.0-staging.2

package/src/plugins/defaults/memory/v3/__tests__/shadow-integration.test.ts

@@ -35,13 +35,13 @@ import { drizzle } from "drizzle-orm/bun-sqlite";
 
 import { ensureMemoryV3SelectionsSchema } from "../../../../../persistence/migrations/338-move-memory-v3-selections-to-memory-db.js";
 import * as schema from "../../../../../persistence/schema/index.js";
+import type { PageIndexEntry } from "../../substrate/page-index.js";
 import { renderCard } from "../card.js";
 import type { EdgeGraph } from "../edge.js";
 import { buildEdgeGraph } from "../edge.js";
 import type { OrchestrateResult } from "../orchestrate.js";
 import { buildSectionNeedle } from "../section-needle.js";
 import { buildSectionIndex } from "../sections.js";
-import type { PageIndexEntry } from "../substrate/page-index.js";
 import type { MemoryRoutingTurn, SectionIndex, Slug } from "../types.js";
 
 // ---------------------------------------------------------------------------
@@ -227,7 +227,9 @@ function candidateSlugs(messages: Message[]): Slug[] {
   const entries: Array<{ id: number; slug: string }> = [];
   for (const msg of messages) {
     for (const block of msg.content) {
-      if (block.type !== "text") continue;
+      if (block.type !== "text") {
+        continue;
+      }
       const cards = /<candidate_cards>\n([\s\S]*?)\n<\/candidate_cards>/.exec(
         block.text,
       );
@@ -244,7 +246,9 @@ function candidateSlugs(messages: Message[]): Slug[] {
       if (finder) {
         for (const line of finder[1].split("\n")) {
           const m = /^\[(\d+)\] (?:\([^)]*\) )?(\S+)(?: — |$)/.exec(line);
-          if (m) entries.push({ id: Number(m[1]), slug: m[2]! });
+          if (m) {
+            entries.push({ id: Number(m[1]), slug: m[2]! });
+          }
         }
       }
     }
@@ -269,8 +273,12 @@ function selectProvider(keep: Slug[], pin: Slug[] = []): Provider {
       const ids: number[] = [];
       const pinned_ids: number[] = [];
       pool.forEach((slug, i) => {
-        if (keep.includes(slug)) ids.push(i + 1);
-        if (pin.includes(slug)) pinned_ids.push(i + 1);
+        if (keep.includes(slug)) {
+          ids.push(i + 1);
+        }
+        if (pin.includes(slug)) {
+          pinned_ids.push(i + 1);
+        }
       });
       return toolUseResponse({ ids, pinned_ids });
     },
@@ -498,6 +506,7 @@ describe("memory-v3 integration — selection-log readout", () => {
         dense: 0,
         edge: 0,
         reply: 0,
+        span: 0,
         learned: 0,
         entity: 0,
       },

package/src/plugins/defaults/memory/v3/__tests__/shadow-plugin.test.ts

@@ -62,16 +62,16 @@ const realOrchestrate = { ...(await import("../orchestrate.js")) };
 const realLearnedEdges = { ...(await import("../learned-edges.js")) };
 const realPlatform = { ...(await import("../../../../../util/platform.js")) };
 const realPageStore = {
-  ...(await import("../substrate/page-store.js")),
+  ...(await import("../../substrate/page-store.js")),
 };
 const realConversationCrud = {
   ...(await import("../../../../../persistence/conversation-crud.js")),
 };
 const realSkillStore = {
-  ...(await import("../substrate/skill-store.js")),
+  ...(await import("../../substrate/skill-store.js")),
 };
 const realCliCommandStore = {
-  ...(await import("../substrate/cli-command-store.js")),
+  ...(await import("../../substrate/cli-command-store.js")),
 };
 const realCoreSet = { ...(await import("../core-set.js")) };
 const realHotSet = { ...(await import("../hot-set.js")) };
@@ -102,9 +102,6 @@ let extraRealConceptPages = 0;
 // Mutable mocked config knob (orchestrate-only) for asserting per-turn tuning
 // re-resolution from a live config edit.
 let selectorEnabledCfg = false;
-// Drives the `memory-v3-injection-gate` feature flag through the shared
-// assistant-feature-flags mock below (default off).
-let gateFlagEnabled = false;
 // Mutable `memory.v3.gate.enabled` config kill-switch carried by the mocked
 // config (default on, mirroring the schema default).
 let gateEnabledCfg = true;
@@ -112,8 +109,7 @@ let messages: Array<{ role: string; content: string }> = [];
 
 // Schema defaults for `memory.v3.gate` (the tuning the mocked config carries
 // and the gate-config threading test asserts against). Includes the default-on
-// `enabled` kill-switch; `observeTurn` overwrites `enabled` with the effective
-// flag AND config value.
+// `enabled` kill-switch that `observeTurn` threads through to orchestrate.
 const GATE_DEFAULTS = MemoryV3GateSchema.parse({});
 
 // A synthetic skill capability slug the page index carries. Its rendered
@@ -217,11 +213,7 @@ const FAKE_SECTION_INDEX: SectionIndex = {
 
 mock.module("../../../../../config/assistant-feature-flags.js", () => ({
   isAssistantFeatureFlagEnabled: (key: string) =>
-    key === "memory-v3-live"
-      ? liveEnabled
-      : key === "memory-v3-injection-gate"
-        ? gateFlagEnabled
-        : false,
+    key === "memory-v3-live" ? liveEnabled : false,
 }));
 
 // `observeTurn` and the injector resolve their tuning through the real
@@ -251,9 +243,8 @@ function seedMemoryConfig(): void {
       },
       edge: { hubDegree: 30, seedCount: 6, perSeed: 1, cap: 6 },
       entity: { enabled: true, idfFloor: 4, cap: 8 },
-      // Gate tuning (schema defaults) with the mutable `enabled` kill-switch;
-      // `observeTurn` spreads this and overwrites `enabled` with the effective
-      // flag AND config value before passing to orchestrate.
+      // Gate tuning (schema defaults) with the mutable `enabled` kill-switch,
+      // threaded through to orchestrate as-is.
       gate: { ...GATE_DEFAULTS, enabled: gateEnabledCfg },
     },
     qdrant: { vectorSize: 8, onDisk: false },
@@ -274,7 +265,9 @@ mock.module("../hot-set.js", () => ({
   computeHotSet: (
     ...args: Parameters<typeof realHotSet.computeHotSet>
   ): HotSetEntry[] => {
-    if (!shadowMockActive) return realHotSet.computeHotSet(...args);
+    if (!shadowMockActive) {
+      return realHotSet.computeHotSet(...args);
+    }
     hotSetOpts = args[0];
     return hotSetResult;
   },
@@ -295,7 +288,7 @@ mock.module("../../../../../persistence/db-connection.js", () => ({
     memoryDbAvailable ? drizzle(memorySqlite, { schema }) : null,
 }));
 
-mock.module("../substrate/page-index.js", () => ({
+mock.module("../../substrate/page-index.js", () => ({
   getPageIndex: async () => ({
     entries: [
       {
@@ -341,7 +334,7 @@ mock.module("../substrate/page-index.js", () => ({
 }));
 
 // `pageContent` (live mode) reads the full page via `readPage`/`renderPageContent`.
-mock.module("../substrate/page-store.js", () => ({
+mock.module("../../substrate/page-store.js", () => ({
   ...realPageStore,
   readPage: async (workspaceDir: string, slug: string) =>
     shadowMockActive
@@ -374,7 +367,7 @@ mock.module("../../../../../util/platform.js", () => ({
 // synthetic slugs through these. Spread the real module so the prefix
 // predicates (`isSkillSlug`/`isCliCommandSlug`) stay intact; override only the
 // content lookup so the capability slug resolves.
-mock.module("../substrate/skill-store.js", () => ({
+mock.module("../../substrate/skill-store.js", () => ({
   ...realSkillStore,
   getSkillCapability: (idOrSlug: string) =>
     shadowMockActive
@@ -384,7 +377,7 @@ mock.module("../substrate/skill-store.js", () => ({
       : realSkillStore.getSkillCapability(idOrSlug),
 }));
 
-mock.module("../substrate/cli-command-store.js", () => ({
+mock.module("../../substrate/cli-command-store.js", () => ({
   ...realCliCommandStore,
   getCliCommandCapability: (idOrSlug: string) =>
     shadowMockActive
@@ -397,7 +390,9 @@ mock.module("../sections.js", () => ({
   buildSectionIndex: async (
     ...args: Parameters<typeof realSections.buildSectionIndex>
   ) => {
-    if (!shadowMockActive) return realSections.buildSectionIndex(...args);
+    if (!shadowMockActive) {
+      return realSections.buildSectionIndex(...args);
+    }
     sectionBuilds++;
     // Capture the `pageBody` resolver so a test can exercise the capability
     // branch directly. Returning the FAKE index keeps the other tests cheap.
@@ -411,7 +406,9 @@ mock.module("../section-needle.js", () => ({
   buildSectionNeedle: (
     ...args: Parameters<typeof realSectionNeedle.buildSectionNeedle>
   ) => {
-    if (!shadowMockActive) return realSectionNeedle.buildSectionNeedle(...args);
+    if (!shadowMockActive) {
+      return realSectionNeedle.buildSectionNeedle(...args);
+    }
     needleBuilds++;
     return { query: () => [], bestSection: () => -1 };
   },
@@ -422,7 +419,9 @@ mock.module("../edge.js", () => ({
   buildEdgeGraph: async (
     ...args: Parameters<typeof realEdge.buildEdgeGraph>
   ) => {
-    if (!shadowMockActive) return realEdge.buildEdgeGraph(...args);
+    if (!shadowMockActive) {
+      return realEdge.buildEdgeGraph(...args);
+    }
     edgeBuilds++;
     return { adjacency: new Map(), hubs: new Set(), slugs: new Set() };
   },
@@ -433,8 +432,9 @@ mock.module("../learned-edges.js", () => ({
   computeLearnedEdgeGraph: (
     ...args: Parameters<typeof realLearnedEdges.computeLearnedEdgeGraph>
   ) => {
-    if (!shadowMockActive)
+    if (!shadowMockActive) {
       return realLearnedEdges.computeLearnedEdgeGraph(...args);
+    }
     learnedGraphBuilds++;
     return { adjacency: new Map(), hubs: new Set(), slugs: new Set() };
   },
@@ -449,7 +449,9 @@ mock.module("../section-dense-store.js", () => ({
       return realSectionDenseStore.ensureSectionCollection(...args);
     }
     ensureCollectionCalls++;
-    if (ensureCollectionThrows) throw new Error("qdrant unavailable");
+    if (ensureCollectionThrows) {
+      throw new Error("qdrant unavailable");
+    }
   },
 }));
 
@@ -469,7 +471,9 @@ mock.module("../lanes-version-store.js", () => ({
     }
     // The store swallows read errors and returns `undefined`; mirror that so
     // `getLanes` exercises its "cannot judge staleness → serve memo" branch.
-    if (lanesVersionReadThrows) return undefined;
+    if (lanesVersionReadThrows) {
+      return undefined;
+    }
     return mockLanesVersion;
   },
   bumpLanesVersion: (workspaceDir: string) => {
@@ -523,7 +527,6 @@ beforeEach(() => {
   learnedEdgesCap = 0;
   extraRealConceptPages = 0;
   selectorEnabledCfg = false;
-  gateFlagEnabled = false;
   gateEnabledCfg = true;
   messages = [
     {
@@ -565,7 +568,9 @@ async function produce(conversationId: string, turnIndex: number) {
     trust: {} as never,
   });
   const commit = block?.meta?.[MEMORY_V3_COMMIT_META_KEY];
-  if (typeof commit === "function") (commit as () => void)();
+  if (typeof commit === "function") {
+    (commit as () => void)();
+  }
   return block;
 }
 
@@ -775,41 +780,26 @@ describe("memory-v3 engine", () => {
     expect(secondDeps.selectorEnabled).toBe(true);
   });
 
-  test("flag on → threads the gate tuning plus enabled:true into orchestrate", async () => {
-    gateFlagEnabled = true;
+  test("gate enabled (default) → threads the gate tuning plus enabled:true into orchestrate", async () => {
     await observeTurn("conv-1", 0);
 
     const deps = (
       orchestrateSpy.mock.calls as unknown as unknown[][]
     )[0]![1] as { gateConfig?: unknown };
-    // The spread is the live gate config: the `memory.v3.gate` tuning with the
-    // flag-derived `enabled` folded in.
+    // The live gate config is the `memory.v3.gate` tuning, including the
+    // default-on `enabled` kill-switch.
     expect(deps.gateConfig).toEqual({ ...GATE_DEFAULTS, enabled: true });
   });
 
-  test("flag off (default) → gate config threads inert (enabled:false, schema-default tuning)", async () => {
-    // gateFlagEnabled defaults to false in beforeEach.
-    await observeTurn("conv-1", 0);
-
-    const deps = (
-      orchestrateSpy.mock.calls as unknown as unknown[][]
-    )[0]![1] as { gateConfig?: { enabled?: boolean } };
-    // Flag off → the gate is wired in but inert, and the tuning fields are the
-    // schema defaults the config carries.
-    expect(deps.gateConfig?.enabled).toBe(false);
-    expect(deps.gateConfig).toEqual({ ...GATE_DEFAULTS, enabled: false });
-  });
-
-  test("flag on + gate.enabled:false config kill-switch → gate threads inert", async () => {
-    gateFlagEnabled = true;
+  test("gate.enabled:false config kill-switch → gate threads inert", async () => {
     gateEnabledCfg = false;
     await observeTurn("conv-1", 0);
 
     const deps = (
       orchestrateSpy.mock.calls as unknown as unknown[][]
     )[0]![1] as { gateConfig?: unknown };
-    // The config kill-switch wins over the flag: the effective `enabled` is
-    // false, so selection always runs.
+    // The kill-switch makes the effective `enabled` false, so selection
+    // always runs.
     expect(deps.gateConfig).toEqual({ ...GATE_DEFAULTS, enabled: false });
   });
 

package/src/plugins/defaults/memory/v3/__tests__/tuning-profile.test.ts

@@ -47,6 +47,7 @@ describe("resolveV3Tuning", () => {
       needleK: v3.needleK,
       denseK: v3.denseK,
       replyQueryK: v3.replyQueryK,
+      spanQueryK: v3.spanQueryK,
       selectorEnabled: v3.selectorEnabled,
       learnedEdgesCap: v3.learnedEdges.cap,
       edgeSeedCount: v3.edge.seedCount,

package/src/plugins/defaults/memory/v3/candidate-match.ts

@@ -31,8 +31,8 @@ import {
 } from "../../../../persistence/embeddings/embed.js";
 import { abortableSleep, computeRetryDelay } from "../host-utils.js";
 import { getLogger } from "../logging.js";
-import { simBatch } from "./substrate/sim.js";
-import { skillSlugFor } from "./substrate/skill-store.js";
+import { simBatch } from "../substrate/sim.js";
+import { skillSlugFor } from "../substrate/skill-store.js";
 
 const log = getLogger("memory-v3-candidate-match");
 

package/src/plugins/defaults/memory/v3/capabilities.ts

@@ -17,12 +17,12 @@
  *    make a command semantically findable.
  */
 
-import { buildCliCommandSummary } from "./substrate/cli-command-content.js";
+import { buildCliCommandSummary } from "../substrate/cli-command-content.js";
 import {
   getCliCommandCapability,
   isCliCommandSlug,
-} from "./substrate/cli-command-store.js";
-import { getSkillCapability, isSkillSlug } from "./substrate/skill-store.js";
+} from "../substrate/cli-command-store.js";
+import { getSkillCapability, isSkillSlug } from "../substrate/skill-store.js";
 import type { Slug } from "./types.js";
 
 /** True iff the slug is a synthetic skill or CLI-command capability row. */
@@ -127,6 +127,8 @@ export async function capabilityOrDiskBody(
   slug: Slug,
   readDiskBody: (slug: Slug) => Promise<string>,
 ): Promise<string> {
-  if (isCapabilitySlug(slug)) return renderCapabilityBody(slug) ?? "";
+  if (isCapabilitySlug(slug)) {
+    return renderCapabilityBody(slug) ?? "";
+  }
   return readDiskBody(slug);
 }

package/src/plugins/defaults/memory/v3/card.ts

@@ -1,5 +1,5 @@
 import { FRONTMATTER_REGEX, parseFrontmatterFields } from "../frontmatter.js";
-import { injectedConceptHeader } from "./substrate/injected-block-slugs.js";
+import { injectedConceptHeader } from "../substrate/injected-block-slugs.js";
 import type { Slug } from "./types.js";
 
 /**
@@ -32,7 +32,9 @@ const SECTION_HEADING_REGEX = /^## (.*)$/m;
  */
 function renderLinkEntry(entry: string): string {
   const sep = entry.indexOf(" — ");
-  if (sep === -1) return entry.trim();
+  if (sep === -1) {
+    return entry.trim();
+  }
   const target = entry.slice(0, sep).trim();
   let note = entry.slice(sep + " — ".length).trim();
   if (note.length > LINK_NOTE_MAX_CHARS) {
@@ -59,13 +61,17 @@ function renderTocLine(
       .filter((entry): entry is string => typeof entry === "string")
       .map(renderLinkEntry)
       .filter((entry) => entry.length > 0);
-    if (entries.length > 0) return `[linked: ${entries.join(" · ")}]`;
+    if (entries.length > 0) {
+      return `[linked: ${entries.join(" · ")}]`;
+    }
   }
 
   const headings = [...body.matchAll(new RegExp(SECTION_HEADING_REGEX, "gm"))]
     .map((match) => match[1]!.trim())
     .filter((heading) => heading.length > 0);
-  if (headings.length === 0) return null;
+  if (headings.length === 0) {
+    return null;
+  }
   return `[sections: ${headings.map((h) => `§${h}`).join(" · ")}]`;
 }
 
@@ -81,9 +87,13 @@ const CURRENT_MAX_CHARS = 280;
  */
 function renderCurrentLine(fields: Record<string, unknown>): string | null {
   const current = fields.current;
-  if (typeof current !== "string") return null;
+  if (typeof current !== "string") {
+    return null;
+  }
   const collapsed = current.replace(/\s+/g, " ").trim();
-  if (collapsed.length === 0) return null;
+  if (collapsed.length === 0) {
+    return null;
+  }
   const capped =
     collapsed.length > CURRENT_MAX_CHARS
       ? `${collapsed.slice(0, CURRENT_MAX_CHARS).trimEnd()}…`
@@ -138,14 +148,20 @@ export function renderCard(
 
   let card = injectedConceptHeader(slug);
   const current = renderCurrentLine(fields);
-  if (current !== null) card += `\n${current}`;
+  if (current !== null) {
+    card += `\n${current}`;
+  }
   if (annotation !== undefined && annotation.length > 0) {
     card += `\n${annotation}`;
   }
-  if (head.length > 0) card += `\n${head}`;
+  if (head.length > 0) {
+    card += `\n${head}`;
+  }
 
   const toc = renderTocLine(body, fields);
-  if (toc !== null) card += `\n\n${toc}`;
+  if (toc !== null) {
+    card += `\n\n${toc}`;
+  }
 
   return card;
 }

package/src/plugins/defaults/memory/v3/edge.ts

@@ -1,5 +1,5 @@
 import { parseFrontmatterFields } from "../frontmatter.js";
-import type { PageIndexEntry } from "./substrate/page-index.js";
+import type { PageIndexEntry } from "../substrate/page-index.js";
 import type { Slug } from "./types.js";
 
 /**
@@ -89,7 +89,9 @@ function parseLinkEntry(entry: string): {
   description: string | undefined;
 } {
   const sep = entry.indexOf(LINK_SEPARATOR);
-  if (sep === -1) return { target: entry.trim(), description: undefined };
+  if (sep === -1) {
+    return { target: entry.trim(), description: undefined };
+  }
   return {
     target: entry.slice(0, sep).trim(),
     description: entry.slice(sep + LINK_SEPARATOR.length).trim() || undefined,
@@ -104,11 +106,17 @@ function parseWikilinks(body: string): string[] {
   for (const match of body.matchAll(WIKILINK_REGEX)) {
     let target = match[1];
     const pipe = target.indexOf("|");
-    if (pipe !== -1) target = target.slice(0, pipe);
+    if (pipe !== -1) {
+      target = target.slice(0, pipe);
+    }
     const hash = target.indexOf("#");
-    if (hash !== -1) target = target.slice(0, hash);
+    if (hash !== -1) {
+      target = target.slice(0, hash);
+    }
     target = target.trim();
-    if (target) targets.push(target);
+    if (target) {
+      targets.push(target);
+    }
   }
   return targets;
 }
@@ -148,8 +156,12 @@ export async function buildEdgeGraph(
     target: Slug,
     description: string | undefined,
   ): void => {
-    if (target === source) return; // no self-edges
-    if (!slugs.has(target)) return; // drop unknown/dangling targets
+    if (target === source) {
+      return;
+    } // no self-edges
+    if (!slugs.has(target)) {
+      return;
+    } // drop unknown/dangling targets
     let out = adjacency.get(source);
     if (!out) {
       out = new Map();
@@ -175,7 +187,9 @@ export async function buildEdgeGraph(
     const links = parsed?.fields.links;
     if (Array.isArray(links)) {
       for (const entry of links) {
-        if (typeof entry !== "string") continue;
+        if (typeof entry !== "string") {
+          continue;
+        }
         const { target, description } = parseLinkEntry(entry);
         addEdge(source, target, description);
       }
@@ -194,13 +208,17 @@ export async function buildEdgeGraph(
     // (c) numeric page-index edges resolved to slugs — fallback.
     for (const targetId of article.edges) {
       const target = byId.get(targetId);
-      if (target) addEdge(source, target, undefined);
+      if (target) {
+        addEdge(source, target, undefined);
+      }
     }
   }
 
   const hubs = new Set<Slug>();
   for (const [slug, degree] of inDegree) {
-    if (degree > hubDegree) hubs.add(slug);
+    if (degree > hubDegree) {
+      hubs.add(slug);
+    }
   }
 
   return { adjacency, hubs, slugs };
@@ -229,17 +247,33 @@ export function edgeExpand(
   const surfaced = new Map<Slug, string | undefined>();
 
   for (const seed of seeds.slice(0, seedCount)) {
-    if (surfaced.size >= cap) break;
+    if (surfaced.size >= cap) {
+      break;
+    }
     const out = graph.adjacency.get(seed);
-    if (!out) continue;
+    if (!out) {
+      continue;
+    }
     let added = 0;
     for (const [target, description] of out) {
-      if (added >= perSeed) break;
-      if (surfaced.size >= cap) break;
-      if (seedSet.has(target)) continue; // already in the pool
-      if (surfaced.has(target)) continue; // already surfaced via another seed
-      if (graph.hubs.has(target)) continue; // hubs excluded
-      if (alive && !alive(target)) continue;
+      if (added >= perSeed) {
+        break;
+      }
+      if (surfaced.size >= cap) {
+        break;
+      }
+      if (seedSet.has(target)) {
+        continue;
+      } // already in the pool
+      if (surfaced.has(target)) {
+        continue;
+      } // already surfaced via another seed
+      if (graph.hubs.has(target)) {
+        continue;
+      } // hubs excluded
+      if (alive && !alive(target)) {
+        continue;
+      }
       surfaced.set(target, description);
       added++;
     }

package/src/plugins/defaults/memory/v3/gate.ts

@@ -17,9 +17,9 @@
 // regardless of how the thresholds are tuned.
 //
 // This module is intentionally PURE — no async, no I/O, no logging, and no
-// imports beyond the two scored-hit types. `config.enabled` is the resolved
-// effective enable (feature flag AND `memory.v3.gate.enabled`) supplied by the
-// caller, which also feeds in the finder-lane hits.
+// imports beyond the two scored-hit types. `config.enabled` is the
+// `memory.v3.gate.enabled` kill-switch supplied by the caller, which also
+// feeds in the finder-lane hits.
 
 import type { DenseHitScored } from "./dense.js";
 import type { SectionNeedleScoredHit } from "./section-needle.js";
@@ -37,7 +37,7 @@ export type V3GateReason =
   | "disabled";
 
 export interface V3GateConfig {
-  enabled: boolean; // effective enable — flag AND config kill-switch, resolved in observeTurn
+  enabled: boolean; // the `memory.v3.gate.enabled` kill-switch, threaded through by observeTurn
   denseThreshold: number;
   sparseThreshold: number;
   sparseOnlyThreshold: number;

package/src/plugins/defaults/memory/v3/injector.ts

@@ -59,7 +59,10 @@
  */
 
 import { getConfig } from "../../../../config/loader.js";
-import { isMemoryV3Live } from "../../../../config/memory-v3-gate.js";
+import {
+  isMemoryEnabled,
+  isMemoryV3Live,
+} from "../../../../config/memory-v3-gate.js";
 import {
   type PendingConversationNotice,
   queueConversationNotice,
@@ -257,7 +260,9 @@ export const memoryV3Injector: Injector = {
   order: 1000,
   async produce(ctx: TurnContext): Promise<InjectionBlock | null> {
     const config = getConfig();
-    if (config.memory.enabled === false) return null;
+    if (!isMemoryEnabled(config)) {
+      return null;
+    }
     const live = isMemoryV3Live(config);
     if (!live) return null;
     if (!isPersonalMemoryAllowed(ctx.trust)) return null;
@@ -370,7 +375,9 @@ export const memoryV3SpotlightInjector: Injector = {
   order: 1001,
   async produce(ctx: TurnContext): Promise<InjectionBlock | null> {
     const config = getConfig();
-    if (config.memory.enabled === false) return null;
+    if (!isMemoryEnabled(config)) {
+      return null;
+    }
     // The spotlight rides the live `<memory>` layer; with `memory.v3.live` off
     // it produces nothing and keeps no ring state.
     if (!isMemoryV3Live(config)) return null;

package/src/plugins/defaults/memory/v3/maintain-job.ts

@@ -76,6 +76,9 @@ import { executeDeleteManagedSkill } from "../../../../tools/skills/delete-manag
 import { embedWithBackend } from "../embeddings.js";
 import { getLogger } from "../logging.js";
 import { getWorkspaceDir } from "../paths.js";
+import { getPageIndex } from "../substrate/page-index.js";
+import { readPage } from "../substrate/page-store.js";
+import { skillSlugFor } from "../substrate/skill-store.js";
 import { capabilityOrDiskBody, isCapabilitySlug } from "./capabilities.js";
 import { loadCoreSet as realLoadCoreSet } from "./core-set.js";
 import {
@@ -87,9 +90,6 @@ import {
 } from "./section-dense-store.js";
 import { buildSectionIndex as realBuildSectionIndex } from "./sections.js";
 import { invalidateLanes as realInvalidateLanes } from "./shadow-plugin.js";
-import { getPageIndex } from "./substrate/page-index.js";
-import { readPage } from "./substrate/page-store.js";
-import { skillSlugFor } from "./substrate/skill-store.js";
 import type { Slug } from "./types.js";
 
 const DAY_MS = 24 * 60 * 60 * 1000;