@vellumai/assistant 0.10.0 → 0.10.1-dev.202606240317.ea25efe

package/src/memory/migrations/136-drop-assistant-id-columns.ts

@@ -1,6 +1,6 @@
 import { getLogger } from "../../util/logger.js";
 import { type DrizzleDb, getSqliteFrom } from "../db-connection.js";
-import { withCrashRecovery } from "./validate-migration-state.js";
+import { tableExists } from "./schema-introspection.js";
 
 /**
  * Reverse v19: add assistant_id columns back to all 16 tables via
@@ -68,248 +68,270 @@ const log = getLogger("migration-136");
  *  4. Recreate indexes without the `assistant_id` column.
  */
 export function migrateDropAssistantIdColumns(database: DrizzleDb): void {
-  withCrashRecovery(database, "migration_drop_assistant_id_columns_v1", () => {
-    const raw = getSqliteFrom(database);
-
-    // The 16 tables that carry assistant_id.
-    const tables = [
-      "contacts",
-      "assistant_ingress_invites",
-      "assistant_inbox_thread_state",
-      "call_sessions",
-      "channel_guardian_verification_challenges",
-      "channel_guardian_approval_requests",
-      "channel_guardian_rate_limits",
-      "guardian_action_requests",
-      "scoped_approval_grants",
-      "notification_events",
-      "notification_preferences",
-      "notification_deliveries",
-      "conversation_attention_events",
-      "conversation_assistant_attention_state",
-      "actor_token_records",
-      "actor_refresh_token_records",
-    ];
-
-    // --- Safety assertion ---
-    // Verify all existing assistant_id values are 'self' or NULL before dropping.
-    for (const table of tables) {
-      const cols = new Set(
-        (
-          raw.query(`PRAGMA table_info(${table})`).all() as Array<{
-            name: string;
-          }>
-        ).map((c) => c.name),
-      );
-
-      if (!cols.has("assistant_id")) {
-        log.info(
-          { table },
-          "Table does not have assistant_id column — skipping",
-        );
-        continue;
-      }
-
-      const unexpected = raw
-        .query(
-          `SELECT DISTINCT assistant_id FROM ${table} WHERE assistant_id IS NOT NULL AND assistant_id != 'self'`,
-        )
-        .all() as Array<{ assistant_id: string }>;
-
-      if (unexpected.length > 0) {
-        log.warn(
-          { table, values: unexpected.map((r) => r.assistant_id) },
-          "Unexpected assistant_id values found — skipping table",
-        );
-        continue;
-      }
-    }
-
-    // --- Drop ALL indexes that include assistant_id ---
-    // Every index below references the assistant_id column. SQLite will error
-    // on ALTER TABLE ... DROP COLUMN if any index still references the column.
-
-    // channel_guardian_verification_challenges indexes (migrations 110, 026, 027a)
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_channel_guardian_challenges_lookup`,
-    );
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_guardian_sessions_active`);
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_guardian_sessions_identity`);
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_guardian_sessions_destination`);
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_guardian_sessions_bootstrap`);
-
-    // channel_guardian_rate_limits indexes (migration 110)
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_channel_guardian_rate_limits_actor`,
-    );
-
-    // assistant_ingress_invites indexes (migration 112)
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_ingress_invites_channel_status`);
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_ingress_invites_channel_created`,
-    );
+  const raw = getSqliteFrom(database);
 
-    // assistant_inbox_thread_state indexes (migration 112)
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_inbox_thread_state_channel`);
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_inbox_thread_state_last_msg`);
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_inbox_thread_state_escalation`);
+  // The 16 tables that carry assistant_id.
+  const tables = [
+    "contacts",
+    "assistant_ingress_invites",
+    "assistant_inbox_thread_state",
+    "call_sessions",
+    "channel_guardian_verification_challenges",
+    "channel_guardian_approval_requests",
+    "channel_guardian_rate_limits",
+    "guardian_action_requests",
+    "scoped_approval_grants",
+    "notification_events",
+    "notification_preferences",
+    "notification_deliveries",
+    "conversation_attention_events",
+    "conversation_assistant_attention_state",
+    "actor_token_records",
+    "actor_refresh_token_records",
+  ];
 
-    // notification_preferences indexes (migration 114)
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_notification_preferences_assistant_id`,
-    );
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_notification_preferences_assistant_priority`,
+  // --- Safety assertion ---
+  // Verify all existing assistant_id values are 'self' or NULL before dropping.
+  for (const table of tables) {
+    const cols = new Set(
+      (
+        raw.query(`PRAGMA table_info(${table})`).all() as Array<{
+          name: string;
+        }>
+      ).map((c) => c.name),
     );
 
-    // notification_events indexes (migration 114)
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_notification_events_assistant_event_created`,
-    );
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_notification_events_dedupe`);
+    if (!cols.has("assistant_id")) {
+      log.info({ table }, "Table does not have assistant_id column — skipping");
+      continue;
+    }
 
-    // notification_deliveries indexes (migration 114)
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_notification_deliveries_assistant_status`,
-    );
+    const unexpected = raw
+      .query(
+        `SELECT DISTINCT assistant_id FROM ${table} WHERE assistant_id IS NOT NULL AND assistant_id != 'self'`,
+      )
+      .all() as Array<{ assistant_id: string }>;
 
-    // conversation_attention_events indexes (migration 117)
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_conv_attn_events_assistant_observed`,
-    );
+    if (unexpected.length > 0) {
+      log.warn(
+        { table, values: unexpected.map((r) => r.assistant_id) },
+        "Unexpected assistant_id values found — skipping table",
+      );
+      continue;
+    }
+  }
 
-    // conversation_assistant_attention_state indexes (migration 117)
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_conv_attn_state_assistant_latest_msg`,
-    );
-    raw.exec(
-      /*sql*/ `DROP INDEX IF EXISTS idx_conv_attn_state_assistant_last_seen`,
+  // --- Drop ALL indexes that include assistant_id ---
+  // Every index below references the assistant_id column. SQLite will error
+  // on ALTER TABLE ... DROP COLUMN if any index still references the column.
+
+  // channel_guardian_verification_challenges indexes (migrations 110, 026, 027a)
+  raw.exec(
+    /*sql*/ `DROP INDEX IF EXISTS idx_channel_guardian_challenges_lookup`,
+  );
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_guardian_sessions_active`);
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_guardian_sessions_identity`);
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_guardian_sessions_destination`);
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_guardian_sessions_bootstrap`);
+
+  // channel_guardian_rate_limits indexes (migration 110)
+  raw.exec(
+    /*sql*/ `DROP INDEX IF EXISTS idx_channel_guardian_rate_limits_actor`,
+  );
+
+  // assistant_ingress_invites indexes (migration 112)
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_ingress_invites_channel_status`);
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_ingress_invites_channel_created`);
+
+  // assistant_inbox_thread_state indexes (migration 112)
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_inbox_thread_state_channel`);
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_inbox_thread_state_last_msg`);
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_inbox_thread_state_escalation`);
+
+  // notification_preferences indexes (migration 114)
+  raw.exec(
+    /*sql*/ `DROP INDEX IF EXISTS idx_notification_preferences_assistant_id`,
+  );
+  raw.exec(
+    /*sql*/ `DROP INDEX IF EXISTS idx_notification_preferences_assistant_priority`,
+  );
+
+  // notification_events indexes (migration 114)
+  raw.exec(
+    /*sql*/ `DROP INDEX IF EXISTS idx_notification_events_assistant_event_created`,
+  );
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_notification_events_dedupe`);
+
+  // notification_deliveries indexes (migration 114)
+  raw.exec(
+    /*sql*/ `DROP INDEX IF EXISTS idx_notification_deliveries_assistant_status`,
+  );
+
+  // conversation_attention_events indexes (migration 117)
+  raw.exec(
+    /*sql*/ `DROP INDEX IF EXISTS idx_conv_attn_events_assistant_observed`,
+  );
+
+  // conversation_assistant_attention_state indexes (migration 117)
+  raw.exec(
+    /*sql*/ `DROP INDEX IF EXISTS idx_conv_attn_state_assistant_latest_msg`,
+  );
+  raw.exec(
+    /*sql*/ `DROP INDEX IF EXISTS idx_conv_attn_state_assistant_last_seen`,
+  );
+
+  // actor_token_records indexes (migration 038)
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_actor_tokens_active_device`);
+
+  // actor_refresh_token_records indexes (migration 039)
+  raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_refresh_tokens_active_device`);
+
+  // --- Drop assistant_id column from each table ---
+  for (const table of tables) {
+    const cols = new Set(
+      (
+        raw.query(`PRAGMA table_info(${table})`).all() as Array<{
+          name: string;
+        }>
+      ).map((c) => c.name),
     );
 
-    // actor_token_records indexes (migration 038)
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_actor_tokens_active_device`);
+    if (!cols.has("assistant_id")) continue;
 
-    // actor_refresh_token_records indexes (migration 039)
-    raw.exec(/*sql*/ `DROP INDEX IF EXISTS idx_refresh_tokens_active_device`);
+    // Re-verify safety before each drop
+    const unexpected = raw
+      .query(
+        `SELECT DISTINCT assistant_id FROM ${table} WHERE assistant_id IS NOT NULL AND assistant_id != 'self'`,
+      )
+      .all() as Array<{ assistant_id: string }>;
 
-    // --- Drop assistant_id column from each table ---
-    for (const table of tables) {
-      const cols = new Set(
-        (
-          raw.query(`PRAGMA table_info(${table})`).all() as Array<{
-            name: string;
-          }>
-        ).map((c) => c.name),
+    if (unexpected.length > 0) {
+      log.warn(
+        { table, values: unexpected.map((r) => r.assistant_id) },
+        "Unexpected assistant_id values — skipping column drop",
       );
-
-      if (!cols.has("assistant_id")) continue;
-
-      // Re-verify safety before each drop
-      const unexpected = raw
-        .query(
-          `SELECT DISTINCT assistant_id FROM ${table} WHERE assistant_id IS NOT NULL AND assistant_id != 'self'`,
-        )
-        .all() as Array<{ assistant_id: string }>;
-
-      if (unexpected.length > 0) {
-        log.warn(
-          { table, values: unexpected.map((r) => r.assistant_id) },
-          "Unexpected assistant_id values — skipping column drop",
-        );
-        continue;
-      }
-
-      raw.exec(/*sql*/ `ALTER TABLE ${table} DROP COLUMN assistant_id`);
-      log.info({ table }, "Dropped assistant_id column");
+      continue;
     }
 
-    // --- Recreate indexes without assistant_id ---
-    // Each index below is the equivalent of the dropped index but with the
-    // assistant_id column removed. Index names are updated to avoid
-    // collisions with the old names.
+    raw.exec(/*sql*/ `ALTER TABLE ${table} DROP COLUMN assistant_id`);
+    log.info({ table }, "Dropped assistant_id column");
+  }
 
-    // channel_guardian_verification_challenges
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_channel_guardian_challenges_lookup ON channel_guardian_verification_challenges(channel, challenge_hash, status)`,
-    );
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_guardian_sessions_active ON channel_guardian_verification_challenges(channel, status)`,
-    );
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_guardian_sessions_identity ON channel_guardian_verification_challenges(channel, expected_external_user_id, expected_chat_id, status)`,
-    );
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_guardian_sessions_destination ON channel_guardian_verification_challenges(channel, destination_address)`,
-    );
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_guardian_sessions_bootstrap ON channel_guardian_verification_challenges(channel, bootstrap_token_hash, status)`,
-    );
+  // --- Recreate indexes without assistant_id ---
+  // Each index below is the equivalent of the dropped index but with the
+  // assistant_id column removed. Index names are updated to avoid
+  // collisions with the old names.
+  //
+  // Some of these tables may have been dropped or renamed by earlier
+  // migrations. `CREATE INDEX IF NOT EXISTS` only guards against the index
+  // already existing — it still throws "no such table" when the underlying
+  // table is gone — so recreate each index only when its table is present.
+  const recreateIndex = (table: string, sql: string): void => {
+    if (!tableExists(database, table)) return;
+    raw.exec(sql);
+  };
+
+  // channel_guardian_verification_challenges
+  recreateIndex(
+    "channel_guardian_verification_challenges",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_channel_guardian_challenges_lookup ON channel_guardian_verification_challenges(channel, challenge_hash, status)`,
+  );
+  recreateIndex(
+    "channel_guardian_verification_challenges",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_guardian_sessions_active ON channel_guardian_verification_challenges(channel, status)`,
+  );
+  recreateIndex(
+    "channel_guardian_verification_challenges",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_guardian_sessions_identity ON channel_guardian_verification_challenges(channel, expected_external_user_id, expected_chat_id, status)`,
+  );
+  recreateIndex(
+    "channel_guardian_verification_challenges",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_guardian_sessions_destination ON channel_guardian_verification_challenges(channel, destination_address)`,
+  );
+  recreateIndex(
+    "channel_guardian_verification_challenges",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_guardian_sessions_bootstrap ON channel_guardian_verification_challenges(channel, bootstrap_token_hash, status)`,
+  );
 
-    // channel_guardian_rate_limits
-    raw.exec(
-      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_channel_guardian_rate_limits_actor ON channel_guardian_rate_limits(channel, actor_external_user_id, actor_chat_id)`,
-    );
+  // channel_guardian_rate_limits
+  recreateIndex(
+    "channel_guardian_rate_limits",
+    /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_channel_guardian_rate_limits_actor ON channel_guardian_rate_limits(channel, actor_external_user_id, actor_chat_id)`,
+  );
 
-    // assistant_ingress_invites
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_status ON assistant_ingress_invites(source_channel, status, expires_at)`,
-    );
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_created ON assistant_ingress_invites(source_channel, created_at)`,
-    );
+  // assistant_ingress_invites
+  recreateIndex(
+    "assistant_ingress_invites",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_status ON assistant_ingress_invites(source_channel, status, expires_at)`,
+  );
+  recreateIndex(
+    "assistant_ingress_invites",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_ingress_invites_channel_created ON assistant_ingress_invites(source_channel, created_at)`,
+  );
 
-    // assistant_inbox_thread_state
-    raw.exec(
-      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_inbox_thread_state_channel ON assistant_inbox_thread_state(source_channel, external_chat_id)`,
-    );
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_last_msg ON assistant_inbox_thread_state(last_message_at)`,
-    );
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_escalation ON assistant_inbox_thread_state(has_pending_escalation, last_message_at)`,
-    );
+  // assistant_inbox_thread_state
+  recreateIndex(
+    "assistant_inbox_thread_state",
+    /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_inbox_thread_state_channel ON assistant_inbox_thread_state(source_channel, external_chat_id)`,
+  );
+  recreateIndex(
+    "assistant_inbox_thread_state",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_last_msg ON assistant_inbox_thread_state(last_message_at)`,
+  );
+  recreateIndex(
+    "assistant_inbox_thread_state",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_inbox_thread_state_escalation ON assistant_inbox_thread_state(has_pending_escalation, last_message_at)`,
+  );
 
-    // notification_preferences
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_preferences_priority ON notification_preferences(priority DESC)`,
-    );
+  // notification_preferences
+  recreateIndex(
+    "notification_preferences",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_preferences_priority ON notification_preferences(priority DESC)`,
+  );
 
-    // notification_events
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_events_event_created ON notification_events(source_event_name, created_at)`,
-    );
-    raw.exec(
-      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_notification_events_dedupe ON notification_events(dedupe_key) WHERE dedupe_key IS NOT NULL`,
-    );
+  // notification_events
+  recreateIndex(
+    "notification_events",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_events_event_created ON notification_events(source_event_name, created_at)`,
+  );
+  recreateIndex(
+    "notification_events",
+    /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_notification_events_dedupe ON notification_events(dedupe_key) WHERE dedupe_key IS NOT NULL`,
+  );
 
-    // notification_deliveries
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_deliveries_status ON notification_deliveries(status)`,
-    );
+  // notification_deliveries
+  recreateIndex(
+    "notification_deliveries",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_notification_deliveries_status ON notification_deliveries(status)`,
+  );
 
-    // conversation_attention_events
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_events_observed ON conversation_attention_events(observed_at)`,
-    );
+  // conversation_attention_events
+  recreateIndex(
+    "conversation_attention_events",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_events_observed ON conversation_attention_events(observed_at)`,
+  );
 
-    // conversation_assistant_attention_state
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_latest_msg ON conversation_assistant_attention_state(latest_assistant_message_at)`,
-    );
-    raw.exec(
-      /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_last_seen ON conversation_assistant_attention_state(last_seen_assistant_message_at)`,
-    );
+  // conversation_assistant_attention_state
+  recreateIndex(
+    "conversation_assistant_attention_state",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_latest_msg ON conversation_assistant_attention_state(latest_assistant_message_at)`,
+  );
+  recreateIndex(
+    "conversation_assistant_attention_state",
+    /*sql*/ `CREATE INDEX IF NOT EXISTS idx_conv_attn_state_last_seen ON conversation_assistant_attention_state(last_seen_assistant_message_at)`,
+  );
 
-    // actor_token_records
-    raw.exec(
-      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_actor_tokens_active_device ON actor_token_records(guardian_principal_id, hashed_device_id) WHERE status = 'active'`,
-    );
+  // actor_token_records
+  recreateIndex(
+    "actor_token_records",
+    /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_actor_tokens_active_device ON actor_token_records(guardian_principal_id, hashed_device_id) WHERE status = 'active'`,
+  );
 
-    // actor_refresh_token_records
-    raw.exec(
-      /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_refresh_tokens_active_device ON actor_refresh_token_records(guardian_principal_id, hashed_device_id) WHERE status = 'active'`,
-    );
+  // actor_refresh_token_records
+  recreateIndex(
+    "actor_refresh_token_records",
+    /*sql*/ `CREATE UNIQUE INDEX IF NOT EXISTS idx_refresh_tokens_active_device ON actor_refresh_token_records(guardian_principal_id, hashed_device_id) WHERE status = 'active'`,
+  );
 
-    log.info("Completed dropping assistant_id columns from all tables");
-  });
+  log.info("Completed dropping assistant_id columns from all tables");
 }