npm - @vee-stack/delta-cli - Versions diffs - 2.0.5 → 2.0.7 - Mend

@vee-stack/delta-cli 2.0.5 → 2.0.7

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (7) hide show

package/dist/auth/secure-auth.js +40 -86
package/dist/commands/analyze.js +34 -7
package/dist/commands/auth.js +2 -1
package/dist/commands/config.js +3 -2
package/dist/commands/logout.js +2 -1
package/dist/commands/whoami.js +1 -0
package/package.json +1 -1

package/dist/auth/secure-auth.js CHANGED Viewed

@@ -141,120 +141,53 @@ export async function startOAuthFlow(method = 'oauth') {
         // Get API URL from environment or use default
         const apiUrl = process.env.DELTA_API_URL || 'http://localhost:3000';
         const { verifier, challenge } = generatePKCE();
-        const redirectUri = 'http://localhost:3456/callback';
         const state = crypto.randomBytes(16).toString('hex');
-        // Build OAuth URL
-        const oauthUrl = new URL(`${apiUrl}/api/auth/authorize`);
-        oauthUrl.searchParams.set('response_type', 'code');
-        oauthUrl.searchParams.set('client_id', 'delta-cli');
-        oauthUrl.searchParams.set('redirect_uri', redirectUri);
-        oauthUrl.searchParams.set('code_challenge', challenge);
-        oauthUrl.searchParams.set('code_challenge_method', 'S256');
-        oauthUrl.searchParams.set('state', state);
-        oauthUrl.searchParams.set('scope', 'read write analyze');
-        if (method === 'github') {
-            oauthUrl.searchParams.set('provider', 'github');
-        }
-        else if (method === 'google') {
-            oauthUrl.searchParams.set('provider', 'google');
-        }
-        stopSpinner(true, 'OAuth server ready');
-        // Open browser
-        printInfo(`Opening browser for authentication...`);
-        printInfo(`URL: ${oauthUrl.toString().substring(0, 80)}...`);
-        await open(oauthUrl.toString());
-        // Start local server to capture callback
-        const authCode = await new Promise((resolve, reject) => {
+        // Start local server FIRST to capture callback and get actual port
+        const { authCode, redirectUri } = await new Promise((resolve, reject) => {
             const server = createServer(async (req, res) => {
-                // Get actual port from server address
-                const address = server.address();
-                const actualPort = typeof address === 'object' && address ? address.port : 3000;
-                const url = new URL(req.url || '/', `http://localhost:${actualPort}`);
+                const url = new URL(req.url || '/', `http://localhost:${redirectPort}`);
                 if (url.pathname === '/callback') {
                     const code = url.searchParams.get('code');
                     const returnedState = url.searchParams.get('state');
                     const error = url.searchParams.get('error');
                     if (error) {
                         res.writeHead(400, { 'Content-Type': 'text/html' });
-                        res.end(`
-              <html>
-                <body style="font-family: system-ui; text-align: center; padding: 50px;">
-                  <h1 style="color: #e74c3c;">❌ Authentication Failed</h1>
-                  <p>${error}</p>
-                  <p>You can close this window.</p>
-                </body>
-              </html>
-            `);
+                        res.end(`<html><body><h1>❌ Authentication Failed</h1><p>${error}</p></body></html>`);
                         reject(new Error(error));
                         server.close();
                         return;
                     }
                     if (!code || returnedState !== state) {
                         res.writeHead(400, { 'Content-Type': 'text/html' });
-                        res.end(`
-              <html>
-                <body style="font-family: system-ui; text-align: center; padding: 50px;">
-                  <h1 style="color: #e74c3c;">❌ Invalid Response</h1>
-                  <p>You can close this window.</p>
-                </body>
-              </html>
-            `);
+                        res.end(`<html><body><h1>❌ Invalid Response</h1></body></html>`);
                         reject(new Error('Invalid OAuth response'));
                         server.close();
                         return;
                     }
                     res.writeHead(200, { 'Content-Type': 'text/html' });
-                    res.end(`
-            <html>
-              <head>
-                <style>
-                  body {
-                    font-family: system-ui, -apple-system, sans-serif;
-                    text-align: center;
-                    padding: 50px;
-                    background: linear-gradient(135deg, #667eea 0%, #764ba2 100%);
-                    color: white;
-                    min-height: 100vh;
-                    display: flex;
-                    align-items: center;
-                    justify-content: center;
-                  }
-                  .container {
-                    background: rgba(255,255,255,0.1);
-                    backdrop-filter: blur(10px);
-                    padding: 40px;
-                    border-radius: 20px;
-                    box-shadow: 0 20px 60px rgba(0,0,0,0.3);
-                  }
-                  h1 { margin: 0 0 20px; font-size: 48px; }
-                  .check { font-size: 64px; margin-bottom: 20px; }
-                  p { font-size: 18px; opacity: 0.9; }
-                </style>
-              </head>
-              <body>
-                <div class="container">
-                  <div class="check">✓</div>
-                  <h1>Successfully Signed In!</h1>
-                  <p>You can close this window and return to the terminal.</p>
-                </div>
-              </body>
-            </html>
-          `);
-                    resolve(code);
+                    res.end(`<html><body style="text-align:center;padding:50px;"><h1>✓ Successfully Signed In!</h1><p>You can close this window.</p></body></html>`);
+                    const address = server.address();
+                    const actualPort = typeof address === 'object' && address ? address.port : 3456;
+                    resolve({ authCode: code, redirectUri: `http://localhost:${actualPort}/callback` });
                     server.close();
                 }
             });
-            // Try to listen on port 3456, or let OS assign available port if busy
+            let redirectPort = 3456;
+            // Try to listen on port 3456
             server.listen(3456, '127.0.0.1', () => {
-                const address = server.address();
-                const actualPort = typeof address === 'object' && address ? address.port : 3456;
-                console.log(chalk.dim(`  Waiting for authentication on port ${actualPort}...`));
+                console.log(chalk.dim(`  Waiting for authentication on port ${redirectPort}...`));
             });
             // Handle port in use error by trying random port
             server.on('error', (err) => {
                 if (err.code === 'EADDRINUSE') {
                     printWarning('Port 3456 is busy, trying alternative port...');
-                    server.listen(0, '127.0.0.1'); // Let OS assign available port
+                    redirectPort = 0; // Let OS assign
+                    server.listen(0, '127.0.0.1', () => {
+                        const address = server.address();
+                        const actualPort = typeof address === 'object' && address ? address.port : 3456;
+                        redirectPort = actualPort;
+                        console.log(chalk.dim(`  Waiting for authentication on port ${actualPort}...`));
+                    });
                 }
                 else {
                     reject(err);
@@ -266,6 +199,27 @@ export async function startOAuthFlow(method = 'oauth') {
                 reject(new Error('Authentication timeout'));
             }, 5 * 60 * 1000);
         });
+        // NOW build OAuth URL with correct redirect_uri
+        const oauthUrl = new URL(`${apiUrl}/api/auth/authorize`);
+        oauthUrl.searchParams.set('response_type', 'code');
+        oauthUrl.searchParams.set('client_id', 'delta-cli');
+        oauthUrl.searchParams.set('redirect_uri', redirectUri);
+        oauthUrl.searchParams.set('code_challenge', challenge);
+        oauthUrl.searchParams.set('code_challenge_method', 'S256');
+        oauthUrl.searchParams.set('state', state);
+        oauthUrl.searchParams.set('scope', 'read write analyze');
+        if (method === 'github') {
+            oauthUrl.searchParams.set('provider', 'github');
+        }
+        else if (method === 'google') {
+            oauthUrl.searchParams.set('provider', 'google');
+        }
+        stopSpinner(true, 'OAuth server ready');
+        // Open browser with correct URL
+        printInfo(`Opening browser for authentication...`);
+        printInfo(`Full URL: ${oauthUrl.toString()}`);
+        await open(oauthUrl.toString());
+        // Wait for authCode (already resolved above)
         // Exchange code for tokens
         startSpinner('Exchanging authorization code...');
         const tokenResponse = await fetch(`${apiUrl}/api/auth/token`, {

package/dist/commands/analyze.js CHANGED Viewed

@@ -22,6 +22,26 @@ function extractApiErrorPayload(payload) {
 }
 export async function analyzeCommand(projectPath, options) {
     const targetPath = path.resolve(projectPath);
+    // Check authentication FIRST if upload is requested
+    if (options.upload) {
+        printInfo('🔐 Checking authentication...');
+        const config = await loadConfig();
+        const pat = await SecureTokenStore.getAccessToken();
+        if (!pat) {
+            console.error();
+            console.error(chalk.red('❌ Error: You must be logged in to upload reports.'));
+            console.error();
+            console.error(chalk.yellow('Please authenticate first:'));
+            console.error(chalk.cyan('  delta login'));
+            console.error();
+            console.error(chalk.dim('Or use --upload with a valid PAT:'));
+            console.error(chalk.cyan('  delta analyze . --upload --token <your-pat>'));
+            console.error();
+            process.exit(1);
+        }
+        printSuccess('✓ Authenticated');
+        console.log();
+    }
     printInfo('🔍 Starting Delta Analysis Engine...');
     printDivider();
     console.log(`${icons.folder}  Project: ${chalk.cyan(targetPath)}`);
@@ -153,18 +173,25 @@ export async function analyzeCommand(projectPath, options) {
         printSuccess('✨ No issues found! Great job!');
     }
     console.log();
-    // Save report to file
-    const outputDir = path.resolve(options.output);
-    await fs.mkdir(outputDir, { recursive: true });
-    const reportFile = path.join(outputDir, `report-${Date.now()}.json`);
-    await fs.writeFile(reportFile, JSON.stringify(report, null, 2));
-    printInfo(`${icons.chart} Report saved: ${chalk.cyan(reportFile)}`);
-    console.log();
+    // Save report to file ONLY if not uploading
+    if (!options.upload) {
+        const outputDir = path.resolve(options.output);
+        await fs.mkdir(outputDir, { recursive: true });
+        const reportFile = path.join(outputDir, `report-${Date.now()}.json`);
+        await fs.writeFile(reportFile, JSON.stringify(report, null, 2));
+        printInfo(`${icons.chart} Report saved: ${chalk.cyan(reportFile)}`);
+        console.log();
+    }
+    else {
+        printInfo(`${icons.chart} Report will be available on Delta Cloud Dashboard`);
+        console.log();
+    }
     // Upload to cloud if requested
     if (options.upload) {
         console.log(`${icons.rocket} Uploading to Delta Cloud...`);
         await uploadReport(report);
     }
+    process.exit(0);
 }
 async function uploadReport(report) {
     const config = await loadConfig();

package/dist/commands/auth.js CHANGED Viewed

@@ -44,7 +44,7 @@ export const authCommands = {
             console.log();
             printCommandHint('delta whoami', 'to see account details');
             printCommandHint('delta analyze', 'to start analyzing code');
-            return;
+            process.exit(0);
         }
         // PAT Token flow (when token is provided)
         // Validate token format
@@ -102,6 +102,7 @@ export const authCommands = {
             console.log();
             printCommandHint('delta whoami', 'to see full account details');
             printCommandHint('delta analyze', 'to start analyzing code');
+            process.exit(0);
         }
         catch (error) {
             stopSpinner(false, 'Authentication failed');

package/dist/commands/config.js CHANGED Viewed

@@ -13,7 +13,7 @@ export async function configCommand(options) {
         else {
             console.log(`${options.get}: (not set)`);
         }
-        return;
+        process.exit(0);
     }
     if (options.set) {
         const [key, value] = options.set.split('=');
@@ -28,7 +28,7 @@ export async function configCommand(options) {
         };
         await saveConfig(newConfig);
         console.log(`✅ Set ${key} = ${value}`);
-        return;
+        process.exit(0);
     }
     if (options.list || (!options.get && !options.set)) {
         console.log('🔧 Delta CLI Configuration');
@@ -45,6 +45,7 @@ export async function configCommand(options) {
         if (config.lastUsedAt) {
             console.log(`   Last used: ${new Date(config.lastUsedAt).toLocaleString()}`);
         }
+        process.exit(0);
     }
 }
 //# sourceMappingURL=config.js.map

package/dist/commands/logout.js CHANGED Viewed

@@ -9,7 +9,7 @@ export async function logoutCommand() {
         const hasToken = await SecureTokenStore.hasTokens();
         if (!hasToken) {
             console.log('ℹ️  Not currently authenticated');
-            return;
+            process.exit(0);
         }
         // Clear tokens from keychain and remove config file
         await SecureTokenStore.clearTokens();
@@ -21,6 +21,7 @@ export async function logoutCommand() {
         }
         console.log('✅ Successfully logged out');
         console.log('   Authentication data removed');
+        process.exit(0);
     }
     catch (error) {
         console.error('❌ Error during logout:', error instanceof Error ? error.message : String(error));

package/dist/commands/whoami.js CHANGED Viewed

@@ -51,6 +51,7 @@ export async function whoamiCommand(_options) {
         console.log();
         printCommandHint('delta analyze', 'to run a code analysis');
         printCommandHint('delta status', 'to check project status');
+        process.exit(0);
     }
     catch (error) {
         stopSpinner(false);

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@vee-stack/delta-cli",
-  "version": "2.0.5",
+  "version": "2.0.7",
   "description": "Delta CLI v2 - Next-gen terminal interface with React Ink",
   "type": "module",
   "main": "./dist/index.js",