@vectoriox/iox-builder 4.12.0 → 4.13.0

package/fesm2022/vectoriox-iox-builder.mjs

@@ -701,15 +701,42 @@ const freshId = () => Math.random().toString(36).substr(2, 9);
  * A reference pointing OUTSIDE the cloned subtree (id not in the map) is left untouched — the copy
  * intentionally still points at the external node.
  *
+ * TRAIT values are NOT ids and are copied verbatim — with one exception. A trait that carries an
+ * IDENTITY rather than a setting must be reissued, or the copy silently shares the original's
+ * identity. `formId` is the first: two forms with the same id share one submissions stream, and the
+ * server resolves a submission against whichever page it reaches first. See REGENERATED_TRAITS.
+ *
  * `styleId` strategy:
  *   - `'clear'` (default) — drop styleId so the clone OWNS its own CSS rule (independent copy).
  *   - `'regenerate'`      — keep a styleId but give it a fresh value (legacy builder.component path).
  */
+/**
+ * Trait names whose value is an IDENTITY, not a setting, and must therefore be reissued on every
+ * clone. Add a name here the moment a trait starts identifying something rather than describing it.
+ *
+ * `formId` — a form's submissions stream. Duplicating a page, pasting a form or dropping a saved
+ * block twice used to produce two forms claiming the same stream.
+ */
+const REGENERATED_TRAITS = new Set(['formId']);
+/** Reissue identity-carrying traits on a node, preserving the original's prefix where it had one. */
+function reissueIdentityTraits(node) {
+    for (const trait of (node.traits ?? [])) {
+        if (!trait?.name || !REGENERATED_TRAITS.has(trait.name))
+            continue;
+        if (trait.default === undefined || trait.default === '')
+            continue;
+        // Keep the human-readable prefix a preset gave it (`contact-a1b2c3` → `contact-<new>`), so a
+        // duplicated contact form is still recognisably a contact form in the inbox.
+        const prefix = String(trait.default).split('-')[0];
+        trait.default = `${prefix}-${freshId()}`;
+    }
+}
 function regenerateNodeIds(root, opts = {}) {
     const idMap = new Map();
     const assign = (node) => {
         const oldId = node.id;
         node.id = freshId();
+        reissueIdentityTraits(node);
         if (opts.styleId === 'regenerate') {
             if (node.styleId)
                 node.styleId = freshId();
@@ -5907,9 +5934,14 @@ class BuilderComponent {
             return;
         // Straight onto the live instance: this is a VIEW state, not page data — it must never be
         // persisted, or a page would ship showing its own success message.
-        const instance = this.overlayService.getNodeRef(form)?.componentRef?.instance;
-        if (instance) {
-            safeSetInput(this.overlayService.getNodeRef(form).componentRef, 'renderState', state);
+        //
+        // Two input names on purpose: the CANVAS renders the container twin (`formState`) while the
+        // ENGINE renders IoxFormComponent (`renderState`). safeSetInput drops whichever the rendered
+        // component does not declare, so this works on either path without branching on type.
+        const ref = this.overlayService.getNodeRef(form)?.componentRef;
+        if (ref) {
+            safeSetInput(ref, 'formState', state);
+            safeSetInput(ref, 'renderState', state);
         }
         this.cdr.detectChanges();
     }
@@ -9705,13 +9737,16 @@ class FieldComponentConfig extends ComponentConfig {
                 { label: 'Radio group', value: 'radio' },
                 { label: 'Date', value: 'date' },
                 { label: 'Time', value: 'time' },
-                { label: 'File upload', value: 'file' },
+                // ⚠️ 'file' is DELIBERATELY ABSENT until uploads are implemented. A file input's
+                // `value` is the browser's fake path (`C:\fakepath\cv.pdf`), and `fileType`/
+                // `fileSize` operate on a file list — so on a string they pass vacuously. Offering
+                // it meant an author could set "PDF only, 5MB" and silently get neither the
+                // enforcement nor the file. See forms-and-inputs-plan.md → Remaining work P0/1.
                 { label: 'Hidden', value: 'hidden' },
             ], 'text'),
             new TraitConfig('placeholder', 'Placeholder', TraitInputType.Text, undefined, '', false, { trait: 'control', values: ['text', 'email', 'tel', 'url', 'number', 'password', 'textarea', 'select'] }),
             new TraitConfig('help', 'Help text', TraitInputType.Text, undefined, ''),
             new TraitConfig('rows', 'Rows', TraitInputType.Number, undefined, 4, false, { trait: 'control', values: 'textarea' }),
-            new TraitConfig('accept', 'Accepted file types', TraitInputType.Text, undefined, '', false, { trait: 'control', values: 'file' }),
             new TraitConfig('labelHidden', 'Hide label (screen readers still read it)', TraitInputType.Checkbox, undefined, false),
             // The submitted key. Derived from the label; editable for external integrations.
             new TraitConfig('name', 'Submitted key', TraitInputType.Text, undefined, ''),