@vdegenne/highlight-manager 0.1.8 → 0.1.9

package/lib/index.d.ts

@@ -49,7 +49,7 @@ interface Options {
     /**
      * @default undefined
      */
-    scrollStrategy: ScrollStrategy | undefined;
+    scrollStrategy: Partial<ScrollStrategy> | undefined;
     /**
      * If true, will select the next visible candidate if the highlight is offscreen.
      *
@@ -59,7 +59,7 @@ interface Options {
 }
 export declare function setGlobalBeforeHighlight(fct: () => void): void;
 interface HighlightOptions {
-    scrollStrategy: ScrollStrategy | undefined;
+    scrollStrategy: Partial<ScrollStrategy> | undefined;
 }
 export declare class HighLightManager {
     #private;
@@ -78,7 +78,7 @@ export declare class HighLightManager {
     /**
      * @returns {boolean} true if the highlight succeeded, false otherwise.
      */
-    highlight(start: number, end?: number, unhighlightAll?: boolean, cache?: boolean, options?: HighlightOptions): boolean;
+    highlight(start: number, end?: number, unhighlightAll?: boolean, cache?: boolean, options?: Partial<HighlightOptions>): boolean;
     previous(step?: number, cache?: boolean): void;
     next(step?: number, cache?: boolean): void;
     extendLeftHighlight(step?: number, cache?: boolean): void;

package/lib/index.js

@@ -155,7 +155,7 @@ export class HighLightManager {
     /**
      * @returns {boolean} true if the highlight succeeded, false otherwise.
      */
-    highlight(start, end, unhighlightAll = true, cache = false, options) {
+    highlight(start, end, unhighlightAll = true, cache = false, options = {}) {
         if (end === undefined) {
             end = start;
         }
@@ -172,11 +172,13 @@ export class HighLightManager {
         }
         // console.log(highlightIndexStart, highlightIndexEnd, start, end)
         const _options = {
-            scrollStrategy: {
-                ...scrollStrategyDefaults,
-                ...this.#options.scrollStrategy,
-                ...options?.scrollStrategy,
-            },
+            scrollStrategy: options?.scrollStrategy || this.#options.scrollStrategy
+                ? {
+                    ...scrollStrategyDefaults,
+                    ...this.#options.scrollStrategy,
+                    ...options?.scrollStrategy,
+                }
+                : undefined,
         };
         globalBeforeHighlight?.();
         this.#options.beforeHighlight?.();

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@vdegenne/highlight-manager",
-	"version": "0.1.8",
+	"version": "0.1.9",
 	"description": "helper to navigate/highlight elements in a page based on a css selector",
 	"type": "module",
 	"exports": {