@vcmap/viewshed 2.0.2 → 2.0.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vcmap/viewshed",
-  "version": "2.0.2",
+  "version": "2.0.4",
   "description": "Tool to simulate a \"viewer\" and their field of vision from a certain standpoint in the map. It allows the user to see which areas and buildings can or can't be seen from a specific standpoint, regarding different viewing distances, viewers' sizes and orientations.Th",
   "type": "module",
   "main": "src/index.js",

package/src/ViewshedWindow.vue

@@ -1,7 +1,12 @@
 <template>
   <div>
     <div v-if="viewshedMode === ViewshedPluginModes.CREATE" class="px-2 py-1">
-      {{ $t('viewshed.createDescription') }}
+      <template v-if="viewshedType === ViewshedTypes.CONE">
+        {{ $t('viewshed.createDescription') }}
+      </template>
+      <template v-else-if="viewshedType === ViewshedTypes.THREESIXTY">
+        {{ $t('viewshed.createThreeSixtyDescription') }}
+      </template>
     </div>
     <VcsFormSection
       v-else-if="

package/src/index.js

@@ -163,9 +163,11 @@ export default function plugin(config) {
           move: 'Move viewpoint',
           createDescription:
             'Click the map twice. First click places the origin, second defines the distance and direction of the viewshed.',
+          createThreeSixtyDescription:
+            'Click the map twice. First click places the origin, second defines the distance of the viewshed.',
           remove: 'Remove',
           editor: {
-            general: 'General',
+            general: 'General Settings',
             visibleColor: 'Visible color',
             shadowColor: 'Shadow color',
             tools: 'Tools',
@@ -197,11 +199,13 @@ export default function plugin(config) {
           move: 'Viewpoint verschieben',
           createDescription:
             'Klicke zweimal in die Karte. Der erste Klick platziert den Ursprung, der zweite die Distanz und die Richtung des Viewsheds.',
+          createThreeSixtyDescription:
+            'Klicke zweimal in die Karte. Der erste Klick platziert den Ursprung, der zweite die Distanz des Viewsheds.',
           remove: 'Entfernen',
           editor: {
-            general: 'Generelles',
+            general: 'Allgemeine Einstellungen',
             visibleColor: 'Sichtbarer Bereich',
-            shadowColor: 'Schatten Bereich',
+            shadowColor: 'Nicht sichtbarer Bereich',
             tools: 'Werkzeuge',
           },
         },

package/src/viewshed.js

@@ -267,7 +267,6 @@ export default class Viewshed extends VcsObject {
         this.position[1],
         this.position[2] + value,
       );
-      this._updateShadowMap();
       this._updatePrimitive();
     }
   }
@@ -289,7 +288,9 @@ export default class Viewshed extends VcsObject {
       value > Viewshed.MIN_DISTANCE ? value : Viewshed.MIN_DISTANCE;
     if (this._shadowCamera) {
       this._shadowCamera.frustum.far = this._frustumOptions.far;
-      this._updateShadowMap();
+      if (this._viewshedType === ViewshedTypes.THREESIXTY) {
+        this._updateShadowMap();
+      }
       if (this._viewshedType === ViewshedTypes.CONE) {
         this._updatePrimitive();
       }
@@ -314,7 +315,6 @@ export default class Viewshed extends VcsObject {
       /** @type {import("@vcmap-cesium/engine").PerspectiveFrustum} */ (
         this._shadowCamera.frustum
       ).fov = value * CesiumMath.RADIANS_PER_DEGREE;
-      this._updateShadowMap();
       if (this._viewshedType === ViewshedTypes.CONE) {
         this._updatePrimitive();
       }
@@ -452,8 +452,10 @@ export default class Viewshed extends VcsObject {
       this._updateShadowMap();
       this._updatePrimitive();
       this._shadowMapChangedListener =
-        this._cesiumMap.shadowMapChanged.addEventListener(() => {
-          this.deactivate();
+        this._cesiumMap.shadowMapChanged.addEventListener((newShadowMap) => {
+          if (this._shadowMap !== newShadowMap) {
+            this.deactivate();
+          }
         });
     }
   }
@@ -471,6 +473,7 @@ export default class Viewshed extends VcsObject {
       return;
     }
 
+    this._shadowMap?.destroy();
     // @ts-ignore
     this._shadowMap = new ShadowMap({
       // @ts-ignore
@@ -486,7 +489,6 @@ export default class Viewshed extends VcsObject {
       size: 2048,
     });
     this._shadowMap.viewshed = this._colors;
-    this._scene.shadowMap = this._shadowMap;
     this._cesiumMap.setShadowMap(this._shadowMap);
   }