@vcmap/core 5.0.0-rc.28 → 5.0.0-rc.29

package/README.md

@@ -3,11 +3,14 @@
 > Part of the [VC Map Project](https://github.com/virtualcitySYSTEMS/map-ui)
 
 ## Getting Started
+
 - clone Repo
 - npm install
 
 # Coding Conventions
+
 ### Exporting from a module
+
 - You should export all variables, functions, class etc. from a module
   which are required to use the API.
 - Make sure the names of exports have _meaning outside of their module_. E.g. a
@@ -19,14 +22,16 @@
    * Resets the foo. Exported for testing
    * @private
    */
-  export function resetFooInstance() {} 
+  export function resetFooInstance() {}
   ```
 
 ### TS & Typesafety
+
 - You should use the imported name in your doclets, e.g.:
+
   ```javascript
   import Vector from 'ol/source/Vector.js';
-  
+
   /**
    * @param {Vector} source
    * @returns {Array<import("ol").Feature<import("ol/geom/Geometry").default>>}
@@ -38,7 +43,8 @@
     return [];
   }
   ```
-- You should use dump file imports where possible (WebStorm cannot generate 
+
+- You should use dump file imports where possible (WebStorm cannot generate
   Intelisensse from default imports). Thus `@param {import("ol/Feature").default}`
   would become: `@param {import("ol").Feature}`.
 - You will need to import library own classes use `@param {import("@vcmap/core").CesiumMap}`.

package/build/postinstall.js

@@ -15,7 +15,13 @@ async function fixCesiumTypes() {
   ) {
     console.log('Moving cesium engine index.d.ts');
     await fs.promises.cp(
-      path.join(process.cwd(), 'node_modules', '@vcmap-cesium', 'engine', 'index.d.ts'),
+      path.join(
+        process.cwd(),
+        'node_modules',
+        '@vcmap-cesium',
+        'engine',
+        'index.d.ts',
+      ),
       path.join(process.cwd(), 'build', 'types', 'Cesium_module.d.ts'),
       { force: true },
     );
@@ -27,7 +33,12 @@ async function fixCesiumTypes() {
  * @returns {Promise<void>}
  */
 async function fixTinyQueue() {
-  const fileName = path.join(process.cwd(), 'node_modules', 'tinyqueue', 'package.json');
+  const fileName = path.join(
+    process.cwd(),
+    'node_modules',
+    'tinyqueue',
+    'package.json',
+  );
   if (fs.existsSync(fileName)) {
     const content = await fs.promises.readFile(fileName);
     const jsonContent = JSON.parse(content);

package/index.d.ts

@@ -5328,7 +5328,7 @@ export class ObliqueMap extends BaseOLMap {
     collectionChanged: VcsEvent<ObliqueCollection>;
     switchEnabled: any;
     switchThreshold: any;
-    mapChangeEvent: any;
+    mapChangeEvent: string;
     readonly collection: ObliqueCollection;
     readonly imageChanged: VcsEvent<ObliqueImage>;
     readonly currentImage: ObliqueImage | null;
@@ -8757,48 +8757,57 @@ export class VcsObject {
 
 
 export interface ReplacedEvent<T extends any> {
-    new: T,
-    old: T,
+  new: T;
+  old: T;
 }
 
 export interface OverrideCollectionInterface<T extends any> {
-    replaced: VcsEvent<ReplacedEvent<T>>;
-    shadowMap: Map<string, object[]>;
-    override: (item: T) => T;
-    parseItems: (items: object[], moduleId: string) => Promise<void>;
-    getSerializedByKey: (key: string) => object;
-    removeModule: (moduleId: string) => Promise<void>;
-    serializeModule: (moduleId: string) => object[];
-}
-
-export class OverrideCollection<T extends any> extends Collection<T> implements OverrideCollectionInterface<T> {
-    replaced: VcsEvent<ReplacedEvent<T>>;
-    shadowMap: Map<string, object[]>;
-    override: (item: T) => T;
-    parseItems: (items: object[], moduleId: string) => Promise<void>;
-    getSerializedByKey: (key: string) => object;
-    removeModule: (moduleId: string) => Promise<void>;
-    serializeModule: (moduleId: string) => object[];
-}
-
-export class OverrideLayerCollection extends LayerCollection implements OverrideCollectionInterface<Layer> {
-    replaced: VcsEvent<ReplacedEvent<Layer>>;
-    shadowMap: Map<string, object[]>;
-    override: (item: Layer) => Layer;
-    parseItems: (items: object[], moduleId: string) => Promise<void>;
-    getSerializedByKey: (key: string) => object;
-    removeModule: (moduleId: string) => Promise<void>;
-    serializeModule: (moduleId: string) => object[];
-}
-
-export class OverrideMapCollection extends MapCollection implements OverrideCollectionInterface<VcsMap> {
-    replaced: VcsEvent<ReplacedEvent<VcsMap>>;
-    shadowMap: Map<string, object[]>;
-    override: (item: VcsMap) => VcsMap;
-    parseItems: (items: object[], moduleId: string) => Promise<void>;
-    getSerializedByKey: (key: string) => object;
-    removeModule: (moduleId: string) => Promise<void>;
-    serializeModule: (moduleId: string) => object[];
+  replaced: VcsEvent<ReplacedEvent<T>>;
+  shadowMap: Map<string, object[]>;
+  override: (item: T) => T;
+  parseItems: (items: object[], moduleId: string) => Promise<void>;
+  getSerializedByKey: (key: string) => object;
+  removeModule: (moduleId: string) => Promise<void>;
+  serializeModule: (moduleId: string) => object[];
+}
+
+export class OverrideCollection<T extends any>
+  extends Collection<T>
+  implements OverrideCollectionInterface<T>
+{
+  replaced: VcsEvent<ReplacedEvent<T>>;
+  shadowMap: Map<string, object[]>;
+  override: (item: T) => T;
+  parseItems: (items: object[], moduleId: string) => Promise<void>;
+  getSerializedByKey: (key: string) => object;
+  removeModule: (moduleId: string) => Promise<void>;
+  serializeModule: (moduleId: string) => object[];
+}
+
+export class OverrideLayerCollection
+  extends LayerCollection
+  implements OverrideCollectionInterface<Layer>
+{
+  replaced: VcsEvent<ReplacedEvent<Layer>>;
+  shadowMap: Map<string, object[]>;
+  override: (item: Layer) => Layer;
+  parseItems: (items: object[], moduleId: string) => Promise<void>;
+  getSerializedByKey: (key: string) => object;
+  removeModule: (moduleId: string) => Promise<void>;
+  serializeModule: (moduleId: string) => object[];
+}
+
+export class OverrideMapCollection
+  extends MapCollection
+  implements OverrideCollectionInterface<VcsMap>
+{
+  replaced: VcsEvent<ReplacedEvent<VcsMap>>;
+  shadowMap: Map<string, object[]>;
+  override: (item: VcsMap) => VcsMap;
+  parseItems: (items: object[], moduleId: string) => Promise<void>;
+  getSerializedByKey: (key: string) => object;
+  removeModule: (moduleId: string) => Promise<void>;
+  serializeModule: (moduleId: string) => object[];
 }
 
 
@@ -8813,74 +8822,114 @@ export class OverrideMapCollection extends MapCollection implements OverrideColl
  * Said geometry may be invalid.
  * Geometries created may be in pixel coordinates. Appropriate symbols shall be set by the interaction.
  */
-export interface CreateInteraction<T extends import("ol/geom").Geometry> {
-    finish():void;
-    finished: VcsEvent<T|null>;
-    created: VcsEvent<T>;
-    destroy():void;
+export interface CreateInteraction<T extends import('ol/geom').Geometry> {
+  finish(): void;
+  finished: VcsEvent<T | null>;
+  created: VcsEvent<T>;
+  destroy(): void;
 }
 
-export type Vertex = import("ol").Feature<import("ol/geom").Point>;
+export type Vertex = import('ol').Feature<import('ol/geom').Point>;
 
 export interface SelectFeatureInteraction extends AbstractInteraction {
-    readonly selected: Array<import("ol").Feature>;
-    setSelected(features: Array<import("ol").Feature|import("@vcmap-cesium/engine").Cesium3DTileFeature|import("@vcmap-cesium/engine").Cesium3DTilePointFeature|import("@vcmap-cesium/engine").Entity> | import("ol").Feature|import("@vcmap-cesium/engine").Cesium3DTileFeature|import("@vcmap-cesium/engine").Cesium3DTilePointFeature|import("@vcmap-cesium/engine").Entity ):void;
-    hasFeatureId(id: string): boolean;
-}
-
-declare module "@vcmap-cesium/engine" {
-    interface Entity {
-        getId():number|string;
-        getProperty(key: string): any;
-        [vcsLayerName]: string|null;
-    }
-
-    interface Cesium3DTileFeature {
-        getId():number|string;
-        [vcsLayerName]: string|null;
-    }
-
-    interface Cesium3DTilePointFeature {
-        getId():number|string;
-        [vcsLayerName]: string|null;
-    }
-
-    interface StyleExpression {
-        evaluate(feature: import("@vcmap-cesium/engine").Cesium3DTileFeature | import("ol/Feature").default<import("ol/geom/Geometry").default>):any;
-        evaluateColor(feature: import("@vcmap-cesium/engine").Cesium3DTileFeature | import("ol/Feature").default<import("ol/geom/Geometry").default>):import("@vcmap-cesium/engine").Color;
-    }
-
-    interface Expression {
-        evaluate(feature: import("@vcmap-cesium/engine").Cesium3DTileFeature | import("ol/Feature").default<import("ol/geom/Geometry").default>):any;
-        evaluateColor(feature: import("@vcmap-cesium/engine").Cesium3DTileFeature | import("ol/Feature").default<import("ol/geom/Geometry").default>):import("@vcmap-cesium/engine").Color;
-    }
-}
-
-declare module "ol/geom" {
-    interface Geometry {
-        getCoordinates(): any;
-        setCoordinates(coordinates: any, layout?: any): void;
-        getFlatCoordinates(): number[];
-        getLayout(): import("ol/geom/Geometry").GeometryLayout;
-    }
-
-    interface GeometryCollection {
-        getCoordinates(): Array<import("ol/coordinate").Coordinate | Array<import("ol/coordinate").Coordinate> | Array<Array<import("ol/coordinate").Coordinate>> | Array<Array<Array<import("ol/coordinate").Coordinate>>>>;
-        setCoordinates(coordinates: Array<import("ol/coordinate").Coordinate | Array<import("ol/coordinate").Coordinate> | Array<Array<import("ol/coordinate").Coordinate>> | Array<Array<Array<import("ol/coordinate").Coordinate>>>>): void;
-        getLayout(): import("ol/geom/Geometry").GeometryLayout;
-    }
-
-    interface Circle {
-        getCoordinates(): import("ol/coordinate").Coordinate[];
-        setCoordinates(coordinates: import("ol/coordinate").Coordinate[]): void;
-        rotate(angle: number, anchor: import("ol/coordinate").Coordinate): void;
-    }
-}
-
-declare module "ol/index" {
-    interface Feature<Geometry> {
-        getProperty(key: string): any;
-        getPropertyInherited(key: string): any;
-        [vcsLayerName]: string|null;
-    }
+  readonly selected: Array<import('ol').Feature>;
+  setSelected(
+    features:
+      | Array<
+          | import('ol').Feature
+          | import('@vcmap-cesium/engine').Cesium3DTileFeature
+          | import('@vcmap-cesium/engine').Cesium3DTilePointFeature
+          | import('@vcmap-cesium/engine').Entity
+        >
+      | import('ol').Feature
+      | import('@vcmap-cesium/engine').Cesium3DTileFeature
+      | import('@vcmap-cesium/engine').Cesium3DTilePointFeature
+      | import('@vcmap-cesium/engine').Entity,
+  ): void;
+  hasFeatureId(id: string): boolean;
+}
+
+declare module '@vcmap-cesium/engine' {
+  interface Entity {
+    getId(): number | string;
+    getProperty(key: string): any;
+    [vcsLayerName]: string | null;
+  }
+
+  interface Cesium3DTileFeature {
+    getId(): number | string;
+    [vcsLayerName]: string | null;
+  }
+
+  interface Cesium3DTilePointFeature {
+    getId(): number | string;
+    [vcsLayerName]: string | null;
+  }
+
+  interface StyleExpression {
+    evaluate(
+      feature:
+        | import('@vcmap-cesium/engine').Cesium3DTileFeature
+        | import('ol/Feature').default<import('ol/geom/Geometry').default>,
+    ): any;
+    evaluateColor(
+      feature:
+        | import('@vcmap-cesium/engine').Cesium3DTileFeature
+        | import('ol/Feature').default<import('ol/geom/Geometry').default>,
+    ): import('@vcmap-cesium/engine').Color;
+  }
+
+  interface Expression {
+    evaluate(
+      feature:
+        | import('@vcmap-cesium/engine').Cesium3DTileFeature
+        | import('ol/Feature').default<import('ol/geom/Geometry').default>,
+    ): any;
+    evaluateColor(
+      feature:
+        | import('@vcmap-cesium/engine').Cesium3DTileFeature
+        | import('ol/Feature').default<import('ol/geom/Geometry').default>,
+    ): import('@vcmap-cesium/engine').Color;
+  }
+}
+
+declare module 'ol/geom' {
+  interface Geometry {
+    getCoordinates(): any;
+    setCoordinates(coordinates: any, layout?: any): void;
+    getFlatCoordinates(): number[];
+    getLayout(): import('ol/geom/Geometry').GeometryLayout;
+  }
+
+  interface GeometryCollection {
+    getCoordinates(): Array<
+      | import('ol/coordinate').Coordinate
+      | Array<import('ol/coordinate').Coordinate>
+      | Array<Array<import('ol/coordinate').Coordinate>>
+      | Array<Array<Array<import('ol/coordinate').Coordinate>>>
+    >;
+    setCoordinates(
+      coordinates: Array<
+        | import('ol/coordinate').Coordinate
+        | Array<import('ol/coordinate').Coordinate>
+        | Array<Array<import('ol/coordinate').Coordinate>>
+        | Array<Array<Array<import('ol/coordinate').Coordinate>>>
+      >,
+    ): void;
+    getLayout(): import('ol/geom/Geometry').GeometryLayout;
+  }
+
+  interface Circle {
+    getCoordinates(): import('ol/coordinate').Coordinate[];
+    setCoordinates(coordinates: import('ol/coordinate').Coordinate[]): void;
+    rotate(angle: number, anchor: import('ol/coordinate').Coordinate): void;
+  }
+}
+
+declare module 'ol/index' {
+  interface Feature<Geometry> {
+    getProperty(key: string): any;
+    getPropertyInherited(key: string): any;
+    [vcsLayerName]: string | null;
+  }
 }

package/package.json

@@ -1,13 +1,16 @@
 {
   "name": "@vcmap/core",
-  "version": "5.0.0-rc.28",
+  "version": "5.0.0-rc.29",
   "description": "",
   "main": "index.js",
   "type": "module",
   "types": "index.d.ts",
   "scripts": {
     "test": "node node_modules/mocha/bin/_mocha --exit --require tests/setupJsdom.js --require tests/setup.js --file tests/vcs.js --recursive \"tests/**/*spec.js\"",
-    "lint": "eslint .",
+    "lint:js": "eslint . --ext .vue,.js,.cjs,.mjs",
+    "lint:prettier": "prettier --check .",
+    "lint": "npm run lint:js && npm run lint:prettier",
+    "format": "prettier --write --list-different . && npm run lint:js -- --fix",
     "pretype-check": "npm run build-typedefs",
     "type-check": "node build/typeCheck.js",
     "postinstall": "node build/postinstall.js",
@@ -36,12 +39,12 @@
   "author": "Virtual City Systems",
   "license": "MIT",
   "devDependencies": {
-    "@vcsuite/eslint-config": "^2.0.3",
+    "@vcsuite/eslint-config": "^3.0.3",
     "@vcsuite/tsd-jsdoc": "^1.0.2",
     "c8": "^7.7.1",
     "canvas": "^2.8.0",
     "chai": "^4.3.4",
-    "eslint": "^8.1.0",
+    "eslint": "^8.38.0",
     "jsdoc": "^3.6.7",
     "jsdoc-plugin-typescript": "^2.0.6",
     "jsdom": "^16.5.2",
@@ -50,6 +53,7 @@
     "mocha-junit-reporter": "^2.0.2",
     "nock": "^13.2.4",
     "node-fetch": "^3.2.0",
+    "prettier": "^2.8.7",
     "resize-observer-polyfill": "1.5.1",
     "sinon": "^9.2.4",
     "sinon-chai": "^3.6.0",
@@ -72,6 +76,7 @@
     "*.d.ts",
     "docs"
   ],
+  "prettier": "@vcsuite/eslint-config/prettier.js",
   "dependencies": {
     "@types/rbush": "^3.0.0",
     "@vcsuite/check": "^1.1.2",

package/src/category/category.js

@@ -2,14 +2,19 @@ import { check } from '@vcsuite/check';
 import { v4 as uuidv4 } from 'uuid';
 import { Feature } from 'ol';
 import { moduleIdSymbol, destroyCollection } from '../vcsModuleHelpers.js';
-import makeOverrideCollection, { isOverrideCollection } from '../util/overrideCollection.js';
+import makeOverrideCollection, {
+  isOverrideCollection,
+} from '../util/overrideCollection.js';
 import VcsObject from '../vcsObject.js';
 import VectorLayer from '../layer/vectorLayer.js';
 import IndexedCollection from '../util/indexedCollection.js';
 import { parseGeoJSON, writeGeoJSONFeature } from '../layer/geojsonHelpers.js';
 import Collection from '../util/collection.js';
 import { getStyleOrDefaultStyle } from '../style/styleFactory.js';
-import { categoryClassRegistry, getObjectFromClassRegistry } from '../classRegistry.js';
+import {
+  categoryClassRegistry,
+  getObjectFromClassRegistry,
+} from '../classRegistry.js';
 import OverrideClassRegistry from '../overrideClassRegistry.js';
 import VcsEvent from '../vcsEvent.js';
 
@@ -38,8 +43,13 @@ function assignLayerOptions(layer, options) {
   }
 
   if (options.highlightStyle) {
-    const highlightStyle = getStyleOrDefaultStyle(options.highlightStyle, layer.highlightStyle);
-    layer.setHighlightStyle(/** @type {import("@vcmap/core").VectorStyleItem} */ (highlightStyle));
+    const highlightStyle = getStyleOrDefaultStyle(
+      options.highlightStyle,
+      layer.highlightStyle,
+    );
+    layer.setHighlightStyle(
+      /** @type {import("@vcmap/core").VectorStyleItem} */ (highlightStyle),
+    );
   }
 
   if (options.vectorProperties) {
@@ -60,7 +70,8 @@ function assignLayerOptions(layer, options) {
  * @returns {void}
  */
 function checkMergeOptionOverride(key, value, defaultOption, option) {
-  const isOverride = option == null ? value !== defaultOption : option !== value;
+  const isOverride =
+    option == null ? value !== defaultOption : option !== value;
   if (isOverride) {
     throw new Error(`Cannot merge options, values of ${key} do not match`);
   }
@@ -76,7 +87,9 @@ function checkMergeOptionOverride(key, value, defaultOption, option) {
  * @template {Object|VcsObject} T
  */
 class Category extends VcsObject {
-  static get className() { return 'Category'; }
+  static get className() {
+    return 'Category';
+  }
 
   /**
    * @returns {CategoryOptions}
@@ -110,7 +123,8 @@ class Category extends VcsObject {
      * @type {string}
      * @private
      */
-    this._featureProperty = options.featureProperty || defaultOptions.featureProperty;
+    this._featureProperty =
+      options.featureProperty || defaultOptions.featureProperty;
     /**
      * @type {string|symbol}
      * @private
@@ -163,7 +177,9 @@ class Category extends VcsObject {
    * @type {string|symbol}
    * @readonly
    */
-  get classRegistryName() { return this._classRegistryName; }
+  get classRegistryName() {
+    return this._classRegistryName;
+  }
 
   /**
    * The collection of this category.
@@ -179,7 +195,9 @@ class Category extends VcsObject {
    * @type {VcsEvent<void>}
    * @readonly
    */
-  get collectionChanged() { return this._collectionChanged; }
+  get collectionChanged() {
+    return this._collectionChanged;
+  }
 
   /**
    * Returns the layer of this collection. Caution, do not use the layer API to add or remove items.
@@ -206,14 +224,17 @@ class Category extends VcsObject {
         feature = geoJsonFeature;
       } else if (typeof geoJsonFeature === 'object') {
         const { features } = parseGeoJSON(geoJsonFeature);
-        if (features[0]) { // XXX do we warn on feature collection?
+        if (features[0]) {
+          // XXX do we warn on feature collection?
           feature = features[0];
         }
       }
 
       if (feature) {
         feature.setId(id);
-        setTimeout(() => { this._layer.addFeatures([feature]); }, 0); // We need to set a timeout, since removing and adding the feature in the same sync call leads to undefined behavior in OL TODO recheck in ol 6.11
+        setTimeout(() => {
+          this._layer.addFeatures([feature]);
+        }, 0); // We need to set a timeout, since removing and adding the feature in the same sync call leads to undefined behavior in OL TODO recheck in ol 6.11
       }
     }
   }
@@ -272,7 +293,12 @@ class Category extends VcsObject {
       defaultOptions.featureProperty,
       options.featureProperty,
     );
-    checkMergeOptionOverride('keyProperty', this._keyProperty, defaultOptions.keyProperty, options.keyProperty);
+    checkMergeOptionOverride(
+      'keyProperty',
+      this._keyProperty,
+      defaultOptions.keyProperty,
+      options.keyProperty,
+    );
     this.title = options.title || this.title;
     if (options.layerOptions && this._layer) {
       assignLayerOptions(this._layer, options.layerOptions);
@@ -290,10 +316,14 @@ class Category extends VcsObject {
     check(collection, Collection);
 
     if (this._keyProperty !== collection.uniqueKey) {
-      throw new Error('The collections key property does not match the categories key property');
+      throw new Error(
+        'The collections key property does not match the categories key property',
+      );
     }
 
-    this._collectionListeners.forEach((cb) => { cb(); });
+    this._collectionListeners.forEach((cb) => {
+      cb();
+    });
     if (this._collection) {
       destroyCollection(this._collection);
     }
@@ -301,16 +331,18 @@ class Category extends VcsObject {
       this._layer.removeAllFeatures(); // XXX should we call `itemRemoved` instead?
     }
 
-    this._collection = collection[isOverrideCollection] ?
-      /** @type {OverrideCollection} */ (collection) :
-      makeOverrideCollection(
-        collection,
-        this._getDynamicModuleId.bind(this),
-        this._serializeItem.bind(this),
-        this._deserializeItem.bind(this),
-      );
-
-    [...this.collection].forEach((item) => { this._itemAdded(item); });
+    this._collection = collection[isOverrideCollection]
+      ? /** @type {OverrideCollection} */ (collection)
+      : makeOverrideCollection(
+          collection,
+          this._getDynamicModuleId.bind(this),
+          this._serializeItem.bind(this),
+          this._deserializeItem.bind(this),
+        );
+
+    [...this.collection].forEach((item) => {
+      this._itemAdded(item);
+    });
     /**
      * @type {Array<function():void>}
      * @private
@@ -323,8 +355,10 @@ class Category extends VcsObject {
 
     // @ts-ignore
     if (this._collection.moved) {
-      // @ts-ignore
-      this._collectionListeners.push(this._collection.moved.addEventListener(this._itemMoved.bind(this)));
+      this._collectionListeners.push(
+        // @ts-ignore
+        this._collection.moved.addEventListener(this._itemMoved.bind(this)),
+      );
     }
     this.collectionChanged.raiseEvent();
   }
@@ -337,9 +371,11 @@ class Category extends VcsObject {
       throw new Error('Cannot switch apps');
     }
     this._app = app;
-    this._moduleRemovedListener = this._app.moduleRemoved.addEventListener((module) => {
-      this._collection.removeModule(module._id);
-    });
+    this._moduleRemovedListener = this._app.moduleRemoved.addEventListener(
+      (module) => {
+        this._collection.removeModule(module._id);
+      },
+    );
     if (this._layer) {
       this._app.layers.add(this._layer);
     }
@@ -354,7 +390,9 @@ class Category extends VcsObject {
     if (!this._app) {
       throw new Error('Cannot deserialize item before setting the vcApp');
     }
-    const classRegistry = this._classRegistryName ? this._app[this._classRegistryName] : null;
+    const classRegistry = this._classRegistryName
+      ? this._app[this._classRegistryName]
+      : null;
     if (classRegistry && classRegistry instanceof OverrideClassRegistry) {
       return getObjectFromClassRegistry(classRegistry, config);
     }
@@ -429,7 +467,9 @@ class Category extends VcsObject {
       this._layer.destroy();
     }
 
-    this._collectionListeners.forEach((cb) => { cb(); });
+    this._collectionListeners.forEach((cb) => {
+      cb();
+    });
     this._collectionListeners.splice(0);
     this._moduleRemovedListener();
     this._moduleRemovedListener = () => {};
@@ -441,4 +481,3 @@ class Category extends VcsObject {
 
 export default Category;
 categoryClassRegistry.registerClass(Category.className, Category);
-