@vbarbarosh/node-helpers 2.0.3 → 2.2.0

package/package.json

@@ -2,7 +2,7 @@
     "author": "Vladimir Barbarosh <vladimir.barbarosh@gmail.com>",
     "license": "MIT",
     "name": "@vbarbarosh/node-helpers",
-    "version": "2.0.3",
+    "version": "2.2.0",
     "description": "A set of helpers for JavaScript/Node.js",
     "files": [
         "src"

package/src/fs_mkdirp.js

@@ -19,8 +19,13 @@ async function fs_mkdirp(pathname)
         }
         catch (error) {
             // Error: EEXIST: file already exists, mkdir [...]
-            if (error.code == 'EEXIST') {
-                break;
+            if (error.code === 'EEXIST') {
+                // Exiting here is not correct. When two processes are running in parallel,
+                // one tries to create `a/b/c` and another `a`. When second process creates
+                // `a`, the first process will get `EEXIST` and stops (break) creating any
+                // nested directories, which is not correct.
+                // break;
+                continue;
             }
             throw error;
         }

package/src/fs_mkdirp.test.js

@@ -12,4 +12,13 @@ describe('fs_mkdirp', function () {
             assert(await fs_fi(tmp).then(v => v.isDirectory()));
         });
     });
+    it('should create the same directory structure in parallel', async function () {
+        await fs_tempdir(async function (d) {
+            const tmp = fs_path_resolve(d, 'a/b/c/d/e/f/g/h');
+            await Promise.all(Array(10).fill(tmp).map(async function (v, i) {
+                await fs_mkdirp(tmp);
+                assert(await fs_fi(tmp).then(v => v.isDirectory()));
+            }));
+        });
+    });
 });

package/src/fs_read_buffer.js

@@ -1,8 +1,8 @@
 const fs_read = require('./fs_read');
 
-async function fs_read_buffer(file)
+function fs_read_buffer(file)
 {
-    return await fs_read(file);
+    return fs_read(file);
 }
 
 module.exports = fs_read_buffer;

package/src/fs_read_lines.js

@@ -0,0 +1,10 @@
+const fs_read = require('./fs_read');
+
+// XXX Should support catchReturn, e.g.
+//     fs_read_lines(file).catchReturn(default_value)
+function fs_read_lines(file)
+{
+    return fs_read(file, {encoding: 'utf8'}).then(v => v.split('\n'));
+}
+
+module.exports = fs_read_lines;

package/src/fs_read_utf8.js

@@ -1,8 +1,8 @@
 const fs_read = require('./fs_read');
 
-async function fs_read_utf8(file)
+function fs_read_utf8(file)
 {
-    return await fs_read(file, {encoding: 'utf8'});
+    return fs_read(file, {encoding: 'utf8'});
 }
 
 module.exports = fs_read_utf8;