@vanillagreen/pi-qol 2.1.0 → 2.1.1

package/README.md

@@ -44,6 +44,7 @@ Open `/extensions:settings`; settings appear under the **QOL** tab. Project sett
 - Permission gate: `permissionGate.enabled`, `permissionGate.commands` (comma-separated literal fragments or `/regex/flags`), `permissionGate.previewLines`, `permissionGate.previewChars`.
 - Notifications: `notification.*` (triggers, channels, tmux options, protocol, cooldown, title and body).
 - Compaction and budget guard: `compaction.*` (custom summaries, model, profile, remote endpoint, branch summaries, idle trigger, budget guard thresholds, chunk input cap, handoff artifact, transcript-risk budget).
+  - Pi's own `compaction.enabled` (the top-level `compaction` object in the same settings files, not a QOL key) turns off every automatic compaction: when it is `false`, neither the budget guard nor the idle trigger starts one, and `/qol` reports both as disabled by that key. A manual `/compact` still runs. While it is `true` or absent, both keep the defaults and thresholds above: the budget guard on at `compaction.budgetPercent` 85, the idle trigger off until `compaction.idleEnabled` is set.
 - Thinking: `thinkingLabel.text`, `thinkingTimer.enabled`, `workingIndicator.mode` (`static` if the animated indicator flashes).
 
 Maintainer notes are in [DEVELOPMENT.md](DEVELOPMENT.md).

package/extensions/qol/compaction.ts

@@ -27,7 +27,7 @@ import {
 	type HandoffWriteResult,
 	type QolBudgetHandoff,
 } from "./compaction-handoff.js";
-import { settingBoolean, settingNumber, settingString } from "./settings.js";
+import { piCompactionEnabled, settingBoolean, settingNumber, settingString } from "./settings.js";
 import { stringifyError } from "./util.js";
 
 export type QolSummaryProfile = "concise" | "balanced" | "exhaustive";
@@ -373,6 +373,22 @@ export function compactionTriggerReason(ctx: ExtensionContext): string | undefin
 	return undefined;
 }
 
+/** Whether a QOL automatic compaction trigger may fire, and what turned it
+ * off. Pi core's `compaction.enabled` is read first, so that one key stops
+ * every automatic compaction in Pi; a manual /compact never passes here. */
+export type AutoCompactionGate = "enabled" | "disabled" | "pi-compaction-disabled";
+
+const AUTO_COMPACTION_SWITCHES = {
+	budgetGuard: { key: "compaction.budgetGuardEnabled", fallback: true },
+	idle: { key: "compaction.idleEnabled", fallback: false },
+} as const;
+
+export function autoCompactionGate(trigger: keyof typeof AUTO_COMPACTION_SWITCHES, cwd: string): AutoCompactionGate {
+	if (!piCompactionEnabled(cwd)) return "pi-compaction-disabled";
+	const { key, fallback } = AUTO_COMPACTION_SWITCHES[trigger];
+	return settingBoolean(key, fallback, cwd) ? "enabled" : "disabled";
+}
+
 export type BudgetGuardTrigger = BudgetTrigger;
 export type TranscriptRiskState = TranscriptRiskResult;
 
@@ -383,7 +399,7 @@ export type TranscriptRiskState = TranscriptRiskResult;
  * repeated triggers while usage stays above the threshold.
  */
 export function budgetGuardTrigger(ctx: ExtensionContext): BudgetGuardTrigger | undefined {
-	if (!settingBoolean("compaction.budgetGuardEnabled", true, ctx.cwd)) return undefined;
+	if (autoCompactionGate("budgetGuard", ctx.cwd) !== "enabled") return undefined;
 	const usage = contextUsage(ctx);
 	if (!usage) return undefined;
 	return computeBudgetTrigger({

package/extensions/qol/settings.ts

@@ -69,21 +69,49 @@ export function piSettingsPaths(cwd = process.cwd()): string[] {
 	return projectSettingsTrusted(project) ? [user, project] : [user];
 }
 
-export function readPackageConfig(packageId: string, cwd?: string): Record<string, unknown> {
-	const merged: Record<string, unknown> = {};
+function isRecord(value: unknown): value is Record<string, unknown> {
+	return Boolean(value) && typeof value === "object" && !Array.isArray(value);
+}
+
+/** Each settings file `piSettingsPaths` names that exists and parses, later
+ * files overriding earlier ones. A malformed file is skipped, as Pi's own
+ * settings load treats one as empty. */
+function readPiSettingsFiles(cwd?: string): Record<string, any>[] {
+	const files: Record<string, any>[] = [];
 	for (const settingsPath of piSettingsPaths(cwd)) {
 		if (!existsSync(settingsPath)) continue;
 		try {
 			const parsed = JSON.parse(readFileSync(settingsPath, "utf8"));
-			const config = parsed?.kendex?.extensionManager?.config?.[packageId];
-			if (config && typeof config === "object" && !Array.isArray(config)) Object.assign(merged, config);
+			if (isRecord(parsed)) files.push(parsed);
 		} catch {
-			// Ignore malformed optional manager config.
+			// Ignore a malformed settings file.
 		}
 	}
+	return files;
+}
+
+export function readPackageConfig(packageId: string, cwd?: string): Record<string, unknown> {
+	const merged: Record<string, unknown> = {};
+	for (const settings of readPiSettingsFiles(cwd)) {
+		const config = settings.kendex?.extensionManager?.config?.[packageId];
+		if (isRecord(config)) Object.assign(merged, config);
+	}
 	return merged;
 }
 
+/** Pi core's `compaction.enabled` over the files QOL reads its own config
+ * from, resolved as Pi's `SettingsManager.getCompactionEnabled` resolves it:
+ * the last file that sets the key decides, a key no file sets is Pi's default,
+ * true, and any falsy value turns compaction off. */
+export function piCompactionEnabled(cwd?: string): boolean {
+	let enabled: unknown;
+	for (const settings of readPiSettingsFiles(cwd)) {
+		const compaction = settings.compaction;
+		if (isRecord(compaction) && compaction.enabled !== undefined) enabled = compaction.enabled;
+	}
+	return Boolean(enabled ?? true);
+}
+
 export function readkendexConfig(cwd?: string): kendexConfig {
 	return readPackageConfig(CONFIG_ID, cwd) as kendexConfig;
 }

package/extensions/qol/status-message.ts

@@ -1,7 +1,9 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import { compactionProfile } from "./compaction.js";
+import { autoCompactionGate, compactionProfile, type AutoCompactionGate } from "./compaction.js";
 import {
 	DEFAULT_AUTO_RENAME_MODEL,
+	DEFAULT_BUDGET_GUARD_PERCENT,
+	DEFAULT_BUDGET_GUARD_TOKENS,
 	DEFAULT_COMPACTION_MODEL,
 	DEFAULT_IDLE_COMPACTION_SECONDS,
 	DEFAULT_PERMISSION_GATE_PREVIEW_CHARS,
@@ -15,6 +17,21 @@ import { autoRenameEnabled } from "./session-rename.js";
 import { sessionSearchShortcut } from "./session-search/index.js";
 import { boundedSettingNumber, newlineFallbackKey, settingBoolean, settingNumber, settingString } from "./settings.js";
 
+function autoCompactionStatus(gate: AutoCompactionGate, enabled: () => string): string {
+	switch (gate) {
+		case "enabled":
+			return enabled();
+		case "disabled":
+			return "disabled";
+		case "pi-compaction-disabled":
+			return "disabled by Pi compaction.enabled=false";
+		default: {
+			const unknownGate: never = gate;
+			throw new Error(`pi-qol: unknown auto-compaction gate ${String(unknownGate)}`);
+		}
+	}
+}
+
 export function statusMessage(ctx: ExtensionContext): string {
 	const labels = attachmentLabels(currentEditorText(ctx), ctx.cwd);
 	const searchShortcut = sessionSearchShortcut(ctx.cwd);
@@ -37,7 +54,8 @@ export function statusMessage(ctx: ExtensionContext): string {
 		`Handoff prompt review: ${settingBoolean("handoffReviewPrompt", true, ctx.cwd) ? "enabled" : "disabled"}`,
 		`Session search: ${settingBoolean("sessionSearch.enabled", true, ctx.cwd) ? `enabled (/search${searchShortcut ? `, ${searchShortcut}` : ""})` : "disabled"}`,
 		`Custom compaction: ${settingBoolean("compaction.customEnabled", false, ctx.cwd) ? `enabled (${settingString("compaction.model", DEFAULT_COMPACTION_MODEL, ctx.cwd)}, ${compactionProfile(ctx.cwd)})` : "disabled (Pi default)"}`,
-		`Idle compaction: ${settingBoolean("compaction.idleEnabled", false, ctx.cwd) ? `enabled after ${Math.max(1, Math.floor(settingNumber("compaction.idleTimeoutSeconds", DEFAULT_IDLE_COMPACTION_SECONDS, ctx.cwd)))}s idle` : "disabled"}`,
+		`Budget guard: ${autoCompactionStatus(autoCompactionGate("budgetGuard", ctx.cwd), () => `enabled (budgetPercent=${settingNumber("compaction.budgetPercent", DEFAULT_BUDGET_GUARD_PERCENT, ctx.cwd)}, budgetTokens=${settingNumber("compaction.budgetTokens", DEFAULT_BUDGET_GUARD_TOKENS, ctx.cwd)})`)}`,
+		`Idle compaction: ${autoCompactionStatus(autoCompactionGate("idle", ctx.cwd), () => `enabled after ${Math.max(1, Math.floor(settingNumber("compaction.idleTimeoutSeconds", DEFAULT_IDLE_COMPACTION_SECONDS, ctx.cwd)))}s idle`)}`,
 		`Branch summary override: ${settingBoolean("compaction.branchSummaryEnabled", false, ctx.cwd) ? "enabled" : "disabled"}`,
 		`Notifications: ${settingBoolean("notification.enabled", true, ctx.cwd) ? `enabled (bell=${settingBoolean("notification.bell", true, ctx.cwd)}, muteBell=${settingBoolean("notification.muteBellSound", false, ctx.cwd)}, native=${settingBoolean("notification.native", true, ctx.cwd)}, tmuxClientTty=${settingBoolean("notification.tmuxNativeClientTty", true, ctx.cwd)}, tmuxMessage=${settingBoolean("notification.tmux", false, ctx.cwd)})` : "disabled"}`,
 		`Permission gate: ${settingBoolean("permissionGate.enabled", false, ctx.cwd) ? `enabled (${permissionGateCommands(ctx.cwd).join(", ") || "none configured"}; preview ${boundedSettingNumber("permissionGate.previewLines", DEFAULT_PERMISSION_GATE_PREVIEW_LINES, 4, 40, ctx.cwd)} lines/${boundedSettingNumber("permissionGate.previewChars", DEFAULT_PERMISSION_GATE_PREVIEW_CHARS, 200, 5000, ctx.cwd)} chars)` : "disabled"}`,

package/extensions/qol.ts

@@ -5,6 +5,7 @@ import { getQuestionService, readCavemanBridge, type QuestionOpenedEventLike } f
 import { BudgetGuardDriver } from "./qol/budget-guard-runtime.js";
 import { ansiGreen } from "./qol/ansi.js";
 import {
+	autoCompactionGate,
 	budgetGuardTrigger,
 	compactionTriggerReason,
 	handleQolBranchSummary,
@@ -334,7 +335,7 @@ export default function qol(pi: ExtensionAPI): void {
 
 	const scheduleIdleCompaction = (ctx: ExtensionContext) => {
 		clearIdleCompactionTimer();
-		if (!settingBoolean("compaction.idleEnabled", false, ctx.cwd)) return;
+		if (autoCompactionGate("idle", ctx.cwd) !== "enabled") return;
 		const reason = compactionTriggerReason(ctx);
 		if (!reason) return;
 		const delayMs = Math.max(1, Math.floor(settingNumber("compaction.idleTimeoutSeconds", DEFAULT_IDLE_COMPACTION_SECONDS, ctx.cwd))) * 1000;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vanillagreen/pi-qol",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "Pi quality-of-life extension: compact statusline/π prompt, reliable multiline input, styled pasted-image chips, session naming/search/context import, scheduled prompts, handoff, permission prompts, notifications, custom compaction, and a collapsed-thinking timer.",
   "license": "MIT",
   "keywords": [
@@ -839,7 +839,7 @@
         {
           "key": "compaction.idleEnabled",
           "label": "Idle compaction trigger",
-          "description": "Trigger Pi compaction after the session sits idle above the configured token threshold. Inspired by oh-my-pi idle compaction.",
+          "description": "Trigger Pi compaction after the session sits idle above the configured token threshold. Never fires while Pi's own compaction.enabled is false. Inspired by oh-my-pi idle compaction.",
           "type": "boolean",
           "default": false,
           "category": "Compaction Idle",
@@ -884,7 +884,7 @@
         {
           "key": "compaction.budgetGuardEnabled",
           "label": "Long-session budget guard",
-          "description": "Start bounded compaction when an active session crosses the configured context budget, while giving Pi's built-in compaction priority. Designed for long autonomous runs so transcript growth cannot silently hit provider or buffer limits. Fires once per threshold crossing, not in a loop.",
+          "description": "Start bounded compaction when an active session crosses the configured context budget, while giving Pi's built-in compaction priority. Designed for long autonomous runs so transcript growth cannot silently hit provider or buffer limits. Fires once per threshold crossing, not in a loop. Never fires while Pi's own compaction.enabled is false.",
           "type": "boolean",
           "default": true,
           "category": "Compaction Budget Guard",