@vanillaes/esmtk 1.5.0 → 1.5.1

package/bin/commands/bundle.js

@@ -33,11 +33,20 @@ export async function bundle (input, output, options) {
   args.push(input)
   args.push(`--outfile=${output}`)
 
-  spawn('esbuild', args, {
+  const child = spawn('esbuild', args, {
     cwd: process.cwd(),
     stdio: ['pipe', process.stdout, process.stderr]
-  }).on('error', error => {
+  })
+
+  child.on('error', error => {
     console.error(error)
     process.exitCode = 1
   })
+
+  // forward the error code
+  child.on('close', (/** @type {number} */ code) => {
+    if (code === 1) {
+      process.exitCode = 1
+    }
+  })
 }

package/bin/commands/clean.js

@@ -15,30 +15,30 @@ export async function clean (cwd, options) {
   }
 
   if (options?.bundle) {
-    await cleanOne(cwd, options.bundle, options)
+    await cleanCategory(cwd, options.bundle, options)
   }
 
   if (options?.minify) {
-    await cleanOne(cwd, options.minify, options)
+    await cleanCategory(cwd, options.minify, options)
   }
 
   if (options?.typings) {
-    await cleanOne(cwd, options.typings, options)
+    await cleanCategory(cwd, options.typings, options)
   }
 
   if (options?.custom) {
-    await cleanOne(cwd, options.custom, options)
+    await cleanCategory(cwd, options.custom, options)
   }
 }
 
 /**
- * Run one category of build artifacts
+ * Clean one category of build artifacts
  * @private
  * @param {string} cwd the current working directory (default process.cwd())
  * @param {string} glob the pattern of files to match
  * @param {object} options 'clean' options
  */
-async function cleanOne (cwd, glob, options) {
+async function cleanCategory (cwd, glob, options) {
   const files = await match(glob, cwd, 'node_modules/**')
   await removeMultipleAsync(files, options?.force)
 }

package/bin/commands/commonjs.js

@@ -33,11 +33,20 @@ export async function commonjs (input, output, options) {
   args.push(input)
   args.push(`--outfile=${output}`)
 
-  spawn('esbuild', args, {
+  const child = spawn('esbuild', args, {
     cwd: process.cwd(),
     stdio: ['pipe', process.stdout, process.stderr]
-  }).on('error', error => {
+  })
+
+  child.on('error', error => {
     console.error(error)
     process.exitCode = 1
   })
+
+  // forward the error code
+  child.on('close', (/** @type {number} */ code) => {
+    if (code === 1) {
+      process.exitCode = 1
+    }
+  })
 }

package/bin/commands/lint.js

@@ -16,9 +16,6 @@ export async function lint (options) {
   const child = spawn(BIN_PATH, args, {
     cwd: process.cwd(),
     stdio: ['pipe', 'pipe', 'pipe']
-  }).on('error', error => {
-    console.error(`${error}`)
-    process.exitCode = 1
   })
 
   child.stdout.on('data', (data) => {
@@ -26,11 +23,31 @@ export async function lint (options) {
   })
 
   child.stderr.on('data', (data) => {
-    if (data.toString() === 'lint-es: Run `lint-es --fix` to automatically fix some problems.\n') {
+    data = data.toString()
+    // VSCode debug dumps to stderr for some reason, ignore it
+    if (data === 'Debugger attached.\n' || data === 'Waiting for the debugger to disconnect...\n') {
+      return
+    }
+
+    // catch the --fix message and rewrite it
+    if (data.startsWith('lint-es: Run `lint-es --fix` to automatically fix some problems.\n')) {
       process.stderr.write('esmtk: Run `esmtk lint --fix` to automatically fix some problems.\n')
+      return
     } else {
-      process.stderr.write(`${data}`)
+      process.stderr.write(data)
     }
     process.exitCode = 1
   })
+
+  child.on('error', error => {
+    console.error(`${error}`)
+    process.exitCode = 1
+  })
+
+  // forward the error code
+  child.on('close', (/** @type {number} */ code) => {
+    if (code === 1) {
+      process.exitCode = 1
+    }
+  })
 }

package/bin/commands/minify.js

@@ -37,11 +37,20 @@ export async function minify (input, output, options) {
   args.push(input)
   args.push(`--outfile=${output}`)
 
-  spawn('esbuild', args, {
+  const child = spawn('esbuild', args, {
     cwd: process.cwd(),
     stdio: ['pipe', process.stdout, process.stderr]
-  }).on('error', error => {
+  })
+
+  child.on('error', error => {
     console.error(error)
     process.exitCode = 1
   })
+
+  // forward the error code
+  child.on('close', (/** @type {number} */ code) => {
+    if (code === 1) {
+      process.exitCode = 1
+    }
+  })
 }

package/bin/commands/test.js

@@ -24,9 +24,6 @@ export async function test (glob, options) {
   const child = spawn('node', args, {
     cwd: process.cwd(),
     stdio: ['pipe', 'pipe', 'pipe']
-  }).on('error', error => {
-    console.error(error)
-    process.exitCode = 1
   })
 
   child.stdout.on('data', (data) => {
@@ -34,7 +31,23 @@ export async function test (glob, options) {
   })
 
   child.stderr.on('data', (data) => {
-    process.stderr.write(`${data}`)
+    data = data.toString()
+    if (data === 'Debugger attached.\n' || data === 'Waiting for the debugger to disconnect...\n') {
+      return
+    }
+    process.stderr.write(data)
+    process.exitCode = 1
+  })
+
+  child.on('error', error => {
+    console.error(error)
     process.exitCode = 1
   })
+
+  // forward the error code
+  child.on('close', (/** @type {number} */ code) => {
+    if (code === 1) {
+      process.exitCode = 1
+    }
+  })
 }

package/bin/commands/type.js

@@ -43,11 +43,20 @@ export async function type (entry, options) {
     args.push(options.types)
   }
 
-  spawn('tsc', args, {
+  const child = spawn('tsc', args, {
     cwd: process.cwd(),
     stdio: ['pipe', process.stdout, process.stderr]
-  }).on('error', error => {
+  })
+
+  child.on('error', error => {
     console.error(error)
     process.exitCode = 1
   })
+
+  // forward the error code
+  child.on('close', (/** @type {number} */ code) => {
+    if (code === 1) {
+      process.exitCode = 1
+    }
+  })
 }

package/bin/commands/typings.js

@@ -42,11 +42,20 @@ export async function typings (entry, options) {
     args.push(options.types)
   }
 
-  spawn('tsc', args, {
+  const child = spawn('tsc', args, {
     cwd: process.cwd(),
     stdio: ['pipe', process.stdout, process.stderr]
-  }).on('error', error => {
+  })
+
+  child.on('error', error => {
     console.error(error)
     process.exitCode = 1
   })
+
+  // forward the error code
+  child.on('close', (/** @type {number} */ code) => {
+    if (code === 1) {
+      process.exitCode = 1
+    }
+  })
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vanillaes/esmtk",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "ES Module Toolkit",
   "keywords": [
     "ecmascript",