@valbuild/shared 0.133.0 → 0.134.1

package/CHANGELOG.md

@@ -1,5 +1,79 @@
 # @valbuild/shared
 
+## 0.134.1
+
+### Patch Changes
+
+- [#709](https://github.com/valbuild/val/pull/709) [`821e789`](https://github.com/valbuild/val/commit/821e789c1af47510af5d23eb96384ff78ddd7646) Thanks [@freekh](https://github.com/freekh)! - Show the reason behind a content-service error instead of just "Internal Server
+  Error".
+
+  `content.val.build` answers a handler that threw with `{ message: "Internal
+Server Error", details: "<the actual cause>" }`. Val was reading `message` and
+  dropping `details`, so a failed save put exactly this in front of an editor —
+  and the same text in the app's own logs, because Val was relaying it:
+
+  ```json
+  { "type": "patch-error", "message": "Internal Server Error", "errors": { … } }
+  ```
+
+  A string `details` is now appended to the message (capped at 500 characters).
+  A structured one is not: that is what a _refusal_ carries, and its summary is
+  already the message.
+
+## 0.134.0
+
+### Minor Changes
+
+- [#680](https://github.com/valbuild/val/pull/680) [`eaa265e`](https://github.com/valbuild/val/commit/eaa265e78d9f6d2a1b685c38901612b8a3704eed) Thanks [@freekh](https://github.com/freekh)! - Add `s.view()`: point at another module, so editors can reach it from the page it belongs to.
+
+  Content that has to live in its own module — a `keyOf` target, shared settings, a route-keyed record — is invisible from the page an editor thinks of it as part of. A view field puts a row on that page's screen that leads to it:
+
+  ```ts
+  import employeesVal from "../data/employees.val";
+
+  const schema = s.object({
+    title: s.string(),
+    employees: s.view(employeesVal),
+  });
+
+  export default c.define("/app/menneskene/page.val.ts", schema, {
+    title: "Våre folk",
+    employees: { view: "/data/employees.val.ts" },
+  });
+  ```
+
+  The source is a pointer and nothing else. The module it names keeps its own source, patches, validation and address, and an editor who follows the row lands on that module's own screen — so it is clear they are changing something other pages use too.
+
+  A few things worth knowing:
+
+  - **The path autocompletes, and a wrong one does not compile.** A module now carries its own id in its type, so the source type of the field above is the literal `{ view: "/data/employees.val.ts" }`.
+  - **It is not readable in code.** `useVal(pageVal).employees` is a `ValView<…>` — an opaque pointer with no fields on it. Read the module it names directly, as before.
+  - **`view` is now a reserved object key**, like `_type` and `patch_id`: `s.object({ view: ... })` no longer compiles. A single `view: string` key is what a view pointer looks like, and an ordinary object with that shape would be indistinguishable from one.
+  - **Views may not form a cycle.** `A → B → A`, and a module viewing itself, are reported as module errors by `val validate` and in the Studio.
+  - **A pointer that disagrees with its schema is repaired automatically.** It can only happen in hand-written JSON, and the schema is the authority, so `val validate --fix` and saving in the Studio both write the module the schema names.
+  - **A view's `hidden` and `readonly` are its own, never the module's it points at.** A view whose target is hidden is still shown, and still leads there.
+
+  That last one comes with a change to what `hidden()` means on a **module's own schema**, which is the other half of making a shared module usable:
+
+  ```ts
+  // Not in the nav, and on exactly one page.
+  export default c.define("/data/employees.val.ts", s.record(...).hidden(), { ... });
+  ```
+
+  It now means the nav does not list the module — the Explorer for an ordinary module, Media for a gallery — and nothing more. Previously it also blanked the module's own page, so a module you had hidden was still in the nav and showed nothing when opened. A hidden module is now reached from an `s.view()` row, from search or from a validation error, and renders in full when you get there.
+
+  One gap worth naming rather than leaving to be discovered: a view pointing at a
+  module the project does not have is reported by the FIELD — the row says the
+  target is missing — but not by `val validate`. The schema check compares the
+  pointer against the schema, and the cycle check deliberately skips a target that
+  is not a module of the project, so neither catches it. A project-level check
+  belongs with them and is not here yet.
+
+### Patch Changes
+
+- Updated dependencies [[`16c49ea`](https://github.com/valbuild/val/commit/16c49ea6dd97c7a96bbfdf211af9bab5884579e2), [`eaa265e`](https://github.com/valbuild/val/commit/eaa265e78d9f6d2a1b685c38901612b8a3704eed)]:
+  - @valbuild/core@0.134.0
+
 ## 0.133.0
 
 ### Minor Changes

package/dist/declarations/src/internal/ApiRoutes.d.ts

@@ -956,7 +956,7 @@ export declare const Api: {
                             message: z.ZodString;
                             value: z.ZodOptional<z.ZodUnknown>;
                             fatal: z.ZodOptional<z.ZodBoolean>;
-                            fixes: z.ZodOptional<z.ZodArray<z.ZodType<"image:add-metadata" | "image:check-metadata" | "image:upload-remote" | "image:download-remote" | "image:check-remote" | "images:check-remote" | "images:upload-remote" | "file:add-metadata" | "file:check-metadata" | "file:upload-remote" | "file:download-remote" | "file:check-remote" | "files:check-remote" | "files:upload-remote" | "keyof:check-keys" | "router:check-route" | "locale:check-locale" | "images:check-unique-folder" | "files:check-unique-folder" | "images:check-all-files" | "files:check-all-files" | "jsonValues:extract-entry" | "record:fill-keys" | "external:upload", unknown, z.core.$ZodTypeInternals<"image:add-metadata" | "image:check-metadata" | "image:upload-remote" | "image:download-remote" | "image:check-remote" | "images:check-remote" | "images:upload-remote" | "file:add-metadata" | "file:check-metadata" | "file:upload-remote" | "file:download-remote" | "file:check-remote" | "files:check-remote" | "files:upload-remote" | "keyof:check-keys" | "router:check-route" | "locale:check-locale" | "images:check-unique-folder" | "files:check-unique-folder" | "images:check-all-files" | "files:check-all-files" | "jsonValues:extract-entry" | "record:fill-keys" | "external:upload", unknown>>>>;
+                            fixes: z.ZodOptional<z.ZodArray<z.ZodType<"image:add-metadata" | "image:check-metadata" | "image:upload-remote" | "image:download-remote" | "image:check-remote" | "images:check-remote" | "images:upload-remote" | "file:add-metadata" | "file:check-metadata" | "file:upload-remote" | "file:download-remote" | "file:check-remote" | "files:check-remote" | "files:upload-remote" | "keyof:check-keys" | "router:check-route" | "locale:check-locale" | "images:check-unique-folder" | "files:check-unique-folder" | "images:check-all-files" | "files:check-all-files" | "jsonValues:extract-entry" | "record:fill-keys" | "external:upload" | "view:check-module", unknown, z.core.$ZodTypeInternals<"image:add-metadata" | "image:check-metadata" | "image:upload-remote" | "image:download-remote" | "image:check-remote" | "images:check-remote" | "images:upload-remote" | "file:add-metadata" | "file:check-metadata" | "file:upload-remote" | "file:download-remote" | "file:check-remote" | "files:check-remote" | "files:upload-remote" | "keyof:check-keys" | "router:check-route" | "locale:check-locale" | "images:check-unique-folder" | "files:check-unique-folder" | "images:check-all-files" | "files:check-all-files" | "jsonValues:extract-entry" | "record:fill-keys" | "external:upload" | "view:check-module", unknown>>>>;
                         }, z.core.$strip>>>>;
                     }, z.core.$strip>>;
                 }, z.core.$strip>;

package/dist/declarations/src/internal/zod/SerializedSchema.d.ts

@@ -76,4 +76,23 @@ export declare const SerializedCodeSchema: z.ZodType<SerializedCodeSchemaT>;
 export declare const SerializedLocaleSchema: z.ZodType<SerializedLocaleSchemaT>;
 export declare const SerializedRouteSchema: z.ZodType<SerializedRouteSchemaT>;
 export declare const SerializedSettingsSchema: z.ZodType<SerializedSettingsSchemaT>;
+/**
+ * A view field shows another module and stores nothing of its own.
+ *
+ * Nothing in the type system forces this member to exist: `SerializedSchema` is
+ * declared as `z.ZodType<SerializedSchemaT>`, so a missing member is not a type
+ * error — it is a runtime parse failure of the WHOLE module's schema, since the
+ * containing object fails with it.
+ */
+export declare const SerializedValViewSchema: z.ZodObject<{
+    type: z.ZodLiteral<"view">;
+    render: z.ZodOptional<z.ZodOptional<z.ZodObject<{
+        as: z.ZodLiteral<"inline">;
+    }, z.core.$strip>>>;
+    moduleFilePath: z.ZodType<import("@valbuild/core").ModuleFilePath, unknown, z.core.$ZodTypeInternals<import("@valbuild/core").ModuleFilePath, unknown>>;
+    opt: z.ZodLiteral<false>;
+    readonly: z.ZodOptional<z.ZodBoolean>;
+    hidden: z.ZodOptional<z.ZodBoolean>;
+    description: z.ZodOptional<z.ZodString>;
+}, z.core.$strip>;
 export declare const SerializedSchema: z.ZodType<SerializedSchemaT>;

package/internal/dist/valbuild-shared-internal.cjs.dev.js

@@ -923,6 +923,10 @@ var SourcePath = zod.z.string().transform(function (path) {
   return path;
 });
 
+var ModuleFilePath$1 = zod.z.string().transform(function (path) {
+  return path;
+});
+
 var _excluded = ["directory"];
 
 // A render is static config, so unlike a `preview` it travels WHOLE — this
@@ -1216,7 +1220,25 @@ var SerializedSettingsSchema = zod.z.lazy(function () {
     section: zod.z.string().optional()
   }));
 });
-var SerializedSchema = zod.z.union([SerializedStringSchema, SerializedLiteralSchema, SerializedBooleanSchema, SerializedNumberSchema, SerializedObjectSchema, SerializedArraySchema, SerializedDiscriminatedUnionSchema, SerializedEnumSchema, SerializedRichTextSchema, SerializedRecordSchema, SerializedKeyOfSchema, SerializedRouteSchema, SerializedLocaleSchema, SerializedFileSchema, SerializedDateSchema, SerializedDateTimeSchema, SerializedColorSchema, SerializedCodeSchema, SerializedSettingsSchema, SerializedImageSchema]);
+
+/**
+ * A view field shows another module and stores nothing of its own.
+ *
+ * Nothing in the type system forces this member to exist: `SerializedSchema` is
+ * declared as `z.ZodType<SerializedSchemaT>`, so a missing member is not a type
+ * error — it is a runtime parse failure of the WHOLE module's schema, since the
+ * containing object fails with it.
+ */
+var SerializedValViewSchema = zod.z.object({
+  type: zod.z.literal("view"),
+  render: FieldRender.optional(),
+  moduleFilePath: ModuleFilePath$1,
+  opt: zod.z.literal(false),
+  readonly: zod.z["boolean"]().optional(),
+  hidden: zod.z["boolean"]().optional(),
+  description: zod.z.string().optional()
+});
+var SerializedSchema = zod.z.union([SerializedStringSchema, SerializedLiteralSchema, SerializedBooleanSchema, SerializedNumberSchema, SerializedObjectSchema, SerializedArraySchema, SerializedDiscriminatedUnionSchema, SerializedEnumSchema, SerializedRichTextSchema, SerializedRecordSchema, SerializedKeyOfSchema, SerializedRouteSchema, SerializedLocaleSchema, SerializedFileSchema, SerializedDateSchema, SerializedDateTimeSchema, SerializedColorSchema, SerializedCodeSchema, SerializedSettingsSchema, SerializedImageSchema, SerializedValViewSchema]);
 
 var ValCommit = zod.z.object({
   commitSha: zod.z.string(),
@@ -1402,7 +1424,7 @@ var ValConfig = zod.z.object({
   gitCommit: zod.z.string().optional(),
   gitBranch: zod.z.string().optional()
 });
-var ValidationFixZ = zod.z.union([zod.z.literal("image:add-metadata"), zod.z.literal("image:check-metadata"), zod.z.literal("image:check-remote"), zod.z.literal("image:upload-remote"), zod.z.literal("image:download-remote"), zod.z.literal("images:check-remote"), zod.z.literal("images:upload-remote"), zod.z.literal("file:add-metadata"), zod.z.literal("file:check-metadata"), zod.z.literal("file:check-remote"), zod.z.literal("file:upload-remote"), zod.z.literal("file:download-remote"), zod.z.literal("files:check-remote"), zod.z.literal("files:upload-remote"), zod.z.literal("keyof:check-keys"), zod.z.literal("router:check-route"), zod.z.literal("locale:check-locale"), zod.z.literal("record:fill-keys"), zod.z.literal("images:check-unique-folder"), zod.z.literal("files:check-unique-folder"), zod.z.literal("images:check-all-files"), zod.z.literal("files:check-all-files"), zod.z.literal("jsonValues:extract-entry")]);
+var ValidationFixZ = zod.z.union([zod.z.literal("image:add-metadata"), zod.z.literal("image:check-metadata"), zod.z.literal("image:check-remote"), zod.z.literal("image:upload-remote"), zod.z.literal("image:download-remote"), zod.z.literal("images:check-remote"), zod.z.literal("images:upload-remote"), zod.z.literal("file:add-metadata"), zod.z.literal("file:check-metadata"), zod.z.literal("file:check-remote"), zod.z.literal("file:upload-remote"), zod.z.literal("file:download-remote"), zod.z.literal("files:check-remote"), zod.z.literal("files:upload-remote"), zod.z.literal("keyof:check-keys"), zod.z.literal("router:check-route"), zod.z.literal("locale:check-locale"), zod.z.literal("record:fill-keys"), zod.z.literal("images:check-unique-folder"), zod.z.literal("files:check-unique-folder"), zod.z.literal("images:check-all-files"), zod.z.literal("files:check-all-files"), zod.z.literal("jsonValues:extract-entry"), zod.z.literal("view:check-module")]);
 var ValidationError = zod.z.object({
   message: zod.z.string(),
   value: zod.z.unknown().optional(),
@@ -3035,12 +3057,59 @@ var Api = {
 // `number` is allowed because the client stringifies every query value before it
 // goes on the URL (see createValClient), so a numeric param round-trips fine.
 
+/**
+ * How long an appended `details` may be before it is cut.
+ *
+ * A thrown DAL error in the content service quotes the whole offending ROW back
+ * — which for a patch is every op the editor just made — so an uncapped append
+ * puts kilobytes of JSON in a dialog. The head is where the cause is; the tail
+ * is the evidence, and it belongs in the service's own logs.
+ */
+var MAX_DETAILS_LENGTH = 500;
 function getErrorMessageFromUnknownJson(json, fallback) {
   if (getSitemapTree._typeof(json) === "object" && json !== null && "message" in json && typeof json.message === "string") {
-    return json.message;
+    var details = detailsOf(json);
+    if (details === null || details === json.message) {
+      return json.message;
+    }
+    return "".concat(json.message, ": ").concat(details);
   }
   return fallback;
 }
+
+/**
+ * The cause the content service put beside its message, when it wrote one a
+ * person can read.
+ *
+ * `HttpError` in `home` is `{ statusCode, message?, details? }`, and `details`
+ * is filled in two quite different ways. Where a handler REFUSED, it holds the
+ * structured zod error whose summary is already the `message` — repeating it
+ * adds nothing. Where a handler THREW, `sendResult` writes `message:
+ * "Internal Server Error"` and puts the exception's own message in `details` —
+ * so there the message says nothing and the details say everything.
+ *
+ * Which is why the test is the TYPE rather than the status code: a string
+ * `details` is prose meant to be read, an object is a payload meant to be
+ * parsed. This takes the first and leaves the second.
+ *
+ * It was written after an hour was lost to the second case. A patch save
+ * against a content service that threw showed the Studio exactly
+ * `"Internal Server Error"` and nothing else, in a dialog with no other clue,
+ * while the service's answer had been carrying the reason the whole time.
+ */
+function detailsOf(json) {
+  if (!("details" in json) || typeof json.details !== "string") {
+    return null;
+  }
+  var details = json.details.trim();
+  if (details === "") {
+    return null;
+  }
+  if (details.length <= MAX_DETAILS_LENGTH) {
+    return details;
+  }
+  return "".concat(details.slice(0, MAX_DETAILS_LENGTH), "\u2026");
+}
 var DEFAULT_ERROR_MESSAGE = "Unknown error with unknown message from server";
 
 var createValClient = function createValClient(host, config // We want to use this in the future
@@ -4751,6 +4820,13 @@ function emptyOf(schema, context) {
     }, (_schema$options$forma = (_schema$options = schema.options) === null || _schema$options === void 0 ? void 0 : _schema$options.format) !== null && _schema$options$forma !== void 0 ? _schema$options$forma : core.DEFAULT_COLOR_FORMAT);
   } else if (schema.type === "code") {
     return ""; // An empty editor: no language has a sensible starting snippet
+  } else if (schema.type === "view") {
+    // The pointer IS the empty value: a view has exactly one valid source, and
+    // the schema knows it. A new page with a view field gets the same pointer
+    // every other page's has.
+    return {
+      view: schema.moduleFilePath
+    };
   }
   var _exhaustiveCheck = schema;
   throw Error("Unexpected schema type: " + JSON.stringify(_exhaustiveCheck));
@@ -5398,6 +5474,8 @@ function isSkippableFixCode(fix) {
     case "files:check-unique-folder":
     case "images:check-all-files":
     case "files:check-all-files":
+    case "view:check-module":
+      // schema is code: nothing for an editor to do
       return true;
     case "keyof:check-keys":
     case "router:check-route":
@@ -5879,6 +5957,12 @@ function traverseSchemaSource(source, schema, path, callback) {
     }
     return;
   }
+  if (schema.type === "view") {
+    // The source here is a pointer — a module file path, not content. Indexing
+    // it would make every view a hit for its target's filename, and the target
+    // is already indexed under its own path.
+    return;
+  }
 
   // Exhaustive check
   var exhaustiveCheck = schema;
@@ -6760,6 +6844,7 @@ exports.SerializedRouteSchema = SerializedRouteSchema;
 exports.SerializedSchema = SerializedSchema;
 exports.SerializedSettingsSchema = SerializedSettingsSchema;
 exports.SerializedStringSchema = SerializedStringSchema;
+exports.SerializedValViewSchema = SerializedValViewSchema;
 exports.SharedValConfig = SharedValConfig;
 exports.VAL_ENABLE_COOKIE_NAME = VAL_ENABLE_COOKIE_NAME;
 exports.VAL_GREEN_RAMP = VAL_GREEN_RAMP;

package/internal/dist/valbuild-shared-internal.cjs.prod.js

@@ -923,6 +923,10 @@ var SourcePath = zod.z.string().transform(function (path) {
   return path;
 });
 
+var ModuleFilePath$1 = zod.z.string().transform(function (path) {
+  return path;
+});
+
 var _excluded = ["directory"];
 
 // A render is static config, so unlike a `preview` it travels WHOLE — this
@@ -1216,7 +1220,25 @@ var SerializedSettingsSchema = zod.z.lazy(function () {
     section: zod.z.string().optional()
   }));
 });
-var SerializedSchema = zod.z.union([SerializedStringSchema, SerializedLiteralSchema, SerializedBooleanSchema, SerializedNumberSchema, SerializedObjectSchema, SerializedArraySchema, SerializedDiscriminatedUnionSchema, SerializedEnumSchema, SerializedRichTextSchema, SerializedRecordSchema, SerializedKeyOfSchema, SerializedRouteSchema, SerializedLocaleSchema, SerializedFileSchema, SerializedDateSchema, SerializedDateTimeSchema, SerializedColorSchema, SerializedCodeSchema, SerializedSettingsSchema, SerializedImageSchema]);
+
+/**
+ * A view field shows another module and stores nothing of its own.
+ *
+ * Nothing in the type system forces this member to exist: `SerializedSchema` is
+ * declared as `z.ZodType<SerializedSchemaT>`, so a missing member is not a type
+ * error — it is a runtime parse failure of the WHOLE module's schema, since the
+ * containing object fails with it.
+ */
+var SerializedValViewSchema = zod.z.object({
+  type: zod.z.literal("view"),
+  render: FieldRender.optional(),
+  moduleFilePath: ModuleFilePath$1,
+  opt: zod.z.literal(false),
+  readonly: zod.z["boolean"]().optional(),
+  hidden: zod.z["boolean"]().optional(),
+  description: zod.z.string().optional()
+});
+var SerializedSchema = zod.z.union([SerializedStringSchema, SerializedLiteralSchema, SerializedBooleanSchema, SerializedNumberSchema, SerializedObjectSchema, SerializedArraySchema, SerializedDiscriminatedUnionSchema, SerializedEnumSchema, SerializedRichTextSchema, SerializedRecordSchema, SerializedKeyOfSchema, SerializedRouteSchema, SerializedLocaleSchema, SerializedFileSchema, SerializedDateSchema, SerializedDateTimeSchema, SerializedColorSchema, SerializedCodeSchema, SerializedSettingsSchema, SerializedImageSchema, SerializedValViewSchema]);
 
 var ValCommit = zod.z.object({
   commitSha: zod.z.string(),
@@ -1402,7 +1424,7 @@ var ValConfig = zod.z.object({
   gitCommit: zod.z.string().optional(),
   gitBranch: zod.z.string().optional()
 });
-var ValidationFixZ = zod.z.union([zod.z.literal("image:add-metadata"), zod.z.literal("image:check-metadata"), zod.z.literal("image:check-remote"), zod.z.literal("image:upload-remote"), zod.z.literal("image:download-remote"), zod.z.literal("images:check-remote"), zod.z.literal("images:upload-remote"), zod.z.literal("file:add-metadata"), zod.z.literal("file:check-metadata"), zod.z.literal("file:check-remote"), zod.z.literal("file:upload-remote"), zod.z.literal("file:download-remote"), zod.z.literal("files:check-remote"), zod.z.literal("files:upload-remote"), zod.z.literal("keyof:check-keys"), zod.z.literal("router:check-route"), zod.z.literal("locale:check-locale"), zod.z.literal("record:fill-keys"), zod.z.literal("images:check-unique-folder"), zod.z.literal("files:check-unique-folder"), zod.z.literal("images:check-all-files"), zod.z.literal("files:check-all-files"), zod.z.literal("jsonValues:extract-entry")]);
+var ValidationFixZ = zod.z.union([zod.z.literal("image:add-metadata"), zod.z.literal("image:check-metadata"), zod.z.literal("image:check-remote"), zod.z.literal("image:upload-remote"), zod.z.literal("image:download-remote"), zod.z.literal("images:check-remote"), zod.z.literal("images:upload-remote"), zod.z.literal("file:add-metadata"), zod.z.literal("file:check-metadata"), zod.z.literal("file:check-remote"), zod.z.literal("file:upload-remote"), zod.z.literal("file:download-remote"), zod.z.literal("files:check-remote"), zod.z.literal("files:upload-remote"), zod.z.literal("keyof:check-keys"), zod.z.literal("router:check-route"), zod.z.literal("locale:check-locale"), zod.z.literal("record:fill-keys"), zod.z.literal("images:check-unique-folder"), zod.z.literal("files:check-unique-folder"), zod.z.literal("images:check-all-files"), zod.z.literal("files:check-all-files"), zod.z.literal("jsonValues:extract-entry"), zod.z.literal("view:check-module")]);
 var ValidationError = zod.z.object({
   message: zod.z.string(),
   value: zod.z.unknown().optional(),
@@ -3035,12 +3057,59 @@ var Api = {
 // `number` is allowed because the client stringifies every query value before it
 // goes on the URL (see createValClient), so a numeric param round-trips fine.
 
+/**
+ * How long an appended `details` may be before it is cut.
+ *
+ * A thrown DAL error in the content service quotes the whole offending ROW back
+ * — which for a patch is every op the editor just made — so an uncapped append
+ * puts kilobytes of JSON in a dialog. The head is where the cause is; the tail
+ * is the evidence, and it belongs in the service's own logs.
+ */
+var MAX_DETAILS_LENGTH = 500;
 function getErrorMessageFromUnknownJson(json, fallback) {
   if (getSitemapTree._typeof(json) === "object" && json !== null && "message" in json && typeof json.message === "string") {
-    return json.message;
+    var details = detailsOf(json);
+    if (details === null || details === json.message) {
+      return json.message;
+    }
+    return "".concat(json.message, ": ").concat(details);
   }
   return fallback;
 }
+
+/**
+ * The cause the content service put beside its message, when it wrote one a
+ * person can read.
+ *
+ * `HttpError` in `home` is `{ statusCode, message?, details? }`, and `details`
+ * is filled in two quite different ways. Where a handler REFUSED, it holds the
+ * structured zod error whose summary is already the `message` — repeating it
+ * adds nothing. Where a handler THREW, `sendResult` writes `message:
+ * "Internal Server Error"` and puts the exception's own message in `details` —
+ * so there the message says nothing and the details say everything.
+ *
+ * Which is why the test is the TYPE rather than the status code: a string
+ * `details` is prose meant to be read, an object is a payload meant to be
+ * parsed. This takes the first and leaves the second.
+ *
+ * It was written after an hour was lost to the second case. A patch save
+ * against a content service that threw showed the Studio exactly
+ * `"Internal Server Error"` and nothing else, in a dialog with no other clue,
+ * while the service's answer had been carrying the reason the whole time.
+ */
+function detailsOf(json) {
+  if (!("details" in json) || typeof json.details !== "string") {
+    return null;
+  }
+  var details = json.details.trim();
+  if (details === "") {
+    return null;
+  }
+  if (details.length <= MAX_DETAILS_LENGTH) {
+    return details;
+  }
+  return "".concat(details.slice(0, MAX_DETAILS_LENGTH), "\u2026");
+}
 var DEFAULT_ERROR_MESSAGE = "Unknown error with unknown message from server";
 
 var createValClient = function createValClient(host, config // We want to use this in the future
@@ -4751,6 +4820,13 @@ function emptyOf(schema, context) {
     }, (_schema$options$forma = (_schema$options = schema.options) === null || _schema$options === void 0 ? void 0 : _schema$options.format) !== null && _schema$options$forma !== void 0 ? _schema$options$forma : core.DEFAULT_COLOR_FORMAT);
   } else if (schema.type === "code") {
     return ""; // An empty editor: no language has a sensible starting snippet
+  } else if (schema.type === "view") {
+    // The pointer IS the empty value: a view has exactly one valid source, and
+    // the schema knows it. A new page with a view field gets the same pointer
+    // every other page's has.
+    return {
+      view: schema.moduleFilePath
+    };
   }
   var _exhaustiveCheck = schema;
   throw Error("Unexpected schema type: " + JSON.stringify(_exhaustiveCheck));
@@ -5398,6 +5474,8 @@ function isSkippableFixCode(fix) {
     case "files:check-unique-folder":
     case "images:check-all-files":
     case "files:check-all-files":
+    case "view:check-module":
+      // schema is code: nothing for an editor to do
       return true;
     case "keyof:check-keys":
     case "router:check-route":
@@ -5879,6 +5957,12 @@ function traverseSchemaSource(source, schema, path, callback) {
     }
     return;
   }
+  if (schema.type === "view") {
+    // The source here is a pointer — a module file path, not content. Indexing
+    // it would make every view a hit for its target's filename, and the target
+    // is already indexed under its own path.
+    return;
+  }
 
   // Exhaustive check
   var exhaustiveCheck = schema;
@@ -6760,6 +6844,7 @@ exports.SerializedRouteSchema = SerializedRouteSchema;
 exports.SerializedSchema = SerializedSchema;
 exports.SerializedSettingsSchema = SerializedSettingsSchema;
 exports.SerializedStringSchema = SerializedStringSchema;
+exports.SerializedValViewSchema = SerializedValViewSchema;
 exports.SharedValConfig = SharedValConfig;
 exports.VAL_ENABLE_COOKIE_NAME = VAL_ENABLE_COOKIE_NAME;
 exports.VAL_GREEN_RAMP = VAL_GREEN_RAMP;

package/internal/dist/valbuild-shared-internal.esm.js

@@ -916,6 +916,10 @@ var SourcePath = z.string().transform(function (path) {
   return path;
 });
 
+var ModuleFilePath$1 = z.string().transform(function (path) {
+  return path;
+});
+
 var _excluded = ["directory"];
 
 // A render is static config, so unlike a `preview` it travels WHOLE — this
@@ -1209,7 +1213,25 @@ var SerializedSettingsSchema = z.lazy(function () {
     section: z.string().optional()
   }));
 });
-var SerializedSchema = z.union([SerializedStringSchema, SerializedLiteralSchema, SerializedBooleanSchema, SerializedNumberSchema, SerializedObjectSchema, SerializedArraySchema, SerializedDiscriminatedUnionSchema, SerializedEnumSchema, SerializedRichTextSchema, SerializedRecordSchema, SerializedKeyOfSchema, SerializedRouteSchema, SerializedLocaleSchema, SerializedFileSchema, SerializedDateSchema, SerializedDateTimeSchema, SerializedColorSchema, SerializedCodeSchema, SerializedSettingsSchema, SerializedImageSchema]);
+
+/**
+ * A view field shows another module and stores nothing of its own.
+ *
+ * Nothing in the type system forces this member to exist: `SerializedSchema` is
+ * declared as `z.ZodType<SerializedSchemaT>`, so a missing member is not a type
+ * error — it is a runtime parse failure of the WHOLE module's schema, since the
+ * containing object fails with it.
+ */
+var SerializedValViewSchema = z.object({
+  type: z.literal("view"),
+  render: FieldRender.optional(),
+  moduleFilePath: ModuleFilePath$1,
+  opt: z.literal(false),
+  readonly: z["boolean"]().optional(),
+  hidden: z["boolean"]().optional(),
+  description: z.string().optional()
+});
+var SerializedSchema = z.union([SerializedStringSchema, SerializedLiteralSchema, SerializedBooleanSchema, SerializedNumberSchema, SerializedObjectSchema, SerializedArraySchema, SerializedDiscriminatedUnionSchema, SerializedEnumSchema, SerializedRichTextSchema, SerializedRecordSchema, SerializedKeyOfSchema, SerializedRouteSchema, SerializedLocaleSchema, SerializedFileSchema, SerializedDateSchema, SerializedDateTimeSchema, SerializedColorSchema, SerializedCodeSchema, SerializedSettingsSchema, SerializedImageSchema, SerializedValViewSchema]);
 
 var ValCommit = z.object({
   commitSha: z.string(),
@@ -1395,7 +1417,7 @@ var ValConfig = z.object({
   gitCommit: z.string().optional(),
   gitBranch: z.string().optional()
 });
-var ValidationFixZ = z.union([z.literal("image:add-metadata"), z.literal("image:check-metadata"), z.literal("image:check-remote"), z.literal("image:upload-remote"), z.literal("image:download-remote"), z.literal("images:check-remote"), z.literal("images:upload-remote"), z.literal("file:add-metadata"), z.literal("file:check-metadata"), z.literal("file:check-remote"), z.literal("file:upload-remote"), z.literal("file:download-remote"), z.literal("files:check-remote"), z.literal("files:upload-remote"), z.literal("keyof:check-keys"), z.literal("router:check-route"), z.literal("locale:check-locale"), z.literal("record:fill-keys"), z.literal("images:check-unique-folder"), z.literal("files:check-unique-folder"), z.literal("images:check-all-files"), z.literal("files:check-all-files"), z.literal("jsonValues:extract-entry")]);
+var ValidationFixZ = z.union([z.literal("image:add-metadata"), z.literal("image:check-metadata"), z.literal("image:check-remote"), z.literal("image:upload-remote"), z.literal("image:download-remote"), z.literal("images:check-remote"), z.literal("images:upload-remote"), z.literal("file:add-metadata"), z.literal("file:check-metadata"), z.literal("file:check-remote"), z.literal("file:upload-remote"), z.literal("file:download-remote"), z.literal("files:check-remote"), z.literal("files:upload-remote"), z.literal("keyof:check-keys"), z.literal("router:check-route"), z.literal("locale:check-locale"), z.literal("record:fill-keys"), z.literal("images:check-unique-folder"), z.literal("files:check-unique-folder"), z.literal("images:check-all-files"), z.literal("files:check-all-files"), z.literal("jsonValues:extract-entry"), z.literal("view:check-module")]);
 var ValidationError = z.object({
   message: z.string(),
   value: z.unknown().optional(),
@@ -3028,12 +3050,59 @@ var Api = {
 // `number` is allowed because the client stringifies every query value before it
 // goes on the URL (see createValClient), so a numeric param round-trips fine.
 
+/**
+ * How long an appended `details` may be before it is cut.
+ *
+ * A thrown DAL error in the content service quotes the whole offending ROW back
+ * — which for a patch is every op the editor just made — so an uncapped append
+ * puts kilobytes of JSON in a dialog. The head is where the cause is; the tail
+ * is the evidence, and it belongs in the service's own logs.
+ */
+var MAX_DETAILS_LENGTH = 500;
 function getErrorMessageFromUnknownJson(json, fallback) {
   if (_typeof(json) === "object" && json !== null && "message" in json && typeof json.message === "string") {
-    return json.message;
+    var details = detailsOf(json);
+    if (details === null || details === json.message) {
+      return json.message;
+    }
+    return "".concat(json.message, ": ").concat(details);
   }
   return fallback;
 }
+
+/**
+ * The cause the content service put beside its message, when it wrote one a
+ * person can read.
+ *
+ * `HttpError` in `home` is `{ statusCode, message?, details? }`, and `details`
+ * is filled in two quite different ways. Where a handler REFUSED, it holds the
+ * structured zod error whose summary is already the `message` — repeating it
+ * adds nothing. Where a handler THREW, `sendResult` writes `message:
+ * "Internal Server Error"` and puts the exception's own message in `details` —
+ * so there the message says nothing and the details say everything.
+ *
+ * Which is why the test is the TYPE rather than the status code: a string
+ * `details` is prose meant to be read, an object is a payload meant to be
+ * parsed. This takes the first and leaves the second.
+ *
+ * It was written after an hour was lost to the second case. A patch save
+ * against a content service that threw showed the Studio exactly
+ * `"Internal Server Error"` and nothing else, in a dialog with no other clue,
+ * while the service's answer had been carrying the reason the whole time.
+ */
+function detailsOf(json) {
+  if (!("details" in json) || typeof json.details !== "string") {
+    return null;
+  }
+  var details = json.details.trim();
+  if (details === "") {
+    return null;
+  }
+  if (details.length <= MAX_DETAILS_LENGTH) {
+    return details;
+  }
+  return "".concat(details.slice(0, MAX_DETAILS_LENGTH), "\u2026");
+}
 var DEFAULT_ERROR_MESSAGE = "Unknown error with unknown message from server";
 
 var createValClient = function createValClient(host, config // We want to use this in the future
@@ -4744,6 +4813,13 @@ function emptyOf(schema, context) {
     }, (_schema$options$forma = (_schema$options = schema.options) === null || _schema$options === void 0 ? void 0 : _schema$options.format) !== null && _schema$options$forma !== void 0 ? _schema$options$forma : DEFAULT_COLOR_FORMAT);
   } else if (schema.type === "code") {
     return ""; // An empty editor: no language has a sensible starting snippet
+  } else if (schema.type === "view") {
+    // The pointer IS the empty value: a view has exactly one valid source, and
+    // the schema knows it. A new page with a view field gets the same pointer
+    // every other page's has.
+    return {
+      view: schema.moduleFilePath
+    };
   }
   var _exhaustiveCheck = schema;
   throw Error("Unexpected schema type: " + JSON.stringify(_exhaustiveCheck));
@@ -5391,6 +5467,8 @@ function isSkippableFixCode(fix) {
     case "files:check-unique-folder":
     case "images:check-all-files":
     case "files:check-all-files":
+    case "view:check-module":
+      // schema is code: nothing for an editor to do
       return true;
     case "keyof:check-keys":
     case "router:check-route":
@@ -5872,6 +5950,12 @@ function traverseSchemaSource(source, schema, path, callback) {
     }
     return;
   }
+  if (schema.type === "view") {
+    // The source here is a pointer — a module file path, not content. Indexing
+    // it would make every view a hit for its target's filename, and the target
+    // is already indexed under its own path.
+    return;
+  }
 
   // Exhaustive check
   var exhaustiveCheck = schema;
@@ -6671,4 +6755,4 @@ function resolvePairGround(ground, ramp) {
   return typeof ground === "number" ? ramp[ground] : ground;
 }
 
-export { AA_LARGE, AA_TEXT, Api, BRAND_CONTRAST_PAIRS, BinaryFileRef, CodeOptions, ColorOptions, DEFAULT_ERROR_MESSAGE, DateOptions, ENCODE_DEFAULTS, ENCODE_MIME_TYPE_OF, FileOptions, HistoricalCommit, HistoricalModule, HistoricalPatchSet, HistoryError, ImageEncodeOption, ImageOptions, JSONValue, JSON_ENTRIES_BATCH_MAX, ModuleComparison, NEVER_ENCODED, ParentRef$1 as ParentRef, Patch, PatchBlock, PatchGroup, PatchId, PatchJSON, RAMP_STEPS, RemirrorBr, RemirrorBulletList, RemirrorHeading, RemirrorImage, RemirrorJSON, RemirrorLinkMark, RemirrorListItem, RemirrorOrderedList, RemirrorParagraph, RemirrorText, RemirrorTextMark, RestoreVerdict, RichTextOptions, SCHEMA_SOURCE_FIXES, SerializedArraySchema, SerializedBooleanSchema, SerializedCodeSchema, SerializedColorSchema, SerializedDateSchema, SerializedDateTimeSchema, SerializedDiscriminatedUnionSchema, SerializedEnumSchema, SerializedFileSchema, SerializedImageSchema, SerializedKeyOfSchema, SerializedLiteralSchema, SerializedLocaleSchema, SerializedNumberSchema, SerializedObjectSchema, SerializedRecordSchema, SerializedRichTextSchema, SerializedRouteSchema, SerializedSchema, SerializedSettingsSchema, SerializedStringSchema, SharedValConfig, VAL_ENABLE_COOKIE_NAME, VAL_GREEN_RAMP, VAL_SESSION_COOKIE, VAL_STATE_COOKIE, ValCommit, ValDeployment, accentRamp, buildDuplicatePatch, buildEmptyAtPathPatch, buildFileRefValue, buildImageGalleryPatch, buildRemoveImageGalleryEntryPatch, buildSearchIndex, checkCompatibility, chooseEncoded, concatModulePath, contrastRatio, createRegExpFromPattern, createSearchIndex, createValClient, declaredLocales, describeContainerAtPath, emptyOf, explainIncompatible, filterBlockingValidationErrors, filterRoutesByPatterns, findSimilar, fitWithin, flattenRichText, getErrorMessageFromUnknownJson, getFilenameFromRef, getInlineImgInfo, getKeyOfRecordAt, getRefParts, getRoutesOf, getRoutesWithModulePaths, getSourceAt, indexModule, isMimeTypeAccepted, isRemoteSchema, isSchemaSourceFixError, isSkippedSource, keyOfRecordPath, levenshtein, localeAt, newestCommitSha, partitionValidationErrors, performSearch, relativeLuminance, remirrorToRichTextSource, removeModule, resolveEncodeSettings, resolvePairGround, resolveSchemaSourceFixForError, resolveSchemaSourceFixes, resolveSerializedSchemaAtPath, richTextToRemirror, safeParsePatch, sourcePathOfChild, themeCustomProperties, toolNames, traverseSchemaSource, urlOf, validateRoutePatterns, withExtension };
+export { AA_LARGE, AA_TEXT, Api, BRAND_CONTRAST_PAIRS, BinaryFileRef, CodeOptions, ColorOptions, DEFAULT_ERROR_MESSAGE, DateOptions, ENCODE_DEFAULTS, ENCODE_MIME_TYPE_OF, FileOptions, HistoricalCommit, HistoricalModule, HistoricalPatchSet, HistoryError, ImageEncodeOption, ImageOptions, JSONValue, JSON_ENTRIES_BATCH_MAX, ModuleComparison, NEVER_ENCODED, ParentRef$1 as ParentRef, Patch, PatchBlock, PatchGroup, PatchId, PatchJSON, RAMP_STEPS, RemirrorBr, RemirrorBulletList, RemirrorHeading, RemirrorImage, RemirrorJSON, RemirrorLinkMark, RemirrorListItem, RemirrorOrderedList, RemirrorParagraph, RemirrorText, RemirrorTextMark, RestoreVerdict, RichTextOptions, SCHEMA_SOURCE_FIXES, SerializedArraySchema, SerializedBooleanSchema, SerializedCodeSchema, SerializedColorSchema, SerializedDateSchema, SerializedDateTimeSchema, SerializedDiscriminatedUnionSchema, SerializedEnumSchema, SerializedFileSchema, SerializedImageSchema, SerializedKeyOfSchema, SerializedLiteralSchema, SerializedLocaleSchema, SerializedNumberSchema, SerializedObjectSchema, SerializedRecordSchema, SerializedRichTextSchema, SerializedRouteSchema, SerializedSchema, SerializedSettingsSchema, SerializedStringSchema, SerializedValViewSchema, SharedValConfig, VAL_ENABLE_COOKIE_NAME, VAL_GREEN_RAMP, VAL_SESSION_COOKIE, VAL_STATE_COOKIE, ValCommit, ValDeployment, accentRamp, buildDuplicatePatch, buildEmptyAtPathPatch, buildFileRefValue, buildImageGalleryPatch, buildRemoveImageGalleryEntryPatch, buildSearchIndex, checkCompatibility, chooseEncoded, concatModulePath, contrastRatio, createRegExpFromPattern, createSearchIndex, createValClient, declaredLocales, describeContainerAtPath, emptyOf, explainIncompatible, filterBlockingValidationErrors, filterRoutesByPatterns, findSimilar, fitWithin, flattenRichText, getErrorMessageFromUnknownJson, getFilenameFromRef, getInlineImgInfo, getKeyOfRecordAt, getRefParts, getRoutesOf, getRoutesWithModulePaths, getSourceAt, indexModule, isMimeTypeAccepted, isRemoteSchema, isSchemaSourceFixError, isSkippedSource, keyOfRecordPath, levenshtein, localeAt, newestCommitSha, partitionValidationErrors, performSearch, relativeLuminance, remirrorToRichTextSource, removeModule, resolveEncodeSettings, resolvePairGround, resolveSchemaSourceFixForError, resolveSchemaSourceFixes, resolveSerializedSchemaAtPath, richTextToRemirror, safeParsePatch, sourcePathOfChild, themeCustomProperties, toolNames, traverseSchemaSource, urlOf, validateRoutePatterns, withExtension };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@valbuild/shared",
-  "version": "0.133.0",
+  "version": "0.134.1",
   "private": false,
   "description": "Val shared types and utilities",
   "repository": {
@@ -37,7 +37,7 @@
     "flexsearch": "^0.8.212",
     "zod": "^4.4.3",
     "zod-validation-error": "^5.0.0",
-    "@valbuild/core": "0.130.0"
+    "@valbuild/core": "0.134.0"
   },
   "files": [
     "CHANGELOG.md",